From nobody Fri Apr 3 00:00:51 2026 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9DA372671 for ; Wed, 25 Mar 2026 20:27:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774470445; cv=none; b=GDrzVKgXoCqKLATztnC/9KGsEV0Az81sRyWgjWNUPDcObe5eI1M71jm7DG5E0atdqcp/NNBTAnVgglZzNwMb0imXiYIPScr3jHQZ1d6uO97qvW/4n9oTzx4SNIUPfEXaibicCmX6SVN78TfdtCIWlIrrNdFMLrQdqbD2iL2PQAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774470445; c=relaxed/simple; bh=0onwSdC4aAc8cDI7zylJ8q/ArIAL1vgMBP4pvRTtjWg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lN27ubSXdxAMqOslzJd3VSdq07AnAASuz102i+uv227+wDc2LpYdfJhWnGGzK/gs8n1Ik4SJjVGob2dTWd7M7hovw0VD9u2Rmv3lN9MjmG4/zs5Wb7H+uVpu7VSdJEjJ59dfKitGDVoPSnK1SK+c3TKQ+DMOqJvyk3N9AIm2Rro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FGD26ZYV; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FGD26ZYV" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2c1632faeb9so543596eec.0 for ; Wed, 25 Mar 2026 13:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774470443; x=1775075243; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0O/c1TvyMvLhySUBvQSZ4Jz6C1ecY6F0Rr8Y+sdjF50=; b=FGD26ZYVPQ4zpvVHC9qHDdxgTR/vbfCn+Jj+7cq+R/UZ7wwBkBq6BPj0LEdTlgKET2 ywwQqxv0IJ024c/0jJucjiUqVoPFfnS2zfssQiVurThqX8ZEphTmrhSLq9OIT9Y7zdlU anCKHragPnUuBQBbWwyUuA/bOg7hULNIMuOrwtLmqf7GkDw8xhMsQ7prAspN1d82YnMh 9Q6ETHfJGjDDAwomHEXEePLseoF1Ntbmo8oyrilApJtFAxfsWBjvS/Zr6fh9XDAeWeRf bvs0iEI7ataOaVgyqOvt8nPlcA32rHIkeYyxvcJIlAbPrmvaX4MsQ/gK8LN4X+DJSRtH R58w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774470443; x=1775075243; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0O/c1TvyMvLhySUBvQSZ4Jz6C1ecY6F0Rr8Y+sdjF50=; b=mTwCiSjNyhFmgMXxGtnvAUkUL9b3op2+z+l8KIL8sJlYLNis1tpL7QB79T8RAlnV5z HIQ4GY2l3uVV4Clx57zvLeNl+kJ+HIheQkwu/RtOu8vhNVud/edEXYTa9lt7rbtmegTO j2A4K31e1/htkMOt4QacSExAMYdDfTBB7w466yHqi1rOm6rCa1lXh3/ACN+rIrCfo6nl zQPsssDJAxqxTVjAdy4rm/woknX15T0Rq4wwhubuZxuZYYMcBwT5LcCFH51c1pRvjzjr MHr7VGubmtJYavlCcLjwa4hgA9VVVThR0Dg6o6M9u9KLkE5EVIO9Ytmt5CBj24qlIyOm n05g== X-Forwarded-Encrypted: i=1; AJvYcCVvrnU6umloIOORzuS1Ye8056AdrclzewFQbEZ/KQGpHKkf+YGgbPocYRsYJEv0lxRfunvyGhyOTobV3dc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw427aibBq+7Cgq5bOe7cslwM6cU3xdac3lSOGv7EWfF7fn6Ga5 9ZDFwb/58mpyNfUvcmRF6DqZQzIFH1ZBFLnyJtOUjoR2umpmcD98jmBm X-Gm-Gg: ATEYQzzcyn3lnKo0z7h2WcHOsGiNOraguyhC0F97Nir6Mgczk+tCecIsbahBgXqgB8R bGJYEAiWeCfm8tAft+ab4uwlqmIMZaP09AeYfA/YEJ+EBtBRKReUCWRgq74WZoasOwIZCUPoPR/ iprjk7AHAwtAt8nAWvqy5w5ycOydM8VNZCJjNrhFbpBlwVH0o9CFfq83cLyL65s+mLCw9zOu0EB wom0b9FkfuXrWlQmny8EhHgRzq+UBhpruvx71Gf7ftnWl7xnyXz1yiUDWpHUI4qNdFSwtk/D17/ PxxhUCAFi20cEQXTNZe7WDJq08Re2mfwnVfpmPBdnvKe5ZhI+ZIxD3R9t5D9gHp5JdfN5sSsYXt JsfbRz0lyenFYIUU2XjW2ggYYGmyKGtC7Rhk1q93nCs4BIIrRu5X3mnAJdPYn88+st941xDIwOB zontIK8y7Y3OXGzyGq4z95Itg/6D/iSpBR224rVQxxrH+9BiiEH3g= X-Received: by 2002:a05:7300:6a95:b0:2c1:6eda:476c with SMTP id 5a478bee46e88-2c16eda4baemr434739eec.28.1774470443233; Wed, 25 Mar 2026 13:27:23 -0700 (PDT) Received: from brody-server.tail733610.ts.net ([65.173.245.48]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c16ec815cesm643827eec.13.2026.03.25.13.27.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 13:27:22 -0700 (PDT) From: Brody England To: scott@spiteful.org Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] PCI: cpcihp: Check pci_hp_add_bridge() return value Date: Wed, 25 Mar 2026 13:27:20 -0700 Message-ID: <20260325202720.389400-1-brodyengland3@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" cpci_configure_slot() ignores the return value of pci_hp_add_bridge() and continues with resource assignment and device addition even if bridge setup fails. Check the return value, report the error, and abort slot configuration if adding the bridge fails. Compile-tested only. Signed-off-by: Brody England --- drivers/pci/hotplug/cpci_hotplug_pci.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pci/hotplug/cpci_hotplug_pci.c b/drivers/pci/hotplug/c= pci_hotplug_pci.c index 6c48066acb44..7ae02071e796 100644 --- a/drivers/pci/hotplug/cpci_hotplug_pci.c +++ b/drivers/pci/hotplug/cpci_hotplug_pci.c @@ -269,8 +269,14 @@ int cpci_configure_slot(struct slot *slot) parent =3D slot->dev->bus; =20 for_each_pci_bridge(dev, parent) { - if (PCI_SLOT(dev->devfn) =3D=3D PCI_SLOT(slot->devfn)) - pci_hp_add_bridge(dev); + if (PCI_SLOT(dev->devfn) =3D=3D PCI_SLOT(slot->devfn)) { + ret =3D pci_hp_add_bridge(dev); + if (ret) { + err("Could not add hotplug bridge for slot %02x", + slot->number); + goto out; + } + } } =20 pci_assign_unassigned_bridge_resources(parent->self); --=20 2.47.3