From nobody Mon Apr 6 09:13:55 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7C4A3DC4A3 for ; Wed, 25 Mar 2026 19:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774466704; cv=none; b=jCWgCnFYHa7zApe12iEdfVpgs8bdR/awa/mAtfCQajrIujU/7gxtBKNHWGstqyHMOapouFjh6gaHcNa/FJ2d4fyP1d5OUhhA4Yx6qa8dCTHb2Fjg/02PtW7mnS1gjzD7Xzyym1ESbMb6ZDwk9eZU8rpHHPuGTv71BqKuGeDL9d4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774466704; c=relaxed/simple; bh=mGrpbtd7O99HFdEBvrSlm4J2aaoUidqbZw3lec3A4Ys=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TI0yiN29mtNVY9OqgRpf9I/WV7+mjpU9NSNaC7q05QTaTU0tbbUiw5suD9MKFI1IeVNGqhE36zHGpP4hOqBbuwyqAOQdObV5M1LTuG/fTQ6FIZhoobcQytTpC9vntds6aRAHUU6B1k44WJPp+Q7MLCwuOgrjoFePxOCAGCOXoTg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n61Hb5XX; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n61Hb5XX" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43b45bb7548so103924f8f.1 for ; Wed, 25 Mar 2026 12:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774466701; x=1775071501; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BZvNEX0eQZxtcjPdToyJZElNzJL/cd7oKRQgio/5M8o=; b=n61Hb5XXoTnEr/jobP2KO58hkuFUb0CnZ62i+ZAsGtU7aGzUF5dvq0q71atKS4FrM+ NUYVZlKUvJQoAqy0Yekae4RXvdNjzooCx+8A/1pj8e6YBpBNBwAeHs0KKTpEPsZsXOeR FWdlC8zcvEavkgjRIYxwRSyeVe4pneuqh/UfN/sn6vBrfyWJGrFrnD7DrqNvwJ8laxOx llj52KYUXHUzFRqmTeggAYvMlb7mvYrgALGNJDZ8zAv3IwgAqo66xVO38IM/DVpYKxQS EoUIarqrpzNWRA6dxf8uDuB/wAd93/2kK2GBdU7EI/nbIFUs+UFafxHdfOwItGepjwIu rcYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774466701; x=1775071501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BZvNEX0eQZxtcjPdToyJZElNzJL/cd7oKRQgio/5M8o=; b=C8PoKoEu5DV9Ei4l2AX59qtSIyriCJUlyemF6udIgn5kWBtGyVbZztVQLLA7eRlzBx /chmaNybu0tVSxiIBduys9RqikZhJdjXYdN0OFcy7vG7yYt/7DP3Lh0q4Kf9/0hXBKCp gvsHuPrGmcBIeaY9SO6/2tkudIcTjFbg3KmbH9AZULFBXgkNvNIh2k06B6qlTivwn8fI duXxoNyxLyqlMTaekSuEeIxjwPrddwYwe4BN7BLVjPnlLGL/61KQzWudzDVXrwGHi3G7 9pG7z+K8UmPvKAs33ODvTRYT42AuOJrSHWMH+3u/7uQU5Aib7A1BaSP5YALKyGLRfN5c TFTQ== X-Forwarded-Encrypted: i=1; AJvYcCUk1E/4WKSG6AcEoASMY//ur4MWF7ZOR4Z1slk6OBDPltwsuMV1TNFzf3bSXOInQroeDKADycs6rHiBxyE=@vger.kernel.org X-Gm-Message-State: AOJu0YzG77//3nTwtU9DTK7PpRXSwfCwQvyJkrjzSB2UXAh0nuibbaVG wjEqBRo3/v8zMZJSScKDAfY9iJ1PL8WIEUhVZhssstzlofabzjmkCCW9WcT4Og== X-Gm-Gg: ATEYQzwa7xNmwJq+9h4X97IdM/lS5qMS8P9ioMsFPFF8zJIjYvWrV5DO2+5oSDMY3fE YgStoGkkh07p94ToaUTwHTWm9XsRjGYMCyvsQ43jzvBmqsfPJ1pxARFfqdWJBIJ6mtYwYppsrlT bWxZ/WHvcvjl0BFacU50+c2cG9D70lLjZQmmNr1mrSfszG9lcOoVz0UYh8JDeIclYb3Sa+YjLRO 6bMqusSGZ3Oir7nkhi8gXmEtFGbQ6+87faSlGVMHAj1eirzoyPs/9uxPIOFMT0ZwxuK2z52xUek pOvcHz8P1fHQwwtUv2lGDWJmNi3fw6ea0H1Muex7PtbM7sNpD4tGJzF+csIV6jUpi0l/1XgQkjW 7mHtfsx1hvEbj1SCJrgsZUsOYn3GjTdkJfMmV/T2SErg5DVSLjm3QvX8oEQiWiXk2r9nIs5xyM0 CkOF5ZvvgTWZbAM+rIZlAKua+AKXJZFqq7uYWvwWcjrpf+qF7M X-Received: by 2002:a05:6000:1a8e:b0:43b:54c9:7d21 with SMTP id ffacd0b85a97d-43b88a25a60mr6941545f8f.37.1774466701301; Wed, 25 Mar 2026 12:25:01 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:8138:17e4:88b1:468c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b9192e533sm2464485f8f.2.2026.03.25.12.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 12:25:01 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Thomas Gleixner Cc: Biju Das , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v7 08/16] irqchip/renesas-rzg2l: Replace rzg2l_irqc_irq_{enable,disable} with TINT-specific handlers Date: Wed, 25 Mar 2026 19:24:23 +0000 Message-ID: <20260325192451.172562-9-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260325192451.172562-1-biju.das.jz@bp.renesas.com> References: <20260325192451.172562-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das rzg2l_irqc_irq_disable() and rzg2l_irqc_irq_enable() were used by both the IRQ and TINT chips, but only performed TINT-specific work via rzg2l_tint_irq_endisable(), guarded by a hw_irq range check. Since the IRQ chip does not require this extra enable/disable handling, replace its callbacks with the generic irq_chip_disable_parent() and irq_chip_enable_parent() directly. While at it, simplify rzfive_irqc_irq_enable() by replacing raw_spin_lock locking/unlocking with guard() and update the variable type of offset, tssr_offset, and tssr_index to unsigned int, as these variables are used only for calculation. Signed-off-by: Biju Das --- v6->v7: * No change. v5->v6: * Updated the variable type of offset, tssr_offset, and tssr_index to unsigned int, in rzfive_irqc_irq_enable() as these variables are used only for calculation. * Simplified rzfive_irqc_irq_enable() by replacing raw_spin_lock locking/unlocking with guard(). * Updated commit description. v5: * New patch. --- drivers/irqchip/irq-renesas-rzg2l.c | 40 +++++++++++++---------------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-rene= sas-rzg2l.c index b3457a419bab..6e55b325cca9 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -259,33 +259,29 @@ static void rzfive_irqc_irq_enable(struct irq_data *d) =20 static void rzg2l_tint_irq_endisable(struct irq_data *d, bool enable) { + struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); unsigned int hw_irq =3D irqd_to_hwirq(d); + unsigned int offset =3D hw_irq - IRQC_TINT_START; + unsigned int tssr_offset =3D TSSR_OFFSET(offset); + unsigned int tssr_index =3D TSSR_INDEX(offset); + u32 reg; =20 - if (hw_irq >=3D IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ) { - struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); - u32 offset =3D hw_irq - IRQC_TINT_START; - u32 tssr_offset =3D TSSR_OFFSET(offset); - u8 tssr_index =3D TSSR_INDEX(offset); - u32 reg; - - raw_spin_lock(&priv->lock); - reg =3D readl_relaxed(priv->base + TSSR(tssr_index)); - if (enable) - reg |=3D TIEN << TSSEL_SHIFT(tssr_offset); - else - reg &=3D ~(TIEN << TSSEL_SHIFT(tssr_offset)); - writel_relaxed(reg, priv->base + TSSR(tssr_index)); - raw_spin_unlock(&priv->lock); - } + guard(raw_spinlock)(&priv->lock); + reg =3D readl_relaxed(priv->base + TSSR(tssr_index)); + if (enable) + reg |=3D TIEN << TSSEL_SHIFT(tssr_offset); + else + reg &=3D ~(TIEN << TSSEL_SHIFT(tssr_offset)); + writel_relaxed(reg, priv->base + TSSR(tssr_index)); } =20 -static void rzg2l_irqc_irq_disable(struct irq_data *d) +static void rzg2l_irqc_tint_disable(struct irq_data *d) { irq_chip_disable_parent(d); rzg2l_tint_irq_endisable(d, false); } =20 -static void rzg2l_irqc_irq_enable(struct irq_data *d) +static void rzg2l_irqc_tint_enable(struct irq_data *d) { rzg2l_tint_irq_endisable(d, true); irq_chip_enable_parent(d); @@ -456,8 +452,8 @@ static const struct irq_chip rzg2l_irqc_irq_chip =3D { .irq_eoi =3D rzg2l_irqc_irq_eoi, .irq_mask =3D irq_chip_mask_parent, .irq_unmask =3D irq_chip_unmask_parent, - .irq_disable =3D rzg2l_irqc_irq_disable, - .irq_enable =3D rzg2l_irqc_irq_enable, + .irq_disable =3D irq_chip_disable_parent, + .irq_enable =3D irq_chip_enable_parent, .irq_get_irqchip_state =3D irq_chip_get_parent_state, .irq_set_irqchip_state =3D irq_chip_set_parent_state, .irq_retrigger =3D irq_chip_retrigger_hierarchy, @@ -473,8 +469,8 @@ static const struct irq_chip rzg2l_irqc_tint_chip =3D { .irq_eoi =3D rzg2l_irqc_tint_eoi, .irq_mask =3D irq_chip_mask_parent, .irq_unmask =3D irq_chip_unmask_parent, - .irq_disable =3D rzg2l_irqc_irq_disable, - .irq_enable =3D rzg2l_irqc_irq_enable, + .irq_disable =3D rzg2l_irqc_tint_disable, + .irq_enable =3D rzg2l_irqc_tint_enable, .irq_get_irqchip_state =3D irq_chip_get_parent_state, .irq_set_irqchip_state =3D irq_chip_set_parent_state, .irq_retrigger =3D irq_chip_retrigger_hierarchy, --=20 2.43.0