From nobody Thu Apr 2 01:49:51 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 416513E5563 for ; Wed, 25 Mar 2026 19:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774466705; cv=none; b=Kebwb0r9+c9WJlNaE2MvFXRDIzxm1WpVaFroq3oX4BChTKEJ+zQcgsm1U0cdDSlUIeU+TshXksK+AeGqItGlDzwrMJzF5kVZ2S0N+KdIsXJG3KQN5XUqHzSY6xN+5jCO/U5aI4gFIy0L3RnndQ7wAoTBR3QDznoD+dBtK6cnQBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774466705; c=relaxed/simple; bh=nqVPM1hmwO5JmLKKyP3/lHGeKXnTlQO6jHwvK1jQDG4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TOq07i+w6oGLqnKL0AmOZGHea8+in3HLl93izej1S7CLvIOqYwZ54v28gfF1xZxN/cvVu7kR2BbXGsWMx7HeexR7i/FvTjX+rYwAFFQY75jWpC74Tmg85dp/WazYRY74yKB3GCArI4NdfPnyKZNXrdlMLSS20vETOH82oQgdsBM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZYlibhN7; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZYlibhN7" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43b7481f9d3so89177f8f.3 for ; Wed, 25 Mar 2026 12:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774466702; x=1775071502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RKFHksAcuviXc/otCCQz+QY3AlkGK3IubNjvmIBQfoE=; b=ZYlibhN7FiopoKu5okx9jG1DwW4EwRNTpMIRvtpjZoyNhjH3NTDkB+8n6ickWEJ7pz fIbJqLmAVp2fkKIk4jo91VstDp4W93EbqT3XEPCHR+/TDI/Kfq4/40zKuojKVvfoMXZ7 NJc0bveeR/WDaSeAXiLefw1nbNhcetpdqBydDFSAy2CYRQbNHA3ofXzqT5bM1kVu4/BP OGvCo3FOf7Qomhy5MLgAyHgJ2KmiXbPxAFhity1SBndDME030FNEdOdI2/8fVg69N0/8 gle4/hwqinGDdp5f0gETRwXIn2vXmN9Ly8y5m4t0l/+oT7ulW+dx0lrlMprSIvJmExnj 7zzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774466702; x=1775071502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RKFHksAcuviXc/otCCQz+QY3AlkGK3IubNjvmIBQfoE=; b=ow32bmnoYPfPo17sYFJFjSzqH0SrJnD8IKdXMemBEXnQC/TVmoba5QORoWVDnnBo9p qGSg4xCHcCtu+cBntawgfh/HIyNmE8l+MI7Ejgr7wJqNIgPXfoj8CXxnfk/xjsjJCkLM /Y0UOTtEVMTbNbm3aiXLV7I8hi7/xUrHaT4sBP/YD1KJdm9kBnokBACLrr3IwlIoOSaW SprAeBPBkvyRdxJwVt1dw2tvfZwZnFbBpnJy/mbPDq3IpK+KyLh/YpiIOJ5oZjk8lk6U do+IwAP8ubLErWRV16hConzBNTozbO8LDMfCSuiTVUQQTQRJatFlIKP05QitP/lQHmSR 0OWA== X-Forwarded-Encrypted: i=1; AJvYcCVS75RsWjub4Ky4qYPMkZc6Zbg4JHCJdIHW/YQUSW8bKLINlO231T17tUZbf71cmKs1w5d1ZsKO9txyeT4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywty6MtuMDwwvLuyRhzIBOgKgXUikU3OLoC1ZFLVf+gVXIFjkdk x5+U/gekJ9TFmBm/UMpFr+5JFYVrgBu+hjXAGE0er9DjYk6NG17LMBUT X-Gm-Gg: ATEYQzwzxnOTyx0bp8muNoNJeMypGPG2UJlRGVmmxD7I0NhC8nE5VGyW1xCYi6ZW5Ud gy0znLmUKC2evHUVy64C4SNRA4BZNm5snRxtLkAZGTToyGkRbrDk5elaS1JfZDREhs8cMdQK7S0 1kgYvJKmKNOqKGFKJ9WJqR3iC+57Vp5XYeYJzF8Whc1vGZIGYrB7PcQ0en1d1sbV3+9W11EFOB3 6dHIHh1qWF2cB3hlIFixxsj72WfQgyQtuig+0sSVQ28MXi4EvAWJTMJiFeZbu4VMgMpY63RqjQl Io1oFxANHv80DGLQHBYLDsXP5ZG++3X+VXika0et8FjaGtz/wFSUDt30fKvLcgCq2VH3/+Yl8wG l0jJrCLCcsKiGRAI37C/ikbHtj3M0b9jSDaT2P7TwxFUhHLdz3N+u9fby6PvAGbGHUvZRuSjFK3 8MMFjW+TFkxMXJMrptrrtTdC8EjICOrF1EScoCQGmwiH0qcCQq X-Received: by 2002:a05:6000:2284:b0:43b:3bf9:e008 with SMTP id ffacd0b85a97d-43b889ac064mr7175830f8f.11.1774466702421; Wed, 25 Mar 2026 12:25:02 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:8138:17e4:88b1:468c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b9192e533sm2464485f8f.2.2026.03.25.12.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 12:25:01 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Thomas Gleixner Cc: Biju Das , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v7 09/16] irqchip/renesas-rzg2l: Split rzfive_tint_irq_endisable() into separate IRQ and TINT helpers Date: Wed, 25 Mar 2026 19:24:24 +0000 Message-ID: <20260325192451.172562-10-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260325192451.172562-1-biju.das.jz@bp.renesas.com> References: <20260325192451.172562-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das rzfive_tint_irq_endisable() handled both IRQ and TINT enable/disable paths via a hw_irq range check. Split this into two dedicated helpers, rzfive_irq_endisable() for IRQ interrupts and rzfive_tint_endisable() for TINT interrupts, each operating unconditionally on their respective interrupt type. While at it, simplify rzfive_{irq,tint}_endisable by replacing raw_spin_lock locking/unlocking with guard() and update the variable type of offset, tssr_offset, and tssr_index to unsigned int, as these variables are used only for calculation. Signed-off-by: Biju Das --- v6->v7: * No change. v5->v6: * Simplified rzfive_{irq,tint}_endisable by replacing raw_spin_lock locking/unlocking with guard(). * Updated the variable type of offset, tssr_offset, and tssr_index to unsigned int, in rzfive_tint_endisable() as these variables are used only for calculation. * Dropped stray newline in rzfive_tint_endisable(). * Updated commit description. v5: * New patch. --- drivers/irqchip/irq-renesas-rzg2l.c | 75 +++++++++++++++++------------ 1 file changed, 44 insertions(+), 31 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-rene= sas-rzg2l.c index 6e55b325cca9..79837c754b60 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -212,48 +212,61 @@ static void rzfive_irqc_unmask(struct irq_data *d) irq_chip_unmask_parent(d); } =20 -static void rzfive_tint_irq_endisable(struct irq_data *d, bool enable) +static void rzfive_irq_endisable(struct irq_data *d, bool enable) { struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); unsigned int hwirq =3D irqd_to_hwirq(d); =20 - if (hwirq >=3D IRQC_TINT_START && hwirq < IRQC_NUM_IRQ) { - u32 offset =3D hwirq - IRQC_TINT_START; - u32 tssr_offset =3D TSSR_OFFSET(offset); - u8 tssr_index =3D TSSR_INDEX(offset); - u32 reg; - - raw_spin_lock(&priv->lock); - if (enable) - rzfive_irqc_unmask_tint_interrupt(priv, hwirq); - else - rzfive_irqc_mask_tint_interrupt(priv, hwirq); - reg =3D readl_relaxed(priv->base + TSSR(tssr_index)); - if (enable) - reg |=3D TIEN << TSSEL_SHIFT(tssr_offset); - else - reg &=3D ~(TIEN << TSSEL_SHIFT(tssr_offset)); - writel_relaxed(reg, priv->base + TSSR(tssr_index)); - raw_spin_unlock(&priv->lock); - } else { - raw_spin_lock(&priv->lock); - if (enable) - rzfive_irqc_unmask_irq_interrupt(priv, hwirq); - else - rzfive_irqc_mask_irq_interrupt(priv, hwirq); - raw_spin_unlock(&priv->lock); - } + guard(raw_spinlock)(&priv->lock); + if (enable) + rzfive_irqc_unmask_irq_interrupt(priv, hwirq); + else + rzfive_irqc_mask_irq_interrupt(priv, hwirq); +} + +static void rzfive_tint_endisable(struct irq_data *d, bool enable) +{ + struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); + unsigned int hwirq =3D irqd_to_hwirq(d); + unsigned int offset =3D hwirq - IRQC_TINT_START; + unsigned int tssr_offset =3D TSSR_OFFSET(offset); + unsigned int tssr_index =3D TSSR_INDEX(offset); + u32 reg; + + guard(raw_spinlock)(&priv->lock); + if (enable) + rzfive_irqc_unmask_tint_interrupt(priv, hwirq); + else + rzfive_irqc_mask_tint_interrupt(priv, hwirq); + reg =3D readl_relaxed(priv->base + TSSR(tssr_index)); + if (enable) + reg |=3D TIEN << TSSEL_SHIFT(tssr_offset); + else + reg &=3D ~(TIEN << TSSEL_SHIFT(tssr_offset)); + writel_relaxed(reg, priv->base + TSSR(tssr_index)); } =20 static void rzfive_irqc_irq_disable(struct irq_data *d) { irq_chip_disable_parent(d); - rzfive_tint_irq_endisable(d, false); + rzfive_irq_endisable(d, false); } =20 static void rzfive_irqc_irq_enable(struct irq_data *d) { - rzfive_tint_irq_endisable(d, true); + rzfive_irq_endisable(d, true); + irq_chip_enable_parent(d); +} + +static void rzfive_irqc_tint_disable(struct irq_data *d) +{ + irq_chip_disable_parent(d); + rzfive_tint_endisable(d, false); +} + +static void rzfive_irqc_tint_enable(struct irq_data *d) +{ + rzfive_tint_endisable(d, true); irq_chip_enable_parent(d); } =20 @@ -503,8 +516,8 @@ static const struct irq_chip rzfive_irqc_tint_chip =3D { .irq_eoi =3D rzg2l_irqc_tint_eoi, .irq_mask =3D rzfive_irqc_mask, .irq_unmask =3D rzfive_irqc_unmask, - .irq_disable =3D rzfive_irqc_irq_disable, - .irq_enable =3D rzfive_irqc_irq_enable, + .irq_disable =3D rzfive_irqc_tint_disable, + .irq_enable =3D rzfive_irqc_tint_enable, .irq_get_irqchip_state =3D irq_chip_get_parent_state, .irq_set_irqchip_state =3D irq_chip_set_parent_state, .irq_retrigger =3D irq_chip_retrigger_hierarchy, --=20 2.43.0