From nobody Fri Apr 3 02:58:26 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6B43537C2 for ; Wed, 25 Mar 2026 19:06:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465581; cv=none; b=i4Ta59PpqYNDGlInhqPgXEZ8puTP/wozPsO5e8FoMTt4xPlq9wQkGOJAsX9rYRvRhCTTSi+01y1e6+C9nTf2FmviPtbRBOibtA8lVCSAHUX0SMRVeMerTARuMSXMK42RjE47DeOubTkNs93gNK3CWq5F9FiX6SqylMUoZxBJsqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465581; c=relaxed/simple; bh=Bd/5OfzV7Sarf3QWBs7/bSDFPUaIF5mzDS/I9XfZQvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RkJs9hpxYLk62vQHawHhtuCetoJHh3wzWO35noYaR2EidjgAPORn6UI0iKBQPh/sW+i6JU/qyd0vxnGUEtXJiXhB7uJa7TYsJFqC23AGXMwo4oJNKyEDDXUeq78W+hiA4cFD0wEzslNAsQJto4j8xcMTrm5e1k2/iB0K4MJuckc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OuGDqYxj; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuGDqYxj" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-486fba7ce4cso2244395e9.3 for ; Wed, 25 Mar 2026 12:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774465579; x=1775070379; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eXqWD/J7jCnsXdMGUm54CWym6mF6LX/bj6037DcUiaU=; b=OuGDqYxjqMlqCcA4ZGPzKhN1zI32A4+d3rMeuZTZfiI9E+U/G3VbjscE8NY2pETClm 5tDhheoc5ptEgglkI+O1M+NMaJyp/8JP/ZLnrmQzmzGXjpUbuWjNq9LgK4Kb9vxJIoYK oa8oXbCElcNpaf+RQATKTwkXXACS0tC92shnyibsxFFxZ+z5d2uNR/vajMNEtFEmM6Yv dbwYNAJrt3aXxySncKiXL0gAaW0bLo1c/8/VFCmCQ1jI/glFUg/8ucnb/EefXzaL+L08 FuBDyuCwrKaPDqHobyvyJyOnp3zPpTuB0eRttZheurZ1DWfLqHmOPiZpNp5dsuQnSuyh DRSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774465579; x=1775070379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eXqWD/J7jCnsXdMGUm54CWym6mF6LX/bj6037DcUiaU=; b=hQeL/u6/5DvwTdhJQRJhoxfi/4uPSOiyFhswYtIib3SwYlPlwPrvktK1appuByZJR3 ZyEvw1s1Lj+rVhIOJSqJr6ii9AUnFbwWQSYBRangwpWEmK2Nb+l2VQJTT7Gm8J3Ppzl3 AEDHwO0m4oPhC1oYwwQmIoW04dEsjNn+nRg8Ycm3ZXHypv6Hu9VTGp4AZQiKbZi12KJg JlGF4IzPMjcRr+SpczKA8yr92pqy1D7WpfZi0TrK43iy0YA+zcx5P0fIEFjQhZScx8HK VLp0QPB2/MO+j3M43YUltkpZE20YFm+DhxRVb3HiP/Eup8J0unYYLc0OTvqRSkL8e7OS YpvA== X-Forwarded-Encrypted: i=1; AJvYcCWvbykVNIfaKct+s89HAVWahfZljRCuVE/B8YYKxMODljEVeGOWq3z77L5XQmD+ow6NDgXPAxbaNK7Xofc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7ypCeVy0XTvORbWDO/qIa/MqboiRh2mfsodQBtK/vjBHKHspI RdNXuoMNTtckYlPuSoE5ZyB15rfFUhKH7zStK3minm7wU9esfPHGWy7T+5U3tsr8 X-Gm-Gg: ATEYQzyCVTAMqtoqkn6GhMUqvKRo/1jAykD1xBwlQiJCYKgGECYutFCwKcPwpRAUNDl nhEnbOa5ZpDD1pdt0LRXi2+9AJlGNopOy/SJquA70JEJOm9D49lickuCvi0x+nkzrfPBW0iNVL2 rRwpNkajZPdsU7cD3XE7uKKfNN9C8v1gwetTZQucS/uWj+dMHcMHd6dgtkBUFeATk+wDjY77DZt EMmLhhNKleazdlhBr0tQ2wYxQCozD3aCQBzMbkzyBjX29dJC5WfNo6ZpUiBc8G7XD2RNjTAO2mH gCNsfJS+i91tjv03aj2EimEcCOHqkDkcEK1VAE5IGGZokCmDqGViBY5Rq8S+0QSjMZjLE/RGVTT A4mBHtpD4PhKznpEdJ2Z7TH+ooO8hirTY6ew5/5aF/R3Mvk0fBVEAcwzVLrdsD1sIWVyM0MqFON AH159AIW9DT389o6x1O68CD10= X-Received: by 2002:a05:600c:4685:b0:47d:8479:78d5 with SMTP id 5b1f17b1804b1-48715fc38e8mr72717625e9.7.1774465578884; Wed, 25 Mar 2026 12:06:18 -0700 (PDT) Received: from potato ([31.176.175.159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919df7dcsm2090294f8f.27.2026.03.25.12.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 12:06:18 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v2 3/3] staging: rtl8723bs: clean up callees for sdio_init function Date: Wed, 25 Mar 2026 20:06:00 +0100 Message-ID: <20260325190601.7906-4-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260325190601.7906-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260325190601.7906-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Let rtw_resume_process_normal return errno returned by sdio_init instead of -1. sdio_dvobj_init returns NULL on error so leave that as is. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2dfc8..e943dcea1a21 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1135,10 +1135,10 @@ static int rtw_resume_process_normal(struct adapter= *padapter) pwrpriv =3D adapter_to_pwrctl(padapter); pmlmepriv =3D &padapter->mlmepriv; /* interface init */ - /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; + if (padapter->intf_init) { + ret =3D padapter->intf_init(adapter_to_dvobj(padapter)); + if (ret) + goto exit; } rtw_hal_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ --=20 2.51.0