From nobody Thu Apr 2 23:54:51 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DBDB33A9DD for ; Wed, 25 Mar 2026 19:06:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465578; cv=none; b=Ho/RHkym3bMtwVA1gAGvyk45IMV1hVeFyS/WvDVPGXqNd+7H0+Mto7p5grzkiI9uUaJs5D2zb2FtXQuTCTJcJvIkzUCh1lqCXsDRta/Lkabo1u9y3wRRh05a0m4XQGmz3NfgeuhRqWZWjaATH9Ijh+36ZVjOWK3xj8tHfQ8Ly6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465578; c=relaxed/simple; bh=yMyzaFoknNuQ6pVvN+fu/ld64KkXbgcWoC8dH9PpS/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DHsRJRbM0LMkTmZje+xcaQP5OOjCKtIH985GbY1dDUHuEh6suv7vpMVADKj1h9FWLpzXuC+SnTibrSiFLZxHRLj9GiiqYeUKm8iaTtFDPVB1wPTKa7+A/ZgZ593+2mtb0B4d05ML7QBgQDu+sjvyTV1cFonV4ROUYqvLqXsO6dM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k84ZhYl8; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k84ZhYl8" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-439d8df7620so121073f8f.0 for ; Wed, 25 Mar 2026 12:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774465576; x=1775070376; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=k84ZhYl8gPPBGOg08mnvsKp6VaJ6kTua97dwADrV8Qa7Qt3gRv7+q9iCLemmwAtNSk vS8izHa83pA2QFp+m/LhUBLmvkMw8yUaRJc3sOnjfiF4D2UeJMCBDYlmuSeGjPY/9zpn bLtjswWnvlnb5XcArXOJwqBncLG8TiR7pAsa+ZDnjSodG/rj8EcDSMFR5oQz3uZbjx57 iujky0jkAV5Uk7Fv2aleFeU+6puX2seCMT5wzxYZ8+1AlRhDtKUDq/+BN8D5VA7Ny9tA lYH32cuRjIAnJUf1SLzurBk+wS4myA6eWErYLpxe8JWuSkuZY5025fBShYAnwCqlR6T/ z5uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774465576; x=1775070376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=JFsYOQ0alDi7OYHBqIMelQUviNIl34IN3CCU6CIMOtoltFPXj5Yv92+CrqUMd5tZq1 C8iNXNoE68p81FVlRL8pBqd+Sh1OW3F9a4sp3tbBiRUwDgYdd7kBsKXWq78OEtbwTBPn 3I70F5wmrqoYTCI5gCFU4EAcrWGL+ucKfugu3ntQahtHoKFGV3dIodXUQWjiGmEwGnAS kX5AjeuCA7RG/F4kblWCv5J6gUxF/SPBzJaNmCOj/AlwPQKsFG73okr9B1WRG7qReqc1 LtxOa1N7S4+cXDRKzDSvW/t46oyhLQUPgSJT3rDGGx/7TVIzhtEfqkTCM2u5dbQ30V9N R58w== X-Forwarded-Encrypted: i=1; AJvYcCWi1Z2Bb9ae1YfaP09rw7WdIow1cqFagCZ8G8yvw9r0VeC4dXvLE6HXSlYY78ap7Z4hUZwjr11Sy35JnH4=@vger.kernel.org X-Gm-Message-State: AOJu0YwNfLcVMeEAuP6zSmNG9trFF3FbdC3pvCLYL17bEG6ztdhuthQl aXUCKXa0G+3U2DoFee+Ujp7lffHD93p1bTN7PNeO8MZnFnAMCu94cQM4 X-Gm-Gg: ATEYQzwtM+55FPptI9FiQr68kTzZ362mgXbWWe7sjWAGSdwd5Kl3yALWNEumoJMgGbq y8/i761SF9fXAc/DVFdhCr3tTqKMu53DEEDO3+G7P77rtilx68FK5kQEU3W3VyRuZH95XUf9gsS yMdjIzWi0pvha77KnTyHQs7925z+GLs3sYyH6k/lTf03AObO4AvVd5ft90hk6+R6QlzvwfHFyyM vsTFpLhFVAtx/DF7a0EggGqpm4GwtiypHi90tPe/cGPlA08NQpT+npH3kIeTCmyAKRVJMxTSNUH 3usrttX97Cqa3ovMgfPGPqccXOrh8w6/8IdDSWebZR30chBtatQ79z8XodLdCcaqbjB2jgEFvo8 xWnZwPoXfF3j6RIy3hHXk+TyKboQjKJ615zWs/hwiyalKcP6NKJDppTBB1gtsSrYgNvMOVY9b2y /TSkhtYN++sqX8nfjoFmvNCQg= X-Received: by 2002:a05:6000:2506:b0:43b:852d:a382 with SMTP id ffacd0b85a97d-43b88a0cfb3mr7301831f8f.41.1774465575653; Wed, 25 Mar 2026 12:06:15 -0700 (PDT) Received: from potato ([31.176.175.159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919df7dcsm2090294f8f.27.2026.03.25.12.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 12:06:15 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v2 1/3] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Date: Wed, 25 Mar 2026 20:05:58 +0100 Message-ID: <20260325190601.7906-2-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260325190601.7906-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260325190601.7906-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_dvobj_init() use direct returns Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..358eac0837cf 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -155,13 +155,12 @@ static void sdio_deinit(struct dvobj_priv *dvobj) } static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func) { - int status =3D _FAIL; struct dvobj_priv *dvobj =3D NULL; struct sdio_data *psdio; =20 dvobj =3D devobj_init(); if (!dvobj) - goto exit; + return NULL; =20 sdio_set_drvdata(func, dvobj); =20 @@ -172,18 +171,14 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio= _func *func) goto free_dvobj; =20 rtw_reset_continual_io_error(dvobj); - status =3D _SUCCESS; =20 -free_dvobj: - if (status !=3D _SUCCESS && dvobj) { - sdio_set_drvdata(func, NULL); + return dvobj; =20 - devobj_deinit(dvobj); +free_dvobj: + sdio_set_drvdata(func, NULL); + devobj_deinit(dvobj); =20 - dvobj =3D NULL; - } -exit: - return dvobj; + return NULL; } =20 static void sdio_dvobj_deinit(struct sdio_func *func) --=20 2.51.0 From nobody Thu Apr 2 23:54:51 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1270F34D929 for ; Wed, 25 Mar 2026 19:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465580; cv=none; b=ZwubJF4TH1vKx1n6AC30lSZ25azsSdOk5Omksos508bN2hOguzD6QBIFBMU8yQfH0mSpa8CN2dRJQKtjtA1B4OCi/HzpOXHFYGI5iJsSTk765ABw1Gwg0RoFf8VTs0iqYgoIGE9MQy3jU2C7lfwAPsE8QQ2WDtI5GDd6LjI3qUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465580; c=relaxed/simple; bh=UoObvnnZRPgdvTgqoymjmAp+D17szqmEHwzVj+aDlXc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MRNEpSTeeDXkDnXRD1CGsvYsDhzMB6VWPCpV+jehlq7X72IbhTihpcGufSMNB0Kh9h5YRrDsUBz2yL/QNK2Rfq8xDgdc+0yqh0Rgz12ZYoVGo90P4NekUoEiUgWCa8C5wy6wRHtVPcQFVU/TO+eQE49jkTzJ48tJ5QQnpTnt9vY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oMot5GX3; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oMot5GX3" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-439cd6b0aedso98275f8f.1 for ; Wed, 25 Mar 2026 12:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774465577; x=1775070377; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QxfMVpIjXpWEhI2DEdBaY44M11aQ1DT160hMDVvL9os=; b=oMot5GX3eJF9aX/EgF9YkX4rCkosNM7w+CWsjomWYho/eyYRXi37vC7oTAfBZJmfvd J2KOqtw1dfEaqmFCAj8pbKs28MAG6GWZhtC2AJEqf9LyGhnFBCkbtZaHV8jvgpqKplVD KqCYTRvcOKOymOE6Y2YUrctVD6EArcIvn62BegAlUDoaYDQt8SX9+Ni3rEf7bW+70oa8 dkSrd8lXL+D45Jch/oeflSdqKS5CYmEzIp4fJxu4Q7H/kgnYjBZBj+LxU7EWHq0dmTP+ a6ji31gE06bmRfbiiZ/Zx/lz2YKd4zO0NjvlfQBGvI/hG0B7dZqrOmZVwDRLldFJSBDK FhiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774465577; x=1775070377; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QxfMVpIjXpWEhI2DEdBaY44M11aQ1DT160hMDVvL9os=; b=Vt8a0O4WSh9YX4IzUe+mo41RL9lAuW5vCfkkiexSJ/koQ6vD8LuGXkbpAbPBaRauHH XBbVZG6xfv6lFksZbNsYlJXaTViB6UrUeCeRwifvFwhC0pOnv6Q8EGQVAu6loEyX/M9L AH5/sXvNEHRMm0Qw51ICGukwhWH52IhL3NeQb9tkBN/pgRVtNE5rcdMQXq87btTspOox DCWKrqKgkOQlshHgb3ed3xn8Ru9cWVo0TAeW779SYgq5DwEVAiZlDJZvTeJoHcGiGZac mvKVmNWg2p2PIVW1J5IJc09dQs9QHyfkXhQV1Lfx9AQKgGj1yr/FvLl/nBHYqXqNaukT MPQA== X-Forwarded-Encrypted: i=1; AJvYcCUmRTIOgP459K+gvz3+zWfokuPMpXz+an5qslGR/wqO0vLHhjqZSuK3QsuGBEohxTIjt9LloY/I3QMucEg=@vger.kernel.org X-Gm-Message-State: AOJu0YwuVCG+iOhP1FZuIqrb85QqZvnmcnR+B9GfO6e4HuYeQLIMlyqd 3SgNXVaE79TBPwH5Xxa/P1YA5dc3IHSqE4d2ILSRc0WdWYmYOat8lt2n X-Gm-Gg: ATEYQzzOgatYRdNQFwP8G7d8VTeOVXgJIhXc5NZ1mohADSt/VeKrsUxKBdnpTC5of/8 WgqX1Fl+dxanXoXtKKkk1TEDD/6XUvQee8I73oERawV34lAkmFv9QqZZvf4oPbKPGss9B+NW4ZL 0+u+9BIa0zno8eUIGKNERIuMmyK031sSSgi7tnPRfo8nnW3UUZfulOZuggKKXTPULd1qz3o2k3L q5zAU5R15Lx4UxMKR5iMvSt6+48Br0e79LfFuelpukC9KGzPOMRkpLeG1JMwrZMyL6Ubioe+IYO 5deqZUtFz9F3eZgWfRFP+fekTMlZChhGuse5+2s40NU71oXBbFAlbQW4j1SZQcbum9idGBg6VTo 9K/NbOS0cPTQKsjcRyL1cyB7mAycJ5N37pCQ1/B+ieCzHRAgnt+vrh652XsvIpwBYX9ADYMZQil TgeQ4tXjQRfw5wna58aN/pQqzMaX+1Qq1Bkg== X-Received: by 2002:a05:6000:18a8:b0:43b:464a:28de with SMTP id ffacd0b85a97d-43b8899cdb7mr6621937f8f.14.1774465577338; Wed, 25 Mar 2026 12:06:17 -0700 (PDT) Received: from potato ([31.176.175.159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919df7dcsm2090294f8f.27.2026.03.25.12.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 12:06:16 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v2 2/3] staging: rtl8723bs: cleanup return in sdio_init() Date: Wed, 25 Mar 2026 20:05:59 +0100 Message-ID: <20260325190601.7906-3-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260325190601.7906-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260325190601.7906-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_init() return errno from sdio_enable_func or sdio_set_block_size instead of _SUCCESS/_FAIL vendor-defined macros. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 358eac0837cf..01b5d8a70072 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -131,9 +131,7 @@ static u32 sdio_init(struct dvobj_priv *dvobj) release: sdio_release_host(func); =20 - if (err) - return _FAIL; - return _SUCCESS; + return err; } =20 static void sdio_deinit(struct dvobj_priv *dvobj) --=20 2.51.0 From nobody Thu Apr 2 23:54:51 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6B43537C2 for ; Wed, 25 Mar 2026 19:06:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465581; cv=none; b=i4Ta59PpqYNDGlInhqPgXEZ8puTP/wozPsO5e8FoMTt4xPlq9wQkGOJAsX9rYRvRhCTTSi+01y1e6+C9nTf2FmviPtbRBOibtA8lVCSAHUX0SMRVeMerTARuMSXMK42RjE47DeOubTkNs93gNK3CWq5F9FiX6SqylMUoZxBJsqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465581; c=relaxed/simple; bh=Bd/5OfzV7Sarf3QWBs7/bSDFPUaIF5mzDS/I9XfZQvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RkJs9hpxYLk62vQHawHhtuCetoJHh3wzWO35noYaR2EidjgAPORn6UI0iKBQPh/sW+i6JU/qyd0vxnGUEtXJiXhB7uJa7TYsJFqC23AGXMwo4oJNKyEDDXUeq78W+hiA4cFD0wEzslNAsQJto4j8xcMTrm5e1k2/iB0K4MJuckc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OuGDqYxj; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuGDqYxj" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-486fba7ce4cso2244395e9.3 for ; Wed, 25 Mar 2026 12:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774465579; x=1775070379; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eXqWD/J7jCnsXdMGUm54CWym6mF6LX/bj6037DcUiaU=; b=OuGDqYxjqMlqCcA4ZGPzKhN1zI32A4+d3rMeuZTZfiI9E+U/G3VbjscE8NY2pETClm 5tDhheoc5ptEgglkI+O1M+NMaJyp/8JP/ZLnrmQzmzGXjpUbuWjNq9LgK4Kb9vxJIoYK oa8oXbCElcNpaf+RQATKTwkXXACS0tC92shnyibsxFFxZ+z5d2uNR/vajMNEtFEmM6Yv dbwYNAJrt3aXxySncKiXL0gAaW0bLo1c/8/VFCmCQ1jI/glFUg/8ucnb/EefXzaL+L08 FuBDyuCwrKaPDqHobyvyJyOnp3zPpTuB0eRttZheurZ1DWfLqHmOPiZpNp5dsuQnSuyh DRSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774465579; x=1775070379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eXqWD/J7jCnsXdMGUm54CWym6mF6LX/bj6037DcUiaU=; b=hQeL/u6/5DvwTdhJQRJhoxfi/4uPSOiyFhswYtIib3SwYlPlwPrvktK1appuByZJR3 ZyEvw1s1Lj+rVhIOJSqJr6ii9AUnFbwWQSYBRangwpWEmK2Nb+l2VQJTT7Gm8J3Ppzl3 AEDHwO0m4oPhC1oYwwQmIoW04dEsjNn+nRg8Ycm3ZXHypv6Hu9VTGp4AZQiKbZi12KJg JlGF4IzPMjcRr+SpczKA8yr92pqy1D7WpfZi0TrK43iy0YA+zcx5P0fIEFjQhZScx8HK VLp0QPB2/MO+j3M43YUltkpZE20YFm+DhxRVb3HiP/Eup8J0unYYLc0OTvqRSkL8e7OS YpvA== X-Forwarded-Encrypted: i=1; AJvYcCWvbykVNIfaKct+s89HAVWahfZljRCuVE/B8YYKxMODljEVeGOWq3z77L5XQmD+ow6NDgXPAxbaNK7Xofc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7ypCeVy0XTvORbWDO/qIa/MqboiRh2mfsodQBtK/vjBHKHspI RdNXuoMNTtckYlPuSoE5ZyB15rfFUhKH7zStK3minm7wU9esfPHGWy7T+5U3tsr8 X-Gm-Gg: ATEYQzyCVTAMqtoqkn6GhMUqvKRo/1jAykD1xBwlQiJCYKgGECYutFCwKcPwpRAUNDl nhEnbOa5ZpDD1pdt0LRXi2+9AJlGNopOy/SJquA70JEJOm9D49lickuCvi0x+nkzrfPBW0iNVL2 rRwpNkajZPdsU7cD3XE7uKKfNN9C8v1gwetTZQucS/uWj+dMHcMHd6dgtkBUFeATk+wDjY77DZt EMmLhhNKleazdlhBr0tQ2wYxQCozD3aCQBzMbkzyBjX29dJC5WfNo6ZpUiBc8G7XD2RNjTAO2mH gCNsfJS+i91tjv03aj2EimEcCOHqkDkcEK1VAE5IGGZokCmDqGViBY5Rq8S+0QSjMZjLE/RGVTT A4mBHtpD4PhKznpEdJ2Z7TH+ooO8hirTY6ew5/5aF/R3Mvk0fBVEAcwzVLrdsD1sIWVyM0MqFON AH159AIW9DT389o6x1O68CD10= X-Received: by 2002:a05:600c:4685:b0:47d:8479:78d5 with SMTP id 5b1f17b1804b1-48715fc38e8mr72717625e9.7.1774465578884; Wed, 25 Mar 2026 12:06:18 -0700 (PDT) Received: from potato ([31.176.175.159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919df7dcsm2090294f8f.27.2026.03.25.12.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 12:06:18 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v2 3/3] staging: rtl8723bs: clean up callees for sdio_init function Date: Wed, 25 Mar 2026 20:06:00 +0100 Message-ID: <20260325190601.7906-4-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260325190601.7906-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260325190601.7906-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Let rtw_resume_process_normal return errno returned by sdio_init instead of -1. sdio_dvobj_init returns NULL on error so leave that as is. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2dfc8..e943dcea1a21 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1135,10 +1135,10 @@ static int rtw_resume_process_normal(struct adapter= *padapter) pwrpriv =3D adapter_to_pwrctl(padapter); pmlmepriv =3D &padapter->mlmepriv; /* interface init */ - /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; + if (padapter->intf_init) { + ret =3D padapter->intf_init(adapter_to_dvobj(padapter)); + if (ret) + goto exit; } rtw_hal_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ --=20 2.51.0