From nobody Thu Apr 2 23:54:45 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F5C134D904 for ; Wed, 25 Mar 2026 18:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465178; cv=none; b=tlpsK0fuBvmlaQh/v3/AV2Eqa9IWSs0MZ/xjftIGa1b6XCKRUfahsNtq88lRLEFz6sTxDTWrmUFoXiFKPaf7Trzl2zCwV60Yb0rvaHePMbs0VfxRDPHEYUAHzyFrCVrnXvzwwLzMLyZSA58EXJ83RFIoFDF0zk3SYW9sAOzx4KU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774465178; c=relaxed/simple; bh=5/SJDJkV4+/g5MuOk9P15f7tRAwVbeu/rhg0gcRd66M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pd/K/3UVrP27uXKxndUwqeBCpGi853TXG0UvnFLERJ33a90iQw57u2NiBJ0B/wy6kXEN4THLsvkbpSbHMl0Or8KKZiGsVLbPED7HCJC9ZOKV3lj4o53y0wHMjwxD8ME/yAfj0VMEEOx3LvJX41PJYCyUTbqWCI/6XqU4i2oghbw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AH6Y5ORw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XP7pl4Sy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AH6Y5ORw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XP7pl4Sy" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PFRIIb1432136 for ; Wed, 25 Mar 2026 18:59:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=jQ/oQs6UJQqcj3OwossbpML3FdcdNFDAZeD Kh0U7al4=; b=AH6Y5ORwmX/fye6TGIHruZfMQHtoZP9RYg+ew2hfYoNoeLFpp41 q0mVpuN9vD/dD4zD4tTUaCo5Bo0jAZ9iQQicEkBUsZvY4Lq18wW684EsZddKYP2w LWO0bRNJBsvtaDhUjW8Np88teMNVSQB11XaZrx+/gGn1YAR0+eDO3QAlk3DhfRKD NpVeu9f3beC1MIT2x6dTpEAc7KZFn6y/xMJ8MXp1ihsuwZgQy2Lda54r8MquR3S0 cOHwGMuzm4AsQG2AbS8jbNTxuE1OsX0Pk0rYlDc8b1jRGujLSjAxb/UqUaHbrdAD aoC4V8N07dCE6W3tK4OX1OFNoUiuxqwkvDQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4jc50tvq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 18:59:33 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b0560c1320so3803215ad.2 for ; Wed, 25 Mar 2026 11:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774465173; x=1775069973; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jQ/oQs6UJQqcj3OwossbpML3FdcdNFDAZeDKh0U7al4=; b=XP7pl4SyFrbWflJxzVKF19ziusXByVk6m5VoCxHl98OUFiHiZ/DucuFYRdX6nDIx2m c60ExNOjSSg0cYC0VrLhsNU0tON2uQpV6Gc7FCZmBqCVgrCpkjBGo6UQbN98MQvFenNl nKVgC9O4tfRZbE0qlluuF6d6P+VsgCKInAerFdFJ5+fg+Y4FdWFeTasxOgRNlykHaKen JrRXfp92f07K/5QTYG1s6TLsi2G65406MN/I6sqGy+nbtmz9x8Cuhiv/q9exJbXdiHHx wHei2eSAVtl60flnlM0p3lcyqpn/W5kgzohTj2ytarBmbsxDn5Ur+oTKTRapy1jHSjMk r25Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774465173; x=1775069973; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jQ/oQs6UJQqcj3OwossbpML3FdcdNFDAZeDKh0U7al4=; b=JbNS+JTv7huyN7RE6yWg+qycF9XvGXK9xo+k5I4ZUytm+GARaNQ0dHNIEwx1AfQSk5 DXYXt/ApsdOFG573Moye1N2q/6OGP6VRvDinKnZ9IfXd93xEnAOwLGQs1zgUEAKUXxQY nMxrIKEYU7ZM13MttnhsBpwu6emyppBoe5K0QVpM7XfZMtMDAX3Kq2mesvl0NokQvqsB ZknjIMPSSOyH+GWdnb5uMF9P3iBix5CQW7Gj8dmu0Q0e94CYhxUPSr5u8fjBmSTQQruw /MmBmMsm6WduCbQgEuafst3AuLtcVbMLbKHU4rUtG/UTUvVyLq7IEx9WNxjaOlIfv6y3 6xCQ== X-Forwarded-Encrypted: i=1; AJvYcCX21QRsFGFpN42yLrAelnSArEsZF4D9i51BwTvFDQDhIv1BCN9kRzUUxYnDYCKEFCUlLCa+xJXwi5zchaY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2wzlmozW3jmBvV7nmy0dWQyS6oXTChYwjBcbaiYh3uMviTTPt GWjohqoQamOx2MIG/AzgNVUoVZn8z0NjB830BNt3fSUvUwC8AoQYpa3tiCQi+fgIF9DMF+YxW4b 3jgLwnIbqrBahNUFR8cqy/E992NTnwKtNbjXPZ0TxytFK+Ghx3a5DQ23Ja2zE0pyKRvI= X-Gm-Gg: ATEYQzz/qEUru2VBycJ7tqsPewTDlwzdFAaAmQWlS0xbJ9bU9coXRHZTpnI8gtaImxq b+ohC4dmtzFpFBcFbqK9/N0xclk9E8xJ5sSgAPVbXBlqVNFxLemJYOKhFKsB/KbQUkqS1fX1Ufq Jxt7tlsn9klXKVOlZUjC9tJ2eCU0FL9ixnHRFDuqzLNsvP5TPVv4/ZBv8/jkuEibZ309vS6JQzO smSqSotqZ/kh02gMlQi7IAaxCecvHW0vdcvElfjr3F7wutK22dHu35S4iCP2YBsdiRrtIfzJ8lg YWWpiCRDEYpuutExxcCB2FCwmhoi8CHRpVhUeqAaHR6qMZNFMX/i4WFfg8DeLn2tlwR7VWNOBEQ QmGshWPtLU0CW4FxRI+q5UTjRSD3pHGd/ X-Received: by 2002:a17:903:1b6f:b0:2b0:6263:6a05 with SMTP id d9443c01a7336-2b0b0b1e31dmr50542375ad.51.1774465173017; Wed, 25 Mar 2026 11:59:33 -0700 (PDT) X-Received: by 2002:a17:903:1b6f:b0:2b0:6263:6a05 with SMTP id d9443c01a7336-2b0b0b1e31dmr50542095ad.51.1774465172583; Wed, 25 Mar 2026 11:59:32 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc87ebf1sm5764125ad.44.2026.03.25.11.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 11:59:32 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/msm: Reject fb creation from _NO_SHARE objs Date: Wed, 25 Mar 2026 11:59:26 -0700 Message-ID: <20260325185926.1265661-1-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: ZoG7nE4R6KNYPGmjn1KD8KjvOVB4z6zN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDEzOCBTYWx0ZWRfXyZj0p4PxxOGi c499CwzUbyDrhB2RzsqHWrulaBZOgYJHl/AjgLNmNzzoeZKdEkXFUsJF/fSZT7EUf8lR2UG9DK1 JUg6GUuw4uzCyZJAZpKVudBb14Fd83iXZ2F4HEqhALJ4X6sTN5Z1BVZZ2O+YQMsa1A2l3uiflFT BwtcuSPs2UgI1LjwuIabb30usyByMvEHee0ezcOXBVUS28guFQk8JhSNQzdlIfmijp82fK/wHMy 1MtHHaDoc5PgnUuPPruycVbnufDNAeTRd3TsXqH7JbpRJYtXM3Kn6tUSLqVaFQDhJVEyUYwbFmP fVHhAMAZixTf3PVZLfdJ4oyV17uUU6GMAHCPrQO/B1IOI3MLVXvNfCud38FEtsHKKqO9dFGjjMu CYbuMS2QVtzIyWMlf+7TGLY9GTVfogQhg/4aQw/3Lf4u76ASvtq7b4KrDwAGo6avFUv3r2EgXjC bXiTyS2NAKGTX5nfkAw== X-Proofpoint-ORIG-GUID: ZoG7nE4R6KNYPGmjn1KD8KjvOVB4z6zN X-Authority-Analysis: v=2.4 cv=KaLfcAYD c=1 sm=1 tr=0 ts=69c43096 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=LRWyuCbFSbfGocd5_k0A:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_05,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250138 Content-Type: text/plain; charset="utf-8" It would be an error to map these into kms->vm. So reject this as early as possible, when creating an fb. Fixes: b58e12a66e47 ("drm/msm: Add _NO_SHARE flag") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_fb.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c index 1eff615ff9bf..ce1725990a48 100644 --- a/drivers/gpu/drm/msm/msm_fb.c +++ b/drivers/gpu/drm/msm/msm_fb.c @@ -219,7 +219,12 @@ static struct drm_framebuffer *msm_framebuffer_init(st= ruct drm_device *dev, + mode_cmd->offsets[i]; =20 if (bos[i]->size < min_size) { - ret =3D -EINVAL; + ret =3D UERR(EINVAL, dev, "plane %d too small", i); + goto fail; + } + + if (to_msm_bo(bos[i])->flags & MSM_BO_NO_SHARE) { + ret =3D UERR(EINVAL, dev, "Cannot map _NO_SHARE to kms vm"); goto fail; } =20 --=20 2.53.0