From nobody Thu Apr 2 23:54:47 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E1C7339875 for ; Wed, 25 Mar 2026 18:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774464056; cv=none; b=K/8hC+WC3vJTCLqyi7RhixCrDitzJ1d/xmHTpTdg/C+Pvo0bqrKioKYXyEFSpP1M26ccOiYqYsvWWqI5IM4koano1Vu5KMuwjE5+ftDwYc4wm81fFdllJ/a9e4/vaF9CX1OM0yTv+cyDpawDyzxNTwMAH/HI66V1l9kaj0++lA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774464056; c=relaxed/simple; bh=imin10cSx0YrxDj2Z4/XJpCeru83iyKHIxpZeZ+tMEI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=em8X3QEJtMPjFQIl7zzh7yxCaPG4u54CP9LZHP2cCbfDouqNtn2CdZ+sVaMgHwV292uhQRxILNUj4rIuM9Xm1m7U/QHKgB7bJjbnFDkWzYdIvX4rS/qO80hqkzezdTFpDkfayNYT6b+vaUSUvVfZ0fXIbz0PdmGwl/QU+Ik4sgc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=alB8XlKp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d7ufRlwZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="alB8XlKp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d7ufRlwZ" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PFH3L71257960 for ; Wed, 25 Mar 2026 18:40:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=mvdkUSKRAO5A5qk1dmV1+LN6vXJ34iPcEA/ OJJ+Ig1M=; b=alB8XlKpiWAXN7LlE++Jw/vtqeVlgKNabedRgJSzMbrw9weiY+0 pFhM4qnkvY7YkAITdIWAaJEJJMBhH4goIivhBCWU/NmedpPjl/KYIVDcKthRoXak fG3SNQA0d8tfma0H4qbTz4tf3Ly8Q9THXD1KhLX5Tqr9AyeOQJU04EAz+FtuhLL3 ydf7fhs2RMlB+FE8VU/PchGISiynzi4tKD36mru5QwhPdo3H5vrM7Krp/c7G9oX7 6sAHwcHOEP78AKDfrf+zXLFSLc9a26OIqyI21+OcoZYLp+NSx4n9IhU4twQdiTJq /tvvOCC4m0XwFS05lvrdVe0z5gqRRFALk+g== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4dm2swwg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 18:40:50 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3595485abbbso356041a91.2 for ; Wed, 25 Mar 2026 11:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774464050; x=1775068850; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mvdkUSKRAO5A5qk1dmV1+LN6vXJ34iPcEA/OJJ+Ig1M=; b=d7ufRlwZi7COmb/5CIWwXW3y7R4eEbH4hSis8rfaATf5dEca/NZHwk7loBH+yeFrr4 7YJTJ/ALsSnwbdwoRy96f9Z2G80vzjd5UGlARdKMfuqujMwHI63nsiegT2T5JDeQqeBn llvMYZhri8dktUB4aThfEkPvwVrCL5ZZDD+fw4Xzladn+DjMMevT17eqD8kpukY8Z11Z YWfzKyO7PwWtRLyLw8QNj6N3N4r50x2KeT0tq2WcREhT0wU7o1+GPycDq80ctJO+VP4K jUR/CuhDOTUBOlcveQQY/6pFJQnWHYky8cbkMVTGfVdQeJxiRrEOa/l8HMdLv+HwJRgQ SIVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774464050; x=1775068850; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mvdkUSKRAO5A5qk1dmV1+LN6vXJ34iPcEA/OJJ+Ig1M=; b=ghV6WkhJQ4s7gv4jM1eiPqyKcIYjE1Ya6UW9oQ3f51dKIrydOy/Y05FhCVC8I2AgZL Ut3NkPoWG3XC1kHGBZJJV7l1oDot31wHZofozKM84KBp8SSI/fLgTVzdkc5koodL1Xml iGcIDn1jFtyx5x+V/MOTsy/nnZulj2RDcZiF2PM7eWJAQhhE/BihEWx20amnIAgefLQa /hrixessK49kilNV3c+tdAQdmhRLrjsNYN/6A060ELyQYWdHOYB4xf9OtwGdsJffkLZL YKCBM5+97dlD3EkIzdg3mwzuYwYCP1QtJySUe3FuOnvQ07VBTSSpvmrk2Mrx+Z/vJEbu qgkA== X-Forwarded-Encrypted: i=1; AJvYcCWnux/sN6JvL7MWh9LJAmLnHhYA/UrMTRnjRYh+vWYJV7GBkXtUm9vPFYixDHFh9eAHZC9MjVyHEtW+VRI=@vger.kernel.org X-Gm-Message-State: AOJu0YysMut5yLSdLL9txUo2wl2/0qA6uG3g2jDzRZJmp1WIksh4iF+A 7Q40G8J+Qr+dUINZDndwp/kctKyItnHSV5QIsqCP2sZQxuWRZYFBUFJEbBBIwVH6fWqYsk0SqSu vE0btftdSeewXXyVhP4ReojFkuXtQv0X9Z8oXBpm7GRiOYU6tT7gptPDktrJa17p9XSXqT4CdXW g= X-Gm-Gg: ATEYQzxSPV2L1ZULboaVwcLEScdsDg8vyeacD5OLXb//3ZsWT6YpTFrLZ4Wpx0C2+fF kgNG0ZbQIMb6thKGftsmkUY3HHu7dkTpgUPSGOjmZmjdb3SGjW8xX7IQDvn+UZABGxsY9cjeA15 a2cs4quofrscY7SMp4jZKp1H67zpCrxeuuRHNCqAUTIVnOlLMIo4ApLLgx4K+ctw4EHxwPxLGHs 5l9+quDylBrjuMjeUdVN4sH0UmSsbXGIioQsR0NJU2Tx/NXXBScIvBE51/roHZtzY7BYvboyx8O Q6jUcKTFQXwvq8zeNkjNzswKO3YtxxGKyTw5AXXzQLggGxuuxGYMKwVprw6BWBeLhKBDUtbV5pH nA62GxOw91RxlBraAjvBTXSxcQRB9cvdC X-Received: by 2002:a17:90b:6c3:b0:35a:1762:92ed with SMTP id 98e67ed59e1d1-35c0ddc589bmr3883533a91.24.1774464049576; Wed, 25 Mar 2026 11:40:49 -0700 (PDT) X-Received: by 2002:a17:90b:6c3:b0:35a:1762:92ed with SMTP id 98e67ed59e1d1-35c0ddc589bmr3883507a91.24.1774464049121; Wed, 25 Mar 2026 11:40:49 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0e7452d8sm3198165a91.11.2026.03.25.11.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 11:40:48 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Connor Abbott , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/msm/a6xx: Fix HLSQ register dumpping Date: Wed, 25 Mar 2026 11:40:42 -0700 Message-ID: <20260325184043.1259312-1-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDEzNiBTYWx0ZWRfX7QJwiaWesSIO qnSqV1xvGK6JfhnKbCiesLketlgr75uQyuWOarXkK5pLZ9XzdQBuKItKeErL5Z/ZTyGU0U1POyM k7nH0zMQWCQ9SboYdpA4sp2C4caZ9J0AGLuachFW/pztLxZhDer7R63fbRGzmOYKN1+jcX37Sgl DWV//t/+mnxWYSPCvE30ZzooIqBY5K5hyt951A43lE3Eqv9KExWVcS7L1UmnIhtNdI71MMLGIsD h8O+ZEK3wduAoF6/D7Rz3G5rNXR5x+fdvCcULCO0UdHC6f9tgPlPJMLjvqD4k+VkMV5zVhTh7tC T5jlm4XffcQ0ryfuoXW1/kp3APq4vXyFrh9F0CpPMiipbVUHua9j1W6Ob/DMuq7ZUaMcOGK7Ghg PF1rhbJo1/vSgyIZMemxFFvxGFIej89+wJSDlmcKQOHqeBlfklFLhq4z6U9Ex7zmv+xSJAeJnhh 0VhpXSaXXgCtS03QohQ== X-Proofpoint-GUID: Yd-_f9YF-Z8SuLzoBY8bSbUyBVwYeaD9 X-Authority-Analysis: v=2.4 cv=Fo0IPmrq c=1 sm=1 tr=0 ts=69c42c32 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=AYjmxK_A9T-BKwGzHN8A:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: Yd-_f9YF-Z8SuLzoBY8bSbUyBVwYeaD9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_05,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 clxscore=1015 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250136 Content-Type: text/plain; charset="utf-8" Fix the bitfield offset of HLSQ_READ_SEL state-type bitfield. Otherwise we are always reading TP state when we wanted SP or HLSQ state. Reported-by: Connor Abbott Suggested-by: Connor Abbott Fixes: 1707add81551 ("drm/msm/a6xx: Add a6xx gpu state") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/= msm/adreno/a6xx_gpu_state.c index d2d6b2fd3cba..f7598d0c3975 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c @@ -1013,7 +1013,7 @@ static void a6xx_get_crashdumper_hlsq_registers(struc= t msm_gpu *gpu, u64 out =3D dumper->iova + A6XX_CD_DATA_OFFSET; int i, regcount =3D 0; =20 - in +=3D CRASHDUMP_WRITE(in, REG_A6XX_HLSQ_DBG_READ_SEL, regs->val1); + in +=3D CRASHDUMP_WRITE(in, REG_A6XX_HLSQ_DBG_READ_SEL, (regs->val1 & 0xf= f) << 8); =20 for (i =3D 0; i < regs->count; i +=3D 2) { u32 count =3D RANGE(regs->registers, i); --=20 2.53.0