From nobody Fri Apr 3 03:00:12 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E77F63ED105; Wed, 25 Mar 2026 15:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774452253; cv=none; b=tRR7MMaP9B1OMmgORMMy1XAVZUgHggGNhglrMRfDprtKLdH9+884wiajRXnRuDmIxBrUSXbkltfec8Ura3YReFty0+emjP8O7siuXRBbDn8dSODIik4uPzWWsVMwKa4a3QJ8bhil1TaWXPSbY17It+8OltPAZaHkulKHlWXdO0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774452253; c=relaxed/simple; bh=wdB5iSO2Q7E/YmMgi1ZTD/i9WW0JFtd7I1UeGRiZNUs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ae9HbbjLyf3ZwMhadIBJ6LJuhUsKd6LnLOvj0TQyh45VTJUoHAfECuBqVGgD8DpcQOEwpQHurSIzRQH4vB/vh8FxM/Iwf8430XcY90klHtd3iJo3KeQxR9FUrxPGlIv7kjYxYhQJ8fCv5Gj+Ac8qav2qzlCCR7boITSA9+I0kCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Kd6xL0uJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Kd6xL0uJ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PFHDEE585547; Wed, 25 Mar 2026 15:24:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=k9uKv0XceAw 9mEKUTQczuZqW/qTUYrA68a8Vy8mO7ug=; b=Kd6xL0uJspC4B8CuzwfxI08h3J4 9WIjtplOfvU2C2giQKzcfHRtOdtN21ID5bXCBMg73+ucAsumM4OfZlQ6wydHwzyo gucgEnZ2z6yUiEL7B8tAiSVSqtFpNmCc+YELifnGh1UZLc2kt8GhJHSzCraSFImS WQeQNX40o/SI9X7sjqRDyFkPX2B6+pSzzfed2fl0YlIHpBBrFpbyiK0ijirEXeIg YSEgviRZ8nZ9dAn0PUIkYwA+zcieITRKQ/6W3+OCSrcOnR+Ex0DETGNz/6PN1BQp V/b6uNGQCl9F3zWyZLMFQNJuLzYY7x0Eg7E2+KLxZWkJqtx/70KNA9+tSpA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d46tp2p5p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Mar 2026 15:24:02 +0000 (GMT) Received: from pps.filterd (NALASPPMTA05.qualcomm.com [127.0.0.1]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTP id 62PFO1jn009092; Wed, 25 Mar 2026 15:24:01 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA05.qualcomm.com (PPS) with ESMTPS id 4d473nfj7n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Mar 2026 15:24:01 +0000 Received: from NALASPPMTA05.qualcomm.com (NALASPPMTA05.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 62PFO1M5009072; Wed, 25 Mar 2026 15:24:01 GMT Received: from hu-devc-lv-u22-c.qualcomm.com (hu-cang-lv.qualcomm.com [10.81.25.255]) by NALASPPMTA05.qualcomm.com (PPS) with ESMTPS id 62PFO1sD009040 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Mar 2026 15:24:01 +0000 Received: by hu-devc-lv-u22-c.qualcomm.com (Postfix, from userid 359480) id 2DA725AE; Wed, 25 Mar 2026 08:24:01 -0700 (PDT) From: Can Guo To: avri.altman@wdc.com, bvanassche@acm.org, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Can Guo , "James E.J. Bottomley" , linux-arm-msm@vger.kernel.org (open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER...), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 11/12] scsi: ufs: ufs-qcom: Implement vops apply_tx_eqtr_settings() Date: Wed, 25 Mar 2026 08:21:53 -0700 Message-Id: <20260325152154.1604082-12-can.guo@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260325152154.1604082-1-can.guo@oss.qualcomm.com> References: <20260325152154.1604082-1-can.guo@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: lVzm5otgx3EnjIQpo0s6GlxPKZwAPVw_ X-Authority-Analysis: v=2.4 cv=F4lat6hN c=1 sm=1 tr=0 ts=69c3fe12 cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=PY6Zn8H8AAAA:8 a=N54-gffFAAAA:8 a=EUspDBNiAAAA:8 a=smRfVIh15VBtCzV98ssA:9 a=ySS05r0LPNlNiX1MMvNp:22 X-Proofpoint-GUID: lVzm5otgx3EnjIQpo0s6GlxPKZwAPVw_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDExMCBTYWx0ZWRfX88Z7Nm2jDKUR M6mxSk5PpnI6cvihNdtFs5OIHfSzSFbxNyjeYX/bEzgoti6Viv/Lz/IIT8RBk41seTHL2HwwtDw F3KwwOYLHrvbTlbIZNa03gSB/K8e8o4tFA4oH094JaiqABBD1n9FmBMOCfp8y+Hn4/x0xNLGYgz fxOjvXiju0nShuVvcoIYuJ/Eb/QDuh2xNvHQHJ+Wr8tdthvPAt7XvdQtx1ULa1/V//PZi25ufWa tQ7iF+mdcL07DIQdDAF58YrYi8OnDaetcdPqNIG39GV+IFcn8vaPODm7+CCv2iTZgjswskt0hxG RisXrJ+EtQBSD5TBF6sIGLA2Ikp2lBToxFRN/3sOCrokNbjgCqTiEeCCfvTwzWIImYoX7WrRE6A BzKMl+pmjfireDxrGqyw2+FkotRNzW7JFgJE1sIJ68yYNWNngxy9Rm3aWLNjBGnf7sgR/Lhz/4W tYT0BHUhBxf2Wvhpb5A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_04,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250110 Content-Type: text/plain; charset="utf-8" On some platforms, when Host Software triggers TX Equalization Training, HW does not take TX EQTR settings programmed in PA_TxEQTRSetting, instead HW takes TX EQTR settings from PA_TxEQG1Setting. Implement vops apply_tx_eqtr_setting() to work around it by programming TX EQTR settings to PA_TxEQG1Setting during TX EQTR procedure. Reviewed-by: Bean Huo Reviewed-by: Bart Van Assche Signed-off-by: Can Guo --- drivers/ufs/host/ufs-qcom.c | 31 +++++++++++++++++++++++++++++++ drivers/ufs/host/ufs-qcom.h | 2 ++ 2 files changed, 33 insertions(+) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index a0314cb55c7f..9abdeeee81f7 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -2816,6 +2816,26 @@ static int ufs_qcom_get_rx_fom(struct ufs_hba *hba, return 0; } =20 +static int ufs_qcom_apply_tx_eqtr_settings(struct ufs_hba *hba, + struct ufs_pa_layer_attr *pwr_mode, + struct tx_eqtr_iter *h_iter, + struct tx_eqtr_iter *d_iter) +{ + struct ufs_qcom_host *host =3D ufshcd_get_variant(hba); + u32 setting =3D 0; + int lane; + + if (host->hw_ver.major !=3D 0x7 || host->hw_ver.minor > 0x1) + return 0; + + for (lane =3D 0; lane < pwr_mode->lane_tx; lane++) { + setting |=3D TX_HS_PRESHOOT_BITS(lane, h_iter->preshoot); + setting |=3D TX_HS_DEEMPHASIS_BITS(lane, h_iter->deemphasis); + } + + return ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TXEQG1SETTING), setting); +} + static int ufs_qcom_tx_eqtr_notify(struct ufs_hba *hba, enum ufs_notify_change_status status, struct ufs_pa_layer_attr *pwr_mode) @@ -2838,6 +2858,11 @@ static int ufs_qcom_tx_eqtr_notify(struct ufs_hba *h= ba, return 0; =20 if (status =3D=3D PRE_CHANGE) { + ret =3D ufshcd_dme_get(hba, UIC_ARG_MIB(PA_TXEQG1SETTING), + &host->saved_tx_eq_g1_setting); + if (ret) + return ret; + /* PMC to target HS Gear. */ ret =3D ufshcd_change_power_mode(hba, pwr_mode, UFSHCD_PMC_POLICY_DONT_FORCE); @@ -2845,6 +2870,11 @@ static int ufs_qcom_tx_eqtr_notify(struct ufs_hba *h= ba, dev_err(hba->dev, "%s: Failed to PMC to target HS-G%u, Rate-%s: %d\n", __func__, gear, ufs_hs_rate_to_str(rate), ret); } else { + ret =3D ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TXEQG1SETTING), + host->saved_tx_eq_g1_setting); + if (ret) + return ret; + /* PMC back to HS-G1. */ ret =3D ufshcd_change_power_mode(hba, &pwr_mode_hs_g1, UFSHCD_PMC_POLICY_DONT_FORCE); @@ -2887,6 +2917,7 @@ static const struct ufs_hba_variant_ops ufs_hba_qcom_= vops =3D { .config_esi =3D ufs_qcom_config_esi, .freq_to_gear_speed =3D ufs_qcom_freq_to_gear_speed, .get_rx_fom =3D ufs_qcom_get_rx_fom, + .apply_tx_eqtr_settings =3D ufs_qcom_apply_tx_eqtr_settings, .tx_eqtr_notify =3D ufs_qcom_tx_eqtr_notify, }; =20 diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h index 7183d6b2c8bb..5d083331a7f4 100644 --- a/drivers/ufs/host/ufs-qcom.h +++ b/drivers/ufs/host/ufs-qcom.h @@ -348,6 +348,8 @@ struct ufs_qcom_host { u32 phy_gear; =20 bool esi_enabled; + + u32 saved_tx_eq_g1_setting; }; =20 struct ufs_qcom_drvdata { --=20 2.34.1