From nobody Fri Apr 3 01:23:05 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7314023D291 for ; Wed, 25 Mar 2026 13:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774445880; cv=none; b=I034/gHjcP18yIoy7swLV/+6ewtDJmWweQFRvYIGTJ2A6+Jm/xj/A2TD+QAwJstdkfEsuJ6OX5KaoyMOD44czomVMM8gpeOImyQ9JjatU+r6iEFwCkD7BYgYvFdloHmnWP7SpjpgZBy4DgpiAfLB2yUeBZytSHNN0yFq+7BkGRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774445880; c=relaxed/simple; bh=GJb9TBKKMp/Vghc+ZjmDuJ7z4kr71ATkQ8/gLkStEUM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=SJuRlY1FYblLu3VSUmLJp68x5eIDZX4kBYH5waVbNOZxLCXfqBoeAH34nfmGyLQ8IgXk9qwR63gbMqBfb6fX1yL94PY7F4yjs72yLs8/XxsIi6xVTVBxMJkMnaQHvbWVi7ZVaKv9zjod1Wii0cqfL+dSTgg7U2fgIkJoGFguDdc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RTphhHbe; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RTphhHbe" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35a09e0dd63so6652717a91.3 for ; Wed, 25 Mar 2026 06:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774445878; x=1775050678; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tvyKhPZ3nzUkw+9X1/EbZaf8jGZ4iym5IrAaHhVdOec=; b=RTphhHbezMoDPJCfc7J9fHihjLOUvMOAagQ9CTCRuIkxsiMusEVAZbTnnq7GuVRkGC GPM+MHis23iDyhdhqjfk2lT1WTy0lhh2gOtEGNGgI5Nl1eev4eGaSEpDbIiRmTcePYz6 qgmULidW4NwJr6zQPppGIw3HOWj1Ss7SX3BRY0NyXt4VCKDRboEbQEv3p5HT3dPZ50PC XZ2XhSCkeg2hmD/QqGxbjfAwB1W9D0RRsTgFZGwHcqSacKGzq6S7QHKDrc+6h4FAOb2M yXJJ17M5iwsO2/EgK9fbjJ21AgSf3p1oe3l0VBtI5pIXa0nYlJEFtV8JedetPUOln0li PZeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774445878; x=1775050678; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tvyKhPZ3nzUkw+9X1/EbZaf8jGZ4iym5IrAaHhVdOec=; b=j3niC+yuOrAShTcrMaCNqvqWLkYZuWdT7JoIi/338NFY3JGJMs4kVmgh0yp9At6fCu atihroEE99JGcF9qO/gHTKWuAqLRym7h6mzFumjhjKFha2CELzTRsuc4imnmh6MEcAON JPm1B5iWPOaU6RhbIHa88YJiaH7O9dBlikKLgF9MTbTFYjpovP9Ke4SCGBO3Ea/wtqU3 DME+9a5o5x0Oe2RTz00YxtznFaoNZpOLUiZ8gp1ZJZCrRkkCFqkX47u05LwDqz3vhY+h i+dRTXymOdZz4FOtmPC635dm37U0X9HrTk75wft0XI6p7tGNM2U4bV9UK5PlJkXLmLnn OLNg== X-Forwarded-Encrypted: i=1; AJvYcCVukFeY50fQ93JaCJf5s+RtfE3WHsngZfzkT5omRKw3DzKSjaanSLkz2iDZ9NVOky2Br4k1Asyx3mVFOXY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9lfLZpGqaKULqoMEl0bqimV0ar5H6g2M7btIU++j+E9cIdhfz HAZK3JB262PHXPpQ5BE7PRL8rnZ63XxTo9Uy0E0ja15VrSlNdTk8xie5 X-Gm-Gg: ATEYQzxHLNCadxxpbaGQ5pxYoljw9qOob2RHs9TiyyCX4kp7wft9yf0nJ8zZOhsiXnR HTKKw4GMOnJo2IZgQDzZAMnxsnOhFbox9yP1XyYsMWyXuEPnwDVDGZIyOfgWEpChvEIPJDNWkS1 4SoljjU6GPYszmkOLQgf5jbGIic3mdm41taIKilPQaemFO5YAXzYX70Uk3p/s4myjyg3rUd/59B YT+HBiuXNI7VHH59BbIdoQJMXIFaDgczEuOtivoIWW+Wm6SLwH6+l6rEHEdol88yevEYzA+pdy5 hIobl9rsALLAnW3F2JDnhxlqyJW09aKRan7L1Jqm6d0I8Oc2Nikg/P64DWGM76c6n32XlY+blln URZDJ7olKglDPBBnnznRxQuFsUaYy5ubPpzhTV20vC/IjNM/pnXKM5JHClq7Hml07ucjUEkr3MG L7MmDUG/fl+piarsbOfUIxPglW700m/B29V16Xa4bRP0u9HeZU1M9cvOYHC9LchOUwb8w= X-Received: by 2002:a17:90a:dfc8:b0:35c:936:d4cc with SMTP id 98e67ed59e1d1-35c0dca8e19mr3369159a91.14.1774445877607; Wed, 25 Mar 2026 06:37:57 -0700 (PDT) Received: from lixiang-ThinkCentre-M755e-N000.company.local ([210.184.73.204]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c743a7ff961sm11644178a12.5.2026.03.25.06.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 06:37:57 -0700 (PDT) From: ruipengqi To: jaegeuk@kernel.org Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Ruipeng Qi Subject: [PATCH] f2fs: fix potential deadlock in f2fs_balance_fs() Date: Wed, 25 Mar 2026 21:37:49 +0800 Message-Id: <20260325133749.1053541-1-ruipengqi3@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ruipeng Qi When the f2fs filesystem space is nearly exhausted, we encounter deadlock issues as below: INFO: task A:1890 blocked for more than 120 seconds. Tainted: G O 6.12.41-g3fe07ddf05ab #1 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. task:A state:D stack:0 pid:1890 tgid:1626 ppid:1153 flags:0x0000= 0204 Call trace: __switch_to+0xf4/0x158 __schedule+0x27c/0x908 schedule+0x3c/0x118 io_schedule+0x44/0x68 folio_wait_bit_common+0x174/0x370 folio_wait_bit+0x20/0x38 folio_wait_writeback+0x54/0xc8 truncate_inode_partial_folio+0x70/0x1e0 truncate_inode_pages_range+0x1b0/0x450 truncate_pagecache+0x54/0x88 f2fs_file_write_iter+0x3e8/0xb80 do_iter_readv_writev+0xf0/0x1e0 vfs_writev+0x138/0x2c8 do_writev+0x88/0x130 __arm64_sys_writev+0x28/0x40 invoke_syscall+0x50/0x120 el0_svc_common.constprop.0+0xc8/0xf0 do_el0_svc+0x24/0x38 el0_svc+0x30/0xf8 el0t_64_sync_handler+0x120/0x130 el0t_64_sync+0x190/0x198 INFO: task kworker/u8:11:2680853 blocked for more than 120 seconds. Tainted: G O 6.12.41-g3fe07ddf05ab #1 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. task:kworker/u8:11 state:D stack:0 pid:2680853 tgid:2680853 ppid:2 = flags:0x00000208 Workqueue: writeback wb_workfn (flush-254:0) Call trace: __switch_to+0xf4/0x158 __schedule+0x27c/0x908 schedule+0x3c/0x118 io_schedule+0x44/0x68 folio_wait_bit_common+0x174/0x370 __filemap_get_folio+0x214/0x348 pagecache_get_page+0x20/0x70 f2fs_get_read_data_page+0x150/0x3e8 f2fs_get_lock_data_page+0x2c/0x160 move_data_page+0x50/0x478 do_garbage_collect+0xd38/0x1528 f2fs_gc+0x240/0x7e0 f2fs_balance_fs+0x1a0/0x208 f2fs_write_single_data_page+0x6e4/0x730 //0xfffffe0d6ca08300 f2fs_write_cache_pages+0x378/0x9b0 f2fs_write_data_pages+0x2e4/0x388 do_writepages+0x8c/0x2c8 __writeback_single_inode+0x4c/0x498 writeback_sb_inodes+0x234/0x4a8 __writeback_inodes_wb+0x58/0x118 wb_writeback+0x2f8/0x3c0 wb_workfn+0x2c4/0x508 process_one_work+0x180/0x408 worker_thread+0x258/0x368 kthread+0x118/0x128 ret_from_fork+0x10/0x200 INFO: task kworker/u8:8:2641297 blocked for more than 120 seconds. Tainted: G O 6.12.41-g3fe07ddf05ab #1 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. task:kworker/u8:8 state:D stack:0 pid:2641297 tgid:2641297 ppid:2 = flags:0x00000208 Workqueue: writeback wb_workfn (flush-254:0) Call trace: __switch_to+0xf4/0x158 __schedule+0x27c/0x908 rt_mutex_schedule+0x30/0x60 __rt_mutex_slowlock_locked.constprop.0+0x460/0x8a8 rwbase_write_lock+0x24c/0x378 down_write+0x1c/0x30 f2fs_balance_fs+0x184/0x208 f2fs_write_inode+0xf4/0x328 __writeback_single_inode+0x370/0x498 writeback_sb_inodes+0x234/0x4a8 __writeback_inodes_wb+0x58/0x118 wb_writeback+0x2f8/0x3c0 wb_workfn+0x2c4/0x508 process_one_work+0x180/0x408 worker_thread+0x258/0x368 kthread+0x118/0x128 ret_from_fork+0x10/0x20 INFO: task B:1902 blocked for more than 120 seconds. Tainted: G O 6.12.41-g3fe07ddf05ab #1 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. task:B state:D stack:0 pid:1902 tgid:1626 ppid:1153 flags:0x000= 0020c Call trace: __switch_to+0xf4/0x158 __schedule+0x27c/0x908 rt_mutex_schedule+0x30/0x60 __rt_mutex_slowlock_locked.constprop.0+0x460/0x8a8 rwbase_write_lock+0x24c/0x378 down_write+0x1c/0x30 f2fs_balance_fs+0x184/0x208 f2fs_map_blocks+0x94c/0x1110 f2fs_file_write_iter+0x228/0xb80 do_iter_readv_writev+0xf0/0x1e0 vfs_writev+0x138/0x2c8 do_writev+0x88/0x130 __arm64_sys_writev+0x28/0x40 invoke_syscall+0x50/0x120 el0_svc_common.constprop.0+0xc8/0xf0 do_el0_svc+0x24/0x38 el0_svc+0x30/0xf8 el0t_64_sync_handler+0x120/0x130 el0t_64_sync+0x190/0x198 INFO: task sync:2769849 blocked for more than 120 seconds. Tainted: G O 6.12.41-g3fe07ddf05ab #1 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. task:sync state:D stack:0 pid:2769849 tgid:2769849 ppid:736 = flags:0x0000020c Call trace: __switch_to+0xf4/0x158 __schedule+0x27c/0x908 schedule+0x3c/0x118 wb_wait_for_completion+0xb0/0xe8 sync_inodes_sb+0xc8/0x2b0 sync_inodes_one_sb+0x24/0x38 iterate_supers+0xa8/0x138 ksys_sync+0x54/0xc8 __arm64_sys_sync+0x18/0x30 invoke_syscall+0x50/0x120 el0_svc_common.constprop.0+0xc8/0xf0 do_el0_svc+0x24/0x38 el0_svc+0x30/0xf8 el0t_64_sync_handler+0x120/0x130 el0t_64_sync+0x190/0x198 The root cause is a potential deadlock between the following tasks: kworker/u8:11 Thread A - f2fs_write_single_data_page - f2fs_do_write_data_page - folio_start_writeback(X) - f2fs_outplace_write_data - bio_add_folio(X) - folio_unlock(X) - truncate_inode_pages_range - __filemap_get_folio(X, FGP_LOCK) - truncate_inode_partial_folio(X) - folio_wait_writeback(X) - f2fs_balance_fs - f2fs_gc - do_garbage_collect - move_data_page - f2fs_get_lock_data_page - __filemap_get_folio(X, FGP_LOCK) Both threads try to access folio X. Thread A holds the lock but waits for writeback, while kworker waits for the lock. This causes a deadlock. Other threads also enter D state, waiting for locks such as gc_lock and writepages. To avoid this potential deadlock, always call f2fs_submit_merged_write before triggering f2fs_gc in f2fs_balance_fs. Signed-off-by: Ruipeng Qi --- fs/f2fs/segment.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 6a97fe76712b..b58299e49c23 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -454,6 +454,20 @@ void f2fs_balance_fs(struct f2fs_sb_info *sbi, bool ne= ed) io_schedule(); finish_wait(&sbi->gc_thread->fggc_wq, &wait); } else { + + /* + * Before triggering foreground GC, submit all cached DATA + * write bios. During writeback, pages may be added to + * write_io[DATA].bio with PG_writeback set but the bio not + * yet submitted. If GC's move_data_page() blocks on + * __folio_lock() for such a folio, and the lock holder waits + * for PG_writeback to clear via VFS folio_wait_writeback() + * neither thread can make progress. Flushing here ensures + * the bio completion callback can clear PG_writeback. + */ + + f2fs_submit_merged_write(sbi, DATA); + struct f2fs_gc_control gc_control =3D { .victim_segno =3D NULL_SEGNO, .init_gc_type =3D f2fs_sb_has_blkzoned(sbi) ? --=20 2.25.1