From nobody Fri Apr 3 01:24:31 2026 Received: from va-1-112.ptr.blmpb.com (va-1-112.ptr.blmpb.com [209.127.230.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BED0A3DBD5F for ; Wed, 25 Mar 2026 12:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.127.230.112 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774440700; cv=none; b=GK619z+DMCJhRMn6JQ21r4XZohVNbExtbVKBmHbRYuFn3JIaNKmqjz7mvR2jzMn9323dEMvl1/lwlq8eCbAOQghzLLxN0yYz9uFAElqSIxe4qm0/LmatwG14tdH9ko28UUiRFAKNvJV+Jc3dcjKTpMwvmZSQsKcZDxGFGMnXOSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774440700; c=relaxed/simple; bh=YAUtJDw2f3K/ebctitXa9tJPCYVwC+kEThdG8vlj+yw=; h=From:Date:Message-Id:Mime-Version:To:Subject:Content-Type:Cc; b=eHxPf1Idc6oqmbFyCN32uCbTtrziQoW1D62HzfgRazJZlUI8EgJ3kWnq38GSG7XvneSege6RAmbvU+ZqASK6LV06gCvQnYF2BGD/kSefncsNMxfpJN/uG6jmVD+Xyk6YZDjd6uoPIgp1/ktkQ5Y0mSrvlo19yFALTI8uBsr7qrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=ZgdxCoaA; arc=none smtp.client-ip=209.127.230.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="ZgdxCoaA" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=2212171451; d=bytedance.com; t=1774440685; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=7gvAcvhp23Tp997YHFDCTzlIp6jmCAkjpZ+WoXr7cCM=; b=ZgdxCoaAnsIUVN/p44EDxIRkHUPLJ/n9e6YmiZCL9YaJ1wFN+3gX+22f1+m8QCvi7SizMi VFFkSbtw51NcqpiT8uWsHpyJ8SIPa0dgOtofoURVP/HgcF6TvaPZsv036J38NG+ShaVjN2 xnVDz7CGYoyCNIycKxW3y6hkJTZxDD1Ro4F1r7TXv4PoLo58jMO3h/w2OWe7FOAnW2QT6b 8oeQ72yZOIDxffqc36ZAO3ay8vZxFZFr18HqH34fMthFuQ76VOZPZsHSNMmgApJMZDck4r dtVxtjlPumbGtwbM9Lqw+ppLahyN2+MBA59XH5yl4uZOZGAuj4Rqf4kKWR4Rcw== From: "Rui Qi" Date: Wed, 25 Mar 2026 20:11:09 +0800 Message-Id: <20260325121109.89705-1-qirui.001@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Original-From: Rui Qi X-Lms-Return-Path: To: Subject: [PATCH] ipmi: Fix rcu_read_unlock to srcu_read_unlock in handle_read_event_rsp Cc: , , "Rui Qi" , Content-Transfer-Encoding: quoted-printable X-Mailer: git-send-email 2.52.0 Content-Type: text/plain; charset="utf-8" Fix a bug where rcu_read_unlock() was used instead of srcu_read_unlock() in handle_read_event_rsp() when ipmi_alloc_recv_msg() fails. This mismatch can lead to SRCU read-side critical section imbalance. Fixes: e86ee2d44b44 ("ipmi: Rework locking and shutdown for hot remove") Cc: stable@vger.kernel.org # 6.12 Signed-off-by: Rui Qi --- drivers/char/ipmi/ipmi_msghandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_m= sghandler.c index 71c6ec8a87927..d2bbf8ffd9d76 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -4388,7 +4388,7 @@ static int handle_read_event_rsp(struct ipmi_smi *int= f, =20 recv_msg =3D ipmi_alloc_recv_msg(user); if (IS_ERR(recv_msg)) { - rcu_read_unlock(); + srcu_read_unlock(&intf->users_srcu, index); list_for_each_entry_safe(recv_msg, recv_msg2, &msgs, link) { list_del(&recv_msg->link); --=20 2.20.1