From nobody Fri Apr 3 01:28:26 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFC213CAE79 for ; Wed, 25 Mar 2026 11:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774438343; cv=none; b=A4zblyjA1RW35obZaX4DkLmdTz+blEkpwTEgC9Th9Ypallj6h6XvWnO8W55KR+kfluiDkQRY4719PQbKzJdeaTiImedTOTDViQ92FGI2gh8q8gEf4HsGFPYjOIbVM8T15RGwZ1s9FDNuIVg8mH0BUpxE4cDQ6jWDB0upwZsObYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774438343; c=relaxed/simple; bh=9bHD5B8Z/ub079DT2qNTWRc1w7uwq67J5LW4kHpKAwE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=meiPRC86o6Tp2PI9bOy15mVVvoV/ILokzpW/i7iBuiiOooS0I/9W5+Mw6fSUfA6IlCrYQKJzgIB+am9FMQuHPstOGjyGBawAThC9cmllj3LrsUd4C4vhfLiojRiNOK+SSjiYeOFTjfF9PXoud4MMopaQ6TASeS+0qwf3kfKSUH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=buATWnnr; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="buATWnnr" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-486fb439299so53893955e9.0 for ; Wed, 25 Mar 2026 04:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774438339; x=1775043139; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OLb8SeapcYekp0ky/kzoMYcKAyEOhoSGzMw7aqCMNho=; b=buATWnnrUsdye2HS+LEooLSx+VDaKO7Ag0CgeFmDxJTSrB1OYWKA1V1pmDm7/EA5Hp u018xpdqgWa/93ZVQnfHWB4JukFMEw0pKfKD9Shx5FoPPCQyznBWB/pRVDdbiWnGqYcG ZGuyc2Z7HoQ7sKamDmRBHkFY3NetIRbC80Bc7Pu2049HsWJ+fQPzlCvOYYxzT2vHlHeT f8KRBjfqW5XHl1iZu/m01Z/OMEyw9hd34thpJXcJ4c4aZLXAt4xAHYh/EhVJg5AWRE0d lMcYZGQZmmpihI7pj1BI0CuvvCSeXP3XHozyLyPMovc4Tku8aJ7/JweE7nIy6DsYgn/B foVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774438339; x=1775043139; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OLb8SeapcYekp0ky/kzoMYcKAyEOhoSGzMw7aqCMNho=; b=Wt3wh/LDaOKTOD2tiAmpotfjDYM00D31Ts/QBR5aQUKe4hkxbiCB0o+5caapJAWAI1 VnQQ7kP52OvCa2thm7BkXiKt6Zfsn+0jVcmTXlBSWRiPxfVZeboHN5fTwjJpofKsaBsW Q9dYe++fmFaq8vSCXTIff8FVhUm33hmTn3S/L8jJYGzC0mkmYPj7gmQXPzZUWFb9XlVX aNsuVds1PueVdkW2/K0mjHMZfu4TPW1Nz1/z4ce9gKPyO9tllCkcPj6LXYJIND7S1Uqy T1oSeoev44i/R/lNZQMDpcoTOJcPEeboiaufppyhYcxxIfFu2OFtpJsrfE9uQBYnh7rd l99g== X-Forwarded-Encrypted: i=1; AJvYcCUUxf0Kmxp0eldP03JS0efDuwOMhzlf3WtK7C2yadpyzVmvITSeiCQIWvckLiMI6Rd16ftUjzk/yGvxQYA=@vger.kernel.org X-Gm-Message-State: AOJu0YzmZ2I8ImyS3A/As+JfkxctFLladojLWW4VLDzfVKLI5dKHoChe n/fsGVl9reaIv+hcKKIfzw9BcBf4xOGagvJcKQLeJeVb5aRou6OdpLn1 X-Gm-Gg: ATEYQzyTzqDQMSr4Hl9eZv79YQLBpFoPgxvB4S7ep4zu1xUIhJu1nhH3qjz7VwIE15a gPSajcKBCifeLmRaCTe1aaYK4Ufbe9YfU89V/9Tubi+KzzUIs6rZw1L9dVAp7PHlesHlK1+lUzQ dgyEIZ4hlWUYMAfGHmACDNCmIbE1VO/otCNRX0zfLE3HaVPkfWNPsDXJy0w1lnR1ThbsrgUPXWk bdEZCJmVuQxclW7AIDrsE+ZO3Pdb9GEteJiRj+7T7/V6yDjyRIiELS+PB0Dyj8krQm0a6ZxBPQE FBl5Tz60C36CRONGQXI1bETzG5nlWa0/1a/2uYwyNQHesKVqgP4yOPGwDmmaXLjMoMe66Kd9M4F eL3o7XgpOzWVuRBjscl7GzvoHLcelq0pRfQS086pmB7CK7fezElzMimTPTUAtLfGJtSR1lGo1aE bFM4889ZJxCTx8WIucOt6OB/nzuiBxdbxfuSyXq8A0sGNI68eLhX6D X-Received: by 2002:a05:600c:a4f:b0:480:1e40:3d2 with SMTP id 5b1f17b1804b1-48716067246mr41383255e9.29.1774438338781; Wed, 25 Mar 2026 04:32:18 -0700 (PDT) Received: from aldo-conte-t14.tailf68ad9.ts.net ([217.61.173.50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64703c27sm46510360f8f.18.2026.03.25.04.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 04:32:18 -0700 (PDT) From: Aldo Conte To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Javier Carrasco Subject: [PATCH] iio: light: veml6070: fix veml6070_read() return value Date: Wed, 25 Mar 2026 12:32:16 +0100 Message-ID: <20260325113216.170357-1-aldocontelk@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" veml6070_read() computes the sensor value in ret but returns 0 instead of the actual result. This causes veml6070_read_raw() to always report 0. Return the computed value instead of 0. Running make W=3D1 returns no errors. I was unable to test the patch because I do not have the hardware. Found by code inspection. Fixes: bb18885ed823 ("iio: light: veml6070: add support for integration tim= e") Signed-off-by: Aldo Conte Reviewed-by: Nuno S=C3=A1 --- drivers/iio/light/veml6070.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/light/veml6070.c b/drivers/iio/light/veml6070.c index 6d4483c85f30..74d7246e5225 100644 --- a/drivers/iio/light/veml6070.c +++ b/drivers/iio/light/veml6070.c @@ -134,9 +134,7 @@ static int veml6070_read(struct veml6070_data *data) if (ret < 0) return ret; =20 - ret =3D (msb << 8) | lsb; - - return 0; + return (msb << 8) | lsb; } =20 static const struct iio_chan_spec veml6070_channels[] =3D { --=20 2.53.0