From nobody Fri Apr 3 01:28:04 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3583C3CCFDD for ; Wed, 25 Mar 2026 11:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774437649; cv=none; b=HIJ9YzKU5XmluBKx3D7HgSwKCknBD4uOjsiSSEJioMWHRycoKClpcRMBmRE6VkrQuPOJMW5EQZxZWTo4zo/FDzMy56ZrAZc4gCGOyOYAtoOSKYNoDcCexBdXWX+np8XUhWFl39yYUalwGBQkxjpZV83idFYuU2MuEVoJrmMSkcw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774437649; c=relaxed/simple; bh=O+ThQsahUnk734oWnoBLUJg1oyxuP1qQGEU6Qizf36U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tI3RlHrv7Dvs6wuefjDlx3px+k0LW00hvDYtbaBeTiOKhY9cTrWCCERVBPTrHTxCej+M3UkzUGcZHZRmlCNjskKWs/0djMlkvuwyZwKGlrbxUokgGshm1H7Vu+GISmPbJ8TR7jq8+97xfWQ0Pf0S+kkwB9NpHa7mlybJgFo9nvE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pIK+SGib; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pIK+SGib" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43b87970468so1060238f8f.3 for ; Wed, 25 Mar 2026 04:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774437646; x=1775042446; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0dwTG4J1M8IL8PPbtOF4W3xYh4+M5sfK/wvLd5SnCE8=; b=pIK+SGibUN2f9Z4RPOKgExzsikiDDJZHfhIm9ZIJ3hSf0g7vhVhbv6HqDI9JTaTp5r e5GPk9u3npUZ58+eb7vNS/FzhyzFQ7YacXUNYTs1NUZKm/4ibKkps8CdvtvZc9+fdKyd z7y2cNdKB2XKM5cY61O3DYZ+AxqioV2/ZUuUPlfF0clNUxXFUBfar0+qnhuHUxtuOP5t SiMwQEz1rMjQb0hd6QRWbmPS/R/foy7spDUENzeSx0dyomnWKsKrXTuh+C6S89WSArxF fI/bANCQIDhzUWHOYaJB9wFLVc/E0j4Ooc0Wb9w1v/O/a9kyjSda2tHbibLE2DzSzCS5 aIcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774437646; x=1775042446; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0dwTG4J1M8IL8PPbtOF4W3xYh4+M5sfK/wvLd5SnCE8=; b=BdPLgepVSjNMuelwbsAk4l0smLEmjZeIndgua/yCfkEjc+47j9rw16Bx4Dr+0J34aF sOspeud8/E5GWcWKKxq1yMkAnTrLeMYNUxhkqG5nIIyDa8orKPwR5mX3nkqCn0ZZd5C5 BwQQI1ZOw3Dt1oJVTt6BmfMn0PEflIqQ1fukAsnUW6wvJjw+qMz9OSkARIkUX/5NUYYK ucZAQwvJr5jnjDV4U+vsBc7El6Mw7/FZ1p+5nD0IbDICSATjDuyOWtoFO42kHsxazTlB dRNfzGQcML6DBtRWKLrN//VxvjJeEZBb03TCEWu+3rYM+rLbZzk3bB7LYbsFr5/L9HU8 Dlog== X-Forwarded-Encrypted: i=1; AJvYcCUYvb2N+05uYT3HM0/HmSdTycVTGLTjgUgtoTcgS/YGLOkzLIvujurLay6sy9L5+oQIu8CvtKpYbcgXeGE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyug8D7VRW5VbYlNILwbTkOgHIGAJFXfUD12hL+XegKI8x/dbne UP/VhPSGqOPxOM0VLaSgwRfvcx9czrtAX7Lt2NqaMNU2cx3KaV3w+W2s X-Gm-Gg: ATEYQzxe2iuh+cAK065ZhdnZ7tIhFIfXWcFCAQypUsUwbSMTGeks/uNO76e891LPB3D cHBBZv5KMtcaQted2qYZyhQ4i61IUwA3F37ebBhbJbqM92V41Ezk2xyBixhAXH2mAHYHTojvxOF pj02NCB/Gx1dWQArkx4yTpDo6KlgQCTcx5yE4XU+UBYdl0fmI2vl1+NDD8W8ocqYrBOkbEsbqhU 9+zCxbqCHqQ6kKn/GOmkCBRXgACIH4mSemqFg/MjTQqjOymF4on/MHZIoK3c9R9uvAk/laKX7ZM OTmMxGX5AnaRS+qma45mujtROjsIK9KYLjz5jdwwPF8X8V47ZGTaLsJ5cd454Zfo2zOOWSgshfn P/7XtW3Qf6sUXdQm32hlBP/+K6kTDOyiBDrpOrs5K3axi5BOQExh5LuqdCV5qiU40cu/4CIpZuI zwEth+qMzNx4qzXS3/rBVUrIrF7FZW+CKt2G8WNvd8ndFTfDygdtfm4fmKGlBgH2EBJ83BXB7GX kn8AME2B6lQzVzEvPiKQiF9UKhno0P4Bg3I X-Received: by 2002:a05:600c:1e09:b0:487:5c0:671f with SMTP id 5b1f17b1804b1-48715fe711emr53696995e9.9.1774437646297; Wed, 25 Mar 2026 04:20:46 -0700 (PDT) Received: from iku.Home ([2a06:5906:61b:2d00:3783:5d64:bc35:885]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-487165ecf00sm20077425e9.5.2026.03.25.04.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 04:20:45 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Yoshihiro Shimoda , Vinod Koul , Neil Armstrong , Geert Uytterhoeven , Magnus Damm , Pavel Machek Cc: linux-renesas-soc@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v2] phy: renesas: rcar-gen3-usb2: Simplify ID/VBUS detection logic Date: Wed, 25 Mar 2026 11:20:39 +0000 Message-ID: <20260325112039.464992-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Read USB2_ADPCTRL once in rcar_gen3_check_id() instead of issuing multiple MMIO reads, and derive both IDDIG and VBUSVALID from the same value. Drop the redundant !! operator, as assigning a masked u32 value to a bool already performs the required normalization. Simplify the logic by comparing the ID and VBUS status directly, which is equivalent to the previous conditional but easier to follow. Reported-by: Pavel Machek Closes: https://lore.kernel.org/all/acJVCOdlchLiSe5n@duo.ucw.cz/ Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven --- v1->v2: - Rebased on top of latest next-20260324 - Combined variable declarations and assignments and dropped redundant !! operator - Updated commit message - Corrected the link for closes tag --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas= /phy-rcar-gen3-usb2.c index 79e820e2fe55..9a45d840efeb 100644 --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c @@ -314,13 +314,11 @@ static void rcar_gen3_init_from_a_peri_to_a_host(stru= ct rcar_gen3_chan *ch) static bool rcar_gen3_check_id(struct rcar_gen3_chan *ch) { if (ch->phy_data->vblvl_ctrl) { - bool vbus_valid; - bool device; + u32 val =3D readl(ch->base + USB2_ADPCTRL); + bool vbus_valid =3D val & USB2_ADPCTRL_VBUSVALID; + bool device =3D val & USB2_ADPCTRL_IDDIG; =20 - device =3D !!(readl(ch->base + USB2_ADPCTRL) & USB2_ADPCTRL_IDDIG); - vbus_valid =3D !!(readl(ch->base + USB2_ADPCTRL) & USB2_ADPCTRL_VBUSVALI= D); - - return vbus_valid ? device : !device; + return device =3D=3D vbus_valid; } =20 if (!ch->uses_otg_pins) --=20 2.53.0