From nobody Fri Apr 3 02:58:08 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F63A30BBBC for ; Wed, 25 Mar 2026 08:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774426740; cv=none; b=aDh3JZP6nFqVLpZDag4Qb/EW/qfPCAP5bKeH3bBUVXn4xirLPya7IOERtYOMooIIS4D43OyqjuFFtwWZC31qFX4SaTjRCysxGrAuS7+rPkpZz7PZIg/r9k8c6kKn7+nd5TuR0yFClhkdv9lu07ozhCfZ8X0Oyi0awrwXzUEerzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774426740; c=relaxed/simple; bh=V1rebkYkH0xbbTSdHSmSsIS4Wj4McbCBjLT5yNCpazA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=reUfgyVM2vTeevtugqqoxm3RCDFGoiUBFY4ZbYdpG3XfVLlhP301taeKTE6be6X0Ma8QbzFn+yRI8jz6yrax3oOgSIGP43A9bVRUHM/OERWA+qTvj6Bzx4dFkQxcbDL0pAMfDuPtwT0KtIPruYT5kEJ9YVOOBrq0VVeKthkRtoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P+xUsyxb; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P+xUsyxb" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-82a7ebc729dso1098428b3a.3 for ; Wed, 25 Mar 2026 01:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774426739; x=1775031539; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OYyBTHqBgdWNzLcMu4J26nJ5nXtlUdcoysDntT0XCb4=; b=P+xUsyxbTaAzrETj5SzMYIsGM4bSBhIO75vjRqBtBBAvpsrKy4i7pAruHjmkmn5QA3 xGjXDsRnG1J4CWi+Q2edxe24zLU6CTvDMruqRDtgI7wSqPuB6msRvUMMdQF48q8G0iNe dB/lLuJRNqqgUtNQgwq5QG6XyiFucvR4cZy+9jAGptwMedUzRI3s6PdKjRF4Lrd8suW9 eVIp2sKStqwtHJ+8UXYMX7NVXYaU1q+Xt++02r7mU+VzirkAyZ1FIYpiQNRhVrPKMbos ja9X5HFeJVT/wlTYPXZdklOV1iodkVR8BI4yyJotouENhbj8OaTXDnZ45fXKR5SDYzDm ItZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774426739; x=1775031539; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OYyBTHqBgdWNzLcMu4J26nJ5nXtlUdcoysDntT0XCb4=; b=InVm2c8qxGuk+tbvZ4AVNYo4XseZ0xnnPyQ+exdBCw8rWd4L6dNluNMWCxGdRt9XoU Y7pp83hqS27XrsZ2ssizyL9h8eKJ62LyA0xoDy8LfnvwUe4EzfB4ZYZ9IUNioPkmz9D8 0RVGIzZGjOz0US4docr9R/pNuJjfWk2GjqEu7XVsnt1y/+0qofd7ugRY5NDdKvEO9+w/ WWwiDl/PQYO/3bCG5xJJkSQrbW+yC9fTZj3wfUdMGKjFLFEWQCH+7K5DvcEnspaT1G4p 2fCToZSjSDy+7+fgBo1+mssuEJJqRx1sNyDpZAJZjAzbnEMiboN/Llrl57GloH4XooB6 aG7Q== X-Forwarded-Encrypted: i=1; AJvYcCUhsE4DkpltAWlAtwXZYvwEq8gEu7NFoJY7gAJiYB7fxKlyS5xG/ItMAKaRKu6R4iEm+F66rCgPpY8UBNk=@vger.kernel.org X-Gm-Message-State: AOJu0YyfM1YbbFxgFXaC98CKmEgAx1JZ+6G+f/vcwJIc2HlNjMl8YvcT X4RMxiSIvCfTDVdj3w7gSrXB5GNnUqdcyc2/qe+EgEv1+1TdjJw7OU9G X-Gm-Gg: ATEYQzwYi5WPhFaf/N5rJ0wRwnYuqWusP5u495bqLs50dHJ+TdoYzdRyJKQGQNmN5Cq pNmzKMHeMqwGIUjtaNjhQlX1V3ZC4YePkhc6tz10sVj0RPgjDQvFnKmrDOTICJ0ymisFHo+q08m Qiez0GowcgaU8rpse/U8N63Xf8tIIVt+dEbLESs6gpUD19Nv+WRhgJI4csGcBpO59/GKSmJCJQm zQrq2/BHVtCU9meJWpoS/0VxwTdQbDS8PjtRyWWRRCFyLC26fnrYiNpKrAs4gZV7QpSU0mOj8oR Ad0K/1icYoOVvhAoiuuRGQ0742pCvTnoO8cSSlmTxh5qMk28qqXgNhI5sSLKDr1xoj1cY1+s4pi D7yv8nDz1FKjMJA4dhw1LzTxk4zFzdAV47ZVdZXYmRtYHAVskxDzqnQX6h0oA7erjQDPmvuhjix 5rYgCAAs1Myy079C0SkiPL/axiJFCQzcGYyTK4Te1LOgQ6pyUsKFlERe4trzTQuqCwf/o+Ft2ny dCo8A== X-Received: by 2002:a05:6a00:844:b0:824:9ffc:256c with SMTP id d2e1a72fcca58-82c6e0d0d2cmr2445949b3a.43.1774426738715; Wed, 25 Mar 2026 01:18:58 -0700 (PDT) Received: from toolbx.auup.amity.edu.in ([202.12.103.66]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b03aa9fc6sm15454426b3a.7.2026.03.25.01.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 01:18:58 -0700 (PDT) From: Gopi Krishna Menon To: rafael@kernel.org, daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com Cc: Gopi Krishna Menon , daniel.baluta@nxp.com, simona.toaca@nxp.com, d-gole@ti.com, m-chawdhry@ti.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] thermal: fix error condition for reading st,thermal-flags Date: Wed, 25 Mar 2026 13:48:42 +0530 Message-ID: <20260325081844.13829-1-krishnagopi487@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_property_read_u32 returns 0 on success. The current check returns -EINVAL if the property is read successfully. Fix the check by removing ! from of_property_read_u32 Suggested-by: Daniel Baluta Signed-off-by: Gopi Krishna Menon Reviewed-by: Lukasz Luba --- Note: * This patch is part of the GSoC2026 application process for device tree bi= ndings conversions * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device= -Tree-Bindings * Changes have only been compile tested drivers/thermal/spear_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_therma= l.c index 603dadcd3df5..5e3e9c1f32f8 100644 --- a/drivers/thermal/spear_thermal.c +++ b/drivers/thermal/spear_thermal.c @@ -93,7 +93,7 @@ static int spear_thermal_probe(struct platform_device *pd= ev) struct device_node *np =3D pdev->dev.of_node; int ret =3D 0, val; =20 - if (!np || !of_property_read_u32(np, "st,thermal-flags", &val)) { + if (!np || of_property_read_u32(np, "st,thermal-flags", &val)) { dev_err(&pdev->dev, "Failed: DT Pdata not passed\n"); return -EINVAL; } --=20 2.52.0