From nobody Fri Apr 3 04:33:30 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFA88395DA0 for ; Wed, 25 Mar 2026 07:58:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774425515; cv=none; b=iYDpoRVDvUMNQk9CO6coXH3huxkGl5doq69NW/VFjwAIz+gRmN2JCbq987PglRN6aQ0VOg2a0fxcMYXI6h9GnuGqlCckezEBEI5AjPkgu8WXNwxkm3XPaufmjkBGcntK9JdJZa6dGrZnB/jYfDYwERmYmmUBRX7MMP4F1CKrhkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774425515; c=relaxed/simple; bh=f2O8m6d4zMN/y+57nFPFMsH5+blVJVVbtwfj9AgMxCg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fhFqcw5W/C1kc8ZQcKk7r55FsCyG3wUYPOH907SdkJMPdJwJZEl0LvzfFFGhOo664jfE6zQFrQ7W6qh/VT7gP3fGGX8WBedcQShZ6vNdU00lHNq4imVgEmvUsVaOZXLDbL4oQ/RArhLR8H1drJMvoLmn+gb9Gmt1486sjBMIJFA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=FCO20bCM; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FCO20bCM" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2b05761bec1so3013555ad.1 for ; Wed, 25 Mar 2026 00:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1774425511; x=1775030311; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0hzdGjCbyDsg4HVNNFyo8yv6JV0S2hPiHL6tBzGzVl8=; b=FCO20bCM0STqf8LdyCi24mZEFJaSAo5iOp5kJMt8nIaw0CG+QfC0LEhoBnnytyb8cN vBNaJ//wOy0oH719YZplW5gSoTZqhvN1xVkMgy9O/CAgAogkUxrziQasA7usMlBUVXAp TLJMWebQZO8S0CH6bnifmjN07q1eMUd2xIhnc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774425511; x=1775030311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0hzdGjCbyDsg4HVNNFyo8yv6JV0S2hPiHL6tBzGzVl8=; b=oLcY+HVffu5hHewd+Iw4c+pwzC7mM3ahEi9Ygdhv5s1Zfnhgdaw3AzmNa7Fi/5JEQu OGezHn49MVVY/IXh/JNFzoJ1Vquvag053Hg07Gxh80NOkOw1xkRtfzZjP1eSEbYDWFV6 ejMW5fBZEElQfNo/MuGTuJlUEHmrYdR0c49NVoMGRB7dTx2R+9w7y4gRUwgW/buWybFG 6Umsk412XxnWGp18JcJ+UdTmLLuDaEuWc6jCvBwstpuBwm2tg2xnLZRsv4ruXdtwTH8f Hpn2FCvBzRNs/gEv8dnD2XZgssvXhU7uNllj430XkkoNXEV1AjBvdLivFwkwl4HAXJ/8 LMsw== X-Forwarded-Encrypted: i=1; AJvYcCVmMg7WwQ+XyOfZxyxaCdT6t0UIPJySQAIxzLm5JWVM3zr/oYozyKvG8ock/if5gEARNNo6t0AOL2nkDCo=@vger.kernel.org X-Gm-Message-State: AOJu0YzNY91LFbpY8uZeFB+lbxhUsS5p7KI/LcYzoBb1jG2GZ1a7OiOt 1cctauxdV+Hz8TKp31qE1cv3AUfOKjZv4VRlH5cRfDRA0x14A4qoZVfs/79h5KdjZA== X-Gm-Gg: ATEYQzzgj5adTtikO7tofy8U6PSgSlB/CATusLCKFfcl5D63dU+hFb0tyvVJ+MppLKl +ONXeozBE9hACHeaG2B0yPou4icn5VkSX+6U/1uB+hD7n4wO2qkWwAH25n/irpQYJT/v7KyB3/G ZPIeqLWg/TRX3vzb2n0JeNfoqPfl0R+cXH22tctXU5h/yP2d5kRFYNDmMtrwcvVXuRxG/n+iRJU prUQHN3l3IdTbuNExnJrY9JznyBbxueWWTW9YSPkCq8uHxwS6V75qLcacnIozn+sTBo1F/9aikG cETAFm4YiHeTp0Od1QNqIYrN6KzlGsbw0WvEn32br5EEUvVhwRKf8XehWqylraAPK2VIQbKVtP0 bZ3pOC20ol2ok+L0CWxkTDTqDY9R8c6u3+jFomZpuR0UT1wgUkJojXypKgWm6G8e8RO7/XNxZyo LJOetmpK6ePxukbIaN4p0uWO0LoCgS53bUS68jLiz70syP1rvwU5cgr9dpvl6TOwr6J/CeZrLMg 7bu/ipepXzHzjultQ== X-Received: by 2002:a17:902:f607:b0:2b0:62cf:3537 with SMTP id d9443c01a7336-2b0b06ba4b4mr25966925ad.6.1774425510896; Wed, 25 Mar 2026 00:58:30 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:7ff0:bee3:7d45:eab]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08366c3f7sm219682465ad.60.2026.03.25.00.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 00:58:30 -0700 (PDT) From: Chen-Yu Tsai To: Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno , Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: Icenowy Zheng , Icenowy Zheng , Chen-Yu Tsai , David Airlie , Simona Vetter , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/5] clk: mediatek: Add mt8173-mfgtop driver Date: Wed, 25 Mar 2026 15:19:46 +0800 Message-ID: <20260325071951.544031-3-wenst@chromium.org> X-Mailer: git-send-email 2.53.0.1018.g2bb0e51243-goog In-Reply-To: <20260325071951.544031-1-wenst@chromium.org> References: <20260325071951.544031-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The MFG (GPU) block on the MT8173 has a small glue layer, named MFG_TOP in the datasheet, that contains clock gates, some power sequence signal delays, and other unknown registers that get toggled when the GPU is powered on. The clock gates are exposed as clocks provided by a clock controller, while the power sequencing bits are exposed as one singular power domain. Signed-off-by: Chen-Yu Tsai --- Changes since v1: - Reduce tab after GATE_MFG() by one tab - Move of_match_clk_mt8173_mfgtop to just before clk_mt8173_mfgtop_drv - Rename power domain to "mfg-top" - Add FORCE_ABORT and ACTIVE_PWRCTL_EN bits and explicitly clear ACTIVE_PWRCTL_EN bit --- drivers/clk/mediatek/Kconfig | 9 + drivers/clk/mediatek/Makefile | 1 + drivers/clk/mediatek/clk-mt8173-mfgtop.c | 243 +++++++++++++++++++++++ 3 files changed, 253 insertions(+) create mode 100644 drivers/clk/mediatek/clk-mt8173-mfgtop.c diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig index 2c09fd729bab..8dbd9f14be62 100644 --- a/drivers/clk/mediatek/Kconfig +++ b/drivers/clk/mediatek/Kconfig @@ -537,6 +537,15 @@ config COMMON_CLK_MT8173_IMGSYS help This driver supports MediaTek MT8173 imgsys clocks. =20 +config COMMON_CLK_MT8173_MFGTOP + tristate "Clock and power driver for MediaTek MT8173 mfgtop" + depends on COMMON_CLK_MT8173 + default COMMON_CLK_MT8173 + select PM_GENERIC_DOMAINS + select PM_GENERIC_DOMAINS_OF + help + This driver supports MediaTek MT8173 mfgtop clocks and power domain. + config COMMON_CLK_MT8173_MMSYS tristate "Clock driver for MediaTek MT8173 mmsys" depends on COMMON_CLK_MT8173 diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile index d8736a060dbd..892a54eeb281 100644 --- a/drivers/clk/mediatek/Makefile +++ b/drivers/clk/mediatek/Makefile @@ -82,6 +82,7 @@ obj-$(CONFIG_COMMON_CLK_MT8167_VDECSYS) +=3D clk-mt8167-v= dec.o obj-$(CONFIG_COMMON_CLK_MT8173) +=3D clk-mt8173-apmixedsys.o clk-mt8173-in= fracfg.o \ clk-mt8173-pericfg.o clk-mt8173-topckgen.o obj-$(CONFIG_COMMON_CLK_MT8173_IMGSYS) +=3D clk-mt8173-img.o +obj-$(CONFIG_COMMON_CLK_MT8173_MFGTOP) +=3D clk-mt8173-mfgtop.o obj-$(CONFIG_COMMON_CLK_MT8173_MMSYS) +=3D clk-mt8173-mm.o obj-$(CONFIG_COMMON_CLK_MT8173_VDECSYS) +=3D clk-mt8173-vdecsys.o obj-$(CONFIG_COMMON_CLK_MT8173_VENCSYS) +=3D clk-mt8173-vencsys.o diff --git a/drivers/clk/mediatek/clk-mt8173-mfgtop.c b/drivers/clk/mediate= k/clk-mt8173-mfgtop.c new file mode 100644 index 000000000000..9e18f34166ae --- /dev/null +++ b/drivers/clk/mediatek/clk-mt8173-mfgtop.c @@ -0,0 +1,243 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2024 Google LLC + * Author: Chen-Yu Tsai + * + * Based on driver in downstream ChromeOS v5.15 kernel. + * + * Copyright (c) 2014 MediaTek Inc. + * Author: Chiawen Lee + */ + +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "clk-gate.h" +#include "clk-mtk.h" + +static const struct mtk_gate_regs mfg_cg_regs =3D { + .sta_ofs =3D 0x0000, + .clr_ofs =3D 0x0008, + .set_ofs =3D 0x0004, +}; + +#define GATE_MFG(_id, _name, _parent, _shift, _flags) \ + GATE_MTK_FLAGS(_id, _name, _parent, &mfg_cg_regs, _shift, &mtk_clk_gate_o= ps_setclr, _flags) + +/* TODO: The block actually has dividers for the core and mem clocks. */ +static const struct mtk_gate mfg_clks[] =3D { + GATE_MFG(CLK_MFG_AXI, "mfg_axi", "axi_mfg_in_sel", 0, CLK_SET_RATE_PARENT= ), + GATE_MFG(CLK_MFG_MEM, "mfg_mem", "mem_mfg_in_sel", 1, CLK_SET_RATE_PARENT= ), + GATE_MFG(CLK_MFG_G3D, "mfg_g3d", "mfg_sel", 2, CLK_SET_RATE_PARENT), + GATE_MFG(CLK_MFG_26M, "mfg_26m", "clk26m", 3, 0), +}; + +static const struct mtk_clk_desc mfg_desc =3D { + .clks =3D mfg_clks, + .num_clks =3D ARRAY_SIZE(mfg_clks), +}; + +struct mt8173_mfgtop_data { + struct clk_hw_onecell_data *clk_data; + struct regmap *regmap; + struct generic_pm_domain genpd; + struct of_phandle_args parent_pd, child_pd; + struct clk *clk_26m; +}; + +/* Delay count in clock cycles */ +#define MFG_ACTIVE_POWER_CON0 0x24 + #define RST_B_DELAY_CNT GENMASK(7, 0) /* pwr_rst_b de-assert delay during= power-up */ + #define CLK_EN_DELAY_CNT GENMASK(15, 8) /* CLK_DIS deassert delay during = power-up */ + #define CLK_DIS_DELAY_CNT GENMASK(23, 16) /* CLK_DIS assert delay during = power-down */ + #define FORCE_ABORT BIT(30) /* write 1 to force abort a power event */ + #define ACTIVE_PWRCTL_EN BIT(31) /* enable ACTIVE_POWER */ + +#define MFG_ACTIVE_POWER_CON1 0x28 + #define PWR_ON_S_DELAY_CNT GENMASK(7, 0) /* pwr_on_s assert delay during = power-up */ + #define ISO_DELAY_CNT GENMASK(15, 8) /* ISO assert delay during power-do= wn */ + #define ISOOFF_DELAY_CNT GENMASK(23, 16) /* ISO de-assert delay during po= wer-up */ + #define RST__DELAY_CNT GENMASK(31, 24) /* pwr_rsb_b assert delay during = power-down */ + +static int clk_mt8173_mfgtop_power_on(struct generic_pm_domain *domain) +{ + struct mt8173_mfgtop_data *data =3D container_of(domain, struct mt8173_mf= gtop_data, genpd); + + /* drives internal power management */ + clk_prepare_enable(data->clk_26m); + + /* Power on/off delays for various signals */ + regmap_write(data->regmap, MFG_ACTIVE_POWER_CON0, + FIELD_PREP(RST_B_DELAY_CNT, 77) | + FIELD_PREP(CLK_EN_DELAY_CNT, 61) | + FIELD_PREP(CLK_DIS_DELAY_CNT, 60) | + FIELD_PREP(ACTIVE_PWRCTL_EN, 0)); + regmap_write(data->regmap, MFG_ACTIVE_POWER_CON1, + FIELD_PREP(PWR_ON_S_DELAY_CNT, 11) | + FIELD_PREP(ISO_DELAY_CNT, 68) | + FIELD_PREP(ISOOFF_DELAY_CNT, 69) | + FIELD_PREP(RST__DELAY_CNT, 77)); + + /* Magic numbers related to core switch sequence and delays */ + regmap_write(data->regmap, 0xe0, 0x7a710184); + regmap_write(data->regmap, 0xe4, 0x835f6856); + regmap_write(data->regmap, 0xe8, 0x002b0234); + regmap_write(data->regmap, 0xec, 0x80000000); + regmap_write(data->regmap, 0xa0, 0x08000000); + + return 0; +} + +static int clk_mt8173_mfgtop_power_off(struct generic_pm_domain *domain) +{ + struct mt8173_mfgtop_data *data =3D container_of(domain, struct mt8173_mf= gtop_data, genpd); + + /* Magic numbers related to core switch sequence and delays */ + regmap_write(data->regmap, 0xec, 0); + + /* drives internal power management */ + clk_disable_unprepare(data->clk_26m); + + return 0; +} + +static int clk_mt8173_mfgtop_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct device_node *node =3D dev->of_node; + struct mt8173_mfgtop_data *data; + int ret; + + data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + platform_set_drvdata(pdev, data); + + data->clk_data =3D mtk_devm_alloc_clk_data(dev, ARRAY_SIZE(mfg_clks)); + if (!data->clk_data) + return -ENOMEM; + + /* MTK clock gates also uses regmap */ + data->regmap =3D device_node_to_regmap(node); + if (IS_ERR(data->regmap)) + return dev_err_probe(dev, PTR_ERR(data->regmap), "Failed to get regmap\n= "); + + data->child_pd.np =3D node; + data->child_pd.args_count =3D 0; + ret =3D of_parse_phandle_with_args(node, "power-domains", "#power-domain-= cells", 0, + &data->parent_pd); + if (ret) + return dev_err_probe(dev, ret, "Failed to parse power domain\n"); + + devm_pm_runtime_enable(dev); + /* + * Do a pm_runtime_resume_and_get() to workaround a possible + * deadlock between clk_register() and the genpd framework. + */ + ret =3D pm_runtime_resume_and_get(dev); + if (ret) { + dev_err_probe(dev, ret, "Failed to runtime resume device\n"); + goto put_of_node; + } + + ret =3D mtk_clk_register_gates(dev, node, mfg_clks, ARRAY_SIZE(mfg_clks), + data->clk_data); + if (ret) { + dev_err_probe(dev, ret, "Failed to register clock gates\n"); + goto put_pm_runtime; + } + + data->clk_26m =3D clk_hw_get_clk(data->clk_data->hws[CLK_MFG_26M], "26m"); + if (IS_ERR(data->clk_26m)) { + dev_err_probe(dev, PTR_ERR(data->clk_26m), "Failed to get 26 MHz clock\n= "); + goto unregister_clks; + } + + ret =3D of_clk_add_hw_provider(node, of_clk_hw_onecell_get, data->clk_dat= a); + if (ret) { + dev_err_probe(dev, ret, "Failed to add clk OF provider\n"); + goto put_26m_clk; + } + + data->genpd.name =3D "mfg-top"; + data->genpd.power_on =3D clk_mt8173_mfgtop_power_on; + data->genpd.power_off =3D clk_mt8173_mfgtop_power_off; + ret =3D pm_genpd_init(&data->genpd, NULL, true); + if (ret) { + dev_err_probe(dev, ret, "Failed to add power domain\n"); + goto del_clk_provider; + } + + ret =3D of_genpd_add_provider_simple(node, &data->genpd); + if (ret) { + dev_err_probe(dev, ret, "Failed to add power domain OF provider\n"); + goto remove_pd; + } + + ret =3D of_genpd_add_subdomain(&data->parent_pd, &data->child_pd); + if (ret) { + dev_err_probe(dev, ret, "Failed to link PM domains\n"); + goto del_pd_provider; + } + + pm_runtime_put(dev); + return 0; + +del_pd_provider: + of_genpd_del_provider(node); +remove_pd: + pm_genpd_remove(&data->genpd); +del_clk_provider: + of_clk_del_provider(node); +put_26m_clk: + clk_put(data->clk_26m); +unregister_clks: + mtk_clk_unregister_gates(mfg_clks, ARRAY_SIZE(mfg_clks), data->clk_data); +put_pm_runtime: + pm_runtime_put(dev); +put_of_node: + of_node_put(data->parent_pd.np); + return ret; +} + +static void clk_mt8173_mfgtop_remove(struct platform_device *pdev) +{ + struct mt8173_mfgtop_data *data =3D platform_get_drvdata(pdev); + struct device_node *node =3D pdev->dev.of_node; + + of_genpd_remove_subdomain(&data->parent_pd, &data->child_pd); + of_genpd_del_provider(node); + pm_genpd_remove(&data->genpd); + of_clk_del_provider(node); + clk_put(data->clk_26m); + mtk_clk_unregister_gates(mfg_clks, ARRAY_SIZE(mfg_clks), data->clk_data); +} + +static const struct of_device_id of_match_clk_mt8173_mfgtop[] =3D { + { .compatible =3D "mediatek,mt8173-mfgtop", .data =3D &mfg_desc }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, of_match_clk_mt8173_mfgtop); + +static struct platform_driver clk_mt8173_mfgtop_drv =3D { + .probe =3D clk_mt8173_mfgtop_probe, + .remove =3D clk_mt8173_mfgtop_remove, + .driver =3D { + .name =3D "clk-mt8173-mfgtop", + .of_match_table =3D of_match_clk_mt8173_mfgtop, + }, +}; +module_platform_driver(clk_mt8173_mfgtop_drv); + +MODULE_DESCRIPTION("MediaTek MT8173 mfgtop clock driver"); +MODULE_LICENSE("GPL"); --=20 2.53.0.1018.g2bb0e51243-goog