From nobody Fri Apr 3 02:58:11 2026 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010041.outbound.protection.outlook.com [52.101.69.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2F5A35F60B; Wed, 25 Mar 2026 06:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774421704; cv=fail; b=QBZBZQsRrnlxDknv1keznVNl1S3gsrxTEuFuXjBmU8217Ho2fEIHSNrRSEInUOnMhdFlu3HyzsQgA7YB0EgqrMhnmAewe0qZak0ulvwN6ZrOVeyfGkkLiKw6RzCkCD6ml8UDcl9RPVX8p9VJEVb0tZ+mmVaqXXq4NcZbl7alVIg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774421704; c=relaxed/simple; bh=3K/84AsH9G3E40N5VeFEGTHnjvGOCzwLs9oCYr8TVjk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=iIjZTnD0QZpgdZ59kYgXXEKPisFZcmcMUA1I1rnMdUoTX8zCWrJqGxzDd1ATPeyX8GSsJcKdsL7E0idC+geMjqzNN5A0R7kfbg3UOz5w/nVaSkklzo0yG8ETqug+4vMXCiMq/4ACLk1Bc36z7YjUihxZqq9qMfBa6oyx2Y6CNEc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=lG+4oKV0; arc=fail smtp.client-ip=52.101.69.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="lG+4oKV0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VeR3fET8wo3lwUbuS6CUSnAMWEa0kBYH8JzhKXnW9kF1aLB8wBJjPSV3FbaCzxlRUm4ybuWb0LF60kfMmXHttWulwtTsFBa3dLc99mnBVrDudny1lhMzfzqLemvB56D6jrhBUhrxjCQtwFnjewDgX7hiIIKZT4qn1i+SvWXTt/gbnGvINT9B6GDmBK43aalyg7yg9AaC1yubBilpj45u9Ly6/GN8HGOEagn0USTebrFn65PiUbpTxdZUbRnhhiFnlWm7TUph452hLoT1GGX41rVS2e8mtBDFuSTWiS2uPTQX8PhNYQUDmyFMsx3hHlMt2EFSlzsJ20QlEndoMElhrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QfnxgQGL5ceFXyXTgFz3rOF549xSlY589oIk/zi8jw4=; b=T7R6pqsKbgfkjOALPcRrEFAO8ih/AskO2FKULtVTKiyKqHq/QJOTTb6/ZyCnbaGbJB/yku0PGool21FzYGyv1l2Dr5+EmyoyTSAbbb74rx/oSXZUyF8zmVMGSJWt1rZIbUvtxLLt3/tU0MbwiWo5YDh++Dzk7tDD8t1qQ8BnsNo07XM0uJoGoqPVRzOEwKsvBlDu5NdG7VtGSISIr8Nd4obxIP+/mc6qm/8CXQkbkritwjkLAXv/5RuzEyNeVOU8BhYTFVYHM3SRQuIbJ+PllKxvVr9RHMPZ8CJ5T0dIqnUvHjAtAAxIPxMV5yUWelCElpcWypdb8Xc9/MGoRdpTuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QfnxgQGL5ceFXyXTgFz3rOF549xSlY589oIk/zi8jw4=; b=lG+4oKV0tFEcfmMDyGLYw3mz34s9QEcGj2c3yieIeeNbXCix/N0gVaPXv4g6YC4FAXl65cOM0NeiXvS93JCNifHoDSv9bl7IGtYPYbjxHgkvEqyzBN7dwJUHqBTyJrvp1YO3EhOERYsAcaKtFGrNZF1xcbMPV0dupZuutbLSpAX9rcOqmS1pg2Eg/+LF9o42OAqyyvIFoUY4eNRwEt8AWGE60UA+9gzuas70gYPD5ZBSmXvpzmZLz3zW7XpYVv6m3D9yj4dtAIDGfw+vdD8/K0ma3dU3avq4WDDLZBzysjGwVSWv8J45u2VxSa62gNCqwVA0+GMdXTU4m53JCzYvcQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) by AM8PR04MB7459.eurprd04.prod.outlook.com (2603:10a6:20b:1dc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Wed, 25 Mar 2026 06:55:01 +0000 Received: from PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::b476:c19a:24cd:3694]) by PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::b476:c19a:24cd:3694%3]) with mapi id 15.20.9745.019; Wed, 25 Mar 2026 06:55:01 +0000 From: Wei Fang To: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, alexandru.marginean@nxp.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH net 1/2] net: enetc: check whether the RSS algorithm is Toeplitz Date: Wed, 25 Mar 2026 14:56:46 +0800 Message-Id: <20260325065647.2882997-2-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260325065647.2882997-1-wei.fang@nxp.com> References: <20260325065647.2882997-1-wei.fang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MA5PR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1a8::16) To PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8510:EE_|AM8PR04MB7459:EE_ X-MS-Office365-Filtering-Correlation-Id: c720ac30-03c6-407f-58c4-08de8a3b6fb5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|19092799006|22082099003|18002099003|56012099003|38350700014; X-Microsoft-Antispam-Message-Info: Yizet90ol0lvm8x77dX53Zro0rc1hrXu5kfn8Ntspiv6AmpmBnvp2whvjPRXQ3Sjua2C8JRXw7UX7XPRaCqVywVYe//RWA7cNLIIfnQ78+Ngfwln7ZFH5gI2AC0Cznfc705yBwoY3mX0U2hqpE0V3cSP/hT+7zZsLJWCEi1gOgB9C4/xBtpYSRPDtMmXsM9lAh/bGZmucksRa299G8qtFygcuP2Kkw0S6G2SHsKlXWjzvIpIwnFpaa+qDACraDCn4jN+dqQWM3r4y3T845SkuEtOPSxzQK8EJEEnfWwU4NRoCxzhuz/ozGrcwyQaQ3Mh2AaJr2X1f/CrP/UpUhPCcGAFQ1O0EhsLMBCFntXmDXnZzWD5Qt5GAP7aYR16R4fzbgdaZ0hgzqGrxP9eEtfo5k2+7u75ne9GxNQFGpSWhfxSyv/vwzd/mibLvIFUSzkYD2cASJBAmcG0n2GerWKqLoWB2xnyuG3mQJGcnvXlLY8YyaknHmp7QTjNCQVgCpXh7uJvWZ+UviOY+zCSrfyAsDossBru6SLEAl435ahic96y/Iufjwx95kznb9JDuoJA0FsrnoNyRbOrfL98hNlcKx90y2kS6bs9BtGmR7xbedFxwyVRUWbqfJF0HZ1UwLq5OAaxTUNWBGpJ+SdV7LaHmGRtlJIYDgIFV5wt38XNSGxvfgRWlB0OZXO/OmA+FsrfY9jjKfrNlNmDAqZZ6ARpg382QT24UMl3m8SoFXufQLqzfurRNXucOwvjKvOp+rDKMhn2Dmu2xmuo4B07vTGdp7ArccDt4UrXeUYLPVWckwA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8510.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(19092799006)(22082099003)(18002099003)(56012099003)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kL1tI77Wn2nr8sWOCSgMv1ZfidErh1WhA9Lbks7X3SQk3ImtmhsPuawqPjDe?= =?us-ascii?Q?C3clC0pA9lbS7EJ22fl0nrBS4AGkenOzEG/KlEDX+X54iHdvH5iMhZh5w9UL?= =?us-ascii?Q?VYTIyltrXTAvIQfbODJo7pBV1qvk4uDBd3P5AXw7pQyoAKg3hBtkqXw2Rxy8?= =?us-ascii?Q?HbnlGqMmLxpgKpC8SjHzrVqo4LTh9Xv2R0AgJN66jhW4VX6DHFDXnguFyUEW?= =?us-ascii?Q?bzsWbDhjQ+MQ2KyV7dm58epCSgtqZ9ZLoR93DYxKLTcNLWRm+GmW8DtLNvh+?= =?us-ascii?Q?BJvbgCycvxHQmlbjzo1zb/3QAS35kGjkO9nJX5Zg5tEvDosMQXatjZ4YG2Lj?= =?us-ascii?Q?96iiBpcFYNyQHF9uOV25f41hPI7CgI0zS+CwC8xmz0qdIyizNTVZvHQw7Qr4?= =?us-ascii?Q?PXWoh51tv+j09PtQr9P6agJI3PRlTeMXSYTIPItq+LbTTJUG58RV2z19h44L?= =?us-ascii?Q?e2r5tptKaUT68ZLHMnII0Mojq2cVa8GqdjenneGbsCDh/8TV2V7ncmHlCnpR?= =?us-ascii?Q?4RRQA39/5Dwfu0CsggZtG+hy8JQdWHor5/45Zr3jjCYQfiba7+VppPJnuqhx?= =?us-ascii?Q?NBhjP20eLCpe+AHI1Cs7Dw187RPju8u003ZL6gxrq0E+c7H4XPb3KTkUH2k0?= =?us-ascii?Q?RvmbsI2f85zKdQuIbH7ni0SsSsrlwIKXDmm7JA9PkW7ThPttoxMKaBUV1NMc?= =?us-ascii?Q?F7JRMfolIqH5WqEYJmE8A9THz7HwYYxPNDE3uTD4T8xBXbXqF4QTfvSTlpSw?= =?us-ascii?Q?odH8AlOl9vPM0p78DMa0unNMgnoE7VWyJXau9jdBs14d17RCj3FcESs317eb?= =?us-ascii?Q?ChaIkl5aig016w/V3QmSW8xZjDvfG9ZATpv+4vMqafuA3NG++BitpAKk4176?= =?us-ascii?Q?QFF4fGUWwHFrmvHH+kv2hobI0nxUXzMor87et07daSBxEXIgSFTZoWtRsiNz?= =?us-ascii?Q?IYq7IGAU9gACw8Un0J+zsmrYcwITBeuGnrdugMkC5j3lfMkenpZ/yg4Zz+6S?= =?us-ascii?Q?TwkhgUpm29zHCEd/qDYkBsku1SDwkvr3kDS1gxSsNXZPduWMxmqnPqE7s0fJ?= =?us-ascii?Q?49jn85F03NUVHcDItUPcxv1GHKMHUG95DvBhI4wKw77q6IYhexI2SjJOTO9D?= =?us-ascii?Q?0S9M1rDX9G3RPpwC+ahYIEcnqkBsDPOvdlDeeVu3nV8iOUtfusIO9PgfTXG3?= =?us-ascii?Q?pJ6w9dO+avpIRApa2AoHyS9HaurCo1yk0VxUFP9t5MeOGKZd8wsVLz7jyd27?= =?us-ascii?Q?V3gRE08YNsL52u18NIhVoOK5J228wns7NrDZLpfBUCCZ9YCEFNLp01XH+Mvi?= =?us-ascii?Q?/SASGjCyfnZQmimZ4a/rb7/mPvJ8f5P5C2NbtrmkdWdk9BKCbtR1Kx+RwuA2?= =?us-ascii?Q?eyQDM8+sILNBqGIaqnP6wijkWP9Np2Qa0RhnHChOrqtViPJlWV5c67Wtna7Y?= =?us-ascii?Q?Z5YD68xnqLMDVJK8ECg1CjnonyD/G4UuM0toYR+5s9yffU6QDAhyRQb3hTTp?= =?us-ascii?Q?uo3YejUQ5HIYYgqP0lmfRgYMjlZ7C/Q808MifSr4siqywjCjnQpn75LSSnNg?= =?us-ascii?Q?CjRutF5c6yXOomT4LzCBLa1BL5pGA8KuAHKwYxMEclZifG3PBpfPr9paiC5o?= =?us-ascii?Q?JLuXHlX1dGHjnvrvPwCOa+zqvWFTx1RRfdeHa7ywYkxf673p+zcm21cg4D0N?= =?us-ascii?Q?dA44LX9iHyt/eWm4jj/3Rx8XW9Ega5e9N70ZGQmxM7akJGmIr6d/ZByB+e60?= =?us-ascii?Q?xsLsDZGxtA=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c720ac30-03c6-407f-58c4-08de8a3b6fb5 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8510.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2026 06:55:01.6331 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DpO3xFF+2ugmbq0wWoP9SMg4GSLBLKUVnLIsZPbTGKZTuFP+ZaqPyATi7kgXPLs0BB60AnGMlx4di1U4e5Pr1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7459 Content-Type: text/plain; charset="utf-8" Both ENETC v1 and v4 only provide Toeplitz RSS support. This patch adds a validation check to reject attempts to configure other RSS algorithms, avoiding misleading configuration options for users. Fixes: d382563f541b ("enetc: Add RFS and RSS support") Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers= /net/ethernet/freescale/enetc/enetc_ethtool.c index 2fe140ddebb2..a393647e6062 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c @@ -795,6 +795,10 @@ static int enetc_set_rxfh(struct net_device *ndev, struct enetc_si *si =3D priv->si; int err =3D 0; =20 + if (rxfh->hfunc !=3D ETH_RSS_HASH_NO_CHANGE && + rxfh->hfunc !=3D ETH_RSS_HASH_TOP) + return -EOPNOTSUPP; + /* set hash key, if PF */ if (rxfh->key && enetc_si_is_pf(si)) enetc_set_rss_key(si, rxfh->key); --=20 2.34.1 From nobody Fri Apr 3 02:58:11 2026 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010005.outbound.protection.outlook.com [52.101.69.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 452B136074A; Wed, 25 Mar 2026 06:55:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774421716; cv=fail; b=iJhrHm9Q6l4miVf2ZJqI7+U7a4RrbT/E0m+2+xaBtndEuecRpmwd3yAmaduGNh+JhPRrZJGr+7dJ5Fpzplyi3biQZ8yD7+fHcpQwbM/IW63ls/dJd5Olsdrd/q/v0yKlK7LwIJmfm9ZOp9kdo+iTXmcEissmCzB2/suAMG7OmvE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774421716; c=relaxed/simple; bh=g04+NkbxivEf2q7e4aj3IGGeOAEky23lABB4J9JKczE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=gmicp52wIBN7Bd0JFiiMnQ2elJ5uPviTEuupyu++OgYmPKfCaesIiNXJBauXfrvob/sMbty0yajITWBfF/SlqEb6XAsThgf5VvZcqpf8i3pVGQ0WnT/4gZB8YDqq/o0dowUYmnQLSJNIK9uEJ2yvIxXNjw6lsysUf9ojJOQ9lZg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=YsYvaCi/; arc=fail smtp.client-ip=52.101.69.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="YsYvaCi/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Zm+UQG/saAIKP1RA5HTeTQPySTZvHmT9ckLytB14pNsL4WkyL7V/xM0UKteGIvAk9TM4MR1W0iWnuAeDA1GTkvwuYc1SWTYLyhW1H5sLjO3DCosZ+lT79hUTN2zZzljlitb0ObE50IJgZ4Kau9stYbnIsNfJotcHJi224b9JGaa93dD8TyQUsgVjqJFPaxcc8uWoW+FqrIGla/NlfrbGDgV3CHRE2a0ncGcPf+oeSaj/fUJWtbFDgWRYDehXNMvjawywEW8X2SnF8b099yBC3DzlpEmmrC7yprl3Bgdcr3Bu5lzzEuaf4OiqXxDOKfjg+6RzbEaN0kgUd84bZl5uxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6IZcXhJjmCO+Khiwh/XkWEWCu4sEJ+lb6/M6IZfW0cI=; b=YpFrF21yDS5FejphVZzjBcfBOvHO0LEz88oY72cmz1kNFaOKjE3eYvIJGWoH8YqGyaBTZSuzuaAFOwhVoruWX4p5iWgdwml3p98ql117iwiehzEz/nkCSBjVM2vQQlmSLQ9CmI8WMLiNglmTfOMjL7taWs6F9TT+TR3RupEMPxTvik0uB4yFwb+wUlk30rgzf3xvQY5nlCoEqdqLIwSjHne8jcyIdlejv9vqHcCu4qqkjkEBVDmlrMO+M3/reJG2lBx6yKkC33eW5DkDeOBbrzXKPLX/sEdtV2ci1VhVhm9PceGvHNgOOXa00ro7j4V/542mdYFq/RWWtFGth0vY6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6IZcXhJjmCO+Khiwh/XkWEWCu4sEJ+lb6/M6IZfW0cI=; b=YsYvaCi/9LwQZIhkUuRiUO7Kkgq8RqE1EVB0lwJiRwF+D7RqWiSF7NpsFS4Z/mkuTjZqgql/Ah2GA/EKE5VVyz8ZGiEdLn8CMwE4AMZEtcZ3ogulWDTv++tsWX4Zc0phKG/eA6yssIAELMn82YKfNuidYf1ezP43IEbhsCS4EQV++ZJpbkty4JhjT5kfEdsgK1dtM0KAGHR1y01Bal+tTprH1aePZ9R1WNLfVQRxnD+0InpVTQvXctrgPrcrHdd5vthk/6PvAt0DasbncMPyA2uOYf7fYTclxNGtR0ejNn79xyt0NIy1hK91v8OklKNHLg5hdOSXXwXEECGlUb6+kQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) by AM8PR04MB7459.eurprd04.prod.outlook.com (2603:10a6:20b:1dc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Wed, 25 Mar 2026 06:55:05 +0000 Received: from PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::b476:c19a:24cd:3694]) by PAXPR04MB8510.eurprd04.prod.outlook.com ([fe80::b476:c19a:24cd:3694%3]) with mapi id 15.20.9745.019; Wed, 25 Mar 2026 06:55:05 +0000 From: Wei Fang To: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, alexandru.marginean@nxp.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH net 2/2] net: enetc: do not allow VF to configure the RSS key Date: Wed, 25 Mar 2026 14:56:47 +0800 Message-Id: <20260325065647.2882997-3-wei.fang@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260325065647.2882997-1-wei.fang@nxp.com> References: <20260325065647.2882997-1-wei.fang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MA5PR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1a8::16) To PAXPR04MB8510.eurprd04.prod.outlook.com (2603:10a6:102:211::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8510:EE_|AM8PR04MB7459:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d654346-196a-4ac9-87eb-08de8a3b720e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|19092799006|22082099003|18002099003|56012099003|38350700014; X-Microsoft-Antispam-Message-Info: YoKt6bEw4g7GHvQ8QBCEzfTuBVXrGpQVdHR/SgoF3P0Rt7pGmIjqs4wrtmlajwkrwTanCiz7WYccc7xaKTlfluGK/VW/Spfcl1ipQOrMl7bsFqplCvm5EVZOlZIWrTG0FIGUPAzb0zyzQLXUFIY9IDbyUL9ko06/pVOvHLJCl0OEsjh6SAq4pkp8shxzTrEyp80JWUm4us9/ixlmBlOn9W96n/GxA9CR6FO3YEByeFEcoEJN++Ye4jM8MHfirv6NYHBvKGRYzXPhiMr1QlF30f42XAdr/RLPSrt/SMq6iAokOkO9WG6dgnhH3KcP2bS8Xw+uOgBlfo17lPQouislkREqU4DrbmVGqJzHoCywjglajdJstlWJ+gPP/16IZOAUErBZFv4gNRwdpKH7SfRyzmOpX/t5m0kGVI/I8NZ0lSbSVWMkjeDM/Xv5W1km/bDWji/o/MYKUuW4shM2OMyHiKHLMMpUAT3XSbLXBAY2P6aN2u6JrNIIeLAZV1u61msug+ZJ3ViPgiUcQCtqbcqfTsVloanw8YRmAvL2DhtgZf8rYdYEAnOub1UWK5IwLzvaKWl+T3Apam/rPdmTaYds8ik0rRbaYN22/l5GqSCOYPT4BudE5vQdy2n7yxH1dMzh7Yq8nK8E0ZaEGHmJY6Tc9xuuLEYXA4AYOzjiWt62MMja+Ru2yseIgtZ9ZpP8PvikT5HaQ8kSqwIMaWL3Opn9XAvsYMPf2osc+FFcmRSvdBQNS6MclQrtCJ/oCysRoDn47K/4UdoIL0wxXwiRgiKnxhDe4c6MppeIqXD+MbKCCh0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8510.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(19092799006)(22082099003)(18002099003)(56012099003)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ngahG63veiYpf0ALXwy6H2GkFDxX5rYluAzv7pvITeOoz3QZ2NHJ9BHgciRn?= =?us-ascii?Q?oX3H57WYoXWx7DTtPm+y5MOtHsUSPzbCBDWkFSVnAG31qzoS+3O1FRV4Qwf3?= =?us-ascii?Q?rYr+lSyvWDtLPmAYB1RTDGAe1/edOlm/Pbc0j+mnFB4dG8/AW1hZdyHBxdFY?= =?us-ascii?Q?q9PAh2PFzqPpWND1UAFKCeMetcpzIxfYulFAIuvJzm1hiHp8vw1WaWZ6iS7p?= =?us-ascii?Q?6K3bgzvBSAnaJUaVmEeLH3+dSHOSPTJIsgM7A0ep01Wgexk6rLSHD2hG17xG?= =?us-ascii?Q?XsPNigqXy8vaSZO1wxdxifa7nR2z7VipmNr2fUuE6oJAcGUaTIEu8/Xm7L9C?= =?us-ascii?Q?2ELTByrzHJEkbnUWJ4dkEApYmhZw1A2i+wByGMEka4dIkjj/YDslHIniT1VB?= =?us-ascii?Q?265yR0y/tbJBE3TIUv4fNjBpka6YFv06eXigf9dsXIFA5TUQyJ4LwOdeSJ2n?= =?us-ascii?Q?4pitHPjI24XItgJiXvqWZE0HQix3KdsGxmDfYz2Au71kHVhOpWjWHG2nQVZU?= =?us-ascii?Q?bXU4wLiwJuL9KCLBted0QdiKJrt3cpTMYoGeZrIwxuIXHKVSvT3DMZ9CkAKt?= =?us-ascii?Q?nY85xdPELPNX51rVa682TJuYxXzqRo4iy2qf+o0XlwoqDzClHH/rilwJ63As?= =?us-ascii?Q?jU8MAbnMKeYKLCJRz1WeAXXDDfr0eLRSbwPcJrzuzLrzoyhdecdCdZ/+6NS2?= =?us-ascii?Q?RAlLalV/y0n/0GAvA9PMv7eFMTb6WTG9oGKO7r3qg920HLWIOk7HOd8H15/l?= =?us-ascii?Q?8b7GTwmZ2/SUv8Qd47htqzL2CMkSmlCYTjk9ulfJ54DHIxJBOsHbVuNPcM3u?= =?us-ascii?Q?6zo/SBu3z31QZGca2zaQaTbB54gtvVfdt9RvNqXK6uYWA8CGO5E24rUOsXH4?= =?us-ascii?Q?fVbG9W4Z//YdTg6VM3iy+5QkzePFVPf50KqgNcHdz1r76t36mXI8XQMC2C8b?= =?us-ascii?Q?E3i6aotiAs0RIcNd2WkMdtwuwpH35bf77GbeSW7+xbW+QMej7F8wyxVeMS29?= =?us-ascii?Q?rC1Wmbk2bJRRBj9E6ADUoo/29E09u+hxHgtqwx0HKte606PlhpHIUUZr9E7N?= =?us-ascii?Q?+YDuFxgrysAcnffxeCSb+nT+23RaEP1wSocogm4fCud2EvgobNQG8ww1hgDU?= =?us-ascii?Q?tvYAASygl7xlMf+OdId4Ghf5rsSE9WhRPkKR9hY/kq+gvXiWZ9uOKQYzS3nN?= =?us-ascii?Q?Ng9/hBsMdBjcP2UXAVUB6ulv+euKhCmDrN2311+5D5vepfvY/E4AvjOT6mqH?= =?us-ascii?Q?we6djQiqSyNK00y/IMRsTJWJiecGYIaUOXoc6YlM8MHkfc19yj+wRo7++j7C?= =?us-ascii?Q?k34UShOIrRDh24u0pO+kxZdq4uFJukaBt3G6tmhUpFuRFCHBKRs1qUBqNinA?= =?us-ascii?Q?RAzBiQkqKUdJrxCt7yc3jxN6oiu0YbfY1HYuCfTqIubc0dZACrVK/lKRkaZE?= =?us-ascii?Q?szQpPGnfwFXCGQyX7fr+kraObwcXgzNXv7W6DGYG0AmPzY4aL+LKpes084NP?= =?us-ascii?Q?mhgO0xFbqAQqIwY/euSuNYr+ED82epuG5WSI4PotsqwiTH9GbAxqzE89AhEt?= =?us-ascii?Q?mb6YkE3ar1mdS5xOnhTSjxdVGvFT23gYUYCINHFZzJCFd6wB2Miqo4epFUvP?= =?us-ascii?Q?shG2J4SvMNHNlAdGvfeV/MiwQjw5Ew4/QggHWssEUokAlakrrqy0fyDVfegU?= =?us-ascii?Q?2l2NWhLcw2H2OYe9S7K8kzV1Niie0/9Mtja2Ug0kkAd4yRmuxkPfYjAAmOwk?= =?us-ascii?Q?fFVhRng0WA=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d654346-196a-4ac9-87eb-08de8a3b720e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8510.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2026 06:55:05.5432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xfHbNIm4Zs9rSO+9uULngWyhQCdWvpKAqXMpWynaoRli0zdb3jcO2pRcyD0/BQg5Y+rDrUqdkYFrRN0StFAhlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7459 Content-Type: text/plain; charset="utf-8" VFs do not have privilege to configure the RSS key because the registers are owned by the PF. Currently, if a VF attempts to onfigure the RSS key, enetc_set_rxfh() simply skips the configuration and does not generate a warning, which may mislead users into thinking the feature is supported. To improve this situation, add a check to reject RSS key configuration on VFs. Fixes: d382563f541b ("enetc: Add RFS and RSS support") Signed-off-by: Wei Fang --- drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers= /net/ethernet/freescale/enetc/enetc_ethtool.c index a393647e6062..7c17acaf7a38 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c @@ -800,8 +800,12 @@ static int enetc_set_rxfh(struct net_device *ndev, return -EOPNOTSUPP; =20 /* set hash key, if PF */ - if (rxfh->key && enetc_si_is_pf(si)) + if (rxfh->key) { + if (!enetc_si_is_pf(si)) + return -EOPNOTSUPP; + enetc_set_rss_key(si, rxfh->key); + } =20 /* set RSS table */ if (rxfh->indir) --=20 2.34.1