From nobody Fri Apr 3 04:33:02 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1841870809 for ; Wed, 25 Mar 2026 04:46:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774413997; cv=none; b=nhlx0eqkhCLh21A7H3BLj3P+WlIxyQpCcgMif/SyRbWbCLSvOnTRW6HFbj8ldGdvlfABJxr9P1MjZfm7bIVqWQAU7SvqAVXKr3V2qoobZsjsjbT6hiPKaRikzQ14kpvRpAj4BwSrBioz49FzsqjLkSHLheIriLPmZnIJu7iapBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774413997; c=relaxed/simple; bh=4MwI/roZPxfX0S7ceDw69F6AuQqaCKsoJglHMoZJhlI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a7efoxm1ciTE03KgMjkr4prvmvqzz7bAt+YJr3BgWdiASZdJKmA04kaGzRH43AFNstoEqOn3Vrd2gSvtySx4ZjqGfoGjPsz7Mv0tBCY/5QMGfXpEYbKgopKxOfIzgwPWu0EyfpAC8KX2lmUhVKxdjcC3iY7IT9YI4r+To0/3vBQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G3WfrhX+; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G3WfrhX+" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-35c05d7e0e9so1203992a91.1 for ; Tue, 24 Mar 2026 21:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774413995; x=1775018795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SG8qLlFK9Bv9IOjifKCoHNCffCe/58yR1iKkvJU9MpA=; b=G3WfrhX+0sJlvsOwsqZ79fCZUpL5X9IGLJ1ghggY0wWH2Ylodx47UDd7ZqzwDHRju5 cSb09vXDeC+PZWWuF8cYux8YunYo2Yq438vKAz4ZJQaZAragsDGu8xHh+PilgIP3rTAk CE4PMWZ9cCgkGyqJriYe75G0/ZpwMTUB/7eITpbn7OlaO2OWkjWhD3zIPDC91hOo9HgH yQQUnGi5EFaQYJ1vTC3YltZeGX1H2yvvG4wlUvyUhVT/m1rKU3kj0cIKSsXnD6LR2rT4 Cj37LqOUZQhj9EKzsmnt/otb9WKTtTXk5CKR5ssNGuO04CNniLqab0X4e3V4Sh50YCa1 a2kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774413995; x=1775018795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SG8qLlFK9Bv9IOjifKCoHNCffCe/58yR1iKkvJU9MpA=; b=sKfdVKC3sD0mulD0QUokn942Xs7qzfvkltEAKVZLEaeZnYn1rvnZigLoJVSyAKkEiX WLGJ6L4TTyxBalHtVxupi2nitNWtk4vuxSdrlweiWibrmLHV1aKoIZmaMUvWRChVaCr1 VOxMQ+uzPkYIICF8W+AoN1j64DWDMQq2U7Jthpkr0t8kO3q5xwxrUwRxFy061ZgyQOQd sJv7ip7e3BFnqsEOmPgtKPCE8f1mfKA8osQ3V6aaK2ORjFeWQH768W+LegVF3rdly900 Ap7BWHEhZ8dZuWm/i1sF2/5KXERtUh8ihRAo48jgLLfsAEHJMPxa5FMElT1ph5okbaKC EOUQ== X-Forwarded-Encrypted: i=1; AJvYcCU45kbPQ22TzIZWp6uXrRHC7uuAuYAlVHnRM1ZK1eQgR/1vMufrNYErhtP3ux4FOa59Q+q5iFqK+frFX78=@vger.kernel.org X-Gm-Message-State: AOJu0YxhR3kZVRxhmvDhGmacjjQe+0ZZqL8fxiax5FbLbrS2Sry/c1yV ygopttVWofnv1UbtAfuNW0JW4O0DFzJqY4jgLjkRNnN43koklC73BRtB X-Gm-Gg: ATEYQzx3Ubu7L/QG97jQCJOfWoVSUtFMwv3jgL24fZDlkPoCAtczY25wiCbWj0ogc/o ydQhznfb6Aq+VTbzQN2Q9gVM/fg99j1Q+J5dKZzKj5qpdYpAu6LJbDOoJVXhKBx3i2YtrjKuoGh LtdvQClILleiptwSFC0oyBJ+bWh7PTVa0rW+K3Xcmn7IiHzhoDZa43WsjxLrE5gipqSrh+c6OTK QKPBQtlDMqxAam6xKYU2QJad7O8rrKHC3LS4s7Q86w3nlT+XZ79tLo67w/pyj33KM0YOgIKiS11 GycOwjIQLxWyFW1Z0rD7231qySeLwqjjr2dDFW9JCCZhqnp2ishuKaT2D2hxEFOAMOhQ5j63Pjk ZHcx5Q8XtHGxPbHeHETD/HTuPagWQspI55op++YXFfyAr6ZLvQUGO9EucGNAqUtMW1FF3mkHvmA gnX5NM5d3AYPDpQQYIjlsHSQvvXbQoppna X-Received: by 2002:a17:90a:e705:b0:35b:92c1:8a39 with SMTP id 98e67ed59e1d1-35c0dc86713mr1940670a91.8.1774413995352; Tue, 24 Mar 2026 21:46:35 -0700 (PDT) Received: from ArchDesktopLeo ([2400:a840:5c41:0:e012:ea6c:986:40a8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0b0975da7sm14784405ad.44.2026.03.24.21.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 21:46:35 -0700 (PDT) From: Leo Timmins To: Pasha Tatashin , Mike Rapoport Cc: Pratyush Yadav , Andrew Morton , linux-kernel@vger.kernel.org, Leo Timmins Subject: [PATCH v2 1/2] liveupdate: propagate file deserialization failures Date: Wed, 25 Mar 2026 12:46:07 +0800 Message-ID: <20260325044608.8407-2-leotimmins1974@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260325044608.8407-1-leotimmins1974@gmail.com> References: <20260325044608.8407-1-leotimmins1974@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" luo_session_deserialize() ignored the return value from luo_file_deserialize(). As a result, a session could be left partially restored even though the /dev/liveupdate open path treats deserialization failures as fatal. Propagate the error so a failed file deserialization aborts session deserialization instead of silently continuing. Fixes: 16cec0d26521 ("liveupdate: luo_session: add ioctls for file preserva= tion") Signed-off-by: Leo Timmins Reviewed-by: Pasha Tatashin --- kernel/liveupdate/luo_session.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_sessio= n.c index 783677295640..25ae704d7787 100644 --- a/kernel/liveupdate/luo_session.c +++ b/kernel/liveupdate/luo_session.c @@ -558,8 +558,13 @@ int luo_session_deserialize(void) } =20 scoped_guard(mutex, &session->mutex) { - luo_file_deserialize(&session->file_set, - &sh->ser[i].file_set_ser); + err =3D luo_file_deserialize(&session->file_set, + &sh->ser[i].file_set_ser); + } + if (err) { + pr_warn("Failed to deserialize files for session [%s] %pe\n", + session->name, ERR_PTR(err)); + return err; } } =20 --=20 2.53.0