From nobody Fri Apr 3 04:33:30 2026 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 673BF2D5950; Wed, 25 Mar 2026 04:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774411507; cv=none; b=bmHfCOas2v2F3ni1xZz22j4lThUfCE5QVdxydvKgxntlvt/NhnUEB1j6YSFnUyL43KkfjSFL641Sndx8eMGX0okl9r+vjWl+0JMrbk9Naojnm2ydcE8X38vC5u/VbPoCpCiYZS+rWA0g7ouEnIEZIl1qKIcyF7t3Xv6G4et6YOY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774411507; c=relaxed/simple; bh=OKAC+vqoPH4G4aFuN7LdkobqRd8Cvd2aSwcL3g/1kHw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cS3+YK8MsslVw4cajjQJv6TZ/cfP8e8a3LqvfBUKRlVzsG0qG3Rfb3dX/2eSQmUpmy8jBP24WVmkZV31ACW5R2Sd41K/QznHcjQXb+4aMIJp6jrzwJibKWtr5UZIKoATYiQFuZYuM7CiG8XZOSwYwoHkB+FQegIh5PFbPfAqMhU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=GknNOrM1; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="GknNOrM1" X-UUID: cacf79ae27ff11f1a39cd589f645bc18-20260325 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=e+46r3Yi/z7wZ4y5BUiRO0AV6aK9RmoAXly/Gf3gLZg=; b=GknNOrM1WVH+zUhPgRMOX9OHxDCZmt5AJlWp72qjMqM8lMMYsdZ9E8/r5WHG34rtSih99l84zDPbfilcoeYOX3ipP+emGJwji3fHZcMPuLUM0y61hQgeRCw9L7KDGUVGbniLWGqyjZOhqO3+j1THSCnI1QhKNoZCi3VFnNCnrfU=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:866c456c-2c52-4560-9edf-e935aa5e08ed,IP:0,U RL:0,TC:0,Content:100,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:100 X-CID-META: VersionHash:e7bac3a,CLOUDID:414c1ad5-060f-4ecc-9ee0-121eeeb4a682,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|836|888|898,TC:-5,Content: 3|15|50,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL:0,OSI :0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: cacf79ae27ff11f1a39cd589f645bc18-20260325 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 165407874; Wed, 25 Mar 2026 12:04:59 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Wed, 25 Mar 2026 12:04:58 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Wed, 25 Mar 2026 12:04:58 +0800 From: Jason-JH Lin To: Jassi Brar , Chun-Kuang Hu , AngeloGioacchino Del Regno , Nicolas Dufresne , Mauro Carvalho Chehab CC: Matthias Brugger , Jason-JH Lin , Nancy Lin , Singo Chang , Paul-PL Chen , Moudy Ho , Xiandong Wang , Sirius Wang , Fei Shao , Chen-yu Tsai , , , , , , Subject: [PATCH v2 3/3] mailbox: mtk-cmdq: Remove unsued cmdq_get_shift_pa() Date: Wed, 25 Mar 2026 12:04:22 +0800 Message-ID: <20260325040457.2113120-4-jason-jh.lin@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260325040457.2113120-1-jason-jh.lin@mediatek.com> References: <20260325040457.2113120-1-jason-jh.lin@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MTK: N Content-Type: text/plain; charset="utf-8" Since the mailbox driver data can be obtained using cmdq_get_mbox_priv() and all CMDQ users have transitioned to cmdq_get_mbox_priv(), cmdq_get_shift_pa() can be removed. Signed-off-by: Jason-JH Lin Reviewed-by: AngeloGioacchino Del Regno Acked-by: Jassi Brar --- drivers/mailbox/mtk-cmdq-mailbox.c | 8 -------- include/linux/mailbox/mtk-cmdq-mailbox.h | 12 ------------ 2 files changed, 20 deletions(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-= mailbox.c index d7c6b38888a3..f463f443e834 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -123,14 +123,6 @@ void cmdq_get_mbox_priv(struct mbox_chan *chan, struct= cmdq_mbox_priv *priv) } EXPORT_SYMBOL(cmdq_get_mbox_priv); =20 -u8 cmdq_get_shift_pa(struct mbox_chan *chan) -{ - struct cmdq *cmdq =3D container_of(chan->mbox, struct cmdq, mbox); - - return cmdq->pdata->shift; -} -EXPORT_SYMBOL(cmdq_get_shift_pa); - static void cmdq_vm_init(struct cmdq *cmdq) { int i; diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailb= ox/mtk-cmdq-mailbox.h index 07c1bfbdb8c4..a42b44d5fd49 100644 --- a/include/linux/mailbox/mtk-cmdq-mailbox.h +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h @@ -96,16 +96,4 @@ struct cmdq_pkt { */ void cmdq_get_mbox_priv(struct mbox_chan *chan, struct cmdq_mbox_priv *pri= v); =20 -/** - * cmdq_get_shift_pa() - get the shift bits of physical address - * @chan: mailbox channel - * - * GCE can only fetch the command buffer address from a 32-bit register. - * Some SOCs support more than 32-bit command buffer address for GCE, which - * requires some shift bits to make the address fit into the 32-bit regist= er. - * - * Return: the shift bits of physical address - */ -u8 cmdq_get_shift_pa(struct mbox_chan *chan); - #endif /* __MTK_CMDQ_MAILBOX_H__ */ --=20 2.43.0