From nobody Fri Apr 3 03:04:47 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE8BF13DDAA; Wed, 25 Mar 2026 01:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774403493; cv=none; b=ox9vv+B571zMrqrDfVXDv0uX3F1FOXe5eBZIREDHAfv+Hris2/ESPHXZRQP33+YySVCMJ+m1Ksyl0sotJaSzP3eC3zLOYMGVWu4SWNEwZ9wp7fCNCNkEDoi2XIMQ0xAd/D3tOV+jemeZ0O9VsnIaX80NslQEVn9DienSZc3RxhQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774403493; c=relaxed/simple; bh=5BnDWDcAVzihmhElrqul6nUPWTPPlp4SeTnUC6Tmk1M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CNFdZCk4e/zY2zexY62Y3FxrFm0AbIBSLIrA7h6/LwZQZ38Poy/NUp0r08qcEem5jFbKiGK957lQlxytNhyYKLVBBvwGehTiPTdvNFTzNu0WjFu9HLYRitdcCz/N7pt/uvBJlnqedHP9BluC+dS2tEy2n6dEPYlEmQ5O7SYyiM4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 20d67f2227ed11f1a21c59e7364eecb8-20260325 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.11,REQID:0d811ece-f145-4a90-b204-fb17000dff5b,IP:0,U RL:0,TC:0,Content:-5,EDM:25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:89c9d04,CLOUDID:59261f63daf472cbc4e14dd7d9253d36,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|850|898,TC:nil,Content:0|15|50 ,EDM:5,IP:nil,URL:99|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0 ,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_ULS,TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 20d67f2227ed11f1a21c59e7364eecb8-20260325 X-User: songxiebing@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1803965099; Wed, 25 Mar 2026 09:51:23 +0800 From: songxiebing To: tiwai@suse.com, perex@perex.cz Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, songxiebing@kylinos.cn, kernel test robot Subject: [PATCH v2] ALSA: core/seq: Optimize the return logic in cc_ev_to_ump_midi2 Date: Wed, 25 Mar 2026 09:51:19 +0800 Message-Id: <20260325015119.175835-1-songxiebing@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260323024742.220707-1-songxiebing@kylinos.cn> References: <20260323024742.220707-1-songxiebing@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are multiple early return branches within the func, and compiler optimizations(such as -O2/-O3)lead to abnormal stack frame analysis - objtool cannot comfirm that the stack frames of all branches can be correctly restored, thus generating false warnings. Below: >> sound/core/seq/seq_ump_convert.o: warning: objtool: cc_ev_to_ump_midi2+0= x589: return with modified stack frame So we modify it by uniformly returning at the and of the function. Signed-off-by: songxiebing Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202503200535.J3hAvcjw-lkp@int= el.com/ --- v2: - fix warning: this statement may fall through [-Wimplicit-fallthrough=3D] --- sound/core/seq/seq_ump_convert.c | 35 +++++++++++++++++++------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_conv= ert.c index db2f169cae11..ff4ee26adad1 100644 --- a/sound/core/seq/seq_ump_convert.c +++ b/sound/core/seq/seq_ump_convert.c @@ -841,7 +841,7 @@ static int cc_ev_to_ump_midi2(const struct snd_seq_even= t *event, unsigned char index =3D event->data.control.param & 0x7f; unsigned char val =3D event->data.control.value & 0x7f; struct ump_cvt_to_ump_bank *cc =3D &dest_port->midi2_bank[channel]; - int ret; + int ret =3D 0; =20 /* process special CC's (bank/rpn/nrpn) */ switch (index) { @@ -851,47 +851,54 @@ static int cc_ev_to_ump_midi2(const struct snd_seq_ev= ent *event, cc->cc_rpn_msb =3D val; if (cc->cc_rpn_msb =3D=3D 0x7f && cc->cc_rpn_lsb =3D=3D 0x7f) reset_rpn(cc); - return ret; + break; case UMP_CC_RPN_LSB: ret =3D fill_rpn(cc, data, channel, true); cc->rpn_set =3D 1; cc->cc_rpn_lsb =3D val; if (cc->cc_rpn_msb =3D=3D 0x7f && cc->cc_rpn_lsb =3D=3D 0x7f) reset_rpn(cc); - return ret; + break; case UMP_CC_NRPN_MSB: ret =3D fill_rpn(cc, data, channel, true); cc->nrpn_set =3D 1; cc->cc_nrpn_msb =3D val; - return ret; + break; case UMP_CC_NRPN_LSB: ret =3D fill_rpn(cc, data, channel, true); cc->nrpn_set =3D 1; cc->cc_nrpn_lsb =3D val; - return ret; + break; case UMP_CC_DATA: cc->cc_data_msb_set =3D 1; cc->cc_data_msb =3D val; - return fill_rpn(cc, data, channel, false); + ret =3D fill_rpn(cc, data, channel, false); + break; case UMP_CC_BANK_SELECT: cc->bank_set =3D 1; cc->cc_bank_msb =3D val; - return 0; // skip + ret =3D 0; // skip + break; case UMP_CC_BANK_SELECT_LSB: cc->bank_set =3D 1; cc->cc_bank_lsb =3D val; - return 0; // skip + ret =3D 0; // skip + break; case UMP_CC_DATA_LSB: cc->cc_data_lsb_set =3D 1; cc->cc_data_lsb =3D val; - return fill_rpn(cc, data, channel, false); + ret =3D fill_rpn(cc, data, channel, false); + break; + default: + data->cc.status =3D status; + data->cc.channel =3D channel; + data->cc.index =3D index; + data->cc.data =3D upscale_7_to_32bit(event->data.control.value & 0x7f); + ret =3D 1; + break; } =20 - data->cc.status =3D status; - data->cc.channel =3D channel; - data->cc.index =3D index; - data->cc.data =3D upscale_7_to_32bit(event->data.control.value & 0x7f); - return 1; + return ret; } =20 /* convert one-parameter control event to MIDI 2.0 UMP */ --=20 2.25.1