From nobody Fri Apr 3 04:31:24 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE399267B05; Wed, 25 Mar 2026 01:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774403309; cv=none; b=OrWhwl7UMLv19M/fPZzadt0sXfkuz3wroNN6qaChX1OAlp3jvVTTWb2kMsRM83zhVm8yYCSSekR8mfLtr4RQJbtQUjNNmNRSJEuVupVXqsqB6P0jreD7CTkUxDrA4My77yFLEfBQeOWh0UKkoBfpEASrXAcjWS5qoT1zx/4ZTcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774403309; c=relaxed/simple; bh=D2zqbsmuetU9cdO58nyqDzsxrl4v4tccz7HarHPw5WI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dSUK0rtk9WT4HKsRLUWOix0mZ3CWH8FlQXEOKqwEaxZms8PUz7vZwMhgCOzxe8j9rsX+fJRpSF3xiuAiF2XULZ2+LFoXJkK1ywtjybsYcniFI/UgmYx+WMBq8q4IwS3PIVvUaEcN2mUVFsPpN5yo0tmRBqPSW9Uu1lmPY/L9Gu0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OsgcbNvj; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OsgcbNvj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774403308; x=1805939308; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=D2zqbsmuetU9cdO58nyqDzsxrl4v4tccz7HarHPw5WI=; b=OsgcbNvjXHsD6Tup0LdADye/Wir5De5RNJZvSltOhAtyORIlLF65Mg/X TCSzUAbOzp4+YJ3R5ZXKYCR1ynH3LJPuZXlFoX/cl6EHT0WqQT6s7foA0 LnK96SkJZy6/hzycJ193B9RZeoQZU/XhV9b3mCYlPeBM7HUlyj7xOD4ke V2XLIGVjdgoc4h/7HGXB+JLntnrfIuIJmfqbYJV0lEmruTzwykWasxyKQ LqJF7MxFEe+uzZZ90SfymTr4IiK8ezAtFJtxDt3wdJjw198WiO3imxaTH FdEFgP9WGM1E8xGLixdKjeBKp2fdwOiYyeTP57jXAQA6l+UOnPAmH4CP3 w==; X-CSE-ConnectionGUID: GIo4Y/suTi2EcixVElBLzg== X-CSE-MsgGUID: Bxh0VJKHQgWSoIDG4Dje9w== X-IronPort-AV: E=McAfee;i="6800,10657,11739"; a="75317489" X-IronPort-AV: E=Sophos;i="6.23,139,1770624000"; d="scan'208";a="75317489" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2026 18:48:26 -0700 X-CSE-ConnectionGUID: ApYrjYYOT5qmUCMuAuIEbw== X-CSE-MsgGUID: wEz8rIRNTbyEn9WGd92w0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,139,1770624000"; d="scan'208";a="221190777" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2026 18:48:26 -0700 From: "David E. Box" To: irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, xi.pardee@linux.intel.com, david.e.box@linux.intel.com Cc: hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH V2 02/17] platform/x86/intel/pmt/crashlog: Split init into pre-decode Date: Tue, 24 Mar 2026 18:48:04 -0700 Message-ID: <20260325014819.1283566-3-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260325014819.1283566-1-david.e.box@linux.intel.com> References: <20260325014819.1283566-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor crashlog initialization to use the PMT namespace pre-decode hook: - Add pmt_crashlog_pre_decode() to parse type/version, select the crashlog_info, initialize the control mutex, and set entry->attr_grp. - Simplify pmt_crashlog_header_decode() to only read header fields from the discovery table. - Wire the namespace with .pmt_pre_decode =3D pmt_crashlog_pre_decode. This separates structural initialization from header parsing, aligning crashlog with the PMT class pre/post decode flow. Signed-off-by: David E. Box --- V2 - No changes drivers/platform/x86/intel/pmt/crashlog.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/intel/pmt/crashlog.c b/drivers/platform/x= 86/intel/pmt/crashlog.c index b0393c9c5b4b..f936daf99e4d 100644 --- a/drivers/platform/x86/intel/pmt/crashlog.c +++ b/drivers/platform/x86/intel/pmt/crashlog.c @@ -496,11 +496,9 @@ static const struct crashlog_info *select_crashlog_inf= o(u32 type, u32 version) return &crashlog_type1_ver2; } =20 -static int pmt_crashlog_header_decode(struct intel_pmt_entry *entry, - struct device *dev) +static int pmt_crashlog_pre_decode(struct intel_vsec_device *ivdev, + struct intel_pmt_entry *entry) { - void __iomem *disc_table =3D entry->disc_table; - struct intel_pmt_header *header =3D &entry->header; struct crashlog_entry *crashlog; u32 version; u32 type; @@ -513,6 +511,16 @@ static int pmt_crashlog_header_decode(struct intel_pmt= _entry *entry, mutex_init(&crashlog->control_mutex); =20 crashlog->info =3D select_crashlog_info(type, version); + entry->attr_grp =3D crashlog->info->attr_grp; + + return 0; +} + +static int pmt_crashlog_header_decode(struct intel_pmt_entry *entry, + struct device *dev) +{ + void __iomem *disc_table =3D entry->disc_table; + struct intel_pmt_header *header =3D &entry->header; =20 header->access_type =3D GET_ACCESS(readl(disc_table)); header->guid =3D readl(disc_table + GUID_OFFSET); @@ -521,8 +529,6 @@ static int pmt_crashlog_header_decode(struct intel_pmt_= entry *entry, /* Size is measured in DWORDS, but accessor returns bytes */ header->size =3D GET_SIZE(readl(disc_table + SIZE_OFFSET)); =20 - entry->attr_grp =3D crashlog->info->attr_grp; - return 0; } =20 @@ -530,6 +536,7 @@ static DEFINE_XARRAY_ALLOC(crashlog_array); static struct intel_pmt_namespace pmt_crashlog_ns =3D { .name =3D "crashlog", .xa =3D &crashlog_array, + .pmt_pre_decode =3D pmt_crashlog_pre_decode, .pmt_header_decode =3D pmt_crashlog_header_decode, }; =20 --=20 2.43.0