From nobody Fri Apr 3 02:58:13 2026 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 225C914EC73 for ; Wed, 25 Mar 2026 00:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774399620; cv=none; b=WxNx0imh/dfg2Xef8v582vam7268scIfUuKTi54ce9oIQASdL6dYVyEItqP/BisqGP/lZ1+9CfJzPuzCfnVmCT4roZjEH/C3sXeyRLgGz2pPsbtUopc4PAHzJmGIqkpaL2h0lVxZHfQCYTDYftNDLKitdMLYxl+MvlZ0jKwHxwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774399620; c=relaxed/simple; bh=omhfMEbdyklLrfC8/9tp2lrDLYJX/EWVA++T6ISpEvQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eQUeVXdxYhIoU6RoAhqdLN3o1QthAXg/kAwVbC3jkJjzHiEUt2FkQkMFpKdSaSyOXke4BfX4N+j5XAgj2cKhIn9BHSBNpoT4unuceOMKGiqH34YDbLFTUs/4bvhXQh1Yzf+y7hqC7GbFlEZ+QjJZarBl1tfYYjlM6EEQwAmaBYc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TEIVJFvX; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TEIVJFvX" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-79ac5de41d8so13352267b3.3 for ; Tue, 24 Mar 2026 17:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774399618; x=1775004418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=br4xfo6DPIK3E3Vzz9aRMoe4hQrbDoT6TlpRHwA4dDc=; b=TEIVJFvX5lgwoQACIT3iyfes9kY5SN9R0TWPQkETwHP6X1/AxVEpek188NpZTIWYil jaoP6ybaWliWDOW7xv3Y8PqTdJyZXWb7adPBIyCrCNOkpG0HNbzkxVqyzsk9qtT6LagW P3g26joTYMNz39LmIW70Vs4sZM2h7Bmj+dSmArpNSzUf8M06MmDuJYXvj1hT55+6ChKh 2YaQFlWr6/+Pa8tfTt8jFPEa/o3FuF5jcMfjdTlonLlVhkooNWe3QA8D+qmG7C98BjgF ggoeQGGe5T9lhVFRMsxha/RrE2OdvolZum8oeljNrMig0hdZxX70ATN55UND8oBQL3lA Q4fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774399618; x=1775004418; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=br4xfo6DPIK3E3Vzz9aRMoe4hQrbDoT6TlpRHwA4dDc=; b=NaMJt5nVCGQS0oQQ5Sl4DIDuaXH1r0Wry8ko72lQe+W3pmnSoOzV8jf4VFuYLUDWds S6SpgDK5l/pxdpHQyZKctjbytdWzHYKigvlPsUjlvnjSyzk347ZPrgX7PhxOxpL3HVyC hINydblCOJs0tq4a6oDnBVL+xxH5oGawqa1EUIFvGjznxENqKWBWu9EZxJ3JuCwOAWQP U7TGmROp05wR+C6Wfdx2dODw+alNpgPCUmOzcQe1LePKjPqT/EOcV6UGO9VhGPTnnmF8 RITyHLMBYoBz+9U3CjoXf3TT9OWJJ/UY3ciVIEVGpDzVsTpIcj32G/w515cdu3XlAlhb cqdw== X-Forwarded-Encrypted: i=1; AJvYcCWaaemeMkHjvXBft0IKV29q4WSvwyJwe/UJz9aGS5K/10YCVax2Dd+iJRdMWblolGJ/TnsyQC6vBIfcKNk=@vger.kernel.org X-Gm-Message-State: AOJu0YyXUUmxdDULiZFuZJtjGHkbmmvzBhp7zR9zZX9APz1ekocAYxcE u1iBexEgGSWdLObW/eE4dWlN7NdE16WzUP65ckvJbTbGafgfnWuVFYUh X-Gm-Gg: ATEYQzxScDlYyf8HzAzRx/BGucL0OrWAxSMXsahPCxu0Sv+DpfpyTiZsqE/wepb60j+ IID4pFT+K3wlkb/BWfv8LgOx1UjEPiLOmYkcBrQk9LD4fj2PmKqATA7ep5Nj+nPr0oaYtvQBxxR mHcxfWqL5Hbjp2D0mPXCCiGKFjgbSwrIwaJuMl3WOPU7Z364YL2TQOVvv561CflBnLuzXggNx7M UOOlJHG6M+SaBPLqSReYev2RSoJug0OGfjjnZl+U04YhRjV4Y1AV24ZubrTAFDdDn1PW1fjWvPH vr5mSNAOndq7zxrS3Gk7+LYnC7g+7fAuejt6KlpRHbDNkAigypZZl+4tNhipP4d72gGHpyZ8T/p 1txQLxMFsUygasOm13193bCzGTfGWerXdY1Q9NQl+1Z9cxwx9tQEzWrollhCu3SxX/PiRC+QXq1 x+nTc8CRwJwzvgtEg6HiW8cfTe+RHgi8gT0WYJXHsw/9pjjbavcgTY95v7oDUYTNqv4bIKkAqMi 6Az34tyJjsYJltcXYcxNLYO X-Received: by 2002:a05:690c:c50d:b0:79a:d32f:e4e5 with SMTP id 00721157ae682-79ad32fede6mr3965657b3.45.1774399618019; Tue, 24 Mar 2026 17:46:58 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a903a33acsm81997887b3.3.2026.03.24.17.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 17:46:57 -0700 (PDT) From: Ethan Tidmore To: Mina Almasry , Muchun Song , Oscar Salvador , Andrew Morton Cc: David Hildenbrand , Mike Kravetz , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] hugetlb: Fix possible deadlock Date: Tue, 24 Mar 2026 19:46:53 -0500 Message-ID: <20260325004653.150734-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In allocate_file_region_entries() error path the function region_chg() returns but does not release the lock 'resv->lock'. Release lock 'resv->lock' before returning. Fixes: 0db9d74ed8845 ("hugetlb: disable region_add file_region coalescing") Signed-off-by: Ethan Tidmore --- mm/hugetlb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index d6ea11113f1d..230fd8c63588 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -807,8 +807,10 @@ static long region_chg(struct resv_map *resv, long f, = long t, if (*out_regions_needed =3D=3D 0) *out_regions_needed =3D 1; =20 - if (allocate_file_region_entries(resv, *out_regions_needed)) + if (allocate_file_region_entries(resv, *out_regions_needed)) { + spin_unlock(&resv->lock); return -ENOMEM; + } =20 resv->adds_in_progress +=3D *out_regions_needed; =20 --=20 2.53.0