From nobody Fri Apr 3 02:59:56 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 812A61F4168; Wed, 25 Mar 2026 00:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774399372; cv=none; b=lIaiinSvMEKJ/z8WEx9nm82s4bkSCAVOddW7LNlEgx9t0zrk3z9h8tpMU75ZWFqVG6PkA/MS2D0qQencuNfg314GldvDqNFB6J2UInDpah9LBjD3GHVO8AF2StZQ/qUJxHR3tUlepQxvviVhZYfLekaNrrDjkn6u0l5kDxI/LCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774399372; c=relaxed/simple; bh=AwmGTltHBrrLDTJ/WUcjrqUzJNVcvRLJX0XqBxE3AmE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qgda4OyLsTe1uuSR/SW4YlH69gcrR+WHG8qVbZqdhpDOfIhR+sW8/HsxC1EMduwU1hWR9wP/hplQntMcLXmCXDOM/9mY03L3TUhqT4KHaDeLr81jPbe0q14Td5ByG44RskJRgRbqVEXeF0ZAbLCMV4nVSyIY4EY3V14GYtK7+bg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.197]) by APP-03 (Coremail) with SMTP id rQCowADX8tmFL8Np4QO5Cw--.36127S2; Wed, 25 Mar 2026 08:42:45 +0800 (CST) From: Pengpeng Hou To: Marcel Holtmann , Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn Subject: [PATCH v2] Bluetooth: btusb: clamp SCO altsetting table indices Date: Wed, 25 Mar 2026 08:42:45 +0800 Message-ID: <20260325004245.42452-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260324020427.60125-1-pengpeng@iscas.ac.cn> References: <20260324020427.60125-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowADX8tmFL8Np4QO5Cw--.36127S2 X-Coremail-Antispam: 1UD129KBjvJXoW7AryDGrW3tw1UCr1xArWrZrb_yoW8XF1rpF W0ga4Yyr4rJFs0ya1UZF48uayFga1rXrW7Gr1rC3s8uwn8t34xAF48KrWjyr97Cr4Fgw4j 9F4YkrWrGa1DCFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkG14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUSNtxUUU UU= X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Content-Type: text/plain; charset="utf-8" btusb_work() maps the number of active SCO links to USB alternate settings through a three-entry lookup table when CVSD traffic uses transparent voice settings. The lookup currently indexes alts[] with data->sco_num - 1 without first constraining sco_num to the number of available table entries. While the table only defines alternate settings for up to three SCO links, data->sco_num comes from hci_conn_num() and is used directly. Cap the lookup to the last table entry before indexing it so the driver keeps selecting the highest supported alternate setting without reading past alts[]. Signed-off-by: Pengpeng Hou --- v2: - rewrite the clamped SCO table index as an explicit 0-based clamp to avoid wraparound concerns raised in review drivers/bluetooth/btusb.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index a1c5eb993e47..5c535f3ab722 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -2376,8 +2376,11 @@ static void btusb_work(struct work_struct *work) if (data->air_mode =3D=3D HCI_NOTIFY_ENABLE_SCO_CVSD) { if (hdev->voice_setting & 0x0020) { static const int alts[3] =3D { 2, 4, 5 }; + unsigned int sco_idx; =20 - new_alts =3D alts[data->sco_num - 1]; + sco_idx =3D min_t(unsigned int, data->sco_num - 1, + ARRAY_SIZE(alts) - 1); + new_alts =3D alts[sco_idx]; } else { new_alts =3D data->sco_num; } --=20 2.50.1 (Apple Git-155)