From nobody Fri Apr 3 03:00:12 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCFFE18DB2A for ; Wed, 25 Mar 2026 00:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774397737; cv=none; b=Jf30QPvOWmSJWMqntt7UYGq0sYw2gzVcVBkCrTigdJzR52VxKcbsspPFiS3mKGAmbarH8nTh0lo2n4axcEy2I6PPwoHXFnJFEYahsOPhmcx/nkQDSRb31DZKUVuDNzc2Kktq467oBVZTTvMf+wJpZUfVPsRjdGQF/XVZrIefgFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774397737; c=relaxed/simple; bh=jqh/TnAjq6SCyDhLkI/bK2/6GP4CVAOPQPS3Q/mVx2Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aqpAcx33v5xNHwPq+rTNQSthWzIWCla//UkFajpLiPz9nCljLD2MbdQtTmB3aFWHT9N/b8AwARcFpikyaGBEzgWuWqtYGB/4k9cHCZGkxP0OKZmC5yQohgcYIPHS4me9/X+RZN6+n7Z7R2xnjjwv2Lya+PrmihHbiHBtcNjomiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pdV2wT47; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pdV2wT47" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43a03cb1df9so2052657f8f.1 for ; Tue, 24 Mar 2026 17:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774397734; x=1775002534; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=evIkBxIoJp3ii6ssPtPsrLZkaTHMapWbMqzLO9r5ThI=; b=pdV2wT47NGzjuoOEsurDT89UOn+EQZQtKk/b3b+MZxTCoEI3i2452bvmNRcRzTJwOO Mz+zghPEIQTKErsIoTBpX+EWr4f3zCxyUK+BKHs+6bvGG0lYaXX0rIKLR6iA1kjNOSed R+kDU6+8RITVYjYxjxahk+mOu1LFJ9EBgCvNClAEhseXdZVgrDERWRn7O45S+UXV9HUX EiyP+YNildpVWbQwsX4WnENVLNRRUpBqAmRgUFqHkU+Lrmtp2Oo91xtFUbbMyYQN+s3m YJsgODIylPpPtGPVOsxw9SpPoNp9Tbpod4BVCQc/hlnmdilnuImaWF/WUV9tJwIn+AdU BDHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774397734; x=1775002534; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=evIkBxIoJp3ii6ssPtPsrLZkaTHMapWbMqzLO9r5ThI=; b=ZkeuckID1pmcyDqLv4BqznV4A6dIVKKVUSaAAKKwLzG+g7DGlT7pq9BBi69gBwzvLL 1ouln1BeWkVWebihgNasa8ZqUto2S8IM1ttZPJfYWnEkaUIyJyTBZbLZDZS09PDs7OGW g1sh4ivbda83W8jiVAkaLsWG7X8Al6DnUjPbdv6ii7wEVLWaPRJZxZ8DYjVFTIyxUMf2 kbJFNPAwPVDSY+1nCB4jdNNDxlqWx/x1IREG6ev7NyMHNj8jkWHh4HFk771YgLC58FWg E0kSqMS7katyTINeYbeLV7IVK2/b0aGo7q1VMhOjKohiDqDV/QxFFKytOLCJ9uE/uzQd sBTA== X-Forwarded-Encrypted: i=1; AJvYcCWqR2WK2AY+63+7NKFqKK27EAU2aOUu1xCin8+TpxXoJ05hnRtrtbCkL4TARyUuuLO+Dz9mED5EB4M4bZc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/dv/wwEyE1Hc+KiGCYexe+tHP9mxcxhIMGVzJzbkr1Bu8963V J6KBCHqe5ZiFaS90LeArgsePysTTPb8mZTtF0zw1Z6wl6L/CozY03c+Y X-Gm-Gg: ATEYQzxc833aq7Y9JY52R7egsR7GI42TKzdOToy4zKNtdC37po7CpA/+owAyfscyqPN HOQaAJCa7AppcQMTQg4hPTmIrbx/gshD67NzeYWwYZFBpiiBWyGH8tTZQ+x3PlkEeX41VdWtqRK PZCZ1FkWT8fOAut4+eKZwRNHNYVP/1qxmKYz9qTU51nvLwy6OFWsdnc9wuze6u76kM2wnj+PPVc h17PSz3GH7KYhp2eH5FSrEtbM+t/09wEvr3m1KFLOIh3ld6UjdwGpaRbVUcz2zHQ1UExcTtU2Pc 1QmfBCjuVuvj/s7/G6wUl6++SZZBAaE8a+VpVpj707wNGy8h4LnWQY++KH3lfDKAbpu2ohu5hAG anytDXaSkz3p7kO2c2WS+PGAFi+Ch0mq4FkNMZ81+F5vSYOKShIvMTfJYuehl8a41/t/JLiTaGd 7gxs8tmL9Mh/t6/FAioU0D6v9BMHPQ X-Received: by 2002:a05:600c:3b12:b0:485:3f1c:d887 with SMTP id 5b1f17b1804b1-4871606dc4fmr23619905e9.26.1774397734040; Tue, 24 Mar 2026 17:15:34 -0700 (PDT) Received: from nixos-office ([2001:8a0:e95c:5e00:30a:e2b6:4f44:efa4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6cdfdfa9sm32893962f8f.9.2026.03.24.17.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 17:15:33 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: cezary.rojewski@intel.com, peter.ujfalusi@linux.intel.com, ranjani.sridharan@linux.intel.com, broonie@kernel.org Cc: linux-sound@vger.kernel.org, liam.r.girdwood@linux.intel.com, yung-chuan.liao@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, david.lin@intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH v2] ASoC: Intel: boards: fix unmet dependency on PINCTRL Date: Wed, 25 Mar 2026 00:15:21 +0000 Message-ID: <20260325001522.1727678-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit c073f0757663 ("ASoC: Intel: sof_sdw: select PINCTRL_CS4= 2L43 and SPI_CS42L43") Currently, SND_SOC_INTEL_SOUNDWIRE_SOF_MACH selects PINCTRL_CS42L43 without also selecting or depending on PINCTRL, despite PINCTRL_CS42L43 depending on PINCTRL. See the following Kbuild warning: WARNING: unmet direct dependencies detected for PINCTRL_CS42L43 Depends on [n]: PINCTRL [=3Dn] && MFD_CS42L43 [=3Dm] Selected by [m]: - SND_SOC_INTEL_SOUNDWIRE_SOF_MACH [=3Dm] && SOUND [=3Dy] && SND [=3Dm] &= & SND_SOC [=3Dm] && SND_SOC_INTEL_MACH [=3Dy] && (SND_SOC_SOF_INTEL_COMMON = [=3Dm] || !SND_SOC_SOF_INTEL_COMMON [=3Dm]) && SND_SOC_SOF_INTEL_SOUNDWIRE = [=3Dm] && I2C [=3Dy] && SPI_MASTER [=3Dy] && ACPI [=3Dy] && (MFD_INTEL_LPSS= [=3Dn] || COMPILE_TEST [=3Dy]) && (SND_SOC_INTEL_USER_FRIENDLY_LONG_NAMES = [=3Dn] || COMPILE_TEST [=3Dy]) && SOUNDWIRE [=3Dm] In response to v1 of this patch [1], Arnd pointed out that there is no compile-time dependency sof_sdw and the PINCTRL_CS42L43 driver. After testing, I can confirm that the kernel compiled with SND_SOC_INTEL_SOUNDWIRE_SOF_MACH enabled and PINCTRL_CS42L43 disabled. This unmet dependency was detected by kconfirm, a static analysis tool for Kconfig. Link: https://lore.kernel.org/all/b8aecc71-1fed-4f52-9f6c-263fbe56d493@app.= fastmail.com/ [1] Fixes: c073f0757663 ("ASoC: Intel: sof_sdw: select PINCTRL_CS42L43 and SPI_= CS42L43") Signed-off-by: Julian Braha Acked-by: Arnd Bergmann --- v2: revert commit instead of adding 'select' --- sound/soc/intel/boards/Kconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig index c5942b5655d3..d53af8f7e55b 100644 --- a/sound/soc/intel/boards/Kconfig +++ b/sound/soc/intel/boards/Kconfig @@ -530,8 +530,6 @@ config SND_SOC_INTEL_SOUNDWIRE_SOF_MACH select SND_SOC_CS42L43_SDW select MFD_CS42L43 select MFD_CS42L43_SDW - select PINCTRL_CS42L43 - select SPI_CS42L43 select SND_SOC_CS35L56_SPI select SND_SOC_CS35L56_SDW select SND_SOC_DMIC --=20 2.51.2