From nobody Thu Apr 2 17:23:06 2026 Received: from CWXP265CU010.outbound.protection.outlook.com (mail-ukwestazon11022105.outbound.protection.outlook.com [52.101.101.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49913C8E6 for ; Wed, 25 Mar 2026 00:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.101.105 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774397532; cv=fail; b=nlk1+T3yP6EMC4tjN7Zjgw1YZRiT4KOm1OxD2rko7aKPzvdp1uAMYAm3U4Pa4IIbEU0As8BRn9DLPAQa+ymcGEIsHaW1UGThUK2p2rcwDtlw75KI3ta1mUyulummKK6k0IPAN3WLoKENFCpQbg9LHmrMOVwP3xfUQ31EhP5EIYU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774397532; c=relaxed/simple; bh=lrhmKoMuiDCXcbgL0bt9RV2PfxYJ7+Q1IUZjO5KBePc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ejptRGV4FaSoGa46OII84v27clVoChzcKKPJKe4OGI8XxgkdLOt1piwyXg/GK2yyQQ97/EmVWlgbuP+VH9mDV6vM4Bv7CBBKeDyabJiZ2Bzv7XbS8iDwAXmsddfdDJdAvettGZ7Oq+PIt9+uy06Aqz2M6edLKrlozfoTTEkTf7w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomlin.com; spf=pass smtp.mailfrom=atomlin.com; arc=fail smtp.client-ip=52.101.101.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=atomlin.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MrStyklmGxUHnVYM88ApmhnEr5ONnewjV2Ir4Afwa7IESUwraVd37+8gsNTETRRABDufm1oWiCWw0W9WwMYUEwX1eXl7Ag7xpzP8cRC3ySnQJ1FdY0pNBiRyLhhsHFcxrmiUO0rFVLDzvdT1tJuLuKyeUGb5Unupu/5MthnAL/WGw4KfM6/FDlaznY+QXjUkLdXEUQB8Yvc5ivycx06sGqiJPUtVSK6hztAlE2RtkLENA+RtdBnbGrQU3DXzQQjNCN4juMvmRHVJbq2yvtaPVLi/QLnEeHifmDbgVgDFM2VwKEVCuC5NlEniwmLl9H9wNSibBjxUgXMMcBOl4KohGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PrDL+NjszTcabWNB9WJU5Ia2dv+TLfiXIblrN5rA7TU=; b=ML8b6S2ghdveLHsOPFnGRRLTaLL/ZzjTgPGLMus5vCxgDhRAHNFacEmUyurlWFeme1fthk5grEyXETxr8hto/o1kyeEleJElihbV543N+bEQd9n0xL+CO7xxOtDz7Lld69H27kE021LG/pQKFFNSh+klgEakAW2gh7EJFumYiMEYFpV91BdyvSBqCW8NnKwlyVPsqhQvXPeZ0kxGRmFIhodVUSqSTS7mYx+BtxMmKV4ELYnxAGzaHzUAi1wzMMY9kyrq+ikFlX5STGHBdXzfJzo4K7bm6yzlWVmR/YaLrdYsTInvYFLGj4YrFQe6JnERCZAVxatKmNJ05N4FPg5MHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=atomlin.com; dmarc=pass action=none header.from=atomlin.com; dkim=pass header.d=atomlin.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=atomlin.com; Received: from CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:70::10) by LO2P123MB4078.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:160::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Wed, 25 Mar 2026 00:12:09 +0000 Received: from CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM ([fe80::de8e:2e4f:6c6:f3bf]) by CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM ([fe80::de8e:2e4f:6c6:f3bf%2]) with mapi id 15.20.9745.019; Wed, 25 Mar 2026 00:12:09 +0000 From: Aaron Tomlin To: tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Cc: dave.martin@arm.com, sean@ashe.io, neelx@suse.com, mproche@gmail.com, chjohnst@gmail.com, linux-kernel@vger.kernel.org Subject: [PATCH v6 1/2] fs/resctrl: Report invalid domain ID when parsing io_alloc_cbm Date: Tue, 24 Mar 2026 20:11:58 -0400 Message-ID: <20260325001159.447075-2-atomlin@atomlin.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260325001159.447075-1-atomlin@atomlin.com> References: <20260325001159.447075-1-atomlin@atomlin.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BLAPR03CA0157.namprd03.prod.outlook.com (2603:10b6:208:32f::27) To CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:70::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB3523:EE_|LO2P123MB4078:EE_ X-MS-Office365-Filtering-Correlation-Id: ff11e5a7-8fc5-43d6-3677-08de8a0327c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: JhBZTAhzGzzwck/TvQ01bAiPGVm6BQmcZj3SjOFBbOaUn8B3XqCoqDVV8XDX9OX5ROHJ7zNJGxMHL1ZK3eQE1ZijEijjBPlWeJFM9yHrzY2DLFnpS8OY0c5tRLoTrenb43yLf2dMqKe1VGETEkdRHcRgryIw09C/OkPkqziNGzbuI6bNZfuT4MGufkfyypIMIxD2cNMn5vH4UNOvKmlBihgVqqdY386Bg6HSfZso7QLqQN1BgOxe+TXKOybHierTftSytt+HosBwexQuah3M3jVA1tylXj+4iFpmbSceV7LMSqsJdvkGCZI3rdUlX1HFT9kfWRQMzD1YCqi6GKAptj6zOyN5zYZo4jkrSRJ2FpLVweTxsyuZnX9JurAgOz4e3fGXkXcWPr30lvF6bWIZU/cNC5bpMkVY42rhj28U9LENO9fvoKFcgsCvgcMFcxMuPqDS0cUtYwnJgkkNHJZ6cLKMcEbbBgYnQJoaggEuFDjbC37FHQWdVeIt0BOir7Q6/e9fp97SVFr1gmsrsV91A0mdf5QyYVb0a/sNSt+wILakyRB9o3uOvtKvFbfMIz+K1Qnz0gDc1NWdWcdrel0trW1qeUKS4kWUr6NjS6yCSn+i9zjTRYHlh285Dv6AOTyAOKWPFRJntUhUZzbt1X5CwbqQ7LPRN7PhyIJkw01vVwB4q8aaozq51ACDP5KhVnGk2Yf6/qX7mS7HJa2OlquLrTZpgsd3TuwdkoXLhUmzI8M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JHI2ag+dmC45IeSE+RDp9IuoNCoN4nVEslD3s8UpiKnSHsuW3yys3ALLf5sk?= =?us-ascii?Q?EBNRpr8s6p2kELMJPgX3ykwf7ULdW+iYwp/EQrCx+78wX1+/GR6sPjpSD8jn?= =?us-ascii?Q?g4duypHhkjxa74F1zoA69L8H/2IQs60b9/iGITfzfFBI0DosJ8CUvSgX+MlP?= =?us-ascii?Q?LnmLeLiS7bWPUU3T+6Gb0b3mtO9wQULbk4NNC+QRWmaQ7TX/xfmENh8hKNSB?= =?us-ascii?Q?uPJwXx36Ay7LhhpppWLql0RYNqSoKmx0/OjBVLlXvZSsg4Fs47vN10S/XiU4?= =?us-ascii?Q?TPCzvzZ7GzurWV/YSPt58FArjzdGYEhgiL0viVUj58sh+kKwTfd3n3lk1L0x?= =?us-ascii?Q?ZMSuKXBxMrPZ9UmxtodL5/lwav1OhK2Czx+8PuSpnf3uXqJ7rhetSWamCIob?= =?us-ascii?Q?DaAl3UjhBcCe0GNHD3cg63GWYE07x3btn3bEEcFqhW2RHYid+Hz5D7Pwm38e?= =?us-ascii?Q?4DuQlVxXVvPKCW8ts0QpZMdIkVK5/z8Wqqn5pZl3jWxsB5FYcYSE+7WEZNRB?= =?us-ascii?Q?YHhbxJP1CXq8SGCxtrtOcA+eAZjKwcPQIhVxQPWnMT6XjIe8XPg9NUKQNT+s?= =?us-ascii?Q?+wzjDiVdKS9tYCbUCuazd+Y3W0veGvBUsWBmIGn1KXGun5uIVu/N7DCbaWzh?= =?us-ascii?Q?mDAPvnSh4A5AMb3KVl+h1+1m1M1SqfpB45mFjMhMzOGCgmfkWYkO2ukCGxqT?= =?us-ascii?Q?nG8QKENAdovz1+mN/2qHdZJEH1nKOsBCXiCF3A3cN9jrZ3wWOZozOfyUy1//?= =?us-ascii?Q?wzD8H2VkqJMShUql0x1aRHcNTPCSM1bD5eXEG8U/POJ+2akyTgRgOGN2s1xj?= =?us-ascii?Q?UyWgmIbPgvbzDwDGufTkS8OOy1ebUUk2iSS1JkPKeReZ9Lg6JQomItbZ6pul?= =?us-ascii?Q?fLUt6e97r/egbbOHaM+IwkxhFI3gyKR70U6PUOCzh+aogObsKkcr3i4kJen+?= =?us-ascii?Q?wPabXWstODevgAIafFArje2lAbl0wHIVs/w4h+QHUXuiRLud8bVxa2XDb/wu?= =?us-ascii?Q?BGKNp0rSM9sWfiAcRb2vzzKopIGkZ05yFERyECX5kH9KYmHbuaZ29RAvV6Ok?= =?us-ascii?Q?TX5YLw+tlp9B74O8OPBawnA+GEqQhVBGoP9fc6+q9j/8CV5xiNSkUyOrZ3Ps?= =?us-ascii?Q?04uNSSp6o4Awh+JWS3A36ZRF7Am6c1PS3nwqnuQIhryK//U3HtcSHA/nipNL?= =?us-ascii?Q?ezXlAMl+bkh4yucYm6/p0XfhuwgI22ItCn/sxvc179dQMqQpzhfMJz56H+8p?= =?us-ascii?Q?mMPTnLZdUIkbPMl2ogF2BqmTnfcTU1aQth56I+GfJ+YcLPtUV6ps34hTl6Dv?= =?us-ascii?Q?vAb3mYAmcXHFalN/TxZT79fyZkEr+a/P1hnB3DwvFTlZV7UPxkuuf8DP+3ej?= =?us-ascii?Q?Z9DJn8MZt5InCPDS9DNlMXbr2U+/uSKh/VL8IK+XuWPh4SVpJpwsx/ME+d/i?= =?us-ascii?Q?tvSFHZUqsmanstYtgKny20pLR4XYnu43NAAvT10+s2aQvEFHuxMxRvqry6L0?= =?us-ascii?Q?MCHX2AGbTT83Lk1UFbn1gwSYyDs3EV+R7y4ipC4VYpzTfNAiYuMDhvMNjSPr?= =?us-ascii?Q?8a8ycHUWpVXH9ajE+X4PYR5gYPofSzINLIr8NVIlh7qYY1Q0dcGoxsmPSz6M?= =?us-ascii?Q?xjtcrsH9ZioiLJwpQpX2Nr9NQvDcrtyeKy/naCqVmDZIldNcsvM0Qsfevfc3?= =?us-ascii?Q?jfEdjnBHD5AW2zloebctp9rqLvdSNM1vZ/O4BktQKGs+vnghMYycCDQz9P+1?= =?us-ascii?Q?9unOGU597g=3D=3D?= X-OriginatorOrg: atomlin.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff11e5a7-8fc5-43d6-3677-08de8a0327c2 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2026 00:12:09.0609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e6a32402-7d7b-4830-9a2b-76945bbbcb57 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZRo22mV6sLhLvo5Dk3ageMRN/7NiWmLSpclgz601mmmiYRL4wKvkOKpR2cKdhTDpDmQRRzQNggEPKrqqJjoX0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P123MB4078 Content-Type: text/plain; charset="utf-8" The last_cmd_status file is intended to report details about the most recent resctrl filesystem operation, specifically to aid in diagnosing failures. However, when parsing io_alloc_cbm, if a user provides a domain ID that does not exist in the resource, the operation fails with -EINVAL without updating last_cmd_status. This results in inconsistent behaviour where the system call returns an error, but last_cmd_status misleadingly reports "ok", leaving the user unaware that the failure was caused by an invalid domain ID. Write an error message to last_cmd_status when the target domain ID cannot be found. Fixes: 28fa2cce7a83 ("fs/resctrl: Introduce interface to modify io_alloc ca= pacity bitmasks") Suggested-by: Reinette Chatre Signed-off-by: Aaron Tomlin Reviewed-by: Reinette Chatre --- fs/resctrl/ctrlmondata.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c index cc4237c57cbe..2ef53161ce11 100644 --- a/fs/resctrl/ctrlmondata.c +++ b/fs/resctrl/ctrlmondata.c @@ -992,6 +992,7 @@ static int resctrl_io_alloc_parse_line(char *line, str= uct rdt_resource *r, } } =20 + rdt_last_cmd_printf("Invalid domain %lu\n", dom_id); return -EINVAL; } =20 --=20 2.51.0