From nobody Thu Apr 2 23:53:14 2026 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B02CA329C7C for ; Wed, 25 Mar 2026 20:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774469135; cv=none; b=tWcbEG8wtaUNTO2T0BFTQby13dAW/zNFW0oB5l6GIZ0T0xIjEbSxIulEbjZlf7NV5OjHkHVHLKXL4I1Tx/vTwrF++J+hFQ493U+KCrHuJhmEAld/ZJhzhL11gXmzKvWIEDy2WzIwMc4L9jlh/JHa5ZbU7WzoP1HN4oY8Vem1lbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774469135; c=relaxed/simple; bh=JJ8nr2t7WkOuI49GeZpoE8Xclx7zj3BlOrTzAMDaCaE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=urq8hKRXwJ+/pulOlEh46qU7IWj+bK09wxL49P7nBqKrIcWzP6DMd0K+FRt4uxe4e/zhHjtpZukzaf1zjx/CYgly5ByBWfVF4YwoHYcq3nDRzqPzZTvVN4GXX+C3P+6h+fAUqm8cAkaX5RjJTqRGFyjDZ9Lanb9GT5+udoNAnGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PBM3mWl9; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PBM3mWl9" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-128e4d0cc48so296319c88.1 for ; Wed, 25 Mar 2026 13:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774469133; x=1775073933; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=ua32fXNS7IcDMCnQI4uw/Ijg3hcYV5XkjVPRm0WAddM=; b=PBM3mWl9nR2C6aY+/cf1zWH/mk41866AwC3ulBs7coxudXWwwq5U8YQwLk894iw3cv z7NsUQVAGwR0tuquwskzsH/+KgQfn+Ows/Grwm3/x4ifLn7drVlFx/TmdVYxhlgqoySc yigU5curWzAfeum8QAUNQVVtXPMyH7xOTr8Y96KGXqhExTuekeKeJg8ll+Bhg/ErheR3 ze5PFtobAfgMT1kODpEQsXihfOlZIfhNkoFbAHTvCknbiXTbkhKGxPyPLCLzSjCX3vfA CPoo2a2QK+/XIjQXRFz2OErAe6FRFqKTip9ExB6mnBVuiQnH15P/oNCQcSdgLA37LH9s bLAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774469133; x=1775073933; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ua32fXNS7IcDMCnQI4uw/Ijg3hcYV5XkjVPRm0WAddM=; b=hSsfBcJex0XXhaKOV++dTvm0Y5zBidi592/TcRFsEvliSlxspC6gsjeWcqBJzBuU6K YKgNdljcsUZ39o33IqDmbBWyMbc/sFxt9OeWP+3mE3d2i5viP+hqnbl5DAsDSvyVw7bn 7jVLQGPfjTWTJU49/z73wp2EErzfZekS6rSdcV49oCx3gYhocEqiTI0/x21fAhrn1F30 s0BiFtpPudIrSaBJtDO6awglA/fxWUtxMaINejvh4zk0oqQMd50mRKq5SuaNUUQibYlH XBCEZrmrOWCjvYRUnQ47m36GiKjB8wLl1XLnkcWFiyjGC+zB7PxaXyytxeOI4PlGgJ8j mi7A== X-Forwarded-Encrypted: i=1; AJvYcCVIDv36X/g/9ZiswEu0Sip81/5sqQQMqQsrrINFsmEoMZ6m2nzIO/1VzhRP95aBoQQrJojvQzPNCxDajdA=@vger.kernel.org X-Gm-Message-State: AOJu0YzMOTU361iQFP/C6PE0Gl252y7gA3gUPN3rl4REXsqb6dHaSMoU 1Moyyh2v9dq3cq0oa8GZHAK2NPgPfzIolpzNN7CNYnRqLnkNplDaL/OP X-Gm-Gg: ATEYQzy4v4zO9dtnWh4Ua4cxCrPALRDT5q6HqIBobbSDQawVUKe7XLT7qDLa4c7qgqB 1sbkPEazUlKSQ3SjvYCLYKKtnQKeKGhzvi72Mo0TUu5EpK+dwXzZG6o2xEnPMit0DbVzAlZfqBM w0T6feDZoOY1NysC26S5RIDgq8E1iogu3A4K/K86r5Vzz4pUqVrAg4BaaGxTBoBRrZXH4foEaPD MZ4s9TT3qwWQq1NQln5ALrWGEFJT8PW+rfjmb1DOFeRYCNfd5MJOTih9fTzUQXmYvL963Vk1Mml hMcFZzY53Hii0yFUoO4EjUKmNDPgyyKPdt9ULdOAdHqZRNjvLhuxE0li3WMcvNriBAbrfHnZEyn gdYKJjHgboU2DsKwLhvXukHSUvbEKSaEbsRvIHeg4YBjrBroztIobw1rxRyYofZIOYfjpj8OO78 /obXNVG02z4Z6cAd3LLs3HcihMTV1UfrdDBhizTdtifhGaJKJF6DVAGjvuT3DemEYdf3KD6d/LE 24= X-Received: by 2002:a05:7022:662a:b0:11b:9386:8254 with SMTP id a92af1059eb24-12a96f00133mr2321421c88.41.1774469132676; Wed, 25 Mar 2026 13:05:32 -0700 (PDT) Received: from [192.168.1.8] (177-4-160-195.user3p.v-tal.net.br. [177.4.160.195]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12aa7273848sm701559c88.7.2026.03.25.13.05.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 13:05:31 -0700 (PDT) From: =?utf-8?q?C=C3=A1ssio_Gabriel?= Date: Wed, 25 Mar 2026 17:05:11 -0300 Subject: [PATCH] ASoC: SOF: compress: return the configured codec from get_params Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260325-sof-compr-get-params-v1-1-0758815f13c7@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMQQqDMBBA0avIrB2ICUbwKuIiTUc7gibMqBTEu zdtl2/x/wVKwqTQVxcInayctoKmriC+wjYT8rMYrLHeONuipgljWrPgTDvmIGFV9N5E51pDTee gpFlo4vdvO4x/6/FYKO7fF9z3B/uO9MF4AAAA X-Change-ID: 20260325-sof-compr-get-params-660c3350e173 To: Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Pierre-Louis Bossart , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?C=C3=A1ssio_Gabriel?= X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2917; i=cassiogabrielcontato@gmail.com; h=from:subject:message-id; bh=JJ8nr2t7WkOuI49GeZpoE8Xclx7zj3BlOrTzAMDaCaE=; b=owGbwMvMwCV2IdZeKur/u2bG02pJDJlH7P83xicu0tsd5HFnlpJXafw5nc5s7avcG7v3PoqJE hQwurmto5SFQYyLQVZMkWV10iLLPV0PrtbHrfCAmcPKBDKEgYtTACbi9JXhr9xCuaR9krm8mZMf 3esQ+2D35HdmdVheVFx/9uXkhIsRbxkZLlyfo3nX+o76fSbOpZL8Ra/t/BjL3t0/UO63sOLBZz8 OdgA= X-Developer-Key: i=cassiogabrielcontato@gmail.com; a=openpgp; fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83 The SOF compressed offload path accepts codec parameters in sof_compr_set_params() and forwards them to firmware as extended data in the SOF IPC stream params message. However, sof_compr_get_params() still returns success without filling the snd_codec structure. Since the compress core allocates that structure zeroed and copies it back to userspace on success, SNDRV_COMPRESS_GET_PARAMS returns an all-zero codec description even after the stream has been configured successfully. The stale TODO in this callback conflates get_params() with capability discovery. Supported codec enumeration belongs in get_caps() and get_codec_caps(). get_params() should report the current codec settings. Cache the codec accepted by sof_compr_set_params() in the per-stream SOF compress state and return it from sof_compr_get_params(). Fixes: 6324cf901e14 ("ASoC: SOF: compr: Add compress ops implementation") Signed-off-by: C=C3=A1ssio Gabriel --- sound/soc/sof/compress.c | 8 +++++--- sound/soc/sof/sof-priv.h | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/sound/soc/sof/compress.c b/sound/soc/sof/compress.c index 3dbc05bf3b79..f4c3e10e6344 100644 --- a/sound/soc/sof/compress.c +++ b/sound/soc/sof/compress.c @@ -255,6 +255,7 @@ static int sof_compr_set_params(struct snd_soc_componen= t *component, sstream->sampling_rate =3D params->codec.sample_rate; sstream->channels =3D params->codec.ch_out; sstream->sample_container_bytes =3D pcm->params.sample_container_bytes; + sstream->codec_params =3D params->codec; =20 spcm->prepared[cstream->direction] =3D true; =20 @@ -267,9 +268,10 @@ static int sof_compr_set_params(struct snd_soc_compone= nt *component, static int sof_compr_get_params(struct snd_soc_component *component, struct snd_compr_stream *cstream, struct snd_codec *params) { - /* TODO: we don't query the supported codecs for now, if the - * application asks for an unsupported codec the set_params() will fail. - */ + struct sof_compr_stream *sstream =3D cstream->runtime->private_data; + + *params =3D sstream->codec_params; + return 0; } =20 diff --git a/sound/soc/sof/sof-priv.h b/sound/soc/sof/sof-priv.h index 693d063830fa..38753b088fc1 100644 --- a/sound/soc/sof/sof-priv.h +++ b/sound/soc/sof/sof-priv.h @@ -17,6 +17,7 @@ #include #include #include +#include #include #include =20 @@ -111,6 +112,7 @@ struct sof_compr_stream { u32 sampling_rate; u16 channels; u16 sample_container_bytes; + struct snd_codec codec_params; size_t posn_offset; }; =20 --- base-commit: 5c3743212c70461c076cb11c83c899695a1528f8 change-id: 20260325-sof-compr-get-params-660c3350e173 Best regards, -- =20 C=C3=A1ssio Gabriel