From nobody Thu Apr 2 23:55:38 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36A0B317165; Wed, 25 Mar 2026 18:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774462571; cv=none; b=kWEc/jDRjG70ohJytrrlfLqF1vNMGr9VFTac8Va02OVtKcvJvSsgBUvm3ouKiyg6TJR5ohCq5OtWbuvO8F4w24oVtQ8aoUnODMsraggn88Yg76+nZKVNE/0YHcF9fY35WArkYfF9hKklE7ry6Wv7kG+w9wNLOK13m+lc6sw0e60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774462571; c=relaxed/simple; bh=m7UsOZXePmE6LnIgg7LgNL52WkOjyPU2mtfY4oXXk6Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=dIAUEixx26eoCrQi8N8PHBolhhx7PMbP7f8oAorIGXtU+CG/e1/OPVujgGFnY4fromEtHHtyUgGlvTeG0c5n+0pCQraHtdrHmA+9/tX/1n8FsH3f1YcNIUCnmikiCphxNl30K/hDv3H8KBt4zxYycXwRWB0gt/o/nk0kwrMlHGg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rvuDILxU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rvuDILxU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D68C4C4CEF7; Wed, 25 Mar 2026 18:16:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774462570; bh=m7UsOZXePmE6LnIgg7LgNL52WkOjyPU2mtfY4oXXk6Q=; h=From:To:Cc:Subject:Date:From; b=rvuDILxU7ssQVP8f5HrIbQ0zB96QPDKdqJPLyg+FBKwdbpwS/Z1TBWx12vCddkzq+ ZCsdyKAOacAAYUcANodcwu9rrhN8gH8h9el3qjFjO3e5hJaD89W9M+mUO+a6W0djRz EZqTTkiqE+REXiCfIDmAhREYhsD26bPi/umiRQOJR03gSOKoomOMRkBbu3/RLI/tq6 3n5DsT1+IccXuSaupvAB7a6EL9M6/bcrRks6aHsyb0ZVf8lzlybuEjW3bSTcLcPEzp jB3fCrMetgcrXnKSbZO7BL5FsmB/UqLVZ1cgsJKwgMgL4aKNay+DeO/dbw/iHcF7im At6riJtOCnFyQ== From: Leon Romanovsky To: Yishai Hadas , Jason Gunthorpe , Leon Romanovsky Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Pirko , Jiri Pirko Subject: [PATCH rdma-next] RDMA/mlx4: Restrict external umem for CQ when copy_to_user() is used Date: Wed, 25 Mar 2026 20:16:03 +0200 Message-ID: <20260325-fix-mlx4-external-umem-v1-1-1c7c0e779329@nvidia.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Change-ID: 20260325-fix-mlx4-external-umem-9e8214de61f0 X-Mailer: b4 0.15-dev-18f8f Content-Transfer-Encoding: quoted-printable From: Leon Romanovsky When the mlx4 firmware reports the MLX4_DEV_CAP_FLAG2_SW_CQ_INIT capability, libmlx4 from the rdma-core package expects the driver to initialize memory at the address provided in the buf_addr parameter of ucmd. This behavior cannot be supported by any external umem implementation, so restrict it accordingly. Fixes: f45f195af521 ("RDMA/mlx4: Introduce a modern CQ creation interface") Reported-by: Jiri Pirko Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx4/cq.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/infiniband/hw/mlx4/cq.c b/drivers/infiniband/hw/mlx4/c= q.c index b391883aa4004..6fef3f1724eb9 100644 --- a/drivers/infiniband/hw/mlx4/cq.c +++ b/drivers/infiniband/hw/mlx4/cq.c @@ -173,6 +173,10 @@ int mlx4_ib_create_user_cq(struct ib_cq *ibcq, goto err_cq; } =20 + if (ibcq->umem && + (dev->dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_SW_CQ_INIT)) + return -EOPNOTSUPP; + buf_addr =3D (void *)(unsigned long)ucmd.buf_addr; =20 if (!ibcq->umem) --- base-commit: 05eec2a60c7909acfbe5b6c5fbb64790d5a3ff1c change-id: 20260325-fix-mlx4-external-umem-9e8214de61f0 Best regards, -- =20 Leon Romanovsky