From nobody Thu Apr 2 23:53:31 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ED5138F25F for ; Wed, 25 Mar 2026 23:52:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774482766; cv=none; b=fydNlbWI6s+PCM2yENiUd0vtAQs+avJ6y16Vg/3I0xLtoWQuirOQHDOVa44euoG90NR9wNGe0NuqnAO6t0q9ZB+yZivD6kvlusU5EagR1AScAANQO+kJxc/S5p0/zQCwsm8j7fxQ+mIXrkNvpw17jdAIhdhItgeUiKH2xYDnCUs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774482766; c=relaxed/simple; bh=3FuJuDRCk2GGugQIv8w/KFcBteXXe2wlhM60mPaXzNc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=isoFg98KpuIqWiEzGhN/1x6qwt/WfYsnXfe+BcALl8gPzDJmivcXIpHcpH3T6Yv+T0oAxNGLz3su8rTLAOogcpYE2GNmOlNR8rLfi6DsM2Rb4F3Jw2/TMQA8qq0t8y8Nr92P1SttKT0vSfs2L6yOxo+byRDiv67uZFW3YQBi54k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TFLnhs3z; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=M494XnCo; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TFLnhs3z"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="M494XnCo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774482763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=stCH47cuvvcQcqflbk9cboggTCLsKnNEJ6X8WIUPijo=; b=TFLnhs3z3R5RlwR3TOMWcwlTuC0gow6rtqjkPa200o4DoR0ol2oFFxykR4h3MO53EUEWny aVdkyXuUimYVQ6aeCb2hPxTqy+rrAn+Dhz5hprbgAPpZpgbatqv4IFM9vXzhtMw0n9mkcH ZaWanQuxNQaQ/WbtDuQIZpF8SawEJWo= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-711-wv_LYnzQOymxin6kkNvj2g-1; Wed, 25 Mar 2026 19:52:42 -0400 X-MC-Unique: wv_LYnzQOymxin6kkNvj2g-1 X-Mimecast-MFC-AGG-ID: wv_LYnzQOymxin6kkNvj2g_1774482761 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd849cd562so150345385a.0 for ; Wed, 25 Mar 2026 16:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774482761; x=1775087561; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=stCH47cuvvcQcqflbk9cboggTCLsKnNEJ6X8WIUPijo=; b=M494XnCofsi7EPQTpOx7lSumO/tRvRP/F/rcYQ5bOZ5uhNzHPHR7HLBuSqbSbeq8gY txvWmZPI1BWylzECTHyri5evPHTxlubChp4djFWsSV5GA6R3jcRl+HhvcF51+io9GoYR WlgbdZRl8FPqngDkUgNIosxExv5EI/1rYF0z9H0OEZcQ07fhAXGQLMPoNmGibBxnnlOd ZomNF/YpktWT5H+AQ5t9+Xl77tvDCf7Ry1AVjxyqD42Ye1ZcYkn7tKxzaRByC9xA96zv MNpP/fzodUD/NMmMO6F13HoeCNORvz6eSzzkRfJscTJIsgnN0Q6fqwTD4rlRYS3sD6wV 9r4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774482761; x=1775087561; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=stCH47cuvvcQcqflbk9cboggTCLsKnNEJ6X8WIUPijo=; b=KEhhBqCoY8DvYk6q5xK47fuRS2otXYtBYjwFZwwLgchlPcADuJmEhvkVkLiZZzoBrK OWWFwx10SEli68tOq8u1svlB9aC/WzD6wZ/uOHXKaqUBBE8wZrAeG/OtepWRLQRIezJb Np7xc6pLlHvUzQld9pfWQ0Fuynd2yLcPMMPjbMLNSWiaxR5g5b1ghKcSWokE3nzcMjaa cOtxiRgpX78Jtslz1zGBEPP5gVo8+7cVgxYiurYOofP0LmXzVpJyOP62t6PFCHkOPa7Q qg4h8b8sb22gedftHSaCulGnCIsxd7fKBIjDvs426rpAoeJuuY/bXZQMaxkHsTZkWPUj tjCQ== X-Forwarded-Encrypted: i=1; AJvYcCWw23CuU2/rq7xqFeiCBBnWkQ1uy7+2t4e7EBWKs7vqQVLdMh5E3iCv1wO5ox/LgXAFM8JQAVGXjMb0U4U=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk4rgAJkYhq4TVM/IdllTGrJLUVeKdvQMBk2keSK7Krv35wZeq RgIIaldxj1DmdnvT308US2CnOOQTMx86yK5OLDPaGfmGptdqcguWJx1Nxtd2ZafPErKE0gkiei9 jlFekTNJOC62saWwsJr7r3wIF3kvr8ljJXp6dpxEbw3iYGgimEUY9RBdwkXdXDjhReQ== X-Gm-Gg: ATEYQzwSmlJoCJnx0S8h9Ffluith1/qYUbxj/nRhGm9oUhmBLeybV3wi3lyAEM1HyUP G+K2MD/SPCB56sJ/j1ZjbqQAj6uE6rXK3kjNJkihhR2Fk61oc7B4+Jh9owMEQhv1bDW0/Sc0LKO 113LemgiiK61Vl0uZcJ4zWr2k911el2gz5WIIjON7aqrY4SGu3NFi3/P0nFiFZ21knMIklfKmou liURLoa6zVFBx4DP/7ypuB8kwjQo4uhkjc2VvXtqolaxhSdDZSFNpnYZvgxIB75jMVVYskE3H3C gS7lwmgAn8tvdGSVSJTlyzxscFArJvn5v09XnKiY1cguPOORvjN+wgaE0N8SzmRmGvmEjpPvtJw VdbsXRp3oeSoB4e/moK8WgCbwUvwW6g4DBuw4+9qRa+AHM9G3KSaiaaujuhiz X-Received: by 2002:a05:620a:448e:b0:8cf:dfc9:c0a0 with SMTP id af79cd13be357-8d000ee456dmr688573085a.7.1774482761533; Wed, 25 Mar 2026 16:52:41 -0700 (PDT) X-Received: by 2002:a05:620a:448e:b0:8cf:dfc9:c0a0 with SMTP id af79cd13be357-8d000ee456dmr688569285a.7.1774482761043; Wed, 25 Mar 2026 16:52:41 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8d00e501eedsm106346785a.40.2026.03.25.16.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 16:52:40 -0700 (PDT) From: Brian Masney Date: Wed, 25 Mar 2026 19:52:10 -0400 Subject: [PATCH v2 1/4] clk: move core flags into a new enum for kernel docs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260325-clk-docs-v2-1-bcf660e1ceb5@redhat.com> References: <20260325-clk-docs-v2-0-bcf660e1ceb5@redhat.com> In-Reply-To: <20260325-clk-docs-v2-0-bcf660e1ceb5@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Jonathan Corbet , Shuah Khan Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3764; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=3FuJuDRCk2GGugQIv8w/KFcBteXXe2wlhM60mPaXzNc=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDKPlNqL+pVtual40T+p3Ds2b4Xfjr6D8e57Gj86MyxX3 MJjV2bWUcrCIMbFICumyLIk16ggInWV7b07miwwc1iZQIYwcHEKwET+eDMy7PzWdED0folyRPfO g4oteslZRt8852etqUgwnuT/bN+BSYwMs8UvbWCa++HOwcreGN60dQu0nsvNnmr+T+BQmEbfpcB jjAA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 Let's move all of the existing clk flags into a new enum so that all of the flags can be easily referenced in the kernel documentation. Note that I went with name clk_core_flags for the enum since the name clk_flags is already in use in clk.c for the debugfs interface. Note: The comment about "Please update clk_flags..." is included as a separate comment so it doesn't show up in the generated documents. Signed-off-by: Brian Masney Acked-by: Randy Dunlap --- include/linux/clk-provider.h | 55 +++++++++++++++++++++++++++-------------= ---- 1 file changed, 34 insertions(+), 21 deletions(-) diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index 630705a47129453c241f1b1755f2c2f2a7ed8f77..cb167c17c4f79cf438a26bb113b= 4968d0f223468 100644 --- a/include/linux/clk-provider.h +++ b/include/linux/clk-provider.h @@ -9,29 +9,42 @@ #include #include =20 -/* - * flags used across common struct clk. these flags should only affect the - * top-level framework. custom flags for dealing with hardware specifics - * belong in struct clk_foo +/* Please update clk_flags[] in drivers/clk/clk.c when making changes here= ! */ +/** + * enum clk_core_flags - framework-level clock flags * - * Please update clk_flags[] in drivers/clk/clk.c when making changes here! + * These flags should only affect the top-level framework. Custom flags for + * dealing with hardware specifics belong in struct clk_foo. + * + * @CLK_SET_RATE_GATE: must be gated across rate change + * @CLK_SET_PARENT_GATE: must be gated across re-parent + * @CLK_SET_RATE_PARENT: propagate rate change up one level + * @CLK_IGNORE_UNUSED: do not gate even if unused + * @CLK_GET_RATE_NOCACHE: do not use the cached clk rate + * @CLK_SET_RATE_NO_REPARENT: don't re-parent on rate change + * @CLK_GET_ACCURACY_NOCACHE: do not use the cached clk accuracy + * @CLK_RECALC_NEW_RATES: recalc rates after notifications + * @CLK_SET_RATE_UNGATE: clock needs to run to set rate + * @CLK_IS_CRITICAL: do not gate, ever + * @CLK_OPS_PARENT_ENABLE: parents need enable during gate/ungate, set rat= e and re-parent + * @CLK_DUTY_CYCLE_PARENT: duty cycle call may be forwarded to the parent = clock */ -#define CLK_SET_RATE_GATE BIT(0) /* must be gated across rate change */ -#define CLK_SET_PARENT_GATE BIT(1) /* must be gated across re-parent */ -#define CLK_SET_RATE_PARENT BIT(2) /* propagate rate change up one level */ -#define CLK_IGNORE_UNUSED BIT(3) /* do not gate even if unused */ - /* unused */ - /* unused */ -#define CLK_GET_RATE_NOCACHE BIT(6) /* do not use the cached clk rate */ -#define CLK_SET_RATE_NO_REPARENT BIT(7) /* don't re-parent on rate change = */ -#define CLK_GET_ACCURACY_NOCACHE BIT(8) /* do not use the cached clk accur= acy */ -#define CLK_RECALC_NEW_RATES BIT(9) /* recalc rates after notifications */ -#define CLK_SET_RATE_UNGATE BIT(10) /* clock needs to run to set rate */ -#define CLK_IS_CRITICAL BIT(11) /* do not gate, ever */ -/* parents need enable during gate/ungate, set rate and re-parent */ -#define CLK_OPS_PARENT_ENABLE BIT(12) -/* duty cycle call may be forwarded to the parent clock */ -#define CLK_DUTY_CYCLE_PARENT BIT(13) +enum clk_core_flags { + CLK_SET_RATE_GATE =3D BIT(0), + CLK_SET_PARENT_GATE =3D BIT(1), + CLK_SET_RATE_PARENT =3D BIT(2), + CLK_IGNORE_UNUSED =3D BIT(3), + /* unused */ + /* unused */ + CLK_GET_RATE_NOCACHE =3D BIT(6), + CLK_SET_RATE_NO_REPARENT =3D BIT(7), + CLK_GET_ACCURACY_NOCACHE =3D BIT(8), + CLK_RECALC_NEW_RATES =3D BIT(9), + CLK_SET_RATE_UNGATE =3D BIT(10), + CLK_IS_CRITICAL =3D BIT(11), + CLK_OPS_PARENT_ENABLE =3D BIT(12), + CLK_DUTY_CYCLE_PARENT =3D BIT(13), +}; =20 struct clk; struct clk_hw; --=20 2.53.0 From nobody Thu Apr 2 23:53:31 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11BB639D6F0 for ; Wed, 25 Mar 2026 23:52:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774482768; cv=none; b=GuptKiauFIMJBRFMxhcztblo5T2UxsRtjkt0e5Nw0+bL8Mgx9kuqqmGRGxn4RRaMpUH3mIu3fjjgREh9JRHhBDXNxk9NcUIp9QMsLl7raoVALW66ZckE8IF4u1CgrSY4SA3BQtzMZQLKz2e3M0ihl6+29gfe/3hi1yshmJrWVtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774482768; c=relaxed/simple; bh=rXRD/VUBdjTgqVrg6At08VQ99MspomXd4n+3eE8Z15Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XGQG3SZgz8yzVK+M3CyxYjPPt7pymJGra0TAsJNAfIPmwSz7oLkDH/ec9fZZN6NkX0h3H7BetjYcNhSqwxPnOK9ImyhBmM/wfMHTMtkVudFLzePCwYtzNQr/aaJG6835ZCotXOU51RpKUTZ0UZgyMYxZznBX9LLJ0f4Y/N7oGuo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Pj89hZeb; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ehBYSo2v; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pj89hZeb"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ehBYSo2v" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774482765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8xBD/ObT79//9xMsrPokjqU4w5LxcEClKAdIR9Wy8OA=; b=Pj89hZeblZu/1E84URK7f0cvUBotwoiYoH3T2BoL+p8dfp2Pi7k9lHHniSJSMcVr8/TKg1 kVgCzW3W5qcDHmLouvZQThXJeP4u0cInEOYUBkITatar6j1j6yt2GYE/Ksu1sD/Dq2uuPQ 1xbWN4HKul67+uji4eACxkIwvRfsH70= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-FTq9ELBsMSqPablAb2wsoQ-1; Wed, 25 Mar 2026 19:52:43 -0400 X-MC-Unique: FTq9ELBsMSqPablAb2wsoQ-1 X-Mimecast-MFC-AGG-ID: FTq9ELBsMSqPablAb2wsoQ_1774482763 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cfcf23c0e1so136357485a.2 for ; Wed, 25 Mar 2026 16:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774482763; x=1775087563; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8xBD/ObT79//9xMsrPokjqU4w5LxcEClKAdIR9Wy8OA=; b=ehBYSo2vPtHz1z6kV/ry43eZ1EnvXPum5wvvRbr5trNcH8s2Ce25T8yJ0d7rWVMzUr mpmwchtcoEEfDXqHlFLNIQyq0VSsGLkzhfiCEFSbsGSv555c1lWAHNVzuFwcoDNQ3UzZ TjKlmsvtpgJxQH6XTG6iGyEhzi+C1N3AEhL5g4GXRCT9hY9ghCbHu2mykpq5xEQ0nzo/ xyeVf6Ye4sPB1NovzzWnbv4qRPk5zbsIoNwEwPDLm6w0xwZ16bGFsu2eb146VuwTIgfr k9rALp+M1E+fQflIsHHIJA6EASDQIOfgwdwkJWjNvHRKMmJ82NaNnEuugQYDVXmgb2FU Fr1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774482763; x=1775087563; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8xBD/ObT79//9xMsrPokjqU4w5LxcEClKAdIR9Wy8OA=; b=DK1synOtH1XXslMsA08VnJxmQmBvkFyfau4uryfDwb16KrgGt/xHerC1lQ9QeP8vJH iDtylaQE0q+dnsZpQ+1v1R+go5kel4pL6Ox4Bst7oltshqzfidxomalJJO+OOVS/ndNh nIY4BI6F1WzFn33QUE38IHB35fY9oH1kpCYCfIGQPQDKg3P3IBGRdYHMSBqCk15utiho ftGLYfZVdWcDfbLrp5hMEf2jzi0/WCVN+uzGS+jsIx3IO1dRyCDkGBmnH8/ghyEm+z+r z6Sxd60K0W03OJbLN5iQYqkspNqkwg8CMQS8Yxz/hKNCTDENIu6YBTImb8dGAaDGiKSu 1NgA== X-Forwarded-Encrypted: i=1; AJvYcCUXHFcyHQyPKAD3Zk6Ubg3Vx4GhiOfFxKQPP80lwfj1n0VZ0YRkgOVHlvnPtwdsJtoeguls/u4bAVkFZ9E=@vger.kernel.org X-Gm-Message-State: AOJu0YwP+vSg4+62GVTC/jenwsqB7LETenVSuaED5dnTZKSoRthb8FLF lkKqX+WfjmDWPqmhp7zW3fXw2vH/hg0CoRDrDGyAklT8bhKDaNFrnbDomEEGtKO4lcgmm2liC9L 9oVpv2uk8F742zkDIwHILYMKdZiTZJ1/v4hpUrdOTeTd94iBOhuKmZc8HVsF/1ko6ZA== X-Gm-Gg: ATEYQzzp96wIMfTfzTbvlZSJQcGndwr+vSjxSBHLoTIOZFGoxh06jioRetfqthlmn2+ BbKbWRswen4gZruGwUt6FqUA4/rMybwPgiiUfKmMh8qrhdTByet8Evpv33Ho2n1IbJrJ4V1UfCm FWkH9rtc0IWaHM2B1/VnWJMpEXTn3HDFuUEshqDfRnxpw32LOR0FEKk1U7ZhD7ZSljEVpTMH6BI rwkUHd5HEt+5vLI1b+P36/jj2LPYF5dF06IX2zXU//vrCjqlVfiKBRIOXusebbuILevp36ImCgH qo0V4cEqxno5FFEW4oP2gesp+N1VJrWjsQ+WKmN3NY8vqYab8arqyPIuTsFiCvghjD4qBpk81MT 9UTWX+eYFCnwn6mQ7EPTCtq4mDS8a9R4SaGykQwMSxgnZ7AEJA/O5lhtrCkWu X-Received: by 2002:a05:620a:4552:b0:8cf:b546:fdf1 with SMTP id af79cd13be357-8d000f53868mr807026485a.26.1774482763222; Wed, 25 Mar 2026 16:52:43 -0700 (PDT) X-Received: by 2002:a05:620a:4552:b0:8cf:b546:fdf1 with SMTP id af79cd13be357-8d000f53868mr807023385a.26.1774482762588; Wed, 25 Mar 2026 16:52:42 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8d00e501eedsm106346785a.40.2026.03.25.16.52.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 16:52:42 -0700 (PDT) From: Brian Masney Date: Wed, 25 Mar 2026 19:52:11 -0400 Subject: [PATCH v2 2/4] clk: add kernel docs for struct clk_core Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260325-clk-docs-v2-2-bcf660e1ceb5@redhat.com> References: <20260325-clk-docs-v2-0-bcf660e1ceb5@redhat.com> In-Reply-To: <20260325-clk-docs-v2-0-bcf660e1ceb5@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Jonathan Corbet , Shuah Khan Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3860; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=rXRD/VUBdjTgqVrg6At08VQ99MspomXd4n+3eE8Z15Y=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDKPlDpUat5csO2g3aVT2Ttibhyrs8zinlD34WtruL/o9 vJu8aAXHaUsDGJcDLJiiixLco0KIlJX2d67o8kCM4eVCWQIAxenAEzkoggjw+ywkqkXb2lE+v98 ZHX5219b5VfLpjHkzekXbWv+r3TpwGeG/wmX7ugdsRIUCu7yL3t0xbtFeL6PKltF67mz3yU+7o9 /wgwA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 Document all of the members of struct clk_core. Signed-off-by: Brian Masney Acked-by: Randy Dunlap --- drivers/clk/clk.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 47093cda9df32223c1120c3710261296027c4cd3..08b38ec044db7e50c7313b8f44c= c0f6fa2cd4755 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -63,6 +63,57 @@ struct clk_parent_map { int index; }; =20 +/** + * struct clk_core - The internal state of a clk in the clk tree. + * @name: Unique name of the clk for identification. + * @ops: Pointer to hardware-specific operations for this cl= k. + * @hw: Pointer for traversing from a struct clk to its + * corresponding hardware-specific structure. + * @owner: Kernel module owning this clk (for reference counti= ng). + * @dev: Device associated with this clk (optional) + * @rpm_node: Node for runtime power management list management. + * @of_node: Device tree node associated with this clk (if appli= cable) + * @parent: Pointer to the current parent in the clock tree. + * @parents: Array of possible parents (for muxes/selectable par= ents). + * @num_parents: Number of possible parents. + * @new_parent_index: Index of the new parent during parent change operat= ions. + * @rate: Current cached clock rate (Hz). + * @req_rate: The last rate requested by a call to clk_set_rate()= . It's + * initialized to clk_core->rate. It's also updated to + * clk_core->rate every time the clock is reparented, = and + * when we're doing the orphan -> !orphan transition. + * @new_rate: New rate to be set during a rate change operation. + * @new_parent: Pointer to new parent during parent change. This is= also + * used when a clk's rate is changed. + * @new_child: Pointer to new child during reparenting. This is al= so + * used when a clk's rate is changed. + * @flags: Clock property and capability flags in the + * enum clk_core_flags. + * @orphan: True if this clk is currently orphaned. + * @rpm_enabled: True if runtime power management is enabled for thi= s clk. + * @enable_count: Reference count of enables. + * @prepare_count: Reference count of prepares. + * @protect_count: Protection reference count against disable. + * @min_rate: Minimum supported clock rate (Hz). + * @max_rate: Maximum supported clock rate (Hz). + * @accuracy: Accuracy of the clock rate (parts per billion). + * @phase: Current phase (degrees). + * @duty: Current duty cycle configuration (as ratio: num/den= ). + * @children: All of the children of this clk. + * @child_node: Node for linking as a child in the parent's list. + * @hashtable_node: Node for hash table that allows fast clk lookup by = name. + * @clks: All of the clk consumers registered. + * @notifier_count: Number of notifiers registered for this clk. + * @dentry: DebugFS entry for this clk. + * @debug_node: DebugFS node for this clk. + * @ref: Reference count for structure lifetime management. + * + * Managed by the clk framework. Clk providers and consumers do not intera= ct + * with this structure directly. Instead, clk operations flow through the + * framework and the framework manipulates this structure to keep track of + * parent/child relationships, rate, enable state, etc. + * + */ struct clk_core { const char *name; const struct clk_ops *ops; --=20 2.53.0 From nobody Thu Apr 2 23:53:31 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB21339C63D for ; Wed, 25 Mar 2026 23:52:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774482771; cv=none; b=dbdYwHinqDcS68KbOc94QlPMNlhrL2ZzgmARGZFcADHhZkUgYZkEzQX8aVG/OzVjRRjCb3y8C5Yh+TTBsd24p943qDAcIAKaZzF+rqPvUBzLYymsG38Z9kC4BCSizA+Rt4VEQRzKs8fZLDv/2iuWlCN8W9La7prFloILB/DPKck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774482771; c=relaxed/simple; bh=62suQfreoiy/6IOtX/iHJTSMxZ0uXFmLFj3BP9KodwQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LAGSMIIMprXwkdaCyF2f9FSSbCXbMh/WHuH9ujvgC4B8xiLeepHlIwBHX4zpuvyodqYphL2YX40FAsgOiqWJsBnwBh3zWSuE1JJZAlBSsq5QLp0RyeE9mcsX90EQxQzvcTqOzwsu99BUMEd/U17FhS9gXbviZtzfd6DWLUW/boo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ChQ3ZYX9; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=i33Jp1PV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ChQ3ZYX9"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="i33Jp1PV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774482768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2mtlEG93DWMiKtmpTAPwEdHj6VdNNl773QdBam9e/2o=; b=ChQ3ZYX9i3eYbBiuPPldHqfhAv2us1eUyQeIVSFjcGl+OKkLVa3TIShRl3jNPLZZO870mT xaQRfcmbUYOukRmO/Yw3SZgcA4cAkcK7+WWrxoBZupgAGumTA/ixnInvsMXclV3165AgXh qOnrhJ1NxpTEKG+LQ+iWgO5DJjD6fkY= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-tstHgBUWOmaA6fPIWm6O_w-1; Wed, 25 Mar 2026 19:52:46 -0400 X-MC-Unique: tstHgBUWOmaA6fPIWm6O_w-1 X-Mimecast-MFC-AGG-ID: tstHgBUWOmaA6fPIWm6O_w_1774482765 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cdae902bccso121017385a.0 for ; Wed, 25 Mar 2026 16:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774482765; x=1775087565; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2mtlEG93DWMiKtmpTAPwEdHj6VdNNl773QdBam9e/2o=; b=i33Jp1PVDj8MzLCNf5rYvf+svy9xHALy88HkMdbgcRpdgrwOCru1i7UpIGZORP+dMf HH4wkcUAvNi1ngzGa2IpDxYSzdeo+2y8+K+dmYnzH1syIqowSsb94V9tvzKaUuVkbsyh U/WEDVFg1zw6/dH56Qn+f4e9t9kCBMPdbm7q+var5Ener2QV8cvo88AXr5bV/TeXT+0D 98k6vcpd0m6dZWJJkETcGqKY36JhoIMSetAEjcEjiRUQ7OzDMokd9BUJzyeEjUy46XA/ /ucntOFqZaZCyB8wjyq5WoRevuCexHRk+M1lGVTpLMzUjz1AlXZY7v6PCiERZ0Z8sChx HtsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774482765; x=1775087565; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2mtlEG93DWMiKtmpTAPwEdHj6VdNNl773QdBam9e/2o=; b=RV51ZolDJW9dGoDaMVUu6qoihOHsb5fK1m5cktmTALX2S8Tma3QubfslSdasjt2v0w NWFunQS7siDbRagNM4erYaiEcAr1hwC5heGHAUPW9lr1pzH2kY4ICyg4PrrXyDCT/wAZ 4UxH8Ao0vNEGlaRMyCOXHCerJDsmtMBVZmiplZJlfiwV+6I+wzj4WxPGNuFx3Y75z4eC iZsqBPlmekUSU+IiZV3f/O0FtfgEo4I5IsCVE4i6hWcGojRt5LapyoYa7DTgKMQUAKNL nWPhFJen57iiT4/ZMOVyvgf1aamBiSAdLjzRKOrsAzklCmC3EaCWI4raWuuSwsVOX2qY X7sQ== X-Forwarded-Encrypted: i=1; AJvYcCXDdQOI2JTtCfGJmCPlaw5awsBdJSSu9x/5lHAiocyKlgzs+KeXG4F+WWbPF+GoETg3yZel4WekDJ0/Bu4=@vger.kernel.org X-Gm-Message-State: AOJu0YyS3cyCjueciZluDF5XwPbyc8RMFJIzqAIV/1J3O2EB+y246DL0 GoTiY6uW7qDiFjTRex3qTBaZu2W2IfQ4ypRpcpP7LGAccmJSTMGabhzwX1UnXq1mJ3MmfHH5tdo raWifElg9E0OPWOPeZ+3cNeU0jgs2nirZ0Rmp1fCQXmX9n6o7qDey2K4mddYhvQyjfBNHnaJCsw == X-Gm-Gg: ATEYQzxL8Ttkap3pPG9qu4toCtbwvulJwM4pUQVN/aYGw/rAMxNoUrK3VSx9T3fCpmR vN5scllBRaAwb+ZFbjth+NMOzROupeWCBtKgiiwDErmziFrh47pyeUTaW90kV1iV1gzhfXZazk1 oVPaBNY4VJXPYd4/U6ccr8gD5s2mpaopezf9VjekzCxyGdmreyQrZJrA4ecyiH4g2QBEcjjL3j2 q4ZJ6hJd+KlTujE6vtKJ/Kc5p6z/WJGyLFta5tmSHOK8Hl9nsmZcvBpUFhmrn+zERneDfBTx43K e0w2S3+k4j0Ptcj4YHNSYxi6NwUSffAhAiyv8zGUkhpj8xq4nm9hY+wA/4eZN1LeKXKJj85R8cl xaBvyoDspcY95hnf2UtdlKuRjZvM4i0FjYkjPk4rkuAuM4Ge2FAXnVI8siegt X-Received: by 2002:a05:620a:31a4:b0:8cd:cd30:779e with SMTP id af79cd13be357-8d0010044e9mr743189385a.42.1774482765577; Wed, 25 Mar 2026 16:52:45 -0700 (PDT) X-Received: by 2002:a05:620a:31a4:b0:8cd:cd30:779e with SMTP id af79cd13be357-8d0010044e9mr743187385a.42.1774482765098; Wed, 25 Mar 2026 16:52:45 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8d00e501eedsm106346785a.40.2026.03.25.16.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 16:52:44 -0700 (PDT) From: Brian Masney Date: Wed, 25 Mar 2026 19:52:12 -0400 Subject: [PATCH v2 3/4] docs: clk: include some identifiers to keep documentation up to date Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260325-clk-docs-v2-3-bcf660e1ceb5@redhat.com> References: <20260325-clk-docs-v2-0-bcf660e1ceb5@redhat.com> In-Reply-To: <20260325-clk-docs-v2-0-bcf660e1ceb5@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Jonathan Corbet , Shuah Khan Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3478; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=62suQfreoiy/6IOtX/iHJTSMxZ0uXFmLFj3BP9KodwQ=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDKPlDoWHonXTH5Ws+rgsWApvgNJZuVBf62OPU3sPqJVL PSz9PXnjlIWBjEuBlkxRZYluUYFEamrbO/d0WSBmcPKBDKEgYtTACaicZbhf9gXvUSTMK7Wu+8v VJ/ufBz1tqhKSvmwzec3W235biTMSmP4730qvH33R4eP+dO8Xh76+b8+q3vqqZSZK7axON///ls whRMA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The clk documentation currently has a separate list of some members of struct clk_core and struct clk_ops. Now that all of these structures have proper kernel docs, let's go ahead and just include them here via the identifiers statement in kerneldoc. While changes are being made here, let's also include the newly-added enum clk_core_flags. Signed-off-by: Brian Masney Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- Documentation/driver-api/clk.rst | 58 +++++++-----------------------------= ---- 1 file changed, 9 insertions(+), 49 deletions(-) diff --git a/Documentation/driver-api/clk.rst b/Documentation/driver-api/cl= k.rst index 93bab5336dfda06069eea700d2830089bf3bce03..d3e93519114637b3a7006712819= 2dd302bedad4b 100644 --- a/Documentation/driver-api/clk.rst +++ b/Documentation/driver-api/clk.rst @@ -42,21 +42,8 @@ clock interface. Common data structures and api =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D =20 -Below is the common struct clk_core definition from -drivers/clk/clk.c, modified for brevity:: - - struct clk_core { - const char *name; - const struct clk_ops *ops; - struct clk_hw *hw; - struct module *owner; - struct clk_core *parent; - const char **parent_names; - struct clk_core **parents; - u8 num_parents; - u8 new_parent_index; - ... - }; +.. kernel-doc:: drivers/clk/clk.c + :identifiers: struct clk_core =20 The members above make up the core of the clk tree topology. The clk api itself defines several driver-facing functions which operate on @@ -64,41 +51,14 @@ struct clk. That api is documented in include/linux/cl= k.h. =20 Platforms and devices utilizing the common struct clk_core use the struct clk_ops pointer in struct clk_core to perform the hardware-specific parts = of -the operations defined in clk-provider.h:: +the operations defined in clk-provider.h, and can set one or more +framework-level flags in the enum clk_core_flags. =20 - struct clk_ops { - int (*prepare)(struct clk_hw *hw); - void (*unprepare)(struct clk_hw *hw); - int (*is_prepared)(struct clk_hw *hw); - void (*unprepare_unused)(struct clk_hw *hw); - int (*enable)(struct clk_hw *hw); - void (*disable)(struct clk_hw *hw); - int (*is_enabled)(struct clk_hw *hw); - void (*disable_unused)(struct clk_hw *hw); - unsigned long (*recalc_rate)(struct clk_hw *hw, - unsigned long parent_rate); - long (*round_rate)(struct clk_hw *hw, - unsigned long rate, - unsigned long *parent_rate); - int (*determine_rate)(struct clk_hw *hw, - struct clk_rate_request *req); - int (*set_parent)(struct clk_hw *hw, u8 index); - u8 (*get_parent)(struct clk_hw *hw); - int (*set_rate)(struct clk_hw *hw, - unsigned long rate, - unsigned long parent_rate); - int (*set_rate_and_parent)(struct clk_hw *hw, - unsigned long rate, - unsigned long parent_rate, - u8 index); - unsigned long (*recalc_accuracy)(struct clk_hw *hw, - unsigned long parent_accuracy); - int (*get_phase)(struct clk_hw *hw); - int (*set_phase)(struct clk_hw *hw, int degrees); - void (*init)(struct clk_hw *hw); - void (*debug_init)(struct clk_hw *hw, - struct dentry *dentry); - }; +.. kernel-doc:: include/linux/clk-provider.h + :identifiers: struct clk_ops + +.. kernel-doc:: include/linux/clk-provider.h + :identifiers: enum clk_core_flags =20 Hardware clk implementations =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D --=20 2.53.0 From nobody Thu Apr 2 23:53:31 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F07D39C011 for ; Wed, 25 Mar 2026 23:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774482773; cv=none; b=pDOCuft8GCt5Lj6JGVPsPVQ2Jp7lwTr+ThsQxdIgNAlr9xEbjLiNbgDteXc4+axjSqQCDyFwPedfUbjr3du7Q8D+LCc7Ivyt9fHs1RhiRhsros44bdD0BtZQ4STGutlgW2ILgEh2ei4oRJeaPcfcLFvsmTOCYxQNiO24cGVTeyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774482773; c=relaxed/simple; bh=+jW3MS7DFLqoUmBWO2hApFPt6x7I6eU55roZMBHG3AY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ipfPZ1ahfwD732Un2dASBSXwE9KkKIRS6+rplABcsGlITQOgLjWu27HAcdl2Z0XW2Igj/tBvqCjK+KmarX6ShTWzUYTQDzBZaQNCP3FnpAyYO+LIaHAxdTdA2NlXo2iCZSAOjK2m4crFzpk+0dfeccxTsLNi7ODdakWRsh0Q6qs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fTy1p++B; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=r4N6jeit; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fTy1p++B"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="r4N6jeit" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774482769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ahje0afOzEE5AO8iZY1qk1UFWqM0XHyDZg7ReLCYYwI=; b=fTy1p++BEgqy9W1r/zqMbR5nBQuwISURv9pNNVY8ci26nR4uS8+j8DWJVwZA/vDiIRjY09 hT/n3gkTKsNdzwHY8htCtdNDFqBuFyqLbRoMYFrK3YUqwzhBZSbYOsVjbKIxzIrDYiwP20 A82Wgizfl1smyKQZHy68XZY7m5tr3Rw= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-372-9FAjBDKrPIuO4JmhmhwW8g-1; Wed, 25 Mar 2026 19:52:48 -0400 X-MC-Unique: 9FAjBDKrPIuO4JmhmhwW8g-1 X-Mimecast-MFC-AGG-ID: 9FAjBDKrPIuO4JmhmhwW8g_1774482768 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50b220c72bbso16974191cf.1 for ; Wed, 25 Mar 2026 16:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774482768; x=1775087568; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ahje0afOzEE5AO8iZY1qk1UFWqM0XHyDZg7ReLCYYwI=; b=r4N6jeitw/yPZH+h/CuxK32PZJ1esrFGazci8dWmNiqWpvPrtGuU0TRcHSnJWP0Ezt dDLJhR5195hBS1VJmJdAxtUHlYPgEYZ+y+xH8UzJsyIB3L3ScfmcJRYXhFHJmspVzBo2 Bnj6J777R/rb681x+Brmhd0IPV53LKV+cjMyS3wvq14QhyrCh52AY2cKvLxqVJyGjVLE 38LftgZCtJYMpgaoydzwyZDH5oiNtUNvUip99v/SUaAdZkvszzNpUXpSF6jb16qgw/Vw 95dw4qYuKyOyt1A22+dQLhxjr9+iwMK3JG7KX4g/7cby1OJn8FbjdMP5tCJXrhcIUjfM Zhug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774482768; x=1775087568; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ahje0afOzEE5AO8iZY1qk1UFWqM0XHyDZg7ReLCYYwI=; b=hw9ewpFQSHyhvmKXyr6NrdMGXNhPd+4EEDj2ObJNBSlVpxjuYhnEQSuR7+QKfhU+Nn jda/CJQnRM7qAMYXCvIC92BLTYhDlc4W0Xkecl/WqoZFznLiIaoel9aq4eOScV5d325Z q0yiw6D3x9JMUAFt3VCfpQOnHHKnNRDmBevISZSv/hBc+Axg1aC4gtwtbigXGHEDU8Dg PU91Umtc1tQEzJVyrrudMPUaRIWCNgV3VTDg98Zei5F6pV8U1Jfg2jVizxHTA/KX2+WC 3MZWNnj//HGaJJmW+hxCuj0yAUgdJ6Cc2oVIqoM8gsR0W5H9ul6sL9GZ+24nEUs0ECIg A4OQ== X-Forwarded-Encrypted: i=1; AJvYcCXZ0ASCYGpUxEnmF8k0Dqmk1oiY16+4zzB1PusKwA/Zc0cymcPkyX0TcY+jbbkuXO/DB9jYqLe5kA5aCF0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1fC5Tk4mjc0uqGZXnD12w8/+yUFfbq0rpYbGEJlmdsKC8Ohzu AiSHzyDfHj4Uwl/wqWmiG9Cb+tc4bGDB+jbLKkcujDrq+gxDXXcTXljVI3O94XgYeTILsRzElYq ivYv09gnaiomhcejnqO1z8MM2qu3Xsq4vcw2XcZZVV1OTf984SzUiIlABksqvEbK1jQ== X-Gm-Gg: ATEYQzyDmMTVoCWo99uvp4DlBKIHmDllxO22NwCoouY08GJh39r/oQSccdhHWHFvbwG sLbobAUfdcFiQiHglWmZ4SEI9s/So7VVHmu9/ChfCkYOmy4wNlSJ+1FMiYd+Kb2DuEj65I8P5GL oaUb8rT9PAJi/0V9br7rykrf2gL5yxJpHFeP0T5QlP0Yut0YHbVrHUUFXHIGu/v1JQ6j94S+SDq xzD/R8QXp/BOJR6nWKBXZn5kScnwgOBvj7/4Jfw7dFqZqXyFqj2CtJiSVz3Kx2EmgtkdlihOI2q 7afV5KEqIj1ZzePQy7BW4IcXH3oO0tOvW9bWRSnUjGWv/dP82tTNNARm667kDj+xKKegWeHrZxz 3sziJqpOd/ExBHTrDvDxc/SWuAf9qYXhQ2NKgrc+SlpIZsT2ZJ1hd/6mgqr2e X-Received: by 2002:a05:620a:44d0:b0:8ca:4545:aeee with SMTP id af79cd13be357-8d00101286cmr801586885a.37.1774482767947; Wed, 25 Mar 2026 16:52:47 -0700 (PDT) X-Received: by 2002:a05:620a:44d0:b0:8ca:4545:aeee with SMTP id af79cd13be357-8d00101286cmr801584985a.37.1774482767454; Wed, 25 Mar 2026 16:52:47 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8d00e501eedsm106346785a.40.2026.03.25.16.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 16:52:46 -0700 (PDT) From: Brian Masney Date: Wed, 25 Mar 2026 19:52:13 -0400 Subject: [PATCH v2 4/4] clk: test: convert constants to use HZ_PER_MHZ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260325-clk-docs-v2-4-bcf660e1ceb5@redhat.com> References: <20260325-clk-docs-v2-0-bcf660e1ceb5@redhat.com> In-Reply-To: <20260325-clk-docs-v2-0-bcf660e1ceb5@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Jonathan Corbet , Shuah Khan Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1065; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=+jW3MS7DFLqoUmBWO2hApFPt6x7I6eU55roZMBHG3AY=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDKPlDq+9pR4pOQ7aYO4ngWf48nCF8xr9143nDtDiqv1W E7vpUfLOkpZGMS4GGTFFFmW5BoVRKSusr13R5MFZg4rE8gQBi5OAZgInxzDH85ziXPqPLzmfN3p s7rusprX8dXTws5tqyztfcznrxbv9oXhf4LZ9UdfnWSP/a879PpEunW6QmDqmi0/jd6Id3PzSzU xMAAA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 Convert the DUMMY_CLOCK_* constants over to use HZ_PER_MHZ. Signed-off-by: Brian Masney Reviewed-by: Maxime Ripard --- drivers/clk/clk_test.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk_test.c b/drivers/clk/clk_test.c index a268d7b5d4cb28ec1f029f828c31107f8e130556..372dd289a7ba148a0725ea06433= 42ccda7196216 100644 --- a/drivers/clk/clk_test.c +++ b/drivers/clk/clk_test.c @@ -7,6 +7,7 @@ #include #include #include +#include =20 /* Needed for clk_hw_get_clk() */ #include "clk.h" @@ -21,9 +22,9 @@ =20 static const struct clk_ops empty_clk_ops =3D { }; =20 -#define DUMMY_CLOCK_INIT_RATE (42 * 1000 * 1000) -#define DUMMY_CLOCK_RATE_1 (142 * 1000 * 1000) -#define DUMMY_CLOCK_RATE_2 (242 * 1000 * 1000) +#define DUMMY_CLOCK_INIT_RATE (42 * HZ_PER_MHZ) +#define DUMMY_CLOCK_RATE_1 (142 * HZ_PER_MHZ) +#define DUMMY_CLOCK_RATE_2 (242 * HZ_PER_MHZ) =20 struct clk_dummy_context { struct clk_hw hw; --=20 2.53.0