From nobody Fri Apr 3 01:24:32 2026 Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B19C4331A41 for ; Wed, 25 Mar 2026 19:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.139.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774467675; cv=none; b=ELLFKEzbdN0FhOYmNa2qnrCSvtMvYGkuWQIcWnm7KL8U3J/dHx03qLeL5zkm49dAJSJuMVvb9t7wQvAblJAdM8q2hPU45+ORDBbZXeo745fY+MBbfv2+pNGyoQM2CUqeuhrNs/TQvPYj4NeGhY1Ofl7DylLbR0hFA/p/8nl4nEw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774467675; c=relaxed/simple; bh=7zwsmyUip3CAkS6JVcgPiuvcXkqOuFIklXcl4CKLS7s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gBbLXV4oRcJccA6q8RrDgtpYBza0jOkYC4lqUWXgoeGnj4DHAQKGXkWIQgYfr4BJfbYHY/TrjsLa5Z8OLMgzFx6u3Lc3KCf51lHLrdkBOds41AX6AskgAnSYRpB29EumOwxSDf+txymc30s9bZtlRrgliKwvKzI1wZJ6O/Ik5b0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=Au7sydVY; arc=none smtp.client-ip=148.163.139.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="Au7sydVY" Received: from pps.filterd (m0167074.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PJSY0D3111394 for ; Wed, 25 Mar 2026 15:30:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps01; bh=7qfY 4Yey2B/8xRD7jk2HVXbmFsGdrb8gwFavo/knRp8=; b=Au7sydVYHJxfvhcGusjW FEbpn9GGkRrzgLrTHhOCMbptHSX/ALA6C88pzf3RJSXe3GRiSgydzJVOXWnM9VaY BNdVPii2y6i0oYq7y+9TO5mMxTct2pKIusyD79XPROlhYQeMKRNs87jKHrvyI0uw Wn8noKHIq4KB814b8F0P5FciGNk7ALGmCIX5JsU1y5+3ZOptL+6ahq1z3ywm2k1x MeMBSMQF62gu6jXDiXJrd/WT/tL/m6ciFKIBfAIwvo+/WigpyDrml510h3ho9m// h3PTLxppFUGY/IZ/ripHeVxqmM3JNsTeqGDbAUh4GSukZ/h2dod+qzk1+uc+2Tnd Ag== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 4d474u5u51-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 15:30:42 -0400 (EDT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5093a985e21so13620511cf.3 for ; Wed, 25 Mar 2026 12:30:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774467042; x=1775071842; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7qfY4Yey2B/8xRD7jk2HVXbmFsGdrb8gwFavo/knRp8=; b=Eg0MjCkJHeIa00+y5x0/PeVG6zlQ7RLkHp5S3lhs97x3yfrGPXlt7MFrBWSxUU6TBI 3C7LsI+ZiWnWSYNLmINv3O0FHnFpqQGMQNjSlhhIIeadgogSBWJ3PfmW5GdzIxz331mI WXuSKsjb8/oxgsKo0D0BBNSDUA32C3/r0yno+coqa3Ff9DFIE3iJNG0CBZhI4Seq0xMI iO6mD3qkt2m7CAVBvR/CpRmeNhd0ln32Sddu4zrcFAR20Ic25lq1cw4BZyfu3GBrqVrg r7A0yJmp+Bps1CRyRge/R0kaqMjQE75kZNlcvQ1pr22TjBISIqZPrVW2ZJ3rbiMBHkiy LVGw== X-Forwarded-Encrypted: i=1; AJvYcCUw2Q4JtV6fnwmTHWVp5yAGa4T+MjONsJnApWz5r3KE2FRYwzI3v8NeKj1x+63LNK3oXLPSuoIvJl792zw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+qyxeRxP4Tyh/aVwFkwUmQ17OLfUdik8cg3uGo1KJC2H4R0zA 7V3XgpyyXwGWN+2OjeUeoRnNjkjsFUWE37dEjmurVeM5h/HoOj8hFXiWhnzBSrtxZx47WX03XWJ XC2koNDxA44rOZEjMdJ6+yoBhc0rfPH2lMg3c9hA0PuVJRaRG3XV1Rp8wdShEcA== X-Gm-Gg: ATEYQzygBr6HhprxPFsYT/uOs3cfvj0DNV5B/51SAGSvOUwtAmEtv27E7uhzyqPWLuj U8nQXxcdaRi9I+68zPGavQnH/opKgpuVFW3YqOroSYKYCa9fQ8020LLoVnZBZckv70mxBaSfnOh TiiS6eEYfHmNz9QGDRU9j3vnR7Ct8t1v5HEzs+dtmtwLTruN84/O+8h8dqFloUpTyS1sl+djonS y00qccANBwmAUkRpNntJUnHmWdvuyOciWTaCeMjcunwNYZS6tMrANcKE1iQr5qbkRO7HIJ6Sotb 5fpxAqcTIGm8Bkez5USzwhMddG5C/LSpaJ4uLw4uMgQOaevRLqzIOwUyHz+icjiGpVdaiiYEGr7 jz1TK7euoXN/7+3cKStwts0AYyciP3N6vORXMTA== X-Received: by 2002:a05:622a:9d7:10b0:4ff:c08a:52c4 with SMTP id d75a77b69052e-50b80ce31d4mr55571871cf.18.1774467041721; Wed, 25 Mar 2026 12:30:41 -0700 (PDT) X-Received: by 2002:a05:622a:9d7:10b0:4ff:c08a:52c4 with SMTP id d75a77b69052e-50b80ce31d4mr55571251cf.18.1774467041146; Wed, 25 Mar 2026 12:30:41 -0700 (PDT) Received: from [127.0.1.1] ([129.236.226.199]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50b9234e3a3sm5534221cf.19.2026.03.25.12.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 12:30:40 -0700 (PDT) From: Tal Zussman Date: Wed, 25 Mar 2026 14:43:01 -0400 Subject: [PATCH RFC v4 2/3] iomap: use BIO_COMPLETE_IN_TASK for dropbehind writeback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260325-blk-dontcache-v4-2-c4b56db43f64@columbia.edu> References: <20260325-blk-dontcache-v4-0-c4b56db43f64@columbia.edu> In-Reply-To: <20260325-blk-dontcache-v4-0-c4b56db43f64@columbia.edu> To: Jens Axboe , "Matthew Wilcox (Oracle)" , Christian Brauner , "Darrick J. Wong" , Carlos Maiolino , Alexander Viro , Jan Kara Cc: Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774464193; l=1665; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=7zwsmyUip3CAkS6JVcgPiuvcXkqOuFIklXcl4CKLS7s=; b=L4CWzIK6kHXuFczj/fPjz2aWyUnS1OpJUL3M+esbeR43gMhMyjhAVsUMhpLPiY2zQSiPsjHza J5C73e08cUYBjjsRFhFa/ta9SjUn5dInI/J4XLjlsu/GNzv1JM0+xWE X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDE0MiBTYWx0ZWRfX7rXXkwA6QOy6 GIRr4woykgkQN9rjh9czb8V87s6b9sRUCYxV9RnOovzI1oWrRULYvSVZ8FmtvBBegTSEXaQDXDE UKVwyESt7gMO5J5STjMXJRKjbkCZ0+hOpNEMMdpW9W/eaGu5jvulHwVq68i4Db5HblVu58yIHPo 9Dei4MZHHPruihVvMn/aqpmzQG+Zb+Zlt/Kq/YLiD0l0FAPkU5t3I5Ty7yzgy+5TIzNCD7mejY7 1SS30sKm1CZ2fgPdE/tgNyTaiUQSEVTaTl32lA8m/yxPavu2BwT8BYnf2yEkNhrxRXiV/yAiXrB afi019TQBwZmgduv4xpfrWKGATYeBwXTQTh1l76u8JCK4R3LzXa605t7UxbRa9MDa51tKWTjpIJ JhXSRUq/w0Qh+fqJlY+SQwPfX8C6i8ei6sfULctq4tg1sAZgjDDGcis/t/Ar2Y0W6UgwX+IjSc2 p/Jb3PoIQL0skF9bypA== X-Proofpoint-GUID: c5U2V4_zUz5ZRDqeXTDBmyNlbTqJZpFh X-Authority-Analysis: v=2.4 cv=ANMIVkx+ c=1 sm=1 tr=0 ts=69c437e2 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=QOUmeeuX5y9IvSxXHa6D2A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=x7bEGLp0ZPQA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=azVShVRs0zEubeQ0wG0L:22 a=wJ0dTj9p17mGQU10CegA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: c5U2V4_zUz5ZRDqeXTDBmyNlbTqJZpFh X-Proofpoint-Virus-Version: vendor=nai engine=6800 definitions=11740 signatures=596818 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=10 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 impostorscore=10 bulkscore=10 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250142 Set BIO_COMPLETE_IN_TASK on iomap writeback bios when IOMAP_IOEND_DONTCACHE is set. This ensures that bi_end_io runs in task context, where folio_end_dropbehind() can safely invalidate folios. With the bio layer now handling task-context deferral generically, XFS no longer needs to route DONTCACHE ioends through its completion workqueue for page cache invalidation. Remove the DONTCACHE check from xfs_ioend_needs_wq_completion(). Signed-off-by: Tal Zussman --- fs/iomap/ioend.c | 2 ++ fs/xfs/xfs_aops.c | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/iomap/ioend.c b/fs/iomap/ioend.c index e4d57cb969f1..6b8375d11cc0 100644 --- a/fs/iomap/ioend.c +++ b/fs/iomap/ioend.c @@ -113,6 +113,8 @@ static struct iomap_ioend *iomap_alloc_ioend(struct iom= ap_writepage_ctx *wpc, GFP_NOFS, &iomap_ioend_bioset); bio->bi_iter.bi_sector =3D iomap_sector(&wpc->iomap, pos); bio->bi_write_hint =3D wpc->inode->i_write_hint; + if (ioend_flags & IOMAP_IOEND_DONTCACHE) + bio_set_flag(bio, BIO_COMPLETE_IN_TASK); wbc_init_bio(wpc->wbc, bio); wpc->nr_folios =3D 0; return iomap_init_ioend(wpc->inode, bio, pos, ioend_flags); diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 76678814f46f..0d469b91377d 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -510,10 +510,6 @@ xfs_ioend_needs_wq_completion( if (ioend->io_flags & (IOMAP_IOEND_UNWRITTEN | IOMAP_IOEND_SHARED)) return true; =20 - /* Page cache invalidation cannot be done in irq context. */ - if (ioend->io_flags & IOMAP_IOEND_DONTCACHE) - return true; - return false; } =20 --=20 2.39.5