From nobody Fri Apr 3 04:38:35 2026 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B345B3C5DB2 for ; Tue, 24 Mar 2026 22:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774390238; cv=none; b=kYyOwI3gBUS3Mg1hWNfHGHKeiYvtKpu2c1sxbJUCRvKK1I4UStLwiGUGyd1jUXpyn1Pqsx6hHJ2086PeKENXYqemm7FXjAb9cS394KkXNEsFngL0xFwAEKY8lQAAYLY3hYxBAkC9peVjhnriRgBF2WpKrgCLJIc8t1225310c48= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774390238; c=relaxed/simple; bh=9hrTM3BxY52r/i83ciCo+2/+wCJlHZeKSOLwSgXFeFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tEk4cXpJBn93R5buZZ4XlChK63up79ASspJ4yOi0bc87MtZ5yZvdiBEglAD3u6ghZZVkbfx2ikJZzzdSRwRfj979s63TRiLd4kp1rWwePXROGwNG8o4hViAxer2bjdGvlxGtQ9Hk819uxOQmQD/5Vnyi2hrtJtYoUmIYM2+P5wI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qs0qPxd6; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qs0qPxd6" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2bdd40d3c61so3852229eec.1 for ; Tue, 24 Mar 2026 15:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774390237; x=1774995037; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U2voJFRWYe3/IRDOJSsRfVKzuFslhb/kU1EVyyj6gX0=; b=qs0qPxd6MJEkooxDgpahaOks8g0hG5lpnkyaw8fgsiBNZeAkiSbOji8ME26cOS4Dcf AYSdDhuEQpGb42h/pwiLhdQoW7cIPSiHgR6dtSdqE3UCZup4yTjnfZKwt987iE1AryMf vCtevlZN+xwmvILevtNaKk9LbVHVSmIyuHQlBKz8hF3gF3gMDeKdW9iYa2JwRJR0he/N RfU40mQv2YeBBscVElrD8rjIqoHZrExF+VMBMDEButreMuPOkqCRk7GdRFPGFoKqmQdP UjYO8Y/iMjG6JNprgkyyS4muIFNFKJBDp1x0jsZUz1MImDV96zZkMfsHTAQExcvAzFNf CASA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774390237; x=1774995037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U2voJFRWYe3/IRDOJSsRfVKzuFslhb/kU1EVyyj6gX0=; b=ouCAcvMeX1DTKhO7Tj9nMB8foZY78u6HKrFzeKM0lpwsdpkYkuS8bnFe8HCzVFdvBI S62Qj0WAS0JfO8EjWi3ZoLsHeB7z5PeaCQ8TrgfM8QK4YLNbl9FcC5utO+f/OLZWZMar 0VXZKYkeyE1hnPMmGfDeAq6HH+hkR/bSIgMLbwTobZmRLlWNUqiennC7fg/s7NWVMzst vNUKn6IksvSnr0JT2E7bXPERUoKL5DYYliIn85xvJYjYzsWUjt6AJ6YLI0AX6g79ZFZE g+TH6vCRC5Dch2xHUIPHjDgcyOYaEmfKhGJaqPE2QxwA2w8ejlanErCXCc5+UM31RFyT QIzw== X-Forwarded-Encrypted: i=1; AJvYcCUNleBykIqKrXnZz7VSajLvQB9Y9Koku3LO7hn9JFc+FJixFnY1Bzdmx2vQERaFcG6Iu3++H5huUWwN8B8=@vger.kernel.org X-Gm-Message-State: AOJu0YzrSyVCxHc+5M2Rt9QijN1dCMhTfofRK6vjMoTET3AAeV5iYiRJ po23jUAejhTX2zcwovB+kUEz2IIG3bBl+Q8SDUzCXBS/9CTf0a4Zt3+0 X-Gm-Gg: ATEYQzyz0k+gFTMNsVHGLeAsjsD6kQzqLmuu20MT+wefwSVQZmol+bkMsGjjuEVdNp8 2HDr451jI2ntklhVH+SzScOfi+Kpi07f4fsHVuF5Ouon9Bg9fbYG52KyCJBfJBShxQAvOGq8/et 50CvBhG5TBzOOFSXMFBQHlOKSw3ByKLXk0jD25ORoyslOWolBpISiLVsJ0QWilNJmaFpgx9n3cA +tJZl+LVzRFO6v/jHn9pE1qJbI5Db/64AmQEk6ADorOJfeoxQy0SDx7737IduhHs/CBj1Z9LtuL zD0W0B1EO0EF1d0KnWOPjaoqAKFudPf1i0tOhZiLq6jXpyeNdhUpsfkyzNfGGCu8hXAV4+g7CLt VaW6iNS5WLHgA8XUZCE/2feu2nPT77VqrSCCeG693g2oXQsSCHU3QO3veG86v4QmUjslJ3NLKIH e7n2aPQpNw7gsjicDrngybS/r60b63MOf39A+i91EB0cbjlaOsl0N8UHco8tPNXm1N6eoQCuMhI ZkF X-Received: by 2002:a05:7300:bc8a:b0:2c0:bfe3:b95c with SMTP id 5a478bee46e88-2c15d252487mr532131eec.4.1774390236835; Tue, 24 Mar 2026 15:10:36 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b14c299sm16282832eec.6.2026.03.24.15.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 15:10:36 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/8] platform-x86: lenovo-wmi-other: Fix tunable_attr_01 struct members Date: Tue, 24 Mar 2026 22:10:26 +0000 Message-ID: <20260324221032.1333636-3-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324221032.1333636-1-derekjohn.clark@gmail.com> References: <20260324221032.1333636-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In struct tunable_attr_01 the capdata pointer is unused and the size of the id members is u32 when it should be u8. Fix these prior to adding additional members. Signed-off-by: Derek J. Clark --- drivers/platform/x86/lenovo/wmi-other.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86= /lenovo/wmi-other.c index caf360b76fc5..c1728c7c2957 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -546,11 +546,10 @@ static void lwmi_om_fan_info_collect_cd_fan(struct de= vice *dev, struct cd_list * /* =3D=3D=3D=3D=3D=3D=3D=3D fw_attributes (component: lenovo-wmi-capdata 0= 1) =3D=3D=3D=3D=3D=3D=3D=3D */ =20 struct tunable_attr_01 { - struct capdata01 *capdata; struct device *dev; - u32 feature_id; - u32 device_id; - u32 type_id; + u8 feature_id; + u8 device_id; + u8 type_id; }; =20 static struct tunable_attr_01 ppt_pl1_spl =3D { --=20 2.53.0