From nobody Fri Apr 3 02:59:47 2026 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 026133C73D8 for ; Tue, 24 Mar 2026 22:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774389904; cv=none; b=YN+WbSIqMgvBJKGg+npVqH28oLYCRmcYN9mr4VrVXNJVFhr2eNyeeOD2U+wlJacb8nE202xJSpq/H9NAAQ51lM0BbiGxZxK6QIWnctcMzINTVY0PTlDF6rJ3vCmgblNkZt1sfXA1bPCfokoOnJ7WRXKk40MGkcCgI6C0/qSjzuQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774389904; c=relaxed/simple; bh=yMyzaFoknNuQ6pVvN+fu/ld64KkXbgcWoC8dH9PpS/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ojGcIFDlrLQTZghXcaDhzVu+/ahu82LUc4PPxrvGO4/RlmWXiWtuUxERNXNeSfjQpbnTzEnC9nfm1W4ynNSg3nGPty4j+rjtcW0LMInDxt5pQDYuxymhkYvJ1ky+OmOSM3wveOYw5r35CC8u8hq7Vx0LEcvZ4lNOE3HP3v2chdI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IHHMKURt; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IHHMKURt" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-8cfbbf35354so595832385a.0 for ; Tue, 24 Mar 2026 15:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774389902; x=1774994702; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=IHHMKURtuv7Rmirn88SBSikujdMb+HccchUOk7TQoBqhRCw7as+hxCTxLUR+U6cwZH ucMcFdrNylVh0/XpLBtJhjIbdD6rFgfaX2L4d1QWSwXvpbupO7DKHYAl212/Hf1amenN f+ikyx+pdcN8tzQZXnbd8Uyj2y72a8T6ahfJEWaPloHkcbUfGk+f9AMUGi/8nCwbhF2n C0h27jtdrJ4aSVaG/zClOLrc0dJwQl4Y90wx4P9J2wdIj9ZdftP5XGUPpi9FsjrNqanv +JG9jvoBqA/RzbacbmW1RGegWA4rqc9HIFtOEFRpJrIepRKB6pKVeDMPa5e0u+rDn6vG Obiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774389902; x=1774994702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=lvES8muB93/zkdJO0wnGku6+g0nxhJArKmr/t5Usjntc42Rk67wTCGbC9ogvFZ1C5p UY4S+00q3l2nZ4eZVktp8m4no/NJfL/hsT/788XuK47uTXwHkst1DADV/RqFe1udP28Z Z/9U9OJr0frzTSBwH2ZiQIuAJpn2n34gyMSiYiQ2zWmDpTgxJ8xNiRGO3iRn43p+kopz UG7C69Ddsz8U788eC6kBvVyYnAq0BW2t/zM6BxUWUdAX5BcpTJRsUkne87hLVMiN4Ntv ta5FW9HIdLfjYxpUlaO2KGbtT+RaMLzTzYlqwnE/XEj5vEFHQ7yaE77EOsSiGYvah73g eEqA== X-Forwarded-Encrypted: i=1; AJvYcCXWfcqOX8IwPgVn9YpsdXgvz3d0z+ZEEwnrMFU7Q5GXuZNPLn2anZkHH7j8DB6a4yO+e2OFw0sm0GO9cis=@vger.kernel.org X-Gm-Message-State: AOJu0YzhcgqI8+KyT9XXy9MdkWtLxJFrpGBq16VOzLEc/4pJBpX0h8UZ YYFzwarHPSssXtQOhFCbal1TrIZGRIgl0OLEGbSHqw4jzi7KvjbzXgkN X-Gm-Gg: ATEYQzzL6pMW2D/GGV0oBk3SasKZvVD5Mc3VB9Awo3m/BeuVJStXiItv1PugA3bjmN8 qVGw5MBytcYgSANG67vfE5WTHVDnbnWK490y1IdmKEX8OW2kJDkI7+92d065/N+xDL1cSzmVlIe 9fZHxNWNLTJm5+ZJuQxEPiPgutSccq6fD1UPXiGlKLokNw+GF5WrFWMfmFRA9juQOuMiC/91npf 4Y9BOb9Rpo8VHyFc1RDeVOtLd19yN+ssiGCZkp7Wy4+WIuketpSMUWFwNvGS9yaWjoqajXRUoal K26RTvDx9kRWdhP+j3msmzIRVxZXLebbbvhdh5sXQCzRRuIQzHrQMie4HjONz9cafy7lt7kMRD7 UBs0f/dAe8YhgKpSVCaMEvAbWgsnp3zopr4oTkOYIlleG6eY83O4yIh03EV23++THbPECqwQLLL 2wMr+LbS1f2vG/T65PoKWbZOvjlUDW7Rz+og== X-Received: by 2002:a05:620a:3726:b0:8cd:b315:6af6 with SMTP id af79cd13be357-8d000f22dbamr193350785a.8.1774389901876; Tue, 24 Mar 2026 15:05:01 -0700 (PDT) Received: from potato ([31.176.161.207]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89c8534f9ccsm127590976d6.39.2026.03.24.15.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 15:05:01 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH 1/2] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Date: Tue, 24 Mar 2026 23:04:52 +0100 Message-ID: <20260324220453.47406-2-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260324220453.47406-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_dvobj_init() use direct returns Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..358eac0837cf 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -155,13 +155,12 @@ static void sdio_deinit(struct dvobj_priv *dvobj) } static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func) { - int status =3D _FAIL; struct dvobj_priv *dvobj =3D NULL; struct sdio_data *psdio; =20 dvobj =3D devobj_init(); if (!dvobj) - goto exit; + return NULL; =20 sdio_set_drvdata(func, dvobj); =20 @@ -172,18 +171,14 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio= _func *func) goto free_dvobj; =20 rtw_reset_continual_io_error(dvobj); - status =3D _SUCCESS; =20 -free_dvobj: - if (status !=3D _SUCCESS && dvobj) { - sdio_set_drvdata(func, NULL); + return dvobj; =20 - devobj_deinit(dvobj); +free_dvobj: + sdio_set_drvdata(func, NULL); + devobj_deinit(dvobj); =20 - dvobj =3D NULL; - } -exit: - return dvobj; + return NULL; } =20 static void sdio_dvobj_deinit(struct sdio_func *func) --=20 2.51.0 From nobody Fri Apr 3 02:59:47 2026 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE0CC3C7DEB for ; Tue, 24 Mar 2026 22:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774389906; cv=none; b=e+IRCmr9GQfQ6YNGXUKjHH98ATTC9VPCaMjU7AQEIoK01Dj1SfqtyqYjveRWaF7BVx0SyecxrTm5Tpwn7yv1XKuOLRso2Whb4gDjJdCDMFt2q3EoDILaFTysZ+E41WYFRpJ0xJVJ7NHixU8NqnNhL7tNyK2xQSRunSCx5t18QNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774389906; c=relaxed/simple; bh=UoObvnnZRPgdvTgqoymjmAp+D17szqmEHwzVj+aDlXc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=le2V4OMPzjiB0oPcslPmG10bLf8pT5144Wc4G265aFLmMGweQdg6MBVmZ12NDewLSP+mggAEObO1jSRe9EpPrLZcUYl7R8zbZ9vSZ/0vNhfbP3rrXuW41qqwYPLD4AqbywGYjOhFVtFQP9ipZWNKi6dcpRec27WWYMMBA5VFR8c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A2WJg8F5; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A2WJg8F5" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-89a1347051aso72468736d6.2 for ; Tue, 24 Mar 2026 15:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774389905; x=1774994705; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QxfMVpIjXpWEhI2DEdBaY44M11aQ1DT160hMDVvL9os=; b=A2WJg8F515K77saDbDMLfUxUHYY2a5IWqWevlsPv3ymJhSJOKnekX7XtLaRxcER4XT KxPetEXKRPdbTWL/BW0XWH3e3BcETBbzY6Qtat+ZnuOrxpMKoS+rW0fbg8JzeOyNTRZF lcOxTkJarfvZYIVzCWeTkyYCI57goLMoE8gJiEUfCClzdeR9OJDlJqAlTnqAAH0uWGfn u1KF1HX2DbxL8C+EVcRE025uuNZkey1XAtttcWnyxr3FRrRupJucnoBVUpX610wGb/DC cIRcp/oPatMA2UuPv3WU+UDfUY2WzETtGTe3Eul6bDAiYvJjtNUeOjZwFgzMpLqI54pa 9iUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774389905; x=1774994705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QxfMVpIjXpWEhI2DEdBaY44M11aQ1DT160hMDVvL9os=; b=sxStMcydRRokn5msYrmBtcLsuy4ucSrO8FwC4bJKl6gleLf8N0oZ9URKtRHG19xQUZ GyhN1i7IxObJHtO9rKuseI+D2j9c8FpUfLHUwjr3mOEBiF62ChhSFMSC/ihACksPEox1 UVmNJyRWdchh4H6wfQX/Z8rtJcsavq01VwvWwkLQDhQuQ+Tz5L0LmWc8IfxlHfLIu/o+ hf9ovNB7O56DS8mKrAgm6VY7ViY6uDnCfkmPKLibnBOUHsia2B1jHhrm5u1Qixr3jxl0 SUnMIBztTk1l4rrPVy96Z0GZQ7vDswnQ+/bYQ0GvBLfo5Hdv3042A0U9FK1WwNrQtwtF EBcA== X-Forwarded-Encrypted: i=1; AJvYcCWfBKX+nYzcYx2FbJIkSgeml0eCJ8LwSM1YiZ66tnmyTr71WE1mk4dMPGMOOTfQxgrdRz3YaI5c/X0N17w=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1X5L2WlobA3Li+B21+aayuu78c6TpCeA4dOr7McISaD3f/eqy eXJTuttg9RsrNzfCuvvQbb/bfUahxn/H+T6CfVal9Sn1y/p73/qvaRd0CtvT8Cjl X-Gm-Gg: ATEYQzx0MqlxH13BR1Hr8QEYIMDrWWHJ1nUV3tb3CYvnhFa19pqpgp+DrjBx7dy0BGf fBCbyEX3PfgF3RJlawC5Mj8sAe6gLX/78MdcVt24sfgftU5LNAtG/Ax3IW2aBkwAvP3vygGMUcr Fnc19YEzOQNcYW7BG05aMQ7sQX/mVqkeGwv4hx7ix5qSC7NIpi+Jdqy8wrWfCIXr7mpgUs8XXxP 1ID3AmgE1K4Iwfqpez8/EYGbTsbXZdlorvCI3CBWTBpMGYAadkAYaAHQ7C9V+M4x09nQ2pz5WWG d4H6Nt8pcsW8MDAJ08XJWSEa2Nq8Jk5lCSF1q92rBkNpSEuCGmTKJg4gXSUGlVb4aiMoPT8HgnU a8am1p71CK060/fhPlnvhqC6oYhzGgmYmag/UnmH3RHX9YtMN0Kpxkwy1qbmj+I7zYrk/Q4kgom 9JqaQaX0+QfcSjMAKjN3xjW4o= X-Received: by 2002:a05:6214:dc5:b0:89a:1536:2528 with SMTP id 6a1803df08f44-89cc4a421dbmr23417256d6.26.1774389904494; Tue, 24 Mar 2026 15:05:04 -0700 (PDT) Received: from potato ([31.176.161.207]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89c8534f9ccsm127590976d6.39.2026.03.24.15.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 15:05:04 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH 2/2] staging: rtl8723bs: cleanup return in sdio_init() Date: Tue, 24 Mar 2026 23:04:53 +0100 Message-ID: <20260324220453.47406-3-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260324220453.47406-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_init() return errno from sdio_enable_func or sdio_set_block_size instead of _SUCCESS/_FAIL vendor-defined macros. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 358eac0837cf..01b5d8a70072 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -131,9 +131,7 @@ static u32 sdio_init(struct dvobj_priv *dvobj) release: sdio_release_host(func); =20 - if (err) - return _FAIL; - return _SUCCESS; + return err; } =20 static void sdio_deinit(struct dvobj_priv *dvobj) --=20 2.51.0