From nobody Fri Apr 3 04:34:28 2026 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8105A35E95E for ; Tue, 24 Mar 2026 20:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774385594; cv=none; b=iFDIW6FpkklH335Uw0XfXRIJ/AXdPMoiLMfu4gdWe03cY6mjRaIjgrCrCzYyg+ps9jwmzdNe9oB+Lr62wOtycZEZnbPby8Uda1ZgDEIubsTmgT4yWT9EQO0RHFWHePjAzEVUxzUertSlqUB443NKNdd2gSTmPTga/hIM7yBrvpg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774385594; c=relaxed/simple; bh=xqZQ3SvaBjFkGhtlaYhusneOcuRfyDHHa5x9/WtiaUc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dfe1dwVuQTQkhUygzOg1LVpj26SbW4ItW1LoYbRVgcCx30Xyeoe3ft4BP5t4gHLrN8O9FgeQKVZEOoruWDBApLaHFNFO3soKaf7+jX6JURD2eN2knrFfymXT2mSJZ0Sg9a45gca5xTTU5FVKzYWJzeZQvafPf0iiVc2MK4+cwLw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l8gOfnNb; arc=none smtp.client-ip=209.85.161.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l8gOfnNb" Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-67bbea1e090so3240902eaf.3 for ; Tue, 24 Mar 2026 13:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774385592; x=1774990392; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QV9GcPB3CgMH11snwri74jW6U7GqWaCu+8vUwZySiUA=; b=l8gOfnNbJKIFBeQ/BPo23ak2J4hM+ICAT4sm/uxpT18Lcxio6Doqdrh1D0e5AsXlG5 kKrMd0Fv2fpp+DtJgqAIvWZpFgwx8tRlALGUahnfVRwHfeE6FIjPxw7emClgpusR3IeU 5h2k1iPWf2uanaOWijx0D8G2QzMGrcTUgywreZXp8ZCGWsPlR+Gsv13jSxDowsLHAt1r DrXv0eP+SbdTGM4R3XvUsIQ9jZU+ACrhY5JmYBDXgO9qvjbIAOxHTSzlMQ+4YlKUo3M2 zPlZRYa6TDaeRQvDwOCRopTh1f8OsGIJ344wTzYpSeerbpxdrYHPqAUE9TY8vXKXL/OD tD+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774385592; x=1774990392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QV9GcPB3CgMH11snwri74jW6U7GqWaCu+8vUwZySiUA=; b=A61l0YRzDn2BxZaMBsbiW9ZRuNSRoPo/+xe+6gzpgClFHCI79TYLQuyK6ytTmYkIY3 BziNjEMZ94LspebTdgrvosRBws8CGfKWfito38YoIcKUL+iyFP404hV1RWDvMs9tfe0n q+HPd4DP00I4siyG29NamM7qZxSrnm94G55s5caiYO7fIxT5EkVzKxv8Msa7ax3rGYFj uSI8GQlRao3W+48AtDEXw9ojQRShpF0AtoraTTHjFVH0MYpFUAG8KD1eF4wZCqWBhH/c xqTyZNVkyOlK60MQqxJCCJl/KL7/wnkgsM2EfojcozwrgY0ebLKvjjMGPi26pEtIS1RD gCbg== X-Forwarded-Encrypted: i=1; AJvYcCVPLeSrtTl1tW9HL6mIM5GLWdCZ5aoPO5cdiAjusb+ORK3F8UR5T7ypFSMDCIQFbGQRTbB5fUDjNzyDl4Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzkbKzQsF3LKwYFSSdVwr0WFL175DdbDntk8qhg9vh/5jKirLDR lwuFQAe6qt6Vdr8aDBC/F662yz6UgLhNeAZYsu6rP+e+zQrLgVBM2ZKR X-Gm-Gg: ATEYQzyNniW8I4bqTSdsL3vCF4sUve+UwUn7UyoUMxi/FvjICkpNw3mtxgrLBa+EaLZ AtPZfpDz91g1jIGYMPNgG11tCh4+M6h3eC5ClHesmYDocYygI82l1URzkBNqP1hEkAM8tThI13F pBwVu9S5j1BI8Bx6RneB9xgbp+kl99mv7Pw6yn0ASvw10dzoWF0Q6GHluvydxVdiBF9EED2oX0C BjWJqnk2L1Y2gtiTaWrjkuRQ0ocrl7yKeimXTsxivqEjkuqKy4bpfVBsFms+JuSoXdxHkXzZ3u4 USFKKbktMbLCs9u6SuoqzDDGTFtROjAfQPc7EYQM4oNtWpHttsA7fW0XAHhMbTIwSwm6MKVvLwl OfFv3EK/3G7+T2aZ7PBJWqz7l/BENWMljC61vaRIdA/gbDH5a6ZRE+hMa6EfxMb+9GYUBbCZvaL g3xIDRwF99O9bgUQcD2Isz2zWnUANjKte1VPBi4WJsjnVEdBV4Jgtskc6YW0lbirUtEv6xBAOhg elzR1Ewe6oZfzd82fHgZtYjK/BoeF5Fc2eyHrTa7w== X-Received: by 2002:a05:6820:3108:b0:679:88aa:7531 with SMTP id 006d021491bc7-67dff566397mr657706eaf.62.1774385592564; Tue, 24 Mar 2026 13:53:12 -0700 (PDT) Received: from Atwell-Laptop.. (108-212-132-20.lightspeed.irvnca.sbcglobal.net. [108.212.132.20]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-67c252c91d0sm9125161eaf.5.2026.03.24.13.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 13:53:12 -0700 (PDT) From: Wesley Atwell To: netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni Cc: Eric Dumazet , Neal Cardwell , Kuniyuki Iwashima , David Ahern , Simon Horman , Simon Baatz , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Wesley Atwell Subject: [PATCH net-next v3 3/3] selftests: packetdrill: cover scaled rwnd quantization slack Date: Tue, 24 Mar 2026 14:53:01 -0600 Message-ID: <20260324205301.1361608-4-atwellwea@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260324205301.1361608-1-atwellwea@gmail.com> References: <20260324205301.1361608-1-atwellwea@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a packetdrill reproducer for the free_space-limited scaled no-shrink quantization case. Grow rcv_ssthresh with in-order data, then queue tiny OOO skbs so receive memory drives raw free_space just below rcv_ssthresh without advancing rcv_nxt. The final ACK reaches the case where raw free_space sits just above 84 scaled units while rcv_ssthresh stays slightly larger. Old code rounds that final free_space value up and advertises 85. With the fix, the ACK stays at 84. This gives fail-before/pass-after coverage for the actual raw free_space bug rather than the separate rcv_ssthresh-limited ALIGN-up behavior. Signed-off-by: Wesley Atwell --- v2: - replace the old rcv_ssthresh-limited sequence with an OOO-memory reproducer for the raw free_space case - drop the follow-on ACK transition and keep the final free_space failure case that proves the bug - drop the IPv4-only restriction after verifying the test passes for ipv4, ipv6, and ipv4-mapped-ipv6 - reword the in-file comments to describe the observed behavior without referring to a removed path as "buggy" .../packetdrill/tcp_rcv_quantization_credit.pkt | 62 ++++++++++++++++++= ++++ 1 file changed, 62 insertions(+) create mode 100644 tools/testing/selftests/net/packetdrill/tcp_rcv_quantiz= ation_credit.pkt diff --git a/tools/testing/selftests/net/packetdrill/tcp_rcv_quantization_c= redit.pkt b/tools/testing/selftests/net/packetdrill/tcp_rcv_quantization_cr= edit.pkt new file mode 100644 index 0000000000000000000000000000000000000000..bb4f63772326fb1146574ad3f43= d59082ee49c18 --- /dev/null +++ b/tools/testing/selftests/net/packetdrill/tcp_rcv_quantization_credit.p= kt @@ -0,0 +1,62 @@ +// SPDX-License-Identifier: GPL-2.0 + +--mss=3D1000 + +`./defaults.sh +sysctl -q net.ipv4.tcp_moderate_rcvbuf=3D0 +sysctl -q net.ipv4.tcp_shrink_window=3D0 +sysctl -q net.ipv4.tcp_rmem=3D"4096 131072 $((32*1024*1024))"` + +// Exercise the scaled no-shrink path when raw backed free_space, not +// rcv_ssthresh, limits the post-ACK window in __tcp_select_window(). +// +// Grow rcv_ssthresh with in-order data, then queue tiny OOO skbs so recei= ve +// memory drops raw free_space to just over 84 scaled units while the curr= ent +// rcv_ssthresh stays slightly larger. The final OOO ACK should keep the +// sender-visible window at 84 rather than reopening it to 85. + +0 socket(..., SOCK_STREAM, IPPROTO_TCP) =3D 3 + +0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) =3D 0 + +0 bind(3, ..., ...) =3D 0 + +0 listen(3, 1) =3D 0 + + +0 < S 0:0(0) win 32792 + +0 > S. 0:0(0) ack 1 + +0 < . 1:1(0) ack 1 win 257 + + +0 accept(3, ..., ...) =3D 4 + + +0 < P. 1:10001(10000) ack 1 win 257 + * > . 1:1(0) ack 10001 + + +0 < P. 10001:11024(1023) ack 1 win 257 + * > . 1:1(0) ack 11024 + + +0 < P. 12024:12025(1) ack 1 win 257 + * > . 1:1(0) ack 11024 + + +0 < P. 13024:13025(1) ack 1 win 257 + * > . 1:1(0) ack 11024 + + +0 < P. 14024:14025(1) ack 1 win 257 + * > . 1:1(0) ack 11024 + + +0 < P. 15024:15025(1) ack 1 win 257 + * > . 1:1(0) ack 11024 + + +0 < P. 16024:16025(1) ack 1 win 257 + * > . 1:1(0) ack 11024 + + +0 < P. 17024:17025(1) ack 1 win 257 + * > . 1:1(0) ack 11024 + + +0 < P. 18024:18025(1) ack 1 win 257 + * > . 1:1(0) ack 11024 + + +0 < P. 19024:19025(1) ack 1 win 257 + * > . 1:1(0) ack 11024 + +// The last tiny OOO skb pushes raw free_space just below rcv_ssthresh +// without crossing the next lower scaled unit. + +0 < P. 20024:20025(1) ack 1 win 257 + * > . 1:1(0) ack 11024 win 84 + +0 %{ assert (tcpi_rcv_wnd >> 10) =3D=3D 84, tcpi_rcv_wnd }% --=20 2.43.0