From nobody Sun Apr 5 18:19:07 2026 Received: from mail-dy1-f228.google.com (mail-dy1-f228.google.com [74.125.82.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 557D633EB0A for ; Tue, 24 Mar 2026 20:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774382941; cv=none; b=KjKDF230ZCg0er+FdpTd9B6o4FU4I+gMOEkJcxSHijumgLJ4CDvBNmh8ljPsdNPr6g5ipTJ/WELU0xTBawJEkfopGekgmKQJL3lu0ZulUmrUiFZItuiXmnJmoy1uMB7oDpEDpExBIlwwdmA6VbnZ5Qdjsg8awGzusGtvDGoDaB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774382941; c=relaxed/simple; bh=uupls+EoIqFMksBYu+xgCc7pD5LnmGujwusczIJ2UCE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fVFDqrAn07jb/Djcn1UknCpQbOMHlYmmgYyBU1ozCKELwjgyWDwOXTWIbxm2FGLL7qFj6TPCwIn7f0dG7DPq1lI/TWan4mjGlOtwox1KSxRYwFkpub2YcVileHNr8fDAvuOejNU+kDXqBZ8Dpf1hk+nEeMRawso5DGs39rauK+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=HPJ8Q4ZJ; arc=none smtp.client-ip=74.125.82.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="HPJ8Q4ZJ" Received: by mail-dy1-f228.google.com with SMTP id 5a478bee46e88-2c0c482e069so3588364eec.0 for ; Tue, 24 Mar 2026 13:08:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774382933; x=1774987733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ekLCRy2qgCJCMkJPjj+3TMPL7gi7bF1+gj7eUMscTVs=; b=WBEnryScpcK/0Yggu+KVvoJLi+fRttjpA7g/kjC8X+P2PX/Jide7nmHEW8AYXzYVMY 7VLo+0MJYuPaD3xUDhqMHjosewBs30hTWiVQmIUAkI6nd5K8McQVf03O/ZUJWMJyjaCv fMvTmrXZCcwZb68gYCD17b+ZaT8zRfLmoKpu0g+edaaf2zYcX1yfEkuqjhHVysEe/mEc pcwm9sFmLa7YsaMUkVprVQ+oVJGV+Zwet1egRZQ/vq42z0CfNu2Y2Q8abgOXRG/t+584 UzsZ7kTJUSJw1XbsEOhpBVk8YvCqELBizgXQ/WWIAL16urIOZBWTFnleMJZKyeDrupeb B4Ew== X-Forwarded-Encrypted: i=1; AJvYcCUb6hnbBIM8u4vJBSwQXTMCA+7Rw6pocPQQNpGrmxjBv3VzVjKD15WkKZ8O+Ovf6b1D7TwKahAOCj9RGEc=@vger.kernel.org X-Gm-Message-State: AOJu0YwFEve1Hl4iTN9IZWNcXGLCSBOnnv0ffd32xUJRIAKM0Ve4G4lS elMjtDrbCLVKMd1b73sli6Lsg4+C4ZFzsfIHBZDLrDhq6Aas9loYkwPfCzMsxSPj8gHSGWLkmUM wjO6YXVaVqFmD/A2MkLWwxmDzAKYM/27/xfv35lLJNVg1Pt1wFjmRYbJpJooMJdRdYatF8Qs5Q0 G50K806aNkgGPf7SCVOt4Kd8f77IY7ZeO9B0BP2MnPHv7XdpFmTME2EZ4aLxxiJwy5sxbXDxg8y 3+mYe2rAOUQWC0IPJmLGEbXfQ== X-Gm-Gg: ATEYQzwt7qMt0tGan8FvVBlOHZJB9P9wwTcjXoW8Wg09ozuJJaUsWC2LgejHbCKRVuy n7fLl5v2c8PSZEg16bIq4UpWtSh6tJhD78E4HkcBNZSP0mxNAS/2S9Ee7eUrDJ0DwRybmgu2Lce 01jc4/WFtbAzOPnXw+hErwqyCMZirAI7V1+oE8Aog0rJSvn09cN24I+Lh3SHbC7euWAB0jMomoe GxEkAplaCnM5CMdTMJKZJ4BqF4JirJgQu3vdvizlQ0VSzX5EFAS82tqZh3ebdZV8lweTCrmZ331 W7Y/WcNFz+pNJi9ZCZ25kqWGd/3HhGjJVNOmOEdNhH4bDsmunw2r2R7EefgILL+VcYHoofsl+G4 17fQWTgowfY9IqnQ3PYzTSdtZuhek5AXOwS6p9KL71lZTpdHJhdau3mbRVjlRzzfuXt/aQ5L7y6 CMjepH3k9wppUTcsD9hJZIAyW/egPqSHDMtUZGsRPD5pRVvkDa9BAbwpna28VbmfmrUA== X-Received: by 2002:a05:7301:607:b0:2ba:6fbb:5e7f with SMTP id 5a478bee46e88-2c15d3fb79dmr386917eec.35.1774382932569; Tue, 24 Mar 2026 13:08:52 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-121.dlp.protect.broadcom.com. [144.49.247.121]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-2c159519981sm146125eec.5.2026.03.24.13.08.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Mar 2026 13:08:52 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c741b950511so2691102a12.0 for ; Tue, 24 Mar 2026 13:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1774382931; x=1774987731; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ekLCRy2qgCJCMkJPjj+3TMPL7gi7bF1+gj7eUMscTVs=; b=HPJ8Q4ZJy9WY+EOpNBGctBKsgwuLopldPkQG5+cu0W7JhhZJFpnH/Q/ldclaCXjohh /CdysPj4dSc2a/4K7Xt5zwyRWJ/Mw5hcGRr0hwV89JafINZ5UC41ocldi76Kg7vsfO6R 52Xg3gDIUdeIOzCPHAXMAC+s6EDqARE2JCMco= X-Forwarded-Encrypted: i=1; AJvYcCUCjEPQyF89ztqOIsbydHvqIax1+QxSBnqo1qcSeAVvEq2X5a9P9YF1Rnlelhn9VzjZMTFQEmOcZ5eksSg=@vger.kernel.org X-Received: by 2002:a05:6a20:729f:b0:39b:f026:6f8d with SMTP id adf61e73a8af0-39c4ada9073mr977001637.43.1774382930840; Tue, 24 Mar 2026 13:08:50 -0700 (PDT) X-Received: by 2002:a05:6a20:729f:b0:39b:f026:6f8d with SMTP id adf61e73a8af0-39c4ada9073mr976971637.43.1774382930167; Tue, 24 Mar 2026 13:08:50 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c743a80163bsm9930057a12.1.2026.03.24.13.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 13:08:49 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy Subject: [PATCH net-next v9 08/10] bng_en: implement ndo_get_stats64 Date: Wed, 25 Mar 2026 01:37:38 +0530 Message-ID: <20260324200740.346029-9-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260324200740.346029-1-bhargava.marreddy@broadcom.com> References: <20260324200740.346029-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement the ndo_get_stats64 callback to report aggregate network statistics. The driver gathers these by accumulating the per-ring counters into the provided rtnl_link_stats64 structure. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 103 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 3 + 2 files changed, 106 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 8e59935c6826..3c624f528545 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2872,6 +2872,7 @@ static int bnge_open_core(struct bnge_net *bn) } =20 set_bit(BNGE_STATE_OPEN, &bd->state); + set_bit(BNGE_STATE_STATS_ENABLE, &bn->state); =20 bnge_enable_int(bn); =20 @@ -2910,6 +2911,99 @@ static int bnge_shutdown_nic(struct bnge_net *bn) return 0; } =20 +static void bnge_get_ring_stats(struct bnge_dev *bd, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + u64 *sw; + + nqr =3D &bnapi->nq_ring; + sw =3D nqr->stats.sw_stats; + + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->rx_missed_errors +=3D + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + + stats->multicast +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->tx_dropped +=3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + } +} + +static void bnge_add_prev_stats(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct rtnl_link_stats64 *prev_stats =3D &bn->net_stats_prev; + + stats->rx_packets +=3D prev_stats->rx_packets; + stats->tx_packets +=3D prev_stats->tx_packets; + stats->rx_bytes +=3D prev_stats->rx_bytes; + stats->tx_bytes +=3D prev_stats->tx_bytes; + stats->rx_missed_errors +=3D prev_stats->rx_missed_errors; + stats->multicast +=3D prev_stats->multicast; + stats->tx_dropped +=3D prev_stats->tx_dropped; +} + +static void bnge_get_stats64(struct net_device *dev, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_dev *bd =3D bn->bd; + + rcu_read_lock(); + if (!test_bit(BNGE_STATE_STATS_ENABLE, &bn->state)) { + rcu_read_unlock(); + *stats =3D bn->net_stats_prev; + return; + } + + bnge_get_ring_stats(bd, stats); + bnge_add_prev_stats(bn, stats); + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + u64 *rx =3D bn->port_stats.sw_stats; + u64 *tx =3D bn->port_stats.sw_stats + + BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + + stats->rx_crc_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_fcs_err_frames); + stats->rx_frame_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_align_err_frames); + stats->rx_length_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_undrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_ovrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_runt_frames); + stats->rx_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_false_carrier_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_jbr_frames); + stats->collisions =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_total_collisions); + stats->tx_fifo_errors =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_fifo_underruns); + stats->tx_errors =3D BNGE_GET_TX_PORT_STATS64(tx, tx_err); + } + rcu_read_unlock(); +} + static void bnge_close_core(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2921,6 +3015,14 @@ static void bnge_close_core(struct bnge_net *bn) timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + + /* Save ring stats before shutdown */ + if (bn->bnapi) + bnge_get_ring_stats(bd, &bn->net_stats_prev); + + clear_bit(BNGE_STATE_STATS_ENABLE, &bn->state); + synchronize_rcu(); + bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -2942,6 +3044,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, + .ndo_get_stats64 =3D bnge_get_stats64, .ndo_features_check =3D bnge_features_check, }; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 548c5a77e76a..c972567882bf 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -262,6 +262,7 @@ struct bnge_stats_mem { =20 enum bnge_net_state { BNGE_STATE_NAPI_DISABLED, + BNGE_STATE_STATS_ENABLE, }; =20 #define BNGE_TIMER_INTERVAL HZ @@ -353,6 +354,8 @@ struct bnge_net { =20 u64 flags; =20 + struct rtnl_link_stats64 net_stats_prev; + struct bnge_stats_mem port_stats; struct bnge_stats_mem rx_port_stats_ext; struct bnge_stats_mem tx_port_stats_ext; --=20 2.47.3