From nobody Sun Apr 5 18:19:30 2026 Received: from mail-pf1-f226.google.com (mail-pf1-f226.google.com [209.85.210.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEA5D33344D for ; Tue, 24 Mar 2026 20:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774382935; cv=none; b=klWOYlN8qh1UPFTfkLuQRlRzFl1gRapwlyX3f736zlhOLSwV9sK4KOdgb83KB6MD79CtpqB8G1B4b/+sDTq61/YdPNJF5piVHf53XIDMCSTb2X28woVSmFrjZ17MYNGZ6hJ4cucBbRuje0GWQOrHuXI6o2uT8CLhe6ts4Tk1E88= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774382935; c=relaxed/simple; bh=hgtx5DhPOKPCho9c0wl9Kivlyh35wDQGK0eH+R5yiZE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hbHhDgSDp56GKssB5zBmqj+kw6cHNT2/J1gnT9TmTmWl9Mh2XXk1ujtF0qL36DvUTyfFn6wG7dmFRelGlv0X4G+AY3pmxTfNFNeVAaV4deNAFSt0y2anxit2x6I3Dp6uSK53iRBDZiRiXbLZNnt+wRVCBnKIcS/xI0W547OKGuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=IYs1ln2m; arc=none smtp.client-ip=209.85.210.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="IYs1ln2m" Received: by mail-pf1-f226.google.com with SMTP id d2e1a72fcca58-82ae379000fso121447b3a.1 for ; Tue, 24 Mar 2026 13:08:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774382928; x=1774987728; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1Pxxzbypf53pxP6inFxYsPbLMyq3tzwpCDDjX0r9z0Q=; b=HrnxezqGGKMugytm4L8D65m7k3RKjhtizBiMU+MC4fb/mfZUT9HPBXTAIBBB2I6A0y sdl6GQ48TeSEAr9G1vHlv0YM3uDRQCERn/0/5aTbxTXZdo9aWiXktfLf8J/64WR2WOu4 wcn2k2oe0FVhmxCyJMY1wq7O3Spw5MEPq6iAgvQv+asQGcldb2iACUYnxEE7bT3wL6tt vBu/1fYbL2W6xmrI7K+nOAIoXibV1cYo1kKtQANOJx24PWcUY8OlwwDb5emk4Z0hm9oz OelHMX13FBhKLk4O/kPOgkOerhIhcno4z4nQWruElbIwjKiesuDxZoLzxgx5kxJiKBUz 7sng== X-Forwarded-Encrypted: i=1; AJvYcCXdegjAZyoSxWgCFJtTfE12bXcWdBtXgCKPXJ0eobZThqxNVUC2ljgFjvo4z4brz0c629Df3iDX5F74bjU=@vger.kernel.org X-Gm-Message-State: AOJu0YyrZspO7cJkSu/4xAKbnEh7l4C0SMUnY464OUWdNNs2+MG1Y/0j GnE4cTJvcSiIUU9w8R8gWrLGNSTQPM9rnlcbxWuqiosH8sIDx+r15MenFNOxuoVCKZqKPxY4gnU 3Yiiyy0kF9hRoK5XJZgej+ls6D15b4Z8VqcCconqMAKWBQc7apjCiRW3l7rVk9+TsV93YkEUo2F M609PuYcqiX01zLpt1Xz+cQpL3s2nT7SFyWaqZe74PFZzi/DrBvbzsog1GM7uzbS+VWtYJ4Y+zQ Mc87f+qVw+rORLvL0DIm5sAkg== X-Gm-Gg: ATEYQzzdlMMHZO0PK4bgznGf9wCEDJGpEwYffZZth0nyiAUG+MTdFG1LVKJn9Pvl96r +sJKB0vrKWTN0e6cxnH/Fu+UqGNz4IbWpiCe6IJl3xr77aXHbt7wT9RG9p+DEmvnVPwTLPh8pah lxmTrUltK9+fcU0RUUvfxmG2W4yBw7wmFjLaVxFWx4d0P8Atq/Oe2kpZNobT+dlwwU8tcvEkyEq ruHD2J0J+PWNB40YcqEBk97FIN4g97g3LOMfTXAKdRt7gUjt8lZLbLeOgXPfLvgPOpTn7FKJEe0 tTePP+qDXRe58jSQ99D4KPU7AtvnN1N8EmUt1YaatV0iTl8ijeFCFKCIRpJhInctA3oPl/T2flh Jt37tHr6E39nWt9k1MZ4iX35JB7wdxnFCB7uhwXUT2jTvzIL3LRnI9HWOKLtHqy9K4wie7kfxsL 8XaKcU4RKCIw0JhS06WZLf4z7031hzjgRXG50U9YIYduutZmf2+u3AjpNieEV4Qjn/cw== X-Received: by 2002:a05:6a00:b4f:b0:823:1bc7:ffd8 with SMTP id d2e1a72fcca58-82c6d888801mr923315b3a.9.1774382928136; Tue, 24 Mar 2026 13:08:48 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-102.dlp.protect.broadcom.com. [144.49.247.102]) by smtp-relay.gmail.com with ESMTPS id d2e1a72fcca58-82c6a3e2291sm127673b3a.5.2026.03.24.13.08.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Mar 2026 13:08:48 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c741a9ef5f0so174519a12.1 for ; Tue, 24 Mar 2026 13:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1774382926; x=1774987726; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Pxxzbypf53pxP6inFxYsPbLMyq3tzwpCDDjX0r9z0Q=; b=IYs1ln2mpRDXQqpagkLPUcMS3ZBJb2auA6OZesSGniCFhlJsWWzPY7nJAInbwz811A PI/kKeIijYYmBoKgGbOnIhGJY/kSuMqHvFjJfj7s++6t0p8/PwMIBZaJ+pHNJXpQ8WTF B4KZQ6JU3DBrw5AMZjsM8P1erezmWfmCI+a94= X-Forwarded-Encrypted: i=1; AJvYcCWLP7RCGJwCrTaDK7ecw1BN2tgXFvJeq1X0ZUZy7+EktnOIYl+vf1VKbmsUvZNwEDU1ngHOvnPSBOLnHzM=@vger.kernel.org X-Received: by 2002:a05:6a20:3d19:b0:39c:212c:9088 with SMTP id adf61e73a8af0-39c310290femr4590678637.20.1774382926385; Tue, 24 Mar 2026 13:08:46 -0700 (PDT) X-Received: by 2002:a05:6a20:3d19:b0:39c:212c:9088 with SMTP id adf61e73a8af0-39c310290femr4590635637.20.1774382925594; Tue, 24 Mar 2026 13:08:45 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c743a80163bsm9930057a12.1.2026.03.24.13.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 13:08:45 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rahul Gupta , Ajit Kumar Khaparde Subject: [PATCH net-next v9 07/10] bng_en: periodically fetch and accumulate hardware statistics Date: Wed, 25 Mar 2026 01:37:37 +0530 Message-ID: <20260324200740.346029-8-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260324200740.346029-1-bhargava.marreddy@broadcom.com> References: <20260324200740.346029-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Use the timer to schedule periodic stats collection via the workqueue when the link is up. Fetch fresh counters from hardware via DMA and accumulate them into 64-bit software shadows, handling wrap-around for counters narrower than 64 bits. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rahul Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 90 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 91 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index b03a9f186b97..8e59935c6826 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -313,9 +313,93 @@ static void bnge_timer(struct timer_list *t) } } =20 + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bn, BNGE_PERIODIC_STATS_SP_EVENT); + mod_timer(&bn->timer, jiffies + bn->current_interval); } =20 +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp, sw_val; + + hw &=3D mask; + sw_val =3D READ_ONCE(*sw); + sw_tmp =3D (sw_val & ~mask) | hw; + if (hw < (sw_val & mask)) + sw_tmp +=3D mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *= masks, + int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + u64 hw =3D le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] =3D=3D -1ULL) + WRITE_ONCE(sw_stats[i], hw); + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats =3D NULL; + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr =3D &bnapi->nq_ring; + stats =3D &nqr->stats; + + if (!ring0_stats) + ring0_stats =3D &bn->bnapi[0]->nq_ring.stats; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats =3D &bn->port_stats; + __le64 *hw_stats =3D stats->hw_stats; + u64 *sw_stats =3D stats->sw_stats; + u64 *masks =3D stats->hw_masks; + u16 cnt; + + cnt =3D sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + + hw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt =3D sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + static void bnge_sp_task(struct work_struct *work) { struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); @@ -328,6 +412,12 @@ static void bnge_sp_task(struct work_struct *work) return; } =20 + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bn->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } + if (test_and_clear_bit(BNGE_UPDATE_PHY_SP_EVENT, &bn->sp_event)) { int rc; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 74b08d492c53..548c5a77e76a 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -276,6 +276,7 @@ enum bnge_sp_event { BNGE_LINK_SPEED_CHNG_SP_EVENT, BNGE_LINK_CFG_CHANGE_SP_EVENT, BNGE_UPDATE_PHY_SP_EVENT, + BNGE_PERIODIC_STATS_SP_EVENT, }; =20 struct bnge_net { --=20 2.47.3