From nobody Sun Apr 5 07:34:52 2026 Received: from mail-pj1-f97.google.com (mail-pj1-f97.google.com [209.85.216.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0A053446CA for ; Tue, 24 Mar 2026 20:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774382947; cv=none; b=mPSWKOqCvQ3RXqqDpACauBEo2HpjHrC1lsPjUECd3go5HanOcce2rxZk72rmEnY+OcwA8H74PhmG2QuOE0z0DKq3Ow+pzXEI+zbibrBZDmpRxpI6KPz5tANhDHei+t7QLmkJnRiaJVHHUuPw7LDfPCsy8SNvsmM23VTHjTLljtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774382947; c=relaxed/simple; bh=sAbjxlT8qw0sGpgqfVE0LsFirVoFkcAmYurDavAIbMY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bcip+5z2iDsbvh9DRZO4V0c/eFcIH7ecAwACrWF/wr+E+fx1rvBjSqoMoJg9vJc/NaP3oCqL6bQbSEiOKN4n1G2c/tUa//IcsFYor1R620dXU0mPvgFLnhuB5ugyAEvehms4F6r4DVUjxZh46x6cqzxv4inHC8zSgCci2m8bJiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=PBvzrSz0; arc=none smtp.client-ip=209.85.216.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="PBvzrSz0" Received: by mail-pj1-f97.google.com with SMTP id 98e67ed59e1d1-35a09e0dd63so5714004a91.3 for ; Tue, 24 Mar 2026 13:08:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774382937; x=1774987737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9WA2sjF6rw0bDaGzqjV8DfWH5m3/PdSYizc64vpfSjY=; b=MsgoSjoH4jFV041C5zln2lBGzADQCQwp2DP4d2s+Tzzw1sGHql0ngx0cGSyGinsvhx 8JMn/0gW5GtvvrrYregPcndzDKsL0KUKZYIhwoNCNERNzZAaanIZmHEA0JIak3+p/JzN hNUaFvWGn069r3NeTb+uMXZvEehoFUAQ2FUlP9MixpgDtJw07azjkFtqjESBlnsEL9W0 jgFQesxciRhIFubNIYJdBpV43ptJ+e3TY0Qi7PP+K7UMMJVaq2pRaY6TihdN3HJ9ydvJ UeiVd5q/JLdXlvwsCBXD5jxYnompoFGNCz3w0gYWxv9ncI5UXna9LgeY5xbIHWrKGX2C XR3w== X-Forwarded-Encrypted: i=1; AJvYcCX+np/zhUSWtaV4DcIx8HrTHusTjgJ5E9YqovhumVBr3NatXcJVjno1wtzzJaeSfst5G8shTkEmsIqTCwE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3ka6voY0EZkxynXUX/wHcJSisSjYQemdvgV5SAGFs38qyXpOf PUIPLek0INHQXTZ0UmD+9w6Lu3AQIFZhWO8YD4evqOeBWt/NDlmgwDscTvhAVUApJ332CxhgBz6 19zAS0rHvsqyaGKs/zTryjtqYY5yqvpKrOGJNpWA0xA3f0/WulyGjRNVHGVAeQvnVCygpM6Ft+v CftHoIDeCpCX3c4zVVeFy2ocUwcdHKZYVcteFZfX7m865YW9EfF3v+8i0wQ9UWd6UTxMBuwAmfo w607uWaElOh2uqGfgwoPGmffg== X-Gm-Gg: ATEYQzwaDHV52C1fyRZuEo4r9EmXwZrXZH+5ePhFMOvsQ+sT8zMjaOOOZZHds4JpfHj B7lZxTuJK7ai0q3lMuwpfQ2YGUQbLOhyiS5nUHb5kq7wNvT18Me2fPaq//CNK64Hgh3GsRKr6GW d5UFDg4gG3Hu2HSXf3g2+AHlo5i627YTbe5dzwW3/IEgTqi+PkpsW51I6nIz8wvyWrmn103F9Us x/dCbijN+Pk+7Qb7ZEmQRrIbOQpmJaxmVaph/3b0k5OQk38UGMfP1cyHFHs2kbas59RGpKlj9L7 VMNR1oE/mA3+Y0NsbE8UJZVLobFHi0BDQE73WQpKlY5OQsNdbab0ZtfPliTVz3C4OmFktBBAFG+ G7EQ28FqY2TPkKSmj6se25b2lKYX/MxuT7Cyif45d4h+T0tTDUFZ+ebDIdV64hoBxNSzj1KT20H llocPgmrzGko55UZCRBHb58ylOU/XqjCm0W7c9NNDhzBJQT/DeanuWwUee6y9kHIPBZQ== X-Received: by 2002:a17:90b:2e49:b0:35b:a8cf:7960 with SMTP id 98e67ed59e1d1-35c0dc6276fmr602956a91.3.1774382937230; Tue, 24 Mar 2026 13:08:57 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-35c031df0efsm317368a91.5.2026.03.24.13.08.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Mar 2026 13:08:57 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c70dd30025fso19081887a12.2 for ; Tue, 24 Mar 2026 13:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1774382935; x=1774987735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9WA2sjF6rw0bDaGzqjV8DfWH5m3/PdSYizc64vpfSjY=; b=PBvzrSz0kpgZhwjPG2jTY7mL4B3VoJyd+biOyXquqKscZBKKrkuW/Kj42wa9e9dTrN UWRbeBmihY+3zbMe4snjFi0g4qXS/zST/9gvdYKBW3HTEl3KipH5nAjEOFnZmXByfeoI tjDJUeX9vkOjyuklMdhfs7mQfmU9/upidbHSE= X-Forwarded-Encrypted: i=1; AJvYcCUOv22Wdf0HBhi1Tz10LWupYzdH8qx4/QuHD1lY2XXj1Uo+tkdAzmOB1mb5reGsE6Z9ZoQLPtWYcBK7H1g=@vger.kernel.org X-Received: by 2002:a05:6a20:3945:b0:398:8db5:40fe with SMTP id adf61e73a8af0-39c4aa06d99mr1072346637.7.1774382935513; Tue, 24 Mar 2026 13:08:55 -0700 (PDT) X-Received: by 2002:a05:6a20:3945:b0:398:8db5:40fe with SMTP id adf61e73a8af0-39c4aa06d99mr1072304637.7.1774382934620; Tue, 24 Mar 2026 13:08:54 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c743a80163bsm9930057a12.1.2026.03.24.13.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 13:08:54 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy Subject: [PATCH net-next v9 09/10] bng_en: implement netdev_stat_ops Date: Wed, 25 Mar 2026 01:37:39 +0530 Message-ID: <20260324200740.346029-10-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260324200740.346029-1-bhargava.marreddy@broadcom.com> References: <20260324200740.346029-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement netdev_stat_ops to provide standardized per-queue statistics via the Netlink API. Below is the description of the hardware drop counters: rx-hw-drop-overruns: Packets dropped by HW due to resource limitations (e.g., no BDs available in the host ring). rx-hw-drops: Total packets dropped by HW (sum of overruns and error drops). tx-hw-drop-errors: Packets dropped by HW because they were invalid or malformed. tx-hw-drops: Total packets dropped by HW (sum of resource limitations and error drops). The implementation was verified using the ynl tool: ./tools/net/ynl/pyynl/cli.py --spec \ Documentation/netlink/specs/netdev.yaml --dump qstats-get --json \ '{"ifindex":14, "scope":"queue"}' [{'ifindex': 14, 'queue-id': 0, 'queue-type': 'rx', 'rx-bytes': 758, 'rx-hw-drop-overruns': 0, 'rx-hw-drops': 0, 'rx-packets': 11}, {'ifindex': 14, 'queue-id': 1, 'queue-type': 'rx', 'rx-bytes': 0, 'rx-hw-drop-overruns': 0, 'rx-hw-drops': 0, 'rx-packets': 0}, {'ifindex': 14, 'queue-id': 0, 'queue-type': 'tx', 'tx-bytes': 0, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 0}, {'ifindex': 14, 'queue-id': 1, 'queue-type': 'tx', 'tx-bytes': 0, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 0}, {'ifindex': 14, 'queue-id': 2, 'queue-type': 'tx', 'tx-bytes': 810, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 10},] Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 76 +++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 3c624f528545..797c02224c03 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -3040,6 +3040,81 @@ static int bnge_close(struct net_device *dev) return 0; } =20 +static void bnge_get_queue_stats_rx(struct net_device *dev, int i, + struct netdev_queue_stats_rx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_nq_ring_info *nqr; + u64 *sw; + + if (!bn->bnapi) + return; + + nqr =3D &bn->bnapi[i]->nq_ring; + sw =3D nqr->stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->hw_drop_overruns =3D BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + stats->hw_drops =3D BNGE_GET_RING_STATS64(sw, rx_error_pkts) + + stats->hw_drop_overruns; +} + +static void bnge_get_queue_stats_tx(struct net_device *dev, int i, + struct netdev_queue_stats_tx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_napi *bnapi; + u64 *sw; + + if (!bn->tx_ring) + return; + + bnapi =3D bn->tx_ring[bn->tx_ring_map[i]].bnapi; + sw =3D bnapi->nq_ring.stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->hw_drop_errors =3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + stats->hw_drops =3D BNGE_GET_RING_STATS64(sw, tx_discard_pkts) + + stats->hw_drop_errors; +} + +static void bnge_get_base_stats(struct net_device *dev, + struct netdev_queue_stats_rx *rx, + struct netdev_queue_stats_tx *tx) +{ + struct bnge_net *bn =3D netdev_priv(dev); + + rx->packets =3D bn->net_stats_prev.rx_packets; + rx->bytes =3D bn->net_stats_prev.rx_bytes; + + tx->packets =3D bn->net_stats_prev.tx_packets; + tx->bytes =3D bn->net_stats_prev.tx_bytes; +} + +static const struct netdev_stat_ops bnge_stat_ops =3D { + .get_queue_stats_rx =3D bnge_get_queue_stats_rx, + .get_queue_stats_tx =3D bnge_get_queue_stats_tx, + .get_base_stats =3D bnge_get_base_stats, +}; + static const struct net_device_ops bnge_netdev_ops =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, @@ -3203,6 +3278,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bd->netdev =3D netdev; =20 netdev->netdev_ops =3D &bnge_netdev_ops; + netdev->stat_ops =3D &bnge_stat_ops; =20 bnge_set_ethtool_ops(netdev); =20 --=20 2.47.3