From nobody Fri Apr 3 10:18:21 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A569D2F83B5 for ; Tue, 24 Mar 2026 19:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774380626; cv=none; b=BoxLtk63QmF5afXcuzT48+JqcPAAAVi8y1+vfWgX1G9HhZ7+dhvwDFDugD2CSueVPnnL6GWeOKu3qTruHWn/5yrI2xFfLsurpS1LCh9pYe2cQs8eQ5Z1fVQHr3bJP1jYrompgPfD9kIql9+CqEBxdJ0oVKE/1t+FZ82XOG0IIVo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774380626; c=relaxed/simple; bh=tAIXeDCNByqCw5z/f5mAXfeb5SSuanCsZ35iifvnizg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=k0YEK41eW/HV+/0ioju5hvudfg4rNr4y2bQNck0ziIcEf1F/WHPlWXS1zpUMy+IDdjiXhgSb6x0/+L7JXRxiv2cqX+OPV7wlPbbD5KM2tcfz1zvvGWQHFqXJ1Od0TsQ4pkLmIMihcVuKq5L5VLXxs9Z28KA9HeEYX5XoZizCgnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ON/ulE09; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ON/ulE09" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4870206f73bso24810805e9.3 for ; Tue, 24 Mar 2026 12:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774380623; x=1774985423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4NWl+nIdcZDyj9SaWGNpDFXb3knx3+VKeGhhxFBSjxc=; b=ON/ulE09xZ7GTdjIXMwJQrMaEGG0CcFfZfJC4PR5Ihd7BRwQ1i9IV+7KS3YaYtHqJy 47n3b44soqY/Nfo9VvKb4ZV9DKSRMWGrC2xU8lzrETH1EsPS0TXiwSwxbm5tEParofEL TwDuBXRXJlUjhz7VBgN7Ufd3/1YqbUb+JU0U0fmt1f3Sgut+sbqFrak1If/JV3uH1T0h ulPWCQenhrKn5yuDvc41UtkllBIzZxipCmhZT1V8MBFJgjNdQNncJYv0a1hiGzN/itHh 4sogggrKqeoiY3iThsYaJCcoZFENHudK+niwZmx2eKim+ZBVV9r1C9/AybcRw2NkAAhH d5pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774380623; x=1774985423; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4NWl+nIdcZDyj9SaWGNpDFXb3knx3+VKeGhhxFBSjxc=; b=bma03kn3siK4hoQ1UwtXmQyVjdBy2DKwGx56kVPdpO08ez54fPBaGqKqOQGSPmKGKb aQtOxvNK2RQVVfDcw8PxK8G+YC1W/3UrlXi+XxTrdC9+63KL949N7rmQAYYwuSPnldl4 ojG2MwJ5Qh8EUCCTMqcsGbAXTRscABMvUmdJO8/aOubSdun2Q7P335ZNXwrvIqN+pMkk IVMOheAtoaR7s8ndzAZmEs738wF7Zt7owyrYaaJVdx4MjOqElRIaBF8CO/oeuGnyBitu M6F/+m+R6p+SfvNrNboYWna8NJzaF0YdS1yXcJK2wO8W1seyjcBucpDwjIRfeRCbUXd8 tXyg== X-Forwarded-Encrypted: i=1; AJvYcCVvvmQKB7I7kFWjPPN6HmXlIfH2sLiUqISmAtLRmGSZdt6F+nflrRzFYfHlsh8ldSH4eSo0TEI1SljGr9U=@vger.kernel.org X-Gm-Message-State: AOJu0YwAnxmtdnkI2+h3g62pnQ2nl7jn8ymnpsHDitS+V/HRtPygpj+n ++jkH0KbE/kny50g/jLnTYKsW5ucKsZ2EEw4GEcNPTiamcTVXF7SuQEB X-Gm-Gg: ATEYQzzr/8uhi6f90wfSqRkMFplPJtgfWfNPhIwH8t3XwEDcQfGp3bQeg/XlWjph2W9 rsl4DITZIy/vyYGmYbg5LJMlnUFJWc51Cxfc5iGYhGyGuVawKNrOvo0HUIl6zZeruC75w4OVmOF QIBXTg9SB2wwAvOhscI3fCPpdGXsvmvSgIZii6fDEtTdLm2R6H/B8AHSUyPoKiECDnliqFRuyhR VzsKAjvdPGufeJWv/1EvPwGstPetR82Af7i48auf+fl+i+cHUO8hEB1bXpPDwKgO50m1iebJa5H 2ZhbgqdHhT8+rb9lPcgBRl2muLPKZ2SwlxpyVP9tJRHM1J9X1GFLWElRTsPA+THAUZ+YOhSc/DI aQDANgwia4zi7M3xp+EOT6iPSp+KD7jtSsFfPpmQQq62lt3QXYJGssPaZofHLPYDWYj9HZnFXX2 yEKV57TxeUyKGYXxKArlzNDOxghPbpo/0Cv2yiLR//t9lwmpCmTn6VClFdME8L3RUEiUGeqYgF4 pWQA/BW7hXKWR8ovPrk8frUjnSgpw== X-Received: by 2002:a05:600d:486:20b0:487:386:3714 with SMTP id 5b1f17b1804b1-48716043919mr10455905e9.17.1774380622686; Tue, 24 Mar 2026 12:30:22 -0700 (PDT) Received: from localhost.localdomain (lfbn-nan-1-1836-142.w90-104.abo.wanadoo.fr. [90.104.252.142]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48717373ef3sm737135e9.26.2026.03.24.12.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 12:30:22 -0700 (PDT) From: Julien Chauveau To: Phong LE , Neil Armstrong , dri-devel@lists.freedesktop.org Cc: Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Julien Chauveau Subject: [PATCH] drm/bridge: it66121: acquire reset GPIO in probe Date: Tue, 24 Mar 2026 20:30:11 +0100 Message-ID: <20260324193011.16583-1-chauveau.julien@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The it66121_ctx structure has a gpio_reset field, and it66121_hw_reset() calls gpiod_set_value() on it. However, the GPIO descriptor is never acquired via devm_gpiod_get(), leaving gpio_reset as NULL throughout the driver lifetime. gpiod_set_value() silently returns when passed a NULL descriptor, so the hardware reset sequence in it66121_hw_reset() is a no-op. This leaves the chip in an undefined state at probe time, which can prevent it from responding on the I2C bus. The DT binding marks reset-gpios as a required property, so all compliant device trees provide this GPIO. Add the missing devm_gpiod_get() call after enabling power supplies and before the hardware reset, so the chip is properly reset with power applied. Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver") Cc: stable@vger.kernel.org Signed-off-by: Julien Chauveau --- drivers/gpu/drm/bridge/ite-it66121.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/= ite-it66121.c --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -1559,6 +1559,11 @@ static int it66121_probe(struct i2c_client *client) return ret; } =20 + ctx->gpio_reset =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(ctx->gpio_reset)) + return dev_err_probe(dev, PTR_ERR(ctx->gpio_reset), + "Failed to get reset GPIO\n"); + it66121_hw_reset(ctx);