From nobody Sun Apr 5 13:12:18 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013027.outbound.protection.outlook.com [40.107.201.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A84263B19D8 for ; Tue, 24 Mar 2026 19:10:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.27 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774379445; cv=fail; b=qGPNez6frvNALoMiz3JYKUjvMRhE0Pt8HIDc4tGl7XTYZ2nMIZR22bz597qbqh0Y2xU/ZM6s9+/CdiLD4uqUVlbL9l9I5OyayYE9jBzHo4JqA7SAWEkhgR6Pdxv5aXITYLxsESiVXvFgaqeQLbelJRA9Kl1LwuNJCaX8cM7mHaY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774379445; c=relaxed/simple; bh=qTeUH/zQLlsLIPD+XD9uAwbK1vQyY8StjXEH+MAaQiU=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=E/cgpeoCJ4oDsBB0n6yeo8HHVgQ6cKnZBfa4iLXVcDp1FtNuznQOfSbd76uzVsZ+Oz4lJynmU7pa6W5l2l2Zmy6//9YtBCf82vTcKAPdx3Tqgd4S+WF1A5faH2AUHDfdfwnsGyiF1nu1KQMNcM76MnMRbViDk1G5cZqFzRzBu0c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=3FjW5Y5m; arc=fail smtp.client-ip=40.107.201.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="3FjW5Y5m" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eyydmWCua/+i11tpxISqwF2xwtQdEk3h956RAMtdNzgL2WTVoOriWn8r/xusobaMtFi7XJhiLHWirAe5OJwxmQHxOIhYKV4bvkTomRK0supHcN79UGwkgue9oH4NeFCEA/LT479SgbW9kvuRt5x1SupYA+oOC/XydTL3Oj/axVyqFIlawmwJizhoSv7wFjsJtGmw6S7Uy4jAKr/vtroNKmwPpjzUHUOg+ixtxE05zfDENPS83HPjcHe2KHC3nrxOUxEv+W/pv+KmnRtHrrV7qa2z64WkKPDeNv5Qkum5N+PAswe4o+GyN7EHJtgVU8kui1kLmf2Vgj98lgKOs07ZeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L42njNdkn0g2Z2EwxODJrKHlsvLi4r74QZXuLpsoVWY=; b=QZKxkkztsHwj5qDQNOkFySHuoq4E8inBb7cSmMPsIRFw/PBSDNmmYwbGks7/pitycMVl6GKNjw/LskiQYFm7eEgzvKWm1ofvHBf0gsfwl4Z5S+bX/uF8az4/ZM1H2vDipD4+Ik4dbxeiyxlD1gaIcpKpXfBCdfbHXXtC/opi+pt34GapzSuaHyk3bdKFy8RDzQwCKSXV40oEA1GPbikAoFHPsT0qZN7v5rz5EeLVNQT8frGRrCBIAilS0Xoe2sCGcWjPBbmW6/kGuKto5HVT/Ef9Bs2nWYfEugy/PXu00l4gnfchm5xeXDMdnLU9JiM1IJ0afWd7l/nOyt82A79b7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L42njNdkn0g2Z2EwxODJrKHlsvLi4r74QZXuLpsoVWY=; b=3FjW5Y5mUCBUUdCCF+MgQqA9TafbOddIHQNFPmPpFBKqVn05PgAG2O5Srj3aIx9hbg81lEyTDCumpI6+N63g3mVWYUytDQrXCjiDHAt0N/GXte1CNuZPkqONVjME6GV9c6esl4Ua7fczXNEYGrGqXszA48SrzSILWvZ6lPGbiZA= Received: from BYAPR11CA0042.namprd11.prod.outlook.com (2603:10b6:a03:80::19) by SAWPR12MB999139.namprd12.prod.outlook.com (2603:10b6:806:4e0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.15; Tue, 24 Mar 2026 19:10:38 +0000 Received: from SJ1PEPF000026C7.namprd04.prod.outlook.com (2603:10b6:a03:80:cafe::9b) by BYAPR11CA0042.outlook.office365.com (2603:10b6:a03:80::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9723.31 via Frontend Transport; Tue, 24 Mar 2026 19:10:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF000026C7.mail.protection.outlook.com (10.167.244.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.19 via Frontend Transport; Tue, 24 Mar 2026 19:10:38 +0000 Received: from kaveri.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 24 Mar 2026 14:10:34 -0500 From: Shivank Garg To: Andrew Morton , David Hildenbrand CC: , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , "Alistair Popple" , , , Shivank Garg Subject: [PATCH v3] mm/migrate: rename PAGE_ migration flags to FOLIO_ Date: Tue, 24 Mar 2026 19:07:09 +0000 Message-ID: <20260324190706.964555-4-shivankg@amd.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C7:EE_|SAWPR12MB999139:EE_ X-MS-Office365-Filtering-Correlation-Id: 6223ff2f-289e-49eb-2168-08de89d9090c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|82310400026|36860700016|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: VwJ+c9iTxJvpJxzn0YPVy56diRIP63+xZo23gGQu6HdIOKxDSs+CECH5zZhusCfZjVJ4xd7Xh+wXlr/HXWaILARgUBfnO2OIBWqEDzXAcGWOfNTOk/UrJnrgI0kLtFFTR57IXTkYRSCL0L7k8oaZM3v7UHwWgzcpuW7a4WtaaWWNalfQY71kpuRuYqdQPNfzI3ibcgtrYXc5vfgRiuYgT2SBrOcr0EfR3pJSdT+s+MEIf/1H29FL5QUM2tIJKlc8/2JAVFkUO0aGYgyZ+In4stu+EfSjd6+NuFk5UzemyJBQFaO+lq7t+O/H4IHmayzC6V0ZkxSn2362FIWxeb5pSFRh0zZEl/aC6YC1G5/NGLMhVQ6+CIZG9WMBQhGNkwGr49hDBmNIPijwSqAj1fB7lcmDjPfgesNxijIZLCNvZ4VGg3JeBPCc4Hfsm9N3jTR4QJU8203/bqQA1sf/G4+Y4D3qy8Gb9EAjvmlS0nDUoAN1sTzHno/d8AOunF3OAPNr+Y03YV5bvRop4EK4O9Ky2ujMRspOHKBnUCRCJwmrffGWr2IN7EFL2WLt5A3it0ZPqAmBtj2z52eTlCpX92+TXYcWq7JhiHXMCepMW9W2Q8RFaIeLfkw/EnDYot6Inn48n+EjirtpqqZBBwC3TGuQ7+Pmbg3xRWRrbZc148wfhpl8WI8rG6GduV3KriKMPub0bd2XK0xT184OcA66lhOITzm25mfief9v//DuFKWlR1FwtR01E9fImCQld4ViMImqcG/1ci9nb2V1K9oHvqjjDA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(82310400026)(36860700016)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5Kd+BZuidaDi9rMM7raJ/65/0iCLYEedvFYjA5hnPpmiMbCDpSf1OoOL+H0w2a5GKXJi71Iegb/6cZ4IrYItuFSyqo+0Sk0yZkRjWHM/DqaAOLGiW/k+PW9BdDTMBNRYSXcdIS1iJAtCl888UwN7TyXK5msoexGetfFKcgfCsDLk4+R8at/dwTOBg+2QzRMUuT2BDuuMgkFJWFXGNfTZICR7O58WIkf/IODdrLqzbHTIOGuDMe3eVOg2n9CH+JnqpOho0uo7TXQQG3il+ETem37B6hx0UM2b8tn287EuHRrkxY6vk0s20vkkUpJoR8ereioLAHEwFwamoEJZYNE7wB9uyzpWIg8Cxg0GdVeKHh0KIbhPWuacQMQYavDUUooTANahYq+8LXRpwtVm2OvRHFVhIGBJhmGNqo/HW72Ql7X0UZucwQMuyeBovdrKagBD X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2026 19:10:38.4803 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6223ff2f-289e-49eb-2168-08de89d9090c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026C7.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SAWPR12MB999139 Content-Type: text/plain; charset="utf-8" These flags only track folio-specific state during migration and are not used for movable_ops pages. Rename the enum values and the old_page_state variable to match. No functional change. Suggested-by: David Hildenbrand Acked-by: David Hildenbrand (Arm) Reviewed-by: Zi Yan Signed-off-by: Shivank Garg Reviewed-by: Baolin Wang --- Applies cleanly on mm-new (02b045682c74). v2: https://lore.kernel.org/all/20260324114720.864478-2-shivankg@amd.com v3: - Change to two-tab indent (David) mm/migrate.c | 48 +++++++++++++++++++++++------------------------- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index 05cb408846f2..6d4a85f903d8 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1135,26 +1135,24 @@ static int move_to_new_folio(struct folio *dst, str= uct folio *src, * This is safe because nobody is using it except us. */ enum { - PAGE_WAS_MAPPED =3D BIT(0), - PAGE_WAS_MLOCKED =3D BIT(1), - PAGE_OLD_STATES =3D PAGE_WAS_MAPPED | PAGE_WAS_MLOCKED, + FOLIO_WAS_MAPPED =3D BIT(0), + FOLIO_WAS_MLOCKED =3D BIT(1), + FOLIO_OLD_STATES =3D FOLIO_WAS_MAPPED | FOLIO_WAS_MLOCKED, }; =20 static void __migrate_folio_record(struct folio *dst, - int old_page_state, - struct anon_vma *anon_vma) + int old_folio_state, struct anon_vma *anon_vma) { - dst->private =3D (void *)anon_vma + old_page_state; + dst->private =3D (void *)anon_vma + old_folio_state; } =20 static void __migrate_folio_extract(struct folio *dst, - int *old_page_state, - struct anon_vma **anon_vmap) + int *old_folio_state, struct anon_vma **anon_vmap) { unsigned long private =3D (unsigned long)dst->private; =20 - *anon_vmap =3D (struct anon_vma *)(private & ~PAGE_OLD_STATES); - *old_page_state =3D private & PAGE_OLD_STATES; + *anon_vmap =3D (struct anon_vma *)(private & ~FOLIO_OLD_STATES); + *old_folio_state =3D private & FOLIO_OLD_STATES; dst->private =3D NULL; } =20 @@ -1209,7 +1207,7 @@ static int migrate_folio_unmap(new_folio_t get_new_fo= lio, { struct folio *dst; int rc =3D -EAGAIN; - int old_page_state =3D 0; + int old_folio_state =3D 0; struct anon_vma *anon_vma =3D NULL; bool locked =3D false; bool dst_locked =3D false; @@ -1253,7 +1251,7 @@ static int migrate_folio_unmap(new_folio_t get_new_fo= lio, } locked =3D true; if (folio_test_mlocked(src)) - old_page_state |=3D PAGE_WAS_MLOCKED; + old_folio_state |=3D FOLIO_WAS_MLOCKED; =20 if (folio_test_writeback(src)) { /* @@ -1302,7 +1300,7 @@ static int migrate_folio_unmap(new_folio_t get_new_fo= lio, dst_locked =3D true; =20 if (unlikely(page_has_movable_ops(&src->page))) { - __migrate_folio_record(dst, old_page_state, anon_vma); + __migrate_folio_record(dst, old_folio_state, anon_vma); return 0; } =20 @@ -1328,11 +1326,11 @@ static int migrate_folio_unmap(new_folio_t get_new_= folio, VM_BUG_ON_FOLIO(folio_test_anon(src) && !folio_test_ksm(src) && !anon_vma, src); try_to_migrate(src, mode =3D=3D MIGRATE_ASYNC ? TTU_BATCH_FLUSH : 0); - old_page_state |=3D PAGE_WAS_MAPPED; + old_folio_state |=3D FOLIO_WAS_MAPPED; } =20 if (!folio_mapped(src)) { - __migrate_folio_record(dst, old_page_state, anon_vma); + __migrate_folio_record(dst, old_folio_state, anon_vma); return 0; } =20 @@ -1344,7 +1342,7 @@ static int migrate_folio_unmap(new_folio_t get_new_fo= lio, if (rc =3D=3D -EAGAIN) ret =3D NULL; =20 - migrate_folio_undo_src(src, old_page_state & PAGE_WAS_MAPPED, + migrate_folio_undo_src(src, old_folio_state & FOLIO_WAS_MAPPED, anon_vma, locked, ret); migrate_folio_undo_dst(dst, dst_locked, put_new_folio, private); =20 @@ -1358,13 +1356,13 @@ static int migrate_folio_move(free_folio_t put_new_= folio, unsigned long private, struct list_head *ret) { int rc; - int old_page_state =3D 0; + int old_folio_state =3D 0; struct anon_vma *anon_vma =3D NULL; bool src_deferred_split =3D false; bool src_partially_mapped =3D false; struct list_head *prev; =20 - __migrate_folio_extract(dst, &old_page_state, &anon_vma); + __migrate_folio_extract(dst, &old_folio_state, &anon_vma); prev =3D dst->lru.prev; list_del(&dst->lru); =20 @@ -1395,10 +1393,10 @@ static int migrate_folio_move(free_folio_t put_new_= folio, unsigned long private, * isolated from the unevictable LRU: but this case is the easiest. */ folio_add_lru(dst); - if (old_page_state & PAGE_WAS_MLOCKED) + if (old_folio_state & FOLIO_WAS_MLOCKED) lru_add_drain(); =20 - if (old_page_state & PAGE_WAS_MAPPED) + if (old_folio_state & FOLIO_WAS_MAPPED) remove_migration_ptes(src, dst, 0); =20 /* @@ -1439,11 +1437,11 @@ static int migrate_folio_move(free_folio_t put_new_= folio, unsigned long private, */ if (rc =3D=3D -EAGAIN) { list_add(&dst->lru, prev); - __migrate_folio_record(dst, old_page_state, anon_vma); + __migrate_folio_record(dst, old_folio_state, anon_vma); return rc; } =20 - migrate_folio_undo_src(src, old_page_state & PAGE_WAS_MAPPED, + migrate_folio_undo_src(src, old_folio_state & FOLIO_WAS_MAPPED, anon_vma, true, ret); migrate_folio_undo_dst(dst, true, put_new_folio, private); =20 @@ -1777,11 +1775,11 @@ static void migrate_folios_undo(struct list_head *s= rc_folios, dst =3D list_first_entry(dst_folios, struct folio, lru); dst2 =3D list_next_entry(dst, lru); list_for_each_entry_safe(folio, folio2, src_folios, lru) { - int old_page_state =3D 0; + int old_folio_state =3D 0; struct anon_vma *anon_vma =3D NULL; =20 - __migrate_folio_extract(dst, &old_page_state, &anon_vma); - migrate_folio_undo_src(folio, old_page_state & PAGE_WAS_MAPPED, + __migrate_folio_extract(dst, &old_folio_state, &anon_vma); + migrate_folio_undo_src(folio, old_folio_state & FOLIO_WAS_MAPPED, anon_vma, true, ret_folios); list_del(&dst->lru); migrate_folio_undo_dst(dst, true, put_new_folio, private); base-commit: 02b045682c74be16c7d1501563f02b0e92d42cdb --=20 2.43.0