From nobody Fri Apr 3 10:17:12 2026 Received: from mail-dy1-f193.google.com (mail-dy1-f193.google.com [74.125.82.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6D4239022D for ; Tue, 24 Mar 2026 15:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774366238; cv=none; b=pSxBBYMrLW4tSTAGYmrtUFQRJtvIXDHC9S/V1fxl+lFoDS6BuWiL3SPp0tIDSFV5fP10QrO89feazs/fRYdteZUX82AWYoufkAW9+8hd6tVFK20+1S7HEgUVYN3INrdPexKu+oKsdhVb5NaIyO8GNUqxP+4rgCvoAnX6nOa5Uqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774366238; c=relaxed/simple; bh=dLAX/MaLMsA55bQXtSczaYIpJZHd96/3ujOVO8C7BxA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lNlxgVUGQ0d5x2cZxk2HgtP+TlYBz/OaVYt02f/yQrEwIII21s3hx6YOOyFH650StzF5CArH/UYAH+DHiXCnT5HfQPc9D9qblUC0qfELRzj6bxziDVfCeQG6m3LysA7i66ZrVwAHCWC6++QXv21butCXE2oSbkrlQl8OZ4lJfTE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z3qZE811; arc=none smtp.client-ip=74.125.82.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z3qZE811" Received: by mail-dy1-f193.google.com with SMTP id 5a478bee46e88-2c10a2e2cd1so5444609eec.0 for ; Tue, 24 Mar 2026 08:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774366236; x=1774971036; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k+MnIitRRQp1/N0eopQVQ2cUe8bKDReL4QPDo76ZT4M=; b=Z3qZE811M40FVN+4GZHqncabVPR1hmqLQfgIPGpQtcwQ0A5jeBek6KxU2L1XmNTzRT kmau+it6XNyzYUvMLijadG6K1NBomCoubTbll8ju+4LpZ+T3G+cKFadTNIUkwz4NV9Qe 2urEDmtp1Kd0l2JGu1ZIQOK+jLLuoIG8e7H9xiN0vFFm9Tvvp1xlFk8+TpHsSiG2RNiG M51DrY9oKX6qt1QDGroFmirsmyMSsXsQbPZ+CS/yQTWD1OR/bEhfj/67In42yOFM/QRE R3hjRY7+U3JTJ6DxyHDhKSzLXFAd/uvKjuHzoo8QBakfmI3TKFJpvVuwoXsWiOru9dm5 9R7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774366236; x=1774971036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=k+MnIitRRQp1/N0eopQVQ2cUe8bKDReL4QPDo76ZT4M=; b=YUIgZbpKsrZtzgrkralPlOb1MiBDErtZiaKL2ag7OJ8+/41TW2aGG0rBtZyt5G4B8D qLsbmBJbJx6nnZVyp3qJBejGwEg37X2sNXNGd8v0tAHrHzLOO/FtP1dzMx28TX8KHUzA V/6bFw70Izf4fw/rYCspAFHAN1b0rI17Lal9o6CS4pwUHnX7+34kysMqOcRs4WZ5A47F 9dsct2w4CqWrYjBT9SwTMyP/Z3gbcDquHHB1AyUFnxJZQGiHve2VsfrRqO8/a8pEZbaC ht1mEiU11GsDh5a8EaB0FTX3FMSnv6CedIeNVwuk4LTFmuM/G7mBPXZHZbO8mkDTTysc Dtgw== X-Forwarded-Encrypted: i=1; AJvYcCX1dAKPrMaNfRRbstyEcqgtn0HjpZV1iMNNeTr+T/kwrhCDisbLYhzG6fRiHhmkaqB1aTHxZ5TaHG2sjYk=@vger.kernel.org X-Gm-Message-State: AOJu0YzPyXQ/8immrztSfei6TA4GCV5YS34G8OhZkLxcx5KOjpYckmQD awAFmVgtsodCxuvC2/UKFlI6DRLf5TwduTl+FVtPBqSSgRp0OWsOMcrhU+PvaLj+XMU= X-Gm-Gg: ATEYQzxhXK6B3KFW3+uhAaAipggWweTDOv63QR6V0OLQK4uXMZKskxyj4mq21aF2wU/ mB50UIQ1Aro3kYcMQgJa78+tswpQn2RWVMibPF2urv7g6aDZQX/RzDcW9raadcvyNTonE9lQ4wm GWStXvdQkXuNxQy+Yn0DEQf3HSgNL+4ttKjPCyU1kifuXEN3ZO0mcPNvrwZjI66T6NvYFT9D8h8 w2aDNQAyzL24968qSh2BNgexrJPzYz6Aj+7EzOs5VDcNyOGeH8WLhNDsjmnABmYVRUfhlQZfVhZ RKgpFM2jLelSvbml28KQ5QLDYyRde/4ZtfNFhczNT6hkiWnkQx0sno3mliy8eoy0L9TS2CFQLaF rUF4lJqCVWUcUZJLywB9qB1+4SGvpignruWdzMQD5hG0usMcuzPfCv+0/ESjG6FZv6td6cGLiTR GMM8iuNKmzh3rVq6frF+/l+W1OETwtpJ2RBnVNloOgFoH6iTWdaD8y4ex3LejGH4pFibXTMg== X-Received: by 2002:a05:7300:e2cc:b0:2bd:d04c:a430 with SMTP id 5a478bee46e88-2c1095fd85dmr9074373eec.12.1774366235748; Tue, 24 Mar 2026 08:30:35 -0700 (PDT) Received: from localhost.localdomain ([38.244.25.197]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10aefd778sm20842577eec.0.2026.03.24.08.30.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 24 Mar 2026 08:30:35 -0700 (PDT) From: Eric-Terminal To: asmadeus@codewreck.org, ericvh@kernel.org, lucho@ionkov.net Cc: stefano.stabellini@amd.com, v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, Yufan Chen Subject: [PATCH v3 2/2] 9p/trans_xen: replace simple_strto* with kstrtouint Date: Tue, 24 Mar 2026 23:30:23 +0800 Message-ID: <20260324153023.86853-3-ericterminal@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324153023.86853-1-ericterminal@gmail.com> References: <20260324153023.86853-1-ericterminal@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1856; i=ericterminal@gmail.com; h=from:subject; bh=J10JPVWKsVQanKp923Zl9fUFEZ4SGvBX5W7Guc7pfaU=; b=owGbwMvMwCXWM/dCzeS3H+sZT6slMWQeWqslevn97QnFyuvcPn1zXGlx4gPn3kMy/Or7fxctP Z0Vvjz1YsdEFgYxLgZLMUWWu//3zc31ujXnOvfhXJg5rEwgQ6RFGhiAgIWBLzcxr9RIx0jPVNtQ z9BIx0DHmIGLUwCmuleMkWG6nuTemQtvls2KNlu8teHmHK1NpntUJ7YzV61g3WjG/esHI8OBU0+ Cpiiy/2YI0tP9fEI3+rawbHSSw0HL42brpnN8ecUGAA== X-Developer-Key: i=ericterminal@gmail.com; a=openpgp; fpr=DDFFBE9D6D4ADA9CD70BC36D8C9DD07C93EDF17F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Yufan Chen In xen_9pfs_front_init(), parse the backend version list as comma-separated tokens with kstrtouint(), keep strict token validation, and explicitly require protocol version 1 to be present. This replaces the deprecated simple_strtoul(), improves error reporting consistency, and avoids partially parsed values in control paths. Signed-off-by: Yufan Chen --- v3: - Split from mixed series into a dedicated 9p/trans_xen series. - Refined commit message to focus on 9p changes. - No functional changes since v2. net/9p/trans_xen.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c index 85b9ebfaa..f9fb2db7a 100644 --- a/net/9p/trans_xen.c +++ b/net/9p/trans_xen.c @@ -413,23 +413,29 @@ static int xen_9pfs_front_init(struct xenbus_device *= dev) int ret, i; struct xenbus_transaction xbt; struct xen_9pfs_front_priv *priv; - char *versions, *v; - unsigned int max_rings, max_ring_order, len =3D 0; + char *versions, *v, *token; + bool version_1 =3D false; + unsigned int max_rings, max_ring_order, len =3D 0, version; =20 versions =3D xenbus_read(XBT_NIL, dev->otherend, "versions", &len); if (IS_ERR(versions)) return PTR_ERR(versions); - for (v =3D versions; *v; v++) { - if (simple_strtoul(v, &v, 10) =3D=3D 1) { - v =3D NULL; - break; + for (v =3D versions; (token =3D strsep(&v, ",")); ) { + if (!*token) + continue; + + ret =3D kstrtouint(token, 10, &version); + if (ret) { + kfree(versions); + return ret; } - } - if (v) { - kfree(versions); - return -EINVAL; + if (version =3D=3D 1) + version_1 =3D true; } kfree(versions); + if (!version_1) + return -EINVAL; + max_rings =3D xenbus_read_unsigned(dev->otherend, "max-rings", 0); if (max_rings < XEN_9PFS_NUM_RINGS)