From nobody Fri Apr 3 10:17:43 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C1933EF644 for ; Tue, 24 Mar 2026 12:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774354733; cv=none; b=l/acSzSGJjBm1MA7xpUmnOM83g6PTi7JKtOIEPYGZJb0nBVCfgSv/PKxJl7H7szW4z3VaIwVMsbaWjCqCG1zSsARKRJm18v7jU5QXIN1GbjKFFvarjE1Z4uT0KfkfXlZsNkODCfTSangWdpVEXA4rpXqxPkn+KvNvsQdHJFztzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774354733; c=relaxed/simple; bh=fN08PYV9p+8K6beZYGN78fUNGE7ccNf08IzjNeTz9Zw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Kl0N1+R8eIZAxVn94Wvs+Dl4Mw24UE95igtAenNNCTG2MDaHDu0rUMVNmnJbTu54gw/DEA31w9rAqe9mQzIo1+I6tct10u1gUZnwL9NSQiRrSpqlUrfcdHapiDAGip+fDs17yDgZ/aoZ17itWKGqjWudex5/ARCCK517yESJHpc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l6aHbm8x; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l6aHbm8x" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2aecefc7503so39582965ad.1 for ; Tue, 24 Mar 2026 05:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774354732; x=1774959532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=M2AJi2+s8XLmMMdhzVHEpZ+yXvhnr+bzOUs74jM3/OM=; b=l6aHbm8xeBxnTls6hiPptcnV48ikU6m5FgzZWIhDXCOl/jAk9TMGf5HmGV7LaliASp v6XaJddMHgLaYGGsa6HVjlPveQV+KwnWCjED6dAG8gnIYTIOf86HJP38aHSwK9j3jhgR 4Lduh0QNGDzITG07NKn8YHTgUcZN6GNaJkgFE2POE17te0gRs4CJ/lWpqyDKWvVgddE2 ofiV1BVZ9SpXavy7JrJzXVY8QIup4qK3spcA67+ia7QjGjjj+Y1br+kiP7UBBSeF83+u ku4+PL3OiQgNVTK24WnzFXnR6v2T1zuube4BTIOkeo3T5aDX+L2IMenmHLngYG/ZZRX+ K3PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774354732; x=1774959532; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M2AJi2+s8XLmMMdhzVHEpZ+yXvhnr+bzOUs74jM3/OM=; b=Ct4Nd5oIJQHBfq0i0v750LIunal5oVJBOg4oGwalzJJq5H0/PWXTfcuwiMSXY3ROZi dOzoDTtcQS1ICFtGuq2ftcs1YspqJ6YovffrmxNSglE36Q10tizxWr8Tl1+MFx8lvGDW C1E85OdSE5pElbpA1Ie/bL3I0+kROHhiGozfC7V8S+Sp6dvTZm0mhGEWGorcSZH/WvdQ jo+gK1exEkR940v+8mO7GgltHoX/xgUwlCpL111sdOFasMD9iwtC8V2rOwzSkDjeBj6p 1Yzsuz0G6QanRRn+tluj5sIqEUNHDb3gPXWVIYCtSUb53FPJHim/fTnUVmBYgFOnb9EN K5KA== X-Forwarded-Encrypted: i=1; AJvYcCVQpYFn0i5zdnaHKYy6kSu3FzPGq0tqFK8iYUoOagJTyQKgBh28U3agk0y46Raiw0EzweFA3R7uZGgUkeQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzBJA8sITK1EK1U7lvhoMpOBZcEqEI7giL+3GNTlnhBnI1UIzdI kl3l+d6JHYo14V8Ktf1xtqhQzC9R31sDHGJGEj9JmlxhOaotBeIbTwzi X-Gm-Gg: ATEYQzzMFRkGHvnFRutKOybVh8PIaffW5A439C265pcC7P9J5WzKlFA+R0O9kQ585jz vpSAddkNMTLe7QWBg4GFwfu5vbaeCa69K5FO8Anxrzoqtm/+QjgTQ3710A8NSGvTCHTdyYJA+iK 8jHAfi1l824K6QJSBQIYAQ6polU826Xtn1MAyCPhs/mWjW5sjcNBQy6M5Thhq1ZWLfm08hKkRXN k75px75c0J4Q8ULZL0IwLajN8pe7e8Ar4YjSWueIljSky0sP1d+F+U/iHBbLZ86oZX81PlOCkZX 1bIfdGZUuu65MJzT7wILhWi7OWqvIXLLSwJ8Ux61VwPlK1z6Tvl8yyB4RwhO95+MpBUhvaHfdiv d37wb66o1ca6rQ9F1GoBXmTmmPtMH4n9+HnrxabhoU/ItXwO37dhZFmZNCPIMokuOVfuzo58OUJ /BTCkFXLl9JYb8mqmHLcMN6gg= X-Received: by 2002:a17:902:d548:b0:2ae:3b9b:db34 with SMTP id d9443c01a7336-2b0827a4cfamr134359325ad.42.1774354731859; Tue, 24 Mar 2026 05:18:51 -0700 (PDT) Received: from arch-btw ([106.0.57.176]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0836556desm193138665ad.47.2026.03.24.05.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 05:18:51 -0700 (PDT) From: Sajal Gupta To: gregkh@linuxfoundation.org, s9430939@naver.com Cc: andriy.shevchenko@intel.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, sajal2005gupta@gmail.com Subject: [PATCH v2] staging: rtl8723bs: fix logical continuations in xmit_linux.c Date: Tue, 24 Mar 2026 17:47:47 +0530 Message-ID: <20260324121828.14675-1-sajal2005gupta@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify the conditional by removing redundant boolean comparisons and fixing the continuation line indentation. Signed-off-by: Sajal Gupta Reviewed-by: Andy Shevchenko --- Changes in v2: - compact the condition - drop =3D=3D true and =3D=3D 0 checks - fix tab alignment drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/stagin= g/rtl8723bs/os_dep/xmit_linux.c index 0be3143fffe5..dc0b77f38b1a 100644 --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c @@ -193,12 +193,9 @@ void _rtw_xmit_entry(struct sk_buff *pkt, struct net_d= evice *pnetdev) rtw_check_xmit_resource(padapter, pkt); - if (!rtw_mc2u_disable - && check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true - && (IP_MCAST_MAC(pkt->data) - || ICMPV6_MCAST_MAC(pkt->data) - ) - && padapter->registrypriv.wifi_spec =3D=3D 0) { + if (!rtw_mc2u_disable && check_fwstate(pmlmepriv, WIFI_AP_STATE) && + (IP_MCAST_MAC(pkt->data) || ICMPV6_MCAST_MAC(pkt->data)) && + !padapter->registrypriv.wifi_spec) { if (pxmitpriv->free_xmitframe_cnt > (NR_XMITFRAME / 4)) { res =3D rtw_mlcst2unicst(padapter, pkt); if (res) -- 2.53.0