From nobody Fri Apr 3 10:17:45 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAD563F7E79; Tue, 24 Mar 2026 11:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352953; cv=none; b=fw9LdJFSmdf3PnhGrM+es/PUdubZKmffve46NzDszizVbqhIfFjI4d23O3MQspt7wpcNBqAJKqSB1OimNXmvzHVnrVOSb1aG9o3RK4xthhO/ifN3A9iRWmSbkRNm6/m9BnYCBmsHl4LDfIFWIrRf7uuI/mZzvxRIoUgSzF8ovPA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352953; c=relaxed/simple; bh=e9l2eGLM8Fj9YUuxcB2nhRaay/6xOXbkDDgNcShoUO0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hizD7o/y3x77l/Irt7ip0HgPWygeU7R1/btd3rRJIh6db3ZZygzwC9kC7F2ysKTrGGBzntu5cSjNvJ75V1mRyeo+aDMlfdIH41sp9j/nvALXD4d0TYpqA7ZLT60IyOytMfa4YrHh1Vfkiz2fqCf+/Mo0XzfXT889iI43ZLJKRXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=POYcAUL/; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="POYcAUL/" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id F23331A2FBF; Tue, 24 Mar 2026 11:49:07 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C0B526011D; Tue, 24 Mar 2026 11:49:07 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9778E1045034F; Tue, 24 Mar 2026 12:49:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774352947; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=6Htc16u0egxjTg5XK+PPzZYkeVZ6gvD699dGr/7ro+Y=; b=POYcAUL/2xSqy5yhME6CIrkE69/6C6EXrPfheRXNkczbWrQbKkG/DD81xAOKJTBa/AfrXD +TvM3g7c9l3/tlYbNlp9rLJKJhRwxQZ/SE+Rj/ZMi7lR/Cum8XlAVY3B+hRCQxWqyE+oQI GybYudx9VldscY3pX/vmE/GMeKIvWEXaxZ4iWmlShLNuavL+3KYb5YeIFzO5tflnhbJN26 JLea7B43TgxYWZ1qZ1pgmlvB94ggble5SQNNsKL2BOqo4QxxgFIonsngVvzBZI0EOrJM39 yu03PM/yf5x44X18pAm9/ITMn4Th8Ea3AtNv/2Kn8Ci6t52qvJFVtTAwc/FQrw== From: "Herve Codina (Schneider Electric)" To: Wolfram Sang , Geert Uytterhoeven , Wim Van Sebroeck , Guenter Roeck Cc: linux-renesas-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni , "Herve Codina (Schneider Electric)" Subject: [PATCH v3 1/2] watchdog: rzn1: Fix reverse xmas tree declaration Date: Tue, 24 Mar 2026 12:48:44 +0100 Message-ID: <20260324114849.242755-2-herve.codina@bootlin.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324114849.242755-1-herve.codina@bootlin.com> References: <20260324114849.242755-1-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Variables declared in probe() don't follow the reverse xmas tree convention. Fix the declaration in order to follow the convention. Signed-off-by: Herve Codina (Schneider Electric) Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang Reviewed-by: Guenter Roeck --- drivers/watchdog/rzn1_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/rzn1_wdt.c b/drivers/watchdog/rzn1_wdt.c index 96fd04fbc2a2..b7034eac91d0 100644 --- a/drivers/watchdog/rzn1_wdt.c +++ b/drivers/watchdog/rzn1_wdt.c @@ -101,10 +101,10 @@ static const struct watchdog_ops rzn1_wdt_ops =3D { static int rzn1_wdt_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct rzn1_watchdog *wdt; struct device_node *np =3D dev->of_node; - struct clk *clk; + struct rzn1_watchdog *wdt; unsigned long clk_rate; + struct clk *clk; int ret; int irq; =20 --=20 2.53.0 From nobody Fri Apr 3 10:17:45 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D32E93F7E9B; Tue, 24 Mar 2026 11:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352954; cv=none; b=CkhGclD6EUf7jmzgZVJGuVGaacB4iZkVBsItpAqpBVelRWhQS/ld/SDrhf1MNbypAtsmS2T2XSfkL3xCbGhaEriRisjqoZSmmMchM/NQUgOGzOjavIakiOa5n7ELjYSxotJaw0opoe42i41hT0J8nZIKlBdX6xksXZPA07FR9J0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352954; c=relaxed/simple; bh=cnlyyAE0hKJh44VrBo3wLRg1/bJ/z8lV9SX/IznzyPk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TUa044zd+qyJLEzGckvQSRnrZH7BDxs07avymclZmNR0GJL1iRSU42xnbsFRh6BfbG5hXpIbzpdFzjq6Zg9lIn4BBw4H1ciaGDejQrTIe7H8c3/Q9QKmquz0YS/347YmLJI4zLWgY8S/CorBPxcroHvoNVc9rn4hQT1GmRM0Z14= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=EH60VlCb; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="EH60VlCb" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 5E35FC5809A; Tue, 24 Mar 2026 11:49:36 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2161B6011D; Tue, 24 Mar 2026 11:49:09 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 71CC810451126; Tue, 24 Mar 2026 12:49:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774352948; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=+ZO+ja/wZQnveqYe42ml5vWLXL8y3cUnpi0huNlQkmM=; b=EH60VlCb7Awj/fLHNoFZlhIL0+MOuFLtQ7ZCiRx0A2THUYQnAmK978bwzQF3GDLLFmB+5G b5H2zbyMgWQynXXLN4slzgAiXUYWYb5cEHmTRz3vGMaJVp/JVq0VKu3ZZlgBRzDjx1W1oa 0srkEPZgDe9FuiJmGY2E69Faevidnj1zyTTtqxN+H1Cdwg6wgfU7u/HpFAmTVhkpJEVDTQ zm427idnbTPjDE6I3hIQ5RpBrY0kjzmGq0sviFl48HskA7Qk9k5L2WgZwlp8gNc8p9Hizr LWuCBwmh7qi0c5FvPJxy+XvtT5J+U5MmmJk3Dyp0CG/PB0ZfrcP6q6R7i4WQwQ== From: "Herve Codina (Schneider Electric)" To: Wolfram Sang , Geert Uytterhoeven , Wim Van Sebroeck , Guenter Roeck Cc: linux-renesas-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni , "Herve Codina (Schneider Electric)" Subject: [PATCH v3 2/2] watchdog: rzn1: Use dev_err_probe() Date: Tue, 24 Mar 2026 12:48:45 +0100 Message-ID: <20260324114849.242755-3-herve.codina@bootlin.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324114849.242755-1-herve.codina@bootlin.com> References: <20260324114849.242755-1-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" In the probe() function the following pattern is present several times: if (err) { dev_err(dev, ...); return err; } Replace them by dev_err_probe() calls. Signed-off-by: Herve Codina (Schneider Electric) Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang Reviewed-by: Guenter Roeck --- drivers/watchdog/rzn1_wdt.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/watchdog/rzn1_wdt.c b/drivers/watchdog/rzn1_wdt.c index b7034eac91d0..48d5afef62a5 100644 --- a/drivers/watchdog/rzn1_wdt.c +++ b/drivers/watchdog/rzn1_wdt.c @@ -122,22 +122,16 @@ static int rzn1_wdt_probe(struct platform_device *pde= v) =20 ret =3D devm_request_irq(dev, irq, rzn1_wdt_irq, 0, np->name, wdt); - if (ret) { - dev_err(dev, "failed to request irq %d\n", irq); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to request irq %d\n", irq); =20 clk =3D devm_clk_get_enabled(dev, NULL); - if (IS_ERR(clk)) { - dev_err(dev, "failed to get the clock\n"); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), "failed to get the clock\n"); =20 clk_rate =3D clk_get_rate(clk); - if (!clk_rate) { - dev_err(dev, "failed to get the clock rate\n"); - return -EINVAL; - } + if (!clk_rate) + return dev_err_probe(dev, -EINVAL, "failed to get the clock rate\n"); =20 wdt->clk_rate_khz =3D clk_rate / 1000; wdt->wdtdev.info =3D &rzn1_wdt_info; --=20 2.53.0