From nobody Thu Apr 2 11:02:22 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED7F53EF67F for ; Tue, 24 Mar 2026 11:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352627; cv=none; b=O07FeqoNTAdiMkV98JA2OH9WuXLLC/1owcRuDeKkBGuoixwkg7n791Fyb7oAzrU4T5nJAW8KXSqtfGEG6gMU6KK6l9SO3zdNgSNZuoTzajpqXji91HAS6ImTTbTj/XFzyEa3CjXCW43gdTVY+tJBUetpYJkthsJEWLSOR6YwJEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352627; c=relaxed/simple; bh=j0Gd04+kJqJ6VR/s+a8qrHwz+JDzDy6zM8WFPZZZUj8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L+SybNqS0/OVbm6CFnBwWSh21SdSCIhUdtEssWzKrDD7pa3rr1ugpYkslMoqtd8IFx0Ro35ATEzLT6fn3EiGznlQjMCx9ZNo3Q3otEj/KWe2TDLPEunkx6JUlFinCtwx6JzXZQLtMg6LIbEKVLzDzsaMfx5/Dz1KBMRgLSg8NFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kMAoiizq; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kMAoiizq" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-486b96760easo10702945e9.2 for ; Tue, 24 Mar 2026 04:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774352618; x=1774957418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QNiRs4I0KqGZbcAMjICGT778jYVtsL4Bi7idhY15odQ=; b=kMAoiizqinLvsr+eMl2jDd8E5CqUmP/XQQAV6loJXxE+uwmPzUWfO6kmZxhYnnBQYt 6zduq61pvDcXM97BeJZG4k/733igv08RLRwdTOsdCabDOdZKdqr9RHu52BvlPnihne03 oC2QvtFBhkPNruAyzz6lp7gxuF/mrm4/7aEDzO2sDZk8Yq+mEM/hIXmwiNMP1BgzISaY S+ML02m3C0K2VGx7QuF6SfKY8KiZ3NfCHwupO6ZxYcIHHeklPQZT68sqmVIIk4x9LeGc ADDBAQPN1WxIRG1rMgt+GbrzEvmSaVyBfINhBR4i5OMPOA4KthQ+Ymcb0CsQYSWWHePD kjPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352618; x=1774957418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QNiRs4I0KqGZbcAMjICGT778jYVtsL4Bi7idhY15odQ=; b=Vw8mAqDBXOFFtBpPDOg4z5g0O5xymowfEOJD3MQIW2T+WedgaQdm8HQISrUF2yBFgf fBpckN1F+yxWiRAVttvTgwWwPd/xKcSNT7a0lRFo0YvoIF+vriovFD0n56ei2VjOFpju 948nXiPUp/g/kHmL/UecewSEyYibXa9hP/TiYCQDMtSXIs7phZEmGfzFgAn42sxG206o W853ExEu/2Zn3fPw3WhrbBrpmf2so8JteVzGCzaFZNwtNPWdJopG6IDvRGF3aeBgcnWi ZsVz4zqbjzFPyfQ2fySZlGtWH4d8VP8eShe7gYNvqKucXzwTuyC5HkQkZjhLtNC/c1q5 IQCA== X-Forwarded-Encrypted: i=1; AJvYcCXV2eAXac7KhXbH29c1kw54X6iOwnGfNUIcLnY1c5y1h9m1UzYldRjD/jiXFFCDa+t65FOwi9pyb6GDT5Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwrqHinutnniBZDJmQ85SqarJhr9K4hEHivvoCZ6150Vq3HWGzd zKrOAdukyPvn4X1EDg5KM+oEA4OXctkiFV7jtcYJ8+Xy+jOdxsynOSEZ X-Gm-Gg: ATEYQzyxuiMv6y1nyUNe7U0bN2Tbw0b7ao0R8wSlPVXLPJVvNicILE/y3R2oRVDpSO6 eHkafD5ZodBxNIMRKuk644qkEu5XWGcBjUxG3mL5Dpl3UV0BDEa8ny+Q7CylsK2xN0RzBlDrG+G fn2UmPdJ1E1R08fteE87xW+4tcuCPM2i8fZBhtFWwuh6NwSu7ylzeDasAGqhM5GqAjNJXZBPNdx j3PiRZcYain6A4EEJooipm93FAuYPLcAQsyTGi76YqvD19Qpl1ynFXrQ6UK5PwaDuNO+gcrAhNW 5QnkYc2oXKx+ev8ZUnrjw+Ly8DLgygPiDhC+m/8pNQxVke1HtOZr6CM+yetON3l3wZTsTyRC8ut PdrHnvaNUnSufSXnx2f60UCguSvED/uAFhjTJVoKwGphz3bUDA8VNGLS9hzcxcuozJYOkNwjNHn R9v2D9mm/vUKEVoKTip1nWJwa4NU8ZiyAfqD5aWDGBjtD/s7Xq X-Received: by 2002:a05:600c:2d14:b0:487:2b7:18d1 with SMTP id 5b1f17b1804b1-48702b718demr103827345e9.33.1774352618212; Tue, 24 Mar 2026 04:43:38 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:a4a6:e61e:cd81:c756]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f7f5682sm25416465e9.3.2026.03.24.04.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:43:37 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Biju Das , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v8 05/11] clk: renesas: rzg2l-cpg: Add rzg2l_mod_clock_init_mstop_helper() Date: Tue, 24 Mar 2026 11:43:10 +0000 Message-ID: <20260324114329.268249-6-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260324114329.268249-1-biju.das.jz@bp.renesas.com> References: <20260324114329.268249-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Refactor the mstop initialisation logic in rzg2l_mod_clock_init_mstop() into a dedicated helper function rzg2l_mod_clock_init_mstop_helper(). This decouples the logic for setting module stop state on disabled clocks from the iteration loop, allowing it to be reused during resume to re-enable critical clocks. No functional change. Reviewed-by: Geert Uytterhoeven Signed-off-by: Biju Das --- v7->v8: * Fit the comments in rzg2l_mod_clock_init_mstop_helper() to 80 character space. v6->v7: * Collected tag v6: * New patch --- drivers/clk/renesas/rzg2l-cpg.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cp= g.c index a38401c18dcf..738a4b182f27 100644 --- a/drivers/clk/renesas/rzg2l-cpg.c +++ b/drivers/clk/renesas/rzg2l-cpg.c @@ -1594,6 +1594,20 @@ static struct mstop *rzg2l_mod_clock_get_mstop(struc= t rzg2l_cpg_priv *priv, u32 return NULL; } =20 +static void rzg2l_mod_clock_init_mstop_helper(struct rzg2l_cpg_priv *priv, + struct mod_clock *clk) +{ + /* + * Out of reset all modules are enabled. Set module state in case + * associated clocks are disabled at probe. Otherwise module is in + * invalid HW state. + */ + scoped_guard(spinlock_irqsave, &priv->rmw_lock) { + if (!rzg2l_mod_clock_is_enabled(&clk->hw)) + rzg2l_mod_clock_module_set_state(clk, true); + } +} + static void rzg2l_mod_clock_init_mstop(struct rzg2l_cpg_priv *priv) { struct mod_clock *clk; @@ -1603,15 +1617,7 @@ static void rzg2l_mod_clock_init_mstop(struct rzg2l_= cpg_priv *priv) if (!clk->mstop) continue; =20 - /* - * Out of reset all modules are enabled. Set module state - * in case associated clocks are disabled at probe. Otherwise - * module is in invalid HW state. - */ - scoped_guard(spinlock_irqsave, &priv->rmw_lock) { - if (!rzg2l_mod_clock_is_enabled(&clk->hw)) - rzg2l_mod_clock_module_set_state(clk, true); - } + rzg2l_mod_clock_init_mstop_helper(priv, clk); } } =20 --=20 2.43.0