From nobody Sun Apr 5 13:05:44 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C153258CD0 for ; Tue, 24 Mar 2026 08:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774341520; cv=none; b=Kt/OmHgdkzDCy/c0aqsA9YM9dgOFN/N3/xFm5EyU7k0riFj8E4HL/I/BlZkpDVODiIiLJeX/B4FQ822cFdRd2QxR29kDcJUHx/n3/navDklSa9Svxgd8DeqiFIIzLAYzI3h/ypEb7M2E3ALHRcGmGjQzbuWXi6ZBIr097WLXzyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774341520; c=relaxed/simple; bh=sQFLfWDZnN2jbIWb/ty60Z2YG7NkDwuDP/51J79R/Gg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Yel3jSZcMazNHPk9HS8eLQnxOkfsZ4arjXUFaXGXoCiKRY7NM+UErUFzcPxd/SxAyiSv+X2s8yRAPRbNZXOt+O41fuwJ94mpx9Pn3rNNVx7ajFjxdmL4OXnBfHo98meZ+wkVYd+LAr6ujctTIwLCHdSc83BIuUxPQK+LyoEG+xg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=knyO8X1r; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="knyO8X1r" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b9358bc9c50so159741066b.1 for ; Tue, 24 Mar 2026 01:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1774341509; x=1774946309; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Qfe8uxaJUIwAwgeZAc6EHsvJiN9WIJGVAt60/7iwUec=; b=knyO8X1rOUKBVeTHP6Ffqw4DkUvG4J0MWpVsgG/XyksHF9RYjRb+beWcG2Iw6aMK5o XYRiB29QJRxMOJP6IUEWODc7Fd+RkMS/Po+F+EHUHQMeOD2wgWdD+cWRdPYLiClrHKf4 fuOSvLVrdWNRRZYCXPeyuhpQpnGGSnbJ7XBRw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774341509; x=1774946309; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qfe8uxaJUIwAwgeZAc6EHsvJiN9WIJGVAt60/7iwUec=; b=H8X5dAvMKTVv6LKUuMT7D5UkoKv7/Vh81hX/zf9xjsazHEf8XMPc+BIebAfjqBh8ST Cy7F51qjddW1ZGu5Kek17Qy4nfWDg1rPFsawDSCNjzHHcZX5fuzPbbaYE7QWLWG80lnD /ykPZIYYVTNkiXDGWYDsVvxamhpEVU+bVgsRTOWdcByn8fl6RZijKFiaRVBpYAZNzCcQ +lOB3EdumauShJDLz4lWENaQgD9dPJ7R8J3r+5P2B9LVt/hUw52tPMOnmL1W45mKR0fV fuPjdnNgBtL2wQD7rAZjvDNsKLasrWHg6CgjA/evXpR//NbmwUzauZuJMTJ5E9AwtZUQ 24uQ== X-Forwarded-Encrypted: i=1; AJvYcCXSFKPwLu2bURqRLRhAIEK5/ZV4uLMDgsPrS7GHqXyzzPx3dr2PbfooZdjJg24nw7TFBNxDLgAQPYHVCkI=@vger.kernel.org X-Gm-Message-State: AOJu0YzK0Be4KWZ2sGYWYrL5+fosiCbwUtvEQEcEYGAOnAR2/sosow7i bGypLgbRbyHvKwWazaQLpa3UBQF+y/I8m2zBI74xjnB89gYeLAePyLMRlAjUzg1HRg== X-Gm-Gg: ATEYQzy459zy1NWA/1oM3lMK2euJunENgWOQcJRX7xQwGf/87UzNcPjA89eyRlywtp2 8Vk7gKOJmvqvtIrldPCKHKix+xU0RN6jRzBsr5T98nLrXAWAOafkmgMzP6CRV/i2X4LS27nYinb fR3lKqCmVvS22cSZvzeBqM75KQlvPvMwfpUcT/tFMCd+7KuP/+o6CS+vJmL9RfkOC8VC/wi7ufB Ti3nAaWYLdZCIEcKUf55/yfOAgoXOJNpoh8eY/0IP4IZbG0xDKOolS+d99tT1PFT0Zf3FnY1T2Y IoIdQ04ymskhlo/fjtDpfn4TQeA7MUAIc8OnRGH1J2yYWcB9wYpVIhNd7rddClbrBlejDZUQb+d ZkTZXfbt/iiNn0NTwPjaKGjMIZACNwoOd8icQcbtEbBWRU8/tZWEUA6wkqU9FEqSQcbLVdrV81h U8PFZ8X2DOmQH4+OwWI4J2zyC711KPumd8Zpl/iu9UNY/YEcgk9IL3FpJVHcBq+yBj+RAAX7LdS Mn4bIP7swGyIqdBjIYWr9A= X-Received: by 2002:a17:907:9725:b0:b98:6926:13c3 with SMTP id a640c23a62f3a-b9869262e7fmr491579266b.22.1774341508989; Tue, 24 Mar 2026 01:38:28 -0700 (PDT) Received: from akuchynski.c.googlers.com.com (218.127.147.34.bc.googleusercontent.com. [34.147.127.218]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b983365dbe4sm601555666b.47.2026.03.24.01.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 01:38:28 -0700 (PDT) From: Andrei Kuchynski To: Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Andrei Kuchynski , Madhu M Subject: [PATCH] usb: typec: Remove alt->adev.dev.class assignment Date: Tue, 24 Mar 2026 08:38:18 +0000 Message-ID: <20260324083818.686269-1-akuchynski@chromium.org> X-Mailer: git-send-email 2.53.0.983.g0bb29b3bc5-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The typec plug alternate mode is already registered as part of the bus. When both class and bus are set for a device, device_add() attempts to create the "subsystem" symlink in the device's sysfs directory twice, once for the bus and once for the class. This results in a duplicate filename error during registration, causing the alternate mode registration to fail with warnings: cannot create duplicate filename '/devices/pci0000:00/0000:00:1f.0/ PNP0C09:00/GOOG0004:00/cros-ec-dev.1.auto/cros_ec_ucsi.3.auto/typec/ port1/port1-cable/port1-plug0/port1-plug0.0/subsystem' typec port0-plug0: failed to register alternate mode (-17) cros_ec_ucsi.3.auto: failed to registers svid 0x8087 mode 1 Tested-by: Madhu M Signed-off-by: Andrei Kuchynski --- drivers/usb/typec/class.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index 8314309094719..0977581ad1b6e 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -686,10 +686,6 @@ typec_register_altmode(struct device *parent, =20 alt->adev.dev.bus =3D &typec_bus; =20 - /* Plug alt modes need a class to generate udev events. */ - if (is_typec_plug(parent)) - alt->adev.dev.class =3D &typec_class; - ret =3D device_register(&alt->adev.dev); if (ret) { dev_err(parent, "failed to register alternate mode (%d)\n", --=20 2.53.0.983.g0bb29b3bc5-goog