From nobody Sun Apr 5 13:59:51 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 321453CCFC8 for ; Tue, 24 Mar 2026 07:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774336704; cv=none; b=ArGMeU+JWgjNVdAayOBLbLg3WIN7TL3rpUYOz9CP50RnJdwrUKovjuCsXf0aaMOYhgz6IYlinlRqzLLB7+pcr/BKQtmSNrYU4EjiI+8lf4kAZVD12QFd5J3SPMzbaGhUFqYMiTJTXyfBi/Jeh5NADE5vmDhWrPranCKDh//xKtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774336704; c=relaxed/simple; bh=r7eFDFzjkCYc1eM+PcUUcoobdllEhQ+bRB6p/EM6B5Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EH7CVIJPOM1OpB0zpybw+eOR84b4K++2loWJtxZYwOQrmk2lCSQLFb/IMRybxsi5pGEE8efKO6iX0DqSIRx9vp9vBkqvsW1heOOWVeum566TqT+KMRXqOc2M1ZkNpqyRPg2wsb3XdJ9lXfnIW7hm4XrLVJgwcDSRnWcRXadjQa0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CgudRQ2T; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=W5T4iL5r; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CgudRQ2T"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="W5T4iL5r" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774336694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vB7aLaiUDuy/zNum2h8/EvqzLzhAF+RMHtPW9CGDRoQ=; b=CgudRQ2TgaFRtrr7mHo+NkdR8r8f8d0HyRxOeQGv+kp2UJJLhcfWTuQ6V/4SQKHLY1aoKD JRg7U8mQbXDoErIu54gOIP0CHeeJaC6l5+OkZc/hG84tnNCPYaVHrtigGj3vnKqqmCsfTb cLVeJ8/WZQAEEoxFsYQoaKlq2Om8zvQ= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-SIS2OIGZOZGZVmwOPgN-3w-1; Tue, 24 Mar 2026 03:18:12 -0400 X-MC-Unique: SIS2OIGZOZGZVmwOPgN-3w-1 X-Mimecast-MFC-AGG-ID: SIS2OIGZOZGZVmwOPgN-3w_1774336692 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82c245a88a5so1438144b3a.1 for ; Tue, 24 Mar 2026 00:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774336691; x=1774941491; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vB7aLaiUDuy/zNum2h8/EvqzLzhAF+RMHtPW9CGDRoQ=; b=W5T4iL5r+3NVlwikMos3BsnjNDimSctOWmYi7IP3M7f/haIZc/ybGFgRsGAHvZGTNb 4P79bhxqYN+5QpistKGqv7QwNnr3lgE31MaXet5BWTgTU4cJuGuIf0cDn44rawof/b0D AMmBoTFWYg/ocKvtQ7jZFUAn3sOkRRsZawPKDgTxDfvyftgzhGWKcY1iwa/MFZbG1tYD gmq1geStVsgTi2OI6fCyJf4EUwjjbqKYw2SzAvvoMxKdZr+5BRKB2DG2yzKubKRSmfff 0+y+s8MqTyLvn9yCcxz/xs52tJbJnc4ksNYYI36oZGly9SLkO23aaF8jT7/imKNKfbsN qSlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774336691; x=1774941491; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vB7aLaiUDuy/zNum2h8/EvqzLzhAF+RMHtPW9CGDRoQ=; b=D2u7Lr5GRtcDj+UKEKlLjqr7EdrZVuoqjtwewUCEXoIn5q+qJs2YRzGi4D4hHesc2l 26sYQibqhGA4JkTQWCr7MqlR2qRFq3mXJNkuqDCBjJbSc49ATD9X5pEN4voWEe4lRqNT Eia9OISrl0qZ4Wf+pXWa0k7hBTch4ZJLJf1oWe5N3bu9uSZzwx6ZWSg84vaZIoRzL+9h YsMb6dOJauAngR6SvV2RHf/QJacLuQtb2xsX/GYWgoV26QAfq1u6HJbE5LO5MOsothDA UWYJT2UsEiGkQaDw72y4Egw4Gw6OkXhKJKT90GJt1f0zwu/PYFi9XvqhcOLHEeA9FUSu tDAg== X-Gm-Message-State: AOJu0YwMQUcXqNx8DGX4viaeU/AgtvQ4eQrlfDWhmER01VEOK6g6LbSn pUhY1HTkyLm4eHLNiCnIjPF8f/bNdsR09b2HTpbkkP65tORBzATPlnal7H7irjaf4lpo8Fvt7LZ H+mGIcFp4JgE/No7j61ht7jOJHH+aw44i2XqFV53hSOrjLFPBLAATaTB68I8nsC6csioFP1vjal CJj/DvKXsK9MMXcM0bYxfp3ochR14JYELu1tCEQNRTjLozbijT X-Gm-Gg: ATEYQzxiySQEOVMtEBlrS2/qC3MuyhV1SLEqcgzZQLEbn2H0dKWvcAGXO82TLrAUoRn DZg/M8r732kG1wRGiNyzhRxwclUGHjCOkGHs+sYg8o73zzSfG2dP2+JfBeLOjUoVEM9z3AubxfD nvgdSJ97nkfVDTaflo+QOlNxrE/SGGCC8aOvnY64Y2IwDq2VBrKZZ7gBcgCt7didxzb7kosu1d2 XDFwZ2gD0aNs50/3gxlbdgJ6JKQL2Gsmb4zAZtj0V9bBGnX7lG8DmEgG5IHfZQ0vFU3wjeuhJU3 LB+yfJ8z+hZDfFr3vMzX0IstUzGMA3HQb5j4ALzr2+4KVXGmgbhp9l04VVkAPsh9dl1Jlg4Q67u BavWBvACx8okYnAA2KkSir7mJRT/HPC0IYv2n7Okb/obb2DWQbh6FUGsguwSEhQ== X-Received: by 2002:a05:6a00:8d3:b0:81e:f280:f341 with SMTP id d2e1a72fcca58-82c5bd62425mr2173679b3a.6.1774336691639; Tue, 24 Mar 2026 00:18:11 -0700 (PDT) X-Received: by 2002:a05:6a00:8d3:b0:81e:f280:f341 with SMTP id d2e1a72fcca58-82c5bd62425mr2173651b3a.6.1774336691167; Tue, 24 Mar 2026 00:18:11 -0700 (PDT) Received: from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.106.26]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409c681sm13597766b3a.37.2026.03.24.00.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 00:18:10 -0700 (PDT) From: Arun Menon To: linux-kernel@vger.kernel.org Cc: linux-integrity@vger.kernel.org, Jason Gunthorpe , Jarkko Sakkinen , Peter Huewe , Arun Menon Subject: [RFC 1/4] tpm_crb: Add definition of TPM CRB chunking fields Date: Tue, 24 Mar 2026 12:48:00 +0530 Message-ID: <20260324071803.324774-2-armenon@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324071803.324774-1-armenon@redhat.com> References: <20260324071803.324774-1-armenon@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" - Add 2 new registers for invoking the start method and add CRB_INTF_CAP_CRB_CHUNK as the new TCG TPM specifies this CRB Interface Identifier that decides if chunking is allowed. - Refer section 6.4.2.2 of the specification document [1] [1] https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific= -Platform-TPM-Profile-for-TPM-2p0-v1p07_rc1_121225.pdf Signed-off-by: Arun Menon --- drivers/char/tpm/tpm_crb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index 6c25305c256ef..67c0061d4cab7 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -56,12 +56,18 @@ enum crb_ctrl_sts { =20 enum crb_start { CRB_START_INVOKE =3D BIT(0), + CRB_START_RESP_RETRY =3D BIT(1), + CRB_START_NEXT_CHUNK =3D BIT(2), }; =20 enum crb_cancel { CRB_CANCEL_INVOKE =3D BIT(0), }; =20 +enum crb_intf { + CRB_INTF_CAP_CRB_CHUNK =3D BIT(10), +}; + struct crb_regs_head { u32 loc_state; u32 reserved1; --=20 2.53.0 From nobody Sun Apr 5 13:59:51 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 180D53C944D for ; Tue, 24 Mar 2026 07:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774336706; cv=none; b=L66RG7eSGDf7uRO9Nj2/VhSJM9GfIVnZb/QhHUd62EgWF+4KbilDt3w+Jdle/whdobTTinT8NU0TY49c1rP6hhIRmoBCEHifqM6K6COlHn7McQA7ryJDWGN0oB8cFTJqNVAetKXYccEmbH+wsAnLvFFlbmZpvPWT4OWe9ZC+KzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774336706; c=relaxed/simple; bh=SilugzOMu2AyY0n7FNza7D3+fn1Dwqn99jbo8QgsmZU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G5W5az0on4p8TSXHLqW6FRPVlOI5WxUWmtQ4DWIVHSEEZsZgYk9deZEJ6F+25C6to0nG9xdrxm+rFVUoqBZIG5w9+uWkz18RaKNPQL1DvJCJT69Rduc+xu33cyBCY4uex2fP6oh1dnFEgUFUY5BL1OLK+uC2J+BajkZmlX4HKLQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=R9g45oH7; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=t1UvfYt7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R9g45oH7"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="t1UvfYt7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774336696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xQoVz9hmYf6qqip3bEa+gA/UnhF/MBgQeN1TTtkBG3s=; b=R9g45oH7XCXwC9o9dCk9d7TVIOF8Jn9nsK/7xmPi4nOdlbQxMEn4hfJJ/b0sK6x8cXulgK ogTqRz/EXpA+cBShxfudsqxu6LWYKUHuhh+SyhjYi1a4a5u5WKYuZXggCYMsuAdUyzE21Z fXFcnh9FUctCqaUJRAex2jVWu8HgwAc= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-5fnr2KBjMouOOxCbUDqUTg-1; Tue, 24 Mar 2026 03:18:15 -0400 X-MC-Unique: 5fnr2KBjMouOOxCbUDqUTg-1 X-Mimecast-MFC-AGG-ID: 5fnr2KBjMouOOxCbUDqUTg_1774336694 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-829b8bb5173so1995372b3a.3 for ; Tue, 24 Mar 2026 00:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774336694; x=1774941494; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xQoVz9hmYf6qqip3bEa+gA/UnhF/MBgQeN1TTtkBG3s=; b=t1UvfYt77/Spz8U/Y8P93z5BQKpZ4nrSQ9H5wEP4D+j5mn57B1eUJ/WLmiG3IoPKKt 52mJhr/4SgBGe/3JtNabW6guSk0EDDOJAIQk3ULZ295mSrpQ2a6+GuG1N2Ex0b7e7LwY Mz03k2ansjge8kf3q5gcKmLSyDIViy8Cfs6X1t+s6t3oJgyN3w/XMJOVqz554sJTiBcE A9pTkzrmCvGAJTN/AkFW7JRZTP68MhU3qreBNbTBL04ZblUmYLEG9mgpILMu3YecQu4m P8KauZTcMIjmwgH/YDbfUg8uAoGPG9Td9Us9eN/v4N0p2Z6M5SjekWmD5ESvlhYURR2/ YTZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774336694; x=1774941494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xQoVz9hmYf6qqip3bEa+gA/UnhF/MBgQeN1TTtkBG3s=; b=I4v485nw4imaYjR8vh+6UVV0D8ypUwc/MscGm5PYZ+oTcRXacTqzVGxJ4PH0KjkRrC mbdb/nVT4Ctrq40R8lbXQX7d0CnBgOrP21sJ799VSjujGWRP/F8i8wLrR7xFAyT5Pirh RuXP5SUphVER+WiexIQehVdvutxmhdqp4fD+Tz598OhjU4XSMnPkd4K8NiaJTBBsxwJS BF50ZtVLDcRAscZGYNscOoJ9QvhOV4/azDaepyViJI2Ex93kAZHHa1++z0VCd6XX1S2M ooJv8/KiY7aD6G5fBwuobJbpoHzoMKtOOc4+NKCuN3H9+8H6pgY2VuwL4lqo39PVng96 CIzg== X-Gm-Message-State: AOJu0YxnkVlgh2Pa6lpEPCbHTwX2xGKaW5nF67iZCHRIWTFsdVH+C4gW uRilfGIhI+sU+EIAnHcUVPgQHUTJAgR8yFv527a4KxcRqL9z/CScN6haW8Ymy/VrTiFA5uBE9do 2dpPpjUzm597WsDVAZ1p767MeVrjSKwoFKXyoc32h+zvsL/YQFVegsmoha2E79yYXqr0RbdlISj UeMSNq75qgVhxUVNVDT+jY2MnTTqBfxHi6J1U0Wd0mm/YSn2Sa X-Gm-Gg: ATEYQzzjI3ga3W7MKaK9LA8TNb11pMMQ5qiUNSui4XoLJLarOyl6ugy9KwQ6a3BnZfA x8t4B2IzH+Ob2G2lztQcsZeyQv/E6bA16J2TeKY5761Axi6mEktBYF5oulz/H7PrhtdCSSUf/8c TyCwVCK0NkT2GQeXxUGUXlUzbh2Fe6+rXwbC/oCvwW5L9UPL6z15XtgUJYiM0bKLMc1XEiinNIh 6yzgbynQI9VP4JllyBj+kC3NyLSG0bHpP27X1pfyoiXkYvHk7+aBKGqwL4YjzMn9/XYIuoXWsNa /D4zyc6IpuYjM7RJws02UgIjxKt10Ms4ghNQFcPK/pyPnAp4sltwFtF8cRTha2rKBl9q2+hnkwD XBn02HjEP49b5bQW5LrS5P8+W5+9EMCStIZGtHYPJOP1Odyt4UfBQ3EO5c/A8/g== X-Received: by 2002:a05:6a00:22cc:b0:82a:6dc5:4e0c with SMTP id d2e1a72fcca58-82a8c280ccemr13121143b3a.27.1774336694175; Tue, 24 Mar 2026 00:18:14 -0700 (PDT) X-Received: by 2002:a05:6a00:22cc:b0:82a:6dc5:4e0c with SMTP id d2e1a72fcca58-82a8c280ccemr13121104b3a.27.1774336693644; Tue, 24 Mar 2026 00:18:13 -0700 (PDT) Received: from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.106.26]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409c681sm13597766b3a.37.2026.03.24.00.18.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 00:18:13 -0700 (PDT) From: Arun Menon To: linux-kernel@vger.kernel.org Cc: linux-integrity@vger.kernel.org, Jason Gunthorpe , Jarkko Sakkinen , Peter Huewe , Arun Menon Subject: [RFC 2/4] tpm_crb: Add new wrapper function to invoke start method Date: Tue, 24 Mar 2026 12:48:01 +0530 Message-ID: <20260324071803.324774-3-armenon@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324071803.324774-1-armenon@redhat.com> References: <20260324071803.324774-1-armenon@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" - Extract start invocation code into a separate function called crb_trigger_tpm. This will be helpful in repeatedly calling the start method with different bits set to toggle between start, nextChunk or crbRspRetry behaviours. - Based on the bit set, we signal the TPM to consume contents of the command/response buffer. - No functional change intended. Signed-off-by: Arun Menon --- drivers/char/tpm/tpm_crb.c | 50 ++++++++++++++++++++------------------ 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index 67c0061d4cab7..10128d078245c 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -445,6 +445,32 @@ static int tpm_crb_smc_start(struct device *dev, unsig= ned long func_id) } #endif =20 +static int crb_trigger_tpm(struct tpm_chip *chip, u32 start_cmd) +{ + struct crb_priv *priv =3D dev_get_drvdata(&chip->dev); + int rc; + /* The reason for the extra quirk is that the PTT in 4th Gen Core CPUs + * report only ACPI start but in practice seems to require both + * CRB start, hence invoking CRB start method if hid =3D=3D MSFT0101. + */ + if (priv->sm =3D=3D ACPI_TPM2_COMMAND_BUFFER || + priv->sm =3D=3D ACPI_TPM2_MEMORY_MAPPED || + !strcmp(priv->hid, "MSFT0101")) + iowrite32(start_cmd, &priv->regs_t->ctrl_start); + if (priv->sm =3D=3D ACPI_TPM2_START_METHOD || + priv->sm =3D=3D ACPI_TPM2_COMMAND_BUFFER_WITH_START_METHOD) + rc =3D crb_do_acpi_start(chip); + if (priv->sm =3D=3D ACPI_TPM2_COMMAND_BUFFER_WITH_ARM_SMC) { + iowrite32(start_cmd, &priv->regs_t->ctrl_start); + rc =3D tpm_crb_smc_start(&chip->dev, priv->smc_func_id); + } + if (priv->sm =3D=3D ACPI_TPM2_CRB_WITH_ARM_FFA) { + iowrite32(start_cmd, &priv->regs_t->ctrl_start); + rc =3D tpm_crb_ffa_start(CRB_FFA_START_TYPE_COMMAND, chip->locality); + } + return rc; +} + static int crb_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz, size_t = len) { struct crb_priv *priv =3D dev_get_drvdata(&chip->dev); @@ -470,29 +496,7 @@ static int crb_send(struct tpm_chip *chip, u8 *buf, si= ze_t bufsiz, size_t len) /* Make sure that cmd is populated before issuing start. */ wmb(); =20 - /* The reason for the extra quirk is that the PTT in 4th Gen Core CPUs - * report only ACPI start but in practice seems to require both - * CRB start, hence invoking CRB start method if hid =3D=3D MSFT0101. - */ - if (priv->sm =3D=3D ACPI_TPM2_COMMAND_BUFFER || - priv->sm =3D=3D ACPI_TPM2_MEMORY_MAPPED || - !strcmp(priv->hid, "MSFT0101")) - iowrite32(CRB_START_INVOKE, &priv->regs_t->ctrl_start); - - if (priv->sm =3D=3D ACPI_TPM2_START_METHOD || - priv->sm =3D=3D ACPI_TPM2_COMMAND_BUFFER_WITH_START_METHOD) - rc =3D crb_do_acpi_start(chip); - - if (priv->sm =3D=3D ACPI_TPM2_COMMAND_BUFFER_WITH_ARM_SMC) { - iowrite32(CRB_START_INVOKE, &priv->regs_t->ctrl_start); - rc =3D tpm_crb_smc_start(&chip->dev, priv->smc_func_id); - } - - if (priv->sm =3D=3D ACPI_TPM2_CRB_WITH_ARM_FFA) { - iowrite32(CRB_START_INVOKE, &priv->regs_t->ctrl_start); - rc =3D tpm_crb_ffa_start(CRB_FFA_START_TYPE_COMMAND, chip->locality); - } - + rc =3D crb_trigger_tpm(chip, CRB_START_INVOKE); if (rc) return rc; =20 --=20 2.53.0 From nobody Sun Apr 5 13:59:51 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 827C03CD8C3 for ; Tue, 24 Mar 2026 07:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774336709; cv=none; b=Fe9FRvdwz+WJe6+ycuVAUcQFC3rhQvZ6UxjxMYCE+M1K6zeJhVd4bi/UTzon+BCnhDC3Upy84m0Il3QThBtd+8rPi0gXbrv2GsjXbKd36IKkTgcZfMQj8TmAFx+iPul3QQ9D0TP8s6b2Ici1w4GsNNCmGB0wPljw2r8bVWRUSy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774336709; c=relaxed/simple; bh=+sKk+LR9zR9ZKqE6bhd3PLSWqidIdSpmgScoe+3cKZg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tdM+2mR2+p2EdqUv+8jrQhNCmwUPFrk3/7fTmXIVhjArOev4R4gew1aSmp3mQhOFArPdcB+NPBfnWQgKFL2jRW2g6QUa96NRj2jWdd0zWo2SC2WJ9SGNFH/8c7h73yE84tatU8zOqO7CIw4PUl+joB1+edw0qQKo5IpyUni82xE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QgIxm0j+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KVPivqhP; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QgIxm0j+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KVPivqhP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774336699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lNnPw5foALWPQjwieo1e/lEK9v8tBtgy/PYi8XddQNs=; b=QgIxm0j+2hhtRwZO5MbkqiW9ASk+yQ1oxNRRuCOwjbIkfxh5JAtFQ9brGJsHnBjJujZi9n wUUkgUMoXAsdMSW6/qJUkZX5KygxVo5SpDCkPqzisgpOPua65NAYrW+wGbZ9tTnU+exOiF FETlKAOq95JeqwXt5j/Q5HqX5cKxYrA= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-ednZSkYRPC2-3_M66_s5YA-1; Tue, 24 Mar 2026 03:18:18 -0400 X-MC-Unique: ednZSkYRPC2-3_M66_s5YA-1 X-Mimecast-MFC-AGG-ID: ednZSkYRPC2-3_M66_s5YA_1774336697 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c741b950511so2264082a12.0 for ; Tue, 24 Mar 2026 00:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774336697; x=1774941497; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lNnPw5foALWPQjwieo1e/lEK9v8tBtgy/PYi8XddQNs=; b=KVPivqhP2VstkUeZ41TZ0odHldRhv/mbRqjFbqC0MfjO7f5PKWKz6YHuZ3J79uPymB rJQht4FXa+rmDU9evu1TM1JQT7CQ6uG5+cwA3jIeDlh9yiXuXw+AeFUYEgcUWsvjzTYd dpTv/Cj93QIGjhqSadSvIgBxUHGu33xXr6YfcEYYv0SdxT6c8BQ/xsHCQxkWP/Pmt1c0 K2dmZYZoz/zub5PaetGtLAXCa+MdiodTbUy704aTNFVcRXNJFm594qBLsApRoT3h515J bwSz7QrMxw8rGUV6NyavkEKdLFa3a1DcUZzs9FMF54hMQjVjrdgoiGdbpIHZsHREBCmk jS+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774336697; x=1774941497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lNnPw5foALWPQjwieo1e/lEK9v8tBtgy/PYi8XddQNs=; b=KL2QDDVsWXT0DQHWsZgHmafVVjoWLmuHhNrFSBOdUvDkJcehOUHoFWK4PhUSOttU+0 iIz2mmGSKCbODJv6AxQgQz6yD098sLOULDYdUlni7EpiWi6uABnK7ULk2Zz3SRCp8fuO 5aY1ujGTISyL4K+YNr84R9ZY7KfHjC4QoLwivw2rd4wiFPloe14gWm5s5EtOLKi+XIac INl0GppAGNXy5gJt21pDIUHJKuiH2upK0geLMplvIBkCFLE/EhdbAmblDkXDDgbJgxTa DPr3rLnZDxl7EIrOHiXOTeOjjRN548PLYaiXEEAVc/F5DGuCERgVF17l82YMHt6LpS2w sApA== X-Gm-Message-State: AOJu0Yx3okRtlA4oSjaTN5InWkQGzgst3pK1lyR3UN0AJq0vHf7selDt rCOWsGFbPX4qWAb1/yYqPQknDp6EX/0QWmSs2oQMl0zlqAgTaouRvZYBqtkn/ejDQpQ3IlWWlEQ f//isQZE5jSufiFHk1C6i+EYNMJF0hqe1PsIBqAS7ahdNXUxBb6DQDTU1xJYygZg58B34sCvzEL Yeo5Lzz/hZXkLdmwmHeAl3SBfu7R31326NPYPumqOpELPh7b1f X-Gm-Gg: ATEYQzy/Kn0vOqyRZ26fq3fFJfwQvpy+XSnurbNAlDA0ShFO6oehN1kpHOWZZU8IIA/ SWmWQqUEFowlHcR2cL3FLlwpGX3eyDHztiG7L9QZeP3XrcYWh/oDfmuGm7Wf7s2FLIWiYKBysy7 Ecw2/WA5lQdIESs3zPoh+ljpWlJmgb1a51xmr4Z2ioy/RPQYfPujtlP21zoIufbgcUPggni+cSq gSxqbOZYSwiSrOEUBoPyz2duusiiF2ti0Abt63chIbh9KLqbziKDS0N58TZrfMIp3eXqk4QpbaT Q0ZHr1tO0YX6vFazpMhTthWFY+86Nd6UwSDdl+pBPXvnoof9VOJHtjt2xb+lR3XHSyGiwENzRyA aF7/kPw3I0bkHxcrnQGCKtn+FzjxL3xgtU+m594m/cHAaCchodsMn46PeuodAKA== X-Received: by 2002:a05:6a00:13a1:b0:82a:6852:559e with SMTP id d2e1a72fcca58-82a8c21270amr12493389b3a.12.1774336696737; Tue, 24 Mar 2026 00:18:16 -0700 (PDT) X-Received: by 2002:a05:6a00:13a1:b0:82a:6852:559e with SMTP id d2e1a72fcca58-82a8c21270amr12493361b3a.12.1774336696100; Tue, 24 Mar 2026 00:18:16 -0700 (PDT) Received: from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.106.26]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409c681sm13597766b3a.37.2026.03.24.00.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 00:18:15 -0700 (PDT) From: Arun Menon To: linux-kernel@vger.kernel.org Cc: linux-integrity@vger.kernel.org, Jason Gunthorpe , Jarkko Sakkinen , Peter Huewe , Arun Menon Subject: [RFC 3/4] tpm_crb: Implement command and response chunking logic Date: Tue, 24 Mar 2026 12:48:02 +0530 Message-ID: <20260324071803.324774-4-armenon@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324071803.324774-1-armenon@redhat.com> References: <20260324071803.324774-1-armenon@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for sending and receiving TPM command data in chunks when the payload exceeds the physical size of the hardware MMIO window. This introduces the following changes: - crb_map_io(): Checks the device interface capability to determine if chunking is supported, setting the chunking_supported flag. It also stores the hardware's maximum response buffer size in priv->rsp_size. - crb_send(): Iteratively writes command chunks to the fixed priv->cmd MMIO window. It signals the TPM backend to process intermediate chunks using CRB_START_NEXT_CHUNK, and signals the final chunk to begin execution using CRB_START_INVOKE. - crb_recv(): Parses the expected response size from the initial TPM header. It then iteratively reads chunks from the fixed priv->rsp MMIO window into the destination buffer, advancing the buffer offset until the complete response is retrieved. Signed-off-by: Arun Menon --- drivers/char/tpm/tpm_crb.c | 150 +++++++++++++++++++++++++++---------- 1 file changed, 109 insertions(+), 41 deletions(-) diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index 10128d078245c..fb63cc3737253 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -104,11 +104,13 @@ struct crb_priv { u8 __iomem *cmd; u8 __iomem *rsp; u32 cmd_size; + u32 rsp_size; u32 smc_func_id; u32 __iomem *pluton_start_addr; u32 __iomem *pluton_reply_addr; u8 ffa_flags; u8 ffa_attributes; + bool chunking_supported; }; =20 struct tpm2_crb_smc { @@ -368,38 +370,6 @@ static u8 crb_status(struct tpm_chip *chip) return sts; } =20 -static int crb_recv(struct tpm_chip *chip, u8 *buf, size_t count) -{ - struct crb_priv *priv =3D dev_get_drvdata(&chip->dev); - unsigned int expected; - - /* A sanity check that the upper layer wants to get at least the header - * as that is the minimum size for any TPM response. - */ - if (count < TPM_HEADER_SIZE) - return -EIO; - - /* If this bit is set, according to the spec, the TPM is in - * unrecoverable condition. - */ - if (ioread32(&priv->regs_t->ctrl_sts) & CRB_CTRL_STS_ERROR) - return -EIO; - - /* Read the first 8 bytes in order to get the length of the response. - * We read exactly a quad word in order to make sure that the remaining - * reads will be aligned. - */ - memcpy_fromio(buf, priv->rsp, 8); - - expected =3D be32_to_cpup((__be32 *)&buf[2]); - if (expected > count || expected < TPM_HEADER_SIZE) - return -EIO; - - memcpy_fromio(&buf[8], &priv->rsp[8], expected - 8); - - return expected; -} - static int crb_do_acpi_start(struct tpm_chip *chip) { union acpi_object *obj; @@ -474,6 +444,8 @@ static int crb_trigger_tpm(struct tpm_chip *chip, u32 s= tart_cmd) static int crb_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz, size_t = len) { struct crb_priv *priv =3D dev_get_drvdata(&chip->dev); + size_t offset =3D 0; + size_t chunk_size; int rc =3D 0; =20 /* Zero the cancel register so that the next command will not get @@ -481,7 +453,7 @@ static int crb_send(struct tpm_chip *chip, u8 *buf, siz= e_t bufsiz, size_t len) */ iowrite32(0, &priv->regs_t->ctrl_cancel); =20 - if (len > priv->cmd_size) { + if (len > priv->cmd_size && !priv->chunking_supported) { dev_err(&chip->dev, "invalid command count value %zd %d\n", len, priv->cmd_size); return -E2BIG; @@ -491,16 +463,101 @@ static int crb_send(struct tpm_chip *chip, u8 *buf, = size_t bufsiz, size_t len) if (priv->sm =3D=3D ACPI_TPM2_COMMAND_BUFFER_WITH_PLUTON) __crb_cmd_ready(&chip->dev, priv, chip->locality); =20 - memcpy_toio(priv->cmd, buf, len); + while (offset < len) { + chunk_size =3D min_t(size_t, len - offset, priv->cmd_size); + + memcpy_toio(priv->cmd, buf + offset, chunk_size); + offset +=3D chunk_size; + + /* Make sure that cmd is populated before issuing start. */ + wmb(); + if (offset < len) { + rc =3D crb_trigger_tpm(chip, CRB_START_NEXT_CHUNK); + if (rc) + return rc; + if (!crb_wait_for_reg_32(&priv->regs_t->ctrl_start, + CRB_START_NEXT_CHUNK, 0, TPM2_TIMEOUT_C)) { + dev_err(&chip->dev, + "Timeout waiting for backend to consume chunk\n"); + return -ETIME; + } + } else { + rc =3D crb_trigger_tpm(chip, CRB_START_INVOKE); + if (rc) + return rc; + } + } + return crb_try_pluton_doorbell(priv, false); +} =20 - /* Make sure that cmd is populated before issuing start. */ - wmb(); +static int crb_recv(struct tpm_chip *chip, u8 *buf, size_t count) +{ + struct crb_priv *priv =3D dev_get_drvdata(&chip->dev); + unsigned int expected; + size_t offset =3D 0; + size_t chunk_size; + size_t first_read; + int rc; =20 - rc =3D crb_trigger_tpm(chip, CRB_START_INVOKE); - if (rc) - return rc; + /* A sanity check that the upper layer wants to get at least the header + * as that is the minimum size for any TPM response. + */ + if (count < TPM_HEADER_SIZE) + return -EIO; =20 - return crb_try_pluton_doorbell(priv, false); + /* If this bit is set, according to the spec, the TPM is in + * unrecoverable condition. + */ + if (ioread32(&priv->regs_t->ctrl_sts) & CRB_CTRL_STS_ERROR) + return -EIO; + + /* Read the first 8 bytes in order to get the length of the response. + * We read exactly a quad word in order to make sure that the remaining + * reads will be aligned. + */ + memcpy_fromio(buf, priv->rsp, 8); + + expected =3D be32_to_cpup((__be32 *)&buf[2]); + if (expected > count || expected < TPM_HEADER_SIZE) + return -EIO; + + /* + * Set chunk_size by comparing the size of the buffer that the upper laye= r has + * allocated (count) to the hardware tpm limit (priv->rsp_size). + * This is to prevent buffer overflow while writing to buf. + */ + chunk_size =3D min_t(size_t, count, priv->rsp_size); + + /* + * Compare the actual size of the response we found in the header to the = chunk_size. + */ + first_read =3D min_t(size_t, expected, chunk_size); + + memcpy_fromio(&buf[8], &priv->rsp[8], first_read - 8); + offset =3D first_read; + + while (offset < expected) { + if (!priv->chunking_supported) { + dev_err(&chip->dev, "Response larger than MMIO and chunking not support= ed\n"); + return -EIO; + } + + rc =3D crb_trigger_tpm(chip, CRB_START_NEXT_CHUNK); + if (rc) + return rc; + + if (!crb_wait_for_reg_32(&priv->regs_t->ctrl_start, + CRB_START_NEXT_CHUNK, 0, TPM2_TIMEOUT_C)) { + dev_err(&chip->dev, "Timeout waiting for backend response\n"); + return -ETIME; + } + + chunk_size =3D min_t(size_t, expected - offset, priv->rsp_size); + memcpy_fromio(buf + offset, priv->rsp, chunk_size); + offset +=3D chunk_size; + } + + return expected; } =20 static void crb_cancel(struct tpm_chip *chip) @@ -727,6 +784,15 @@ static int crb_map_io(struct acpi_device *device, stru= ct crb_priv *priv, goto out; } =20 + if (priv->regs_h) { + u32 intf_id =3D ioread32((u32 __iomem *)&priv->regs_h->intf_id); + + if (intf_id & CRB_INTF_CAP_CRB_CHUNK) { + priv->chunking_supported =3D true; + dev_info(dev, "CRB Chunking is supported by backend\n"); + } + } + memcpy_fromio(&__rsp_pa, &priv->regs_t->ctrl_rsp_pa, 8); rsp_pa =3D le64_to_cpu(__rsp_pa); rsp_size =3D ioread32(&priv->regs_t->ctrl_rsp_size); @@ -764,8 +830,10 @@ static int crb_map_io(struct acpi_device *device, stru= ct crb_priv *priv, priv->rsp =3D priv->cmd; =20 out: - if (!ret) + if (!ret) { priv->cmd_size =3D cmd_size; + priv->rsp_size =3D rsp_size; + } =20 __crb_go_idle(dev, priv, 0); =20 --=20 2.53.0 From nobody Sun Apr 5 13:59:51 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37DF429BDBB for ; Tue, 24 Mar 2026 07:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774336713; cv=none; b=ooD2wB+3IDNZOp61oj+UKhkjpg9NekvGIAbphRBOcE3+x0EkS/8hRFEPJ3yA+/SRiuP3p6eV5iue741Umm0DAoMY/6nvUcgmhbCMBUHCRZn2K0j+e4nTf4tRK4nzzj6lao7K2zmNLuQioMWVjnNWhoJLE6G8LamVn5cRvgZiL4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774336713; c=relaxed/simple; bh=c0+CCyqLqsT7uXnMFtpyj6HXU7Tg8neMyPe+lwo9mkw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CdYsPUMIdq1s7MxY1DlZVTxwlIkjlpESw33UNFsCSbl0tacPSSYUM0K6LkMDN2CeatizFAHpPo+WDYZA9uFkdQbSWLrusToltuay1DQiHDN8Ncqx1EAbpn9sO+xIsEjSZvizCoTPD1ZNGQFFGVDkFRTrFvdojUuRNr8c96UR4nI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FL56V/C0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kKl7P/PE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FL56V/C0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kKl7P/PE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774336702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jRDEOhjwb87Ldqy0HhU0WTQjTdVi/IKgvfuMA4qMFms=; b=FL56V/C09bcKGYyY61JLS7rHjLXDSmGn/e3gxohJwqVcUvEo8NEUtS3ECKV7vfxM1A6qLg l+/2efmhyRGKqF0FLnAmcgm1ldCdDuICkg2asm/yqjKtREU48dwRjzEKe7sG1SRcNew+KM 2EStiDaUHnBusPrF3LF+at8W3H9FxuA= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-nAmIblbxNVazz8yseGTBVQ-1; Tue, 24 Mar 2026 03:18:20 -0400 X-MC-Unique: nAmIblbxNVazz8yseGTBVQ-1 X-Mimecast-MFC-AGG-ID: nAmIblbxNVazz8yseGTBVQ_1774336699 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82a73ec7290so2158190b3a.1 for ; Tue, 24 Mar 2026 00:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774336699; x=1774941499; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jRDEOhjwb87Ldqy0HhU0WTQjTdVi/IKgvfuMA4qMFms=; b=kKl7P/PE7exOqbbERAUrMa8XjizDi+LZoBKJb0fiAUCgkzVKyWpEN2brJik/WoG4rd iUHg1mGuti4+55CdiO4+YIn5U6fynOQIi3e7/D3xczhUTG90lFTKT4T2Neogi3lGqeot bOI68m5CKig+vudAsV8/6KJdV2+g7vRGwZ8GWXBF1KK5c8X+Ly6eKJqyY1i3HMx1u+8K tWuZpa6joKRyFDtdskcXj77poOnFymP6kLNe9C95P7D5xDoSvYA4p1BqmmUf/MjOvKjI 21MZYbdPc9iPeFwIqHvE6yzArgLQdMiBX82ecRIJZRB/FM/GqimieT4PYBNR39sQGzAK esmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774336699; x=1774941499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jRDEOhjwb87Ldqy0HhU0WTQjTdVi/IKgvfuMA4qMFms=; b=GOPRI2pdb0tVapjTEo3S/ojh3c+eX0H8XlFmHc8XTbVCqU5tM3RtV8kwyNAg06tRBX uixQXjQG2ofsTOnVuVI7kb78pJ3114zkU0AAZl0qWCQQZbHItP6+XpyVvgDHQ42IU36q zmTxcr8W9yHPWiA3m+2pO1F37ofLIcmyMB03/9buvu1ziHsd+WSGODS0859JsMdMLjz8 VZDjeQZYMAexuxLDrRCWmub+3tYzrxziga/JHzkggZKc0kKuFr+kvhmliRS4WqHKebRP O2xOVhfTRWmPzQrVyb3aI5yzE/0n9GKsNgnFmgGkEsw3h+RuOCjK2xD4S3OOoFiv7zp8 3cwg== X-Gm-Message-State: AOJu0YxcKDzyYg8hoqh3UsUM9ADFSl0tbf/vuHbgAsvDet2c0faq8qCq GjZKFpDbXZW7fVE/j6H+ZLCc8UpzMSQmb6IIPmUQfFcpC0mLpRlj5kvF/k1aJ8O8Oywt1i9Xmd+ 9Nu6SvnyRA7craXhmYATxDARQJAKLdJ6Sd4MBnBcsodhxwNxa9Kw7yHg///5YYA3c4jbl/jdH23 obx73f47jm++ppHlCc352I5LCXbJ0BeHlYg+Rcf0/8la2HQ0yZ X-Gm-Gg: ATEYQzxu1jagQx755VqrWVt377/eh9XAkjpNjokGP0XtHlk+NSm5tiryC9ZJnfzEFVF 30dGeEaWlnwUNdhrvh4m4dDERvYEfGeLLxbGR5HDIr4gsHN3BOPonO6omsn0NdTUfOiVFZ4gdqF LDZ/7/DJ+rCvouTqoC/9qf6mnpEOP4l13hdgaLZtdmcOrYiVQWZ6Yj5lqxrvnqwipACKHKms+Jj Fi2BQtSJV2IixnoQJfV6xWpI9ivKOaX5vB0ZEK98fWcJ6Z34Bx1Sn2EEFyNp7LUg3kwEeXOC9zt nVVGgKP8cjMHUdQ9a3DQBSTnDuc2KWde4ayxCmpH7AXdYVkbGRo7R/EAdQPhTKuDJB2mK5/Qd5S UoYkeCPDzextvjQCcskpcr/E1EBN42zgyXenKxd6Zla5efhqYrQafB5L9YxxAOw== X-Received: by 2002:a05:6a00:1d13:b0:81c:717b:9d39 with SMTP id d2e1a72fcca58-82a8c3a5119mr13438043b3a.56.1774336699116; Tue, 24 Mar 2026 00:18:19 -0700 (PDT) X-Received: by 2002:a05:6a00:1d13:b0:81c:717b:9d39 with SMTP id d2e1a72fcca58-82a8c3a5119mr13438016b3a.56.1774336698637; Tue, 24 Mar 2026 00:18:18 -0700 (PDT) Received: from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.106.26]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409c681sm13597766b3a.37.2026.03.24.00.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 00:18:18 -0700 (PDT) From: Arun Menon To: linux-kernel@vger.kernel.org Cc: linux-integrity@vger.kernel.org, Jason Gunthorpe , Jarkko Sakkinen , Peter Huewe , Arun Menon Subject: [RFC 4/4] tpm: Increase TPM_BUFSIZE to 64kB for chunking support Date: Tue, 24 Mar 2026 12:48:03 +0530 Message-ID: <20260324071803.324774-5-armenon@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324071803.324774-1-armenon@redhat.com> References: <20260324071803.324774-1-armenon@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" - In tpm_common_write() the size of the command is checked against TPM_BUFSIZE. We therefore need to increase the TPM_BUFSIZE to allow support for larger commands. Signed-off-by: Arun Menon --- drivers/char/tpm/tpm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h index 87d68ddf270a7..a6933eb075296 100644 --- a/drivers/char/tpm/tpm.h +++ b/drivers/char/tpm/tpm.h @@ -33,7 +33,7 @@ #endif =20 #define TPM_MINOR 224 /* officially assigned */ -#define TPM_BUFSIZE 4096 +#define TPM_BUFSIZE 65536 #define TPM_NUM_DEVICES 65536 #define TPM_RETRY 50 =20 --=20 2.53.0