From nobody Fri Apr 3 17:56:52 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CD052E6116 for ; Tue, 24 Mar 2026 05:20:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774329616; cv=none; b=F1ixwm9C9vELFz5sEpnMVQvbLnQBonbVBCJWu/gM2m++dqHsczG35s/BtciUPjKZfUT0Qao/CzuUhNzRCBGnDWF8oJiEL3DE7pS30VkDcvzuCsdKIFGYoDhCeHkZxZ01TK+3zqj9etpvmkNtm3Q/APDCXGplVtt/BMQWIXV5B/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774329616; c=relaxed/simple; bh=phvAnSpR1eSl5qsE+squuz1VYQdzp5vQhwkgbm0GIbc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l7coZbdjGfFfUA+BGIaqdETkygydc06AxoWITihxiMKnY04YCEdXr+B916Wrs/HLHU7FKndyCwVk+DsJPLKNTS+3QsILsWmZM4n0e6qg4jr5PDJhCquUQEZYECCjSSEQu8PiMgiRTqAfVGrU956FNlOVwMcGt6bsYoPCdlKHpkc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=UJXHZy9J; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UJXHZy9J" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-35a1230c60eso1703672a91.3 for ; Mon, 23 Mar 2026 22:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1774329615; x=1774934415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d+G5opAB+jyNCsDIm/30vZQM14H1ghGVf70HXUwqlUM=; b=UJXHZy9JTxJA+Il27Gb79gv59RmBGE0etnVy74DUtL53mUaSvnIPyRb1Cj+Ee4byks kPt4D4IHgwzI64Ai5UB5KceeYglPMSyJz7YneS4gnuVrJvkCk6w6yv+Z5BNw6OtpAm7W 4JCLQX+w9pMcIkrWyMcwG0oddvZmgSLtY27iI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774329615; x=1774934415; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d+G5opAB+jyNCsDIm/30vZQM14H1ghGVf70HXUwqlUM=; b=qsnlsJt2djjfrU/0Kr19bJj8EP5BzqvhAhOho0wzaiKjRrJig3dyHTZ5skS5Fa+KOO ZCYF9tRUzPns+Mbst6P7P0G6KbLcLy98jRvwsqrNdNyh0jTO19rc99bXjyAJ6zGPbRs2 sH11vHMbDBBYdZVCpVJXwHdrAkzRSPZJZ/spulDh3iVEEkvEUtyaWDYjH2LkWLmAtwbp LTiQ5fLhL4BTpc6Eq7R2801q9GklNKxFctHrqXArX32fRFDTQhpttIM9LZrDbcbxfgdj 8fSM6XO9ahuPmb+GEco5WXWs1MDVZPlMGVMOLzp/2/+IW+Y/NJEqGyuEUkJJPovBzHum JaMQ== X-Forwarded-Encrypted: i=1; AJvYcCXjb8cqO57LPvlaCykKFAM5nL7EujrDhebZFYU5tWQ70L7tHeZpOPwpC7anhnB2lSvscL434mmkxlJigk0=@vger.kernel.org X-Gm-Message-State: AOJu0YzwOnKf50NY1dDT2fja+i5H0nmlySJkRnTdgQBYHJMTJ3NuNLfq giVCRBnRz1e0CQZ4BHhPJ6D/0/NOUhMO1IgCau6bznjLQRNYflsSgKWaM/bfFnDSmw== X-Gm-Gg: ATEYQzwJot+APmT4wHWvmVor9ZOK1ni3m5iTsV1GnDdE2u5lwyXEgPa3AH2DZzYHzX4 1ZyK/krYECEcARcKe/2wf0pSvLTO0QDweR9W+DV/Dp3mb5OJA4W+GdClq9cEHpkmYfzweTKL1OG 5oXuKrs1J4ZBAuEoSJTahfFdOL33g/YcvVXULDmbwCdcwk8LD2ORQyMKqGk7klMtqvkLQIcYOW5 OkmNNSDxQUEW1WBbMwpncm/AVS4BEKMk+Ke6kyJsryfunY0NipcDN0NuS90m6460h9V25ECNTsT tOFDT70jcfM+ukwx3TkOBPQrKH50TqAht3rO3jbtEYJTgpGh1KraaRAxWCXoAiJhW9rrtj6J6TJ +P0MTQjTs9oDu6+W535qY3FpDdeSwStDL/iMkpGv6b5sa/4ubgrEQMCls81U2kdeb5IYLQegF46 Taqn2hoCyCL38CGpXsSlWVpfaRtVx/ZH4HRAoCajrbJKycLN28MR36q7C1x+dQXNwtItHDSutuL kTyMBTK X-Received: by 2002:a17:90a:ec84:b0:35b:e56e:b5a6 with SMTP id 98e67ed59e1d1-35be56eb622mr6319388a91.1.1774329614922; Mon, 23 Mar 2026 22:20:14 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:19a5:8f2f:d584:8078]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c03124a87sm1068647a91.3.2026.03.23.22.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 22:20:14 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Ryder Lee , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas Cc: Chen-Yu Tsai , Bartosz Golaszewski , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v6 1/7] PCI: mediatek-gen3: Clean up mtk_pcie_parse_port() with dev_err_probe() Date: Tue, 24 Mar 2026 13:19:53 +0800 Message-ID: <20260324052002.4072430-2-wenst@chromium.org> X-Mailer: git-send-email 2.53.0.983.g0bb29b3bc5-goog In-Reply-To: <20260324052002.4072430-1-wenst@chromium.org> References: <20260324052002.4072430-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mtk_pcie_parse_port() in the pcie-mediatek-gen driver has a bunch of if (err) { dev_err(dev, "error message\n"); return err; # or goto } patterns. Simplify these with dev_err_probe(). The system also gains proper deferred probe messages that can be seen in /sys/kernel/debug/devices_deferred Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Bartosz Golaszewski Reviewed-by: Manivannan Sadhasivam Signed-off-by: Chen-Yu Tsai --- drivers/pci/controller/pcie-mediatek-gen3.c | 36 ++++++--------------- 1 file changed, 10 insertions(+), 26 deletions(-) diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/cont= roller/pcie-mediatek-gen3.c index 75ddb8bee168..1939cac995b5 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -876,10 +876,8 @@ static int mtk_pcie_parse_port(struct mtk_gen3_pcie *p= cie) if (!regs) return -EINVAL; pcie->base =3D devm_ioremap_resource(dev, regs); - if (IS_ERR(pcie->base)) { - dev_err(dev, "failed to map register base\n"); - return PTR_ERR(pcie->base); - } + if (IS_ERR(pcie->base)) + return dev_err_probe(dev, PTR_ERR(pcie->base), "failed to map register b= ase\n"); =20 pcie->reg_base =3D regs->start; =20 @@ -888,34 +886,20 @@ static int mtk_pcie_parse_port(struct mtk_gen3_pcie *= pcie) =20 ret =3D devm_reset_control_bulk_get_optional_shared(dev, num_resets, pcie->phy_resets); - if (ret) { - dev_err(dev, "failed to get PHY bulk reset\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to get PHY bulk reset\n"); =20 pcie->mac_reset =3D devm_reset_control_get_optional_exclusive(dev, "mac"); - if (IS_ERR(pcie->mac_reset)) { - ret =3D PTR_ERR(pcie->mac_reset); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to get MAC reset\n"); - - return ret; - } + if (IS_ERR(pcie->mac_reset)) + return dev_err_probe(dev, PTR_ERR(pcie->mac_reset), "failed to get MAC r= eset\n"); =20 pcie->phy =3D devm_phy_optional_get(dev, "pcie-phy"); - if (IS_ERR(pcie->phy)) { - ret =3D PTR_ERR(pcie->phy); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to get PHY\n"); - - return ret; - } + if (IS_ERR(pcie->phy)) + return dev_err_probe(dev, PTR_ERR(pcie->phy), "failed to get PHY\n"); =20 pcie->num_clks =3D devm_clk_bulk_get_all(dev, &pcie->clks); - if (pcie->num_clks < 0) { - dev_err(dev, "failed to get clocks\n"); - return pcie->num_clks; - } + if (pcie->num_clks < 0) + return dev_err_probe(dev, pcie->num_clks, "failed to get clocks\n"); =20 ret =3D of_property_read_u32(dev->of_node, "num-lanes", &num_lanes); if (ret =3D=3D 0) { --=20 2.53.0.983.g0bb29b3bc5-goog