From nobody Sun Apr 5 16:28:58 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0296241690 for ; Tue, 24 Mar 2026 00:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774313042; cv=none; b=AOQdq4ruuc1ZxB6EBRt10eWTGaE+dkoxUBF7lAr8F8pDl4Z25O2HX9PVSAj+zN4JekhRq1vuS/dKXCPHVczFqOtB/cThzo4xy/0pEW3z5CKB9cB7gDz30bUUJjcOW+HWCNv7b/iObI1MuS/RAE7ctuujhV+OGOXJS3iti1j60B8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774313042; c=relaxed/simple; bh=YhtyfJ45Egr/v4difiiZp6RTk5abgQy3xHFlwXSZ+mI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=tRVsXMO5QyoZWOtMBbTSUQkJzYEshfGpJGBC8HQNAO8KSVGTG5/sS+M/M5Cm1DtyxPmScE5acC7U7lm+bntHM+BQP+KcK5m7JqGy53UDFjgjKXJE8lM5H60O9lo3Yt2vZJU+RVXoU1r5rxN1NUGoJgTsEvoZXp1XpEQUxVz8ko0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kagXhBpw; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kagXhBpw" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c742723c863so2795237a12.0 for ; Mon, 23 Mar 2026 17:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774313040; x=1774917840; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WDF2rKSjnx+vam0p+IAkZHVoKVx3ZMEABJISbR0EKR8=; b=kagXhBpw2+IPoIgrmJBkqHEJxDZDOS300cG8dfkOWLAnviyHg4I3d7f3cU+1gawLlS /z/gG2dTEJ2ygJa7uzlH+kW7bbheQWWGIlNrW1R9i3nQniipgZakomPSZf7t4vj7uFi9 ASiEi6oIYRoGwwazw0LrB/Tf5h784MMXkLKRei+HcZlkE9KidGnbvDDObZY2rLBrXp4X L+iAp4tFt12o69OKN//BAGeY234zJpUr48027IgFKY/UwZA7F24g/gEZEZ8wCjrqNRwr k0ddklj8BWuHO3qBYGdUI/yK/HLet3zRUcNFzVxo5BXFe7jLsPITIHTMTJ+ijjkBFQMv 4FGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774313040; x=1774917840; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WDF2rKSjnx+vam0p+IAkZHVoKVx3ZMEABJISbR0EKR8=; b=V+HtRM5P2xxg9IMCx6fLsKcXO1je47QmVONowUl5aLdIMf9DC37Gc3Xguf2yUqu6PR PioeVg0O3BrOyMnWhM9pDUyQj7qFmqy42Apcj57KL2iDajf7oZz2TeDNhKHui6kEOqm2 Oj5LzoAmRkvVNXcH4lHWWcLAKQ0afjM/sOjUqySwwtiuokoz8qZ3LWrudcfrRk6ak+k0 rQPA26WOBPSDbS/froySvA1JBl5dvvmpk2bUSY+ZJMdFrVC/LObe5LX4RMi8qQz0WDIf ZedjNzcQEPKcZQP1ZYvV/ORtuny5g/mFdcFCXHqDo5AThTcKkKKI44AS0luyvUIOhBsP cuuw== X-Forwarded-Encrypted: i=1; AJvYcCUfyViJZa5CNsIGEwiL4pDVC3wspa5SUGcUCC29X/BZRMQQcL6fx2TokieZM66MzI8atxVSUKJ9FY4YHoA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0d+T3EvpHvoZY/x50p7vIUgyl889DsuIgmDGPlk6s5bpGJ02Q 1aA+ObPXlG39DB3s4CO5olfnylWVbLFsoyoMc5BIEByWoHEtGr+OehPe X-Gm-Gg: ATEYQzz5qAjoWQTzlvmrtxcYY4GnBomLFPdWFaAfUYs3zI55uhB4Bi+SB4q8PG/os9H YTJRTUjGOj5yMlWFJdr2WcKD4wKNb9sPbnUstgkHKSIJt2oypkDsqfoDd+VJHdMasqwuF5zPuAh 7Zi4EvV61hGvndzlyN/o5VBeRFGFMhs/m3uhVcEz3PS4uARgZsifzv0fOTrkYmfPYe/oN2WOz9G g+U1klftKUpQ7EZfdJ4pqIgc3GfYdrC3QfqM/IMKsABP+kvE06yd6SJSQnMbf3Z1Z8SU2SrySLz /WSZqjqVZmbTm8NRZIYK2M3Q4HJWZzBSvQZowS22XxEfOSo1Mnz6/UO7S/lUpHKL1b47KLbKthX bOfsFIy9sNIuOG9aZMmjFeZG8cCjmc+tZqq5Pdo7UNuShNMc2rZCRgFcfWsl4RK6gY2OU6mPZwD 6c2GJYWSc13gr7YJTXDQ== X-Received: by 2002:a05:6a20:734b:b0:38b:dec8:9da2 with SMTP id adf61e73a8af0-39bce9f7a44mr12203730637.26.1774313040089; Mon, 23 Mar 2026 17:44:00 -0700 (PDT) Received: from localhost ([111.228.63.84]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c74443cc2ddsm8105285a12.24.2026.03.23.17.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 17:43:59 -0700 (PDT) From: Cen Zhang To: jaegeuk@kernel.org Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, Cen Zhang , stable@vger.kernel.org Subject: [PATCH v2] f2fs: annotate data races around fi->i_flags Date: Tue, 24 Mar 2026 08:26:20 +0800 Message-Id: <20260324002620.3879274-1-zzzccc427@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fi->i_flags can be read by f2fs_update_inode() in the writeback path, f2fs_getattr(), and f2fs_fileattr_get() without holding inode_lock or fi->i_sem, while it can be concurrently written by f2fs_setflags_common(), set_compress_context(), and f2fs_disable_compressed_file() under inode_lock and/or fi->i_sem. This is a data race as defined by the LKMM. Use READ_ONCE() on the read side and WRITE_ONCE() on the write side to ensure proper marking of the concurrent accesses. Fixes: 19f99cee206c ("f2fs: add core inode operations") Cc: stable@vger.kernel.org Signed-off-by: Cen Zhang --- fs/f2fs/f2fs.h | 4 ++-- fs/f2fs/file.c | 6 +++--- fs/f2fs/inode.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index c66472e409a3..28161df79e4f 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4764,7 +4764,7 @@ static inline int set_compress_context(struct inode *= inode) fi->i_compress_algorithm =3D=3D COMPRESS_ZSTD) && F2FS_OPTION(sbi).compress_level) fi->i_compress_level =3D F2FS_OPTION(sbi).compress_level; - fi->i_flags |=3D F2FS_COMPR_FL; + WRITE_ONCE(fi->i_flags, READ_ONCE(fi->i_flags) | F2FS_COMPR_FL); set_inode_flag(inode, FI_COMPRESSED_FILE); stat_inc_compr_inode(inode); inc_compr_inode_stat(inode); @@ -4791,7 +4791,7 @@ static inline bool f2fs_disable_compressed_file(struc= t inode *inode) return false; } =20 - fi->i_flags &=3D ~F2FS_COMPR_FL; + WRITE_ONCE(fi->i_flags, READ_ONCE(fi->i_flags) & ~F2FS_COMPR_FL); stat_dec_compr_inode(inode); clear_inode_flag(inode, FI_COMPRESSED_FILE); f2fs_mark_inode_dirty_sync(inode, true); diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index c8a2f17a8f11..abff927a8699 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1005,7 +1005,7 @@ int f2fs_getattr(struct mnt_idmap *idmap, const struc= t path *path, } } =20 - flags =3D fi->i_flags; + flags =3D READ_ONCE(fi->i_flags); if (flags & F2FS_COMPR_FL) stat->attributes |=3D STATX_ATTR_COMPRESSED; if (flags & F2FS_APPEND_FL) @@ -2153,7 +2153,7 @@ static int f2fs_setflags_common(struct inode *inode, = u32 iflags, u32 mask) } } =20 - fi->i_flags =3D iflags | (fi->i_flags & ~mask); + WRITE_ONCE(fi->i_flags, iflags | (READ_ONCE(fi->i_flags) & ~mask)); f2fs_bug_on(F2FS_I_SB(inode), (fi->i_flags & F2FS_COMPR_FL) && (fi->i_flags & F2FS_NOCOMP_FL)); =20 @@ -3437,7 +3437,7 @@ int f2fs_fileattr_get(struct dentry *dentry, struct f= ile_kattr *fa) { struct inode *inode =3D d_inode(dentry); struct f2fs_inode_info *fi =3D F2FS_I(inode); - u32 fsflags =3D f2fs_iflags_to_fsflags(fi->i_flags); + u32 fsflags =3D f2fs_iflags_to_fsflags(READ_ONCE(fi->i_flags)); =20 if (IS_ENCRYPTED(inode)) fsflags |=3D FS_ENCRYPT_FL; diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 078874db918c..17c8aff690fb 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -720,7 +720,7 @@ void f2fs_update_inode(struct inode *inode, struct foli= o *node_folio) else if (S_ISREG(inode->i_mode)) ri->i_gc_failures =3D cpu_to_le16(fi->i_gc_failures); ri->i_xattr_nid =3D cpu_to_le32(fi->i_xattr_nid); - ri->i_flags =3D cpu_to_le32(fi->i_flags); + ri->i_flags =3D cpu_to_le32(READ_ONCE(fi->i_flags)); ri->i_pino =3D cpu_to_le32(fi->i_pino); ri->i_generation =3D cpu_to_le32(inode->i_generation); ri->i_dir_level =3D fi->i_dir_level; --=20 2.34.1