From nobody Sun Apr 5 16:28:26 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB843C141E for ; Mon, 23 Mar 2026 16:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774284094; cv=none; b=Eb1y7w5LLNkzZmJHKJsf8ByU4UPgOwfENXy4UTJN8FuLNWGNdiIRYgdBDCsAi/Xwn0kSJVICQRf6Sr5Z1JM88mz26khvoJDpsSUjII3PQCVCoRq2HdHZCAanw0ODVu1hvtO0ymfaIflKefmYYANscbMKtlmAqoMWu99pPUAy8H0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774284094; c=relaxed/simple; bh=kwohdgYd8IrLunvMAoMYuVyc58nNiOpsOSgXMSwxgWQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=PbI+PME3AzPxz4can+5wLh3e8mwjQ0Cl7iSX+jTzk5kEi4BeohSm/nxE0AYyJ0Z4mbZ7oDF53RGJd9ziSqN3NPU+ixVa4GOaNI5U6907pvjg0eRwfQLZX9YY5+/lKqdzopv9RIAGUloH3vNHBlknN7/Ftqpbgk9lstM9nI/3mrk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iZv5D5gX; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iZv5D5gX" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-82a655cfab5so2929430b3a.1 for ; Mon, 23 Mar 2026 09:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774284093; x=1774888893; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=nndZJkI5xG5h3HrUaxNzDDVTCF1PjouQEC2KLzwoYn0=; b=iZv5D5gXlyp8/IfFkSMs0FQ9GZvMNTMSM+9iic8KrGDptfX0X0iwVz/oMh2IX8yr2g TEnSGvhh2FFW+hW5dpcpdit81bQQRdCuBxQwwVDbM0c/DuKBmcN0WDw1ZIxLwxh/B9f3 GzzJYZUpqOlTKetszka7EZcEf9DJ0kqcqDMBwzEKVPLosiFPDRVe9n0avKLfEdtT6Cv4 8ZevzRHf8FcOWVGZ/KgskGr3sfPLKKO0/qiza7vtVLxDDLTQCHJ1JdV7Nbuhul4fezBY tBeXP2Bdj1oLICtgv6gsIbGJYgBkX3d2v9mEl/tGHsaOspbz6D0s/vKLiVHmewUnN7sE uMjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774284093; x=1774888893; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nndZJkI5xG5h3HrUaxNzDDVTCF1PjouQEC2KLzwoYn0=; b=s6klpxhHlyulnPHuUtiuRxmbm5cjx1tZTDDsuhIAQ/hYuDh6uqg828PGNjzki+8ZA9 c4qprn7/edz0VY/sfbZrpZ/Oh8qHCo88Kc3eQh83BJeGkH+brGHqCmRv9GXuucEMZJL8 xlH6ZmLjMQ5gTlvSWtiOooXzNJCdBMqnJxUhg+B45Jz5M7c2sjTeSWlRRo4exYkqAbvg P2yL6SYBgg/4NziGXm15o6+hNdfQK3X6HwYLeAzKJTd7S/PPJZgp6lloDUsttWBxLXtT KoIzJUMX9TzONoWNZRZkJgoip/m0PjNS+0613Rl64MmPrWv18AaLbMYc+aeM/sfGpllr ZoSA== X-Forwarded-Encrypted: i=1; AJvYcCXCJlVpup4NFwhLhfFIVft3apy/OaiXJmCBOgrf2PZAJKEr56vddM56clhU5p/mmT3DLoDt3pxWstvpefo=@vger.kernel.org X-Gm-Message-State: AOJu0YyskHWCqFqnhtszMpphS09NUPhzf2QxNSN05VQyqDHpt1tk9Ene CDWij2lbeKVSYXPLlhL9SjNj9GIfoKK6kjX/+AIsTPAOch/tzVWRAiAV X-Gm-Gg: ATEYQzwPo76hUdpjTiGxb3abSuysvKcm7H2DsoGjso4F7bp0VpGz8rUdS3Dl1whPCe2 J4mjtXS1yyQRUYqPpR/JIaBsB2hOcIts8QlTajE1OrSrgMIheYDAnNm2/EoHRgb7pvGzFSCne5W 47ODDc5XmWe2pLeXaGtJRTG0NwpPF2pr2xUDFZIYH8DxDSNpu6FDBPLuiRlLshnvc7kuZjYnuFV r35bnyaM3xka/XxBATbGRShJfCJoJwy3Nf36xpA6KyVqFcTMxVE7ZlApc6M05Zc40CLjgISv209 UYpIHhanfLkUwwvlfO9hCGdBmly2VFKjV4JQHD5VrXLXwZzajRMR6OiX5N5U7m+HORa62J/HLh8 RK4QP8ORgrF2uFAx+zilqizypaHyLaMz1XhOi22XnIqe7HajSdmTS0XBlQuslodoI1TE49J2msl HFz7EpMy2gS6LNldINPD8LkdDQZ2m9aAC4823O X-Received: by 2002:a05:6a21:6d9c:b0:39b:e321:784e with SMTP id adf61e73a8af0-39be321794amr9295685637.60.1774284092836; Mon, 23 Mar 2026 09:41:32 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c743a817cffsm8191116a12.11.2026.03.23.09.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 09:41:32 -0700 (PDT) From: Felix Gu Date: Tue, 24 Mar 2026 00:41:28 +0800 Subject: [PATCH] PCI: sky1: Fix missing cleanup of ECAM config on probe failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-sky1-v1-1-6a00cb2776b6@gmail.com> X-B4-Tracking: v=1; b=H4sIADdtwWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYyNj3eLsSkNdC0uDRCAyN0pKNlMCKi0oSk3LrAAbEx1bWwsAo1XYOlY AAAA= X-Change-ID: 20260323-sky1-890a90a72bc6 To: Hans Zhang , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774284090; l=1262; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=kwohdgYd8IrLunvMAoMYuVyc58nNiOpsOSgXMSwxgWQ=; b=ghymkqUJvu+v4wi/ti+ML8CDhq5Lw/lK/ST6y/0+VoUgaql5hghTqO8BAeCwS5bdMkR0jbOZu F2Mk+0b4vQZDIDuosd5djgx/0bNWDdtHwo3+daahwZ45qhqXk1atOq0 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= When devm_kzalloc() for reg_off fails, the code returns -ENOMEM without freeing pcie->cfg, which was allocated earlier by pci_ecam_create(). Add the missing pci_ecam_free() call to properly release the allocated ECAM configuration window on this error path. Fixes: a0d9f2c08f45 ("PCI: sky1: Add PCIe host support for CIX Sky1") Signed-off-by: Felix Gu Reviewed-by: Hans Zhang <18255117159@163.com> --- drivers/pci/controller/cadence/pci-sky1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/cadence/pci-sky1.c b/drivers/pci/contro= ller/cadence/pci-sky1.c index d8c216dc120d..9853a9c82c0e 100644 --- a/drivers/pci/controller/cadence/pci-sky1.c +++ b/drivers/pci/controller/cadence/pci-sky1.c @@ -176,8 +176,10 @@ static int sky1_pcie_probe(struct platform_device *pde= v) cdns_pcie->is_rc =3D 1; =20 reg_off =3D devm_kzalloc(dev, sizeof(*reg_off), GFP_KERNEL); - if (!reg_off) + if (!reg_off) { + pci_ecam_free(pcie->cfg); return -ENOMEM; + } =20 reg_off->ip_reg_bank_offset =3D SKY1_IP_REG_BANK; reg_off->ip_cfg_ctrl_reg_offset =3D SKY1_IP_CFG_CTRL_REG_BANK; --- base-commit: 785f0eb2f85decbe7c1ef9ae922931f0194ffc2e change-id: 20260323-sky1-890a90a72bc6 Best regards, --=20 Felix Gu