From nobody Sun Apr 5 13:12:26 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EA863A168E for ; Tue, 24 Mar 2026 18:27:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376843; cv=none; b=qorO/SRJGe0YGYWOpn10uxIvKw5WaR9AnuNLBPurs32HE3rcFTOl/9LfM40WE3YAHEmJdmbfcQzfR7QMKvvjlO361th6Fe/Dtq07NhY+m4yqfL/o/LTFzSsWNV5UGtcRIWsrejqSKiQ7BI5rACY180tyEnlOqTveRT9MDVjny5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376843; c=relaxed/simple; bh=WceX/6ppqZ5DUDCGfEWL1pZY9tLdtFM/DeuPHESZPQg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J3R47qlohky9aCmNtHEEm6QOH4nqe56v/KFRHiqroNXXHtrnhuFLkjBJBGOtrEfpyU1gRES01U69c6P4G6K82Cv8tfS+LEE73M4PMKozbgSBcRPCBZokMJTC0vzbNDoDICt3ELtVCOO3M3+GXmpP7k1NblvEarsM3ZF4a+OAgmM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N1OR6qgw; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N1OR6qgw" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-35b88a4f123so69411a91.1 for ; Tue, 24 Mar 2026 11:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376841; x=1774981641; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JU53ztXeIg9rAt/w2RhxQEA1HrNV+jGEvjmkGqWYdZA=; b=N1OR6qgwQZFIk1qimWDJyLNC+TZimmi7uUoEB0KNSGLSQ6R8NqoJvBUMPtkqrn/hUi 5d7JWuQhIS65yAhQspsKOpNRvA5T/olX2q0F2IfNBMUTtFoKDQP0yaH2p6cy3G53A8LT 4scid4z+Trm7rWBKmp0M810wqUhWF/HLjnl8OEg1FDuBVSOiYWNtfVFBb15VIUBPjOHR SaCWhmunjTbPRZBz41LBsud4/ZVhv7JSOI8JkY2Lc+4TjI9PkSbjyjoYQ+tANwPQrz48 pee7fBS7IEfZnEwi9jG5lJPkLVey2125luyoENugBAx7jDkrPRMdNNLAjTkB4NtMwi76 kQug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376841; x=1774981641; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JU53ztXeIg9rAt/w2RhxQEA1HrNV+jGEvjmkGqWYdZA=; b=f+nRtkJRyY9f1xKuEZRorsK/fVLvt+Gskg2bpVpdsJWyz3Ut3mDTSKQL89NYe8c4vn ZN4l/Vf06bk+YAngSILTPNMoJrUH3oTCBVla0mb9pYRqxl0GSDphdJVmkDkuzp/lYP4y glAbwV9OzetghKZ8fLIl9D2qK1fGJUVQ40/p/iluje3HMA4cHu3WXwkJ15n0utEOKHrk cqksdtdSdYVlhj8LOb/LWnyGInInZkHHG167JuFw0MGEqNXy3QPtobQ2QsaHklvKa30+ PF7HMxflOpY5IcE6YjIlpfD9uGGFeafkeXggSpRPVGxGVC2A3QEHobX2gyvmUrR/d3lN /n4A== X-Forwarded-Encrypted: i=1; AJvYcCV+rHU1oCCMtguK4M+5ad8eJIx5/UffXoXhdBIxoIRuVXMj8YMZUm64dXnneZKKZqVysmbScqIuDBcpY9w=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0tkx3vJiz5zQ5drS4rwicwRhjPznVX7dYha39uhg6PlLGQf4G cR/w8mKJN8ry6oZCQwN24d8csCfKriWaU3yg9ii4yVTVdqDqi0HlDv04 X-Gm-Gg: ATEYQzzzbLczVrTKMmGCNtRfn76++eBxqi0KKJ1UtB5jzamvXRyGMm1bOxeBiRRNIxW QZtLuRLLsYjKgfmMrZoK+Scuvtw5owx53h15spW0jA+VfTMxpZM1uxesGR762uvl49KVD9b5T0b M2ippnhipwFQeT9EUHOTb1GgDVV5RhVP/xVIAcK+n/mdFcBxXq9jEdZmuc0vaT9kDCHGcUGVEHt Lj7ksUByPgrSutJ2fHWit71gBQPVC1HYZvrr1a3yScpjn8Q2vezVHhGFu79fDTXp6IMHZvcbkny pLFODkXWuPbFTNEl/tjW97gcS2jQLbc1qGhb+jfwePo2Ej/lM+7D2kZ1XlGApLDwNSKb7kt8iH2 oJ/1hkB0QGtvD0MUGsM446jtpS1KHNtSzAXPnVxOPzmK5oTL9VBqNAP7x385fyQekWgCNAXyQaU gXu9o0cMaLZdZjLRXzoRl6rbBO9g== X-Received: by 2002:a17:90b:57e3:b0:34a:be93:72ee with SMTP id 98e67ed59e1d1-35c0d1451d7mr559615a91.8.1774376841343; Tue, 24 Mar 2026 11:27:21 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:20 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:49 +0530 Subject: [PATCH 01/10] i2c: tiny-usb: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-deverr-v1-1-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=922; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=/rm2EO54Io9Vb7rL8ZSyeOBixCamQEqxJe9F/gCdBcU=; b=ndfdbjfGLfy7wqu+RVI89cU1BdFSOOxdC43vbHuPhEqbITAhbeTXofEpCDO4hCGofdSsBz5rg /eaMZdocnKzBw4U70BqYrFGGqU2cbJzMF6jNMLwPSl+hIPTFUD50Y/N X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-tiny-usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-tiny-usb.c b/drivers/i2c/busses/i2c-tin= y-usb.c index 9ef495f88ef2..0637c71126f9 100644 --- a/drivers/i2c/busses/i2c-tiny-usb.c +++ b/drivers/i2c/busses/i2c-tiny-usb.c @@ -260,9 +260,8 @@ static int i2c_tiny_usb_probe(struct usb_interface *int= erface, dev->usb_dev->bus->busnum, dev->usb_dev->devnum); =20 if (usb_write(&dev->adapter, CMD_SET_DELAY, delay, 0, NULL, 0) !=3D 0) { - dev_err(&dev->adapter.dev, - "failure setting delay to %dus\n", delay); - retval =3D -EIO; + retval =3D dev_err_probe(&dev->adapter.dev, -EIO, + "failure setting delay to %dus\n", delay); goto error; } =20 --=20 2.43.0 From nobody Sun Apr 5 13:12:26 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 704BC3A168E for ; Tue, 24 Mar 2026 18:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376853; cv=none; b=OGVL/Tbw08nt5YBJlBeqCVGWZJCAVXi2BdZzphYLPklgB2wg8RPl84Hb240E02WBsv4VF3WKnrS5rJDi3VOjAV3cg76WiflU4WBWn9VSI5FrS/D/Qw2/T7V+7DAJqAuQ7hXF7hUZI7HR1QSxw911xcJK93QpQnUEk4aT2MN29eE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376853; c=relaxed/simple; bh=+c/3pLSCjN8W96sioUUAyB3Q4h2iU9EyKqZsQlwSrmM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uIaRuCDmICXS8P1G5WmkAOmEjdozIeQHVX5tZXe/XUsgzkEO3om1aNrMoCT3yL30sz84gRcCf92pYtFlYSDsPjl0N7aPpUpsMzBGTBjm/beCE8+RyHr5LisVl9XXB5c/XJGUH4d1vArUXi19aZLtQpwj8Nwv6mA6pJtFxouYZoU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GC+or1ZB; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GC+or1ZB" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3567e2b4159so1186506a91.0 for ; Tue, 24 Mar 2026 11:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376852; x=1774981652; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9Gsg2Xtdfdl+8IY6r0o/RyYDfTlBlRsSZJpA/oULFGs=; b=GC+or1ZBszh9b/mDXpyH6YFSURr0Y7FWzKFYXJDiHRRqorLsJ662RFHGQO6Rh2nR8T oswnXCPH9ejMEIda9bLMUS6333IvfiZol2LGDVpZUTvoOlKIt/ifsA+VX1MDE9SJBerP Pz/dvsPKLzzLalpazat9fha9s/qqJ+HE2X1R3Ac32KjrOZqYUNAadRzu40i5FaJH7gEL RD+nDC6/ZIS/vlM3GAXn+ro61ShH5l17OLFsWgT8gbAzHMt5ve2ZPRoxaEnNEH1+FmOQ Tz0GkRr4brxK3jmxMYEBef1q3853H146BClaMsNTRhFsjT5P6bZINZ8q9ev5LG3UWAVN 6Shw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376852; x=1774981652; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9Gsg2Xtdfdl+8IY6r0o/RyYDfTlBlRsSZJpA/oULFGs=; b=auYlYNBs5z222ZipDjFRhZ/vKkdTKULtpsZKqiyDJOAF7IU9r8g4V46wRS+v6hJma3 Co57tBjl6V8Tn248dCGtK0Bk9BlTeiimXcnCOnMpOvjuz7YnyuAMgdLKnSyeMqFl/EK9 okiImvaUJ6SVSVe1VEU/e75AicV9BFj3s1rddRDU7Z4nn4XIQL+SjMrirnzWOYFr3gwd gOPc6UNy3lU+dGKxGZyEiO+bSowQyNFaFa99KP5Z7K7qpWRPrnF+btSQAOTvLiGIetzw PZP0/7ZfMqSzjyyv7f1bdReYB5o6eI0WGhOJcbVTtnVblNWQWbndNlZ+e/JOOTM/vz37 oi3w== X-Forwarded-Encrypted: i=1; AJvYcCX+LQ4IA82RI01+nETXLjG56/rsg0/e09GRDyMwnpoOdU/SEzvp3U64Re/xjUT9U81t2ZKmjxCbBd9/tjc=@vger.kernel.org X-Gm-Message-State: AOJu0YwhKa2jhj8G5JLAemlAMrtZrHldF1JkCfsoZgmdv3N5eE+/yBv7 +rw+fHFECNJNDGhOtOH4pFDygbjIDLbytkLONRLpUKdSufK2vBpCk0i2 X-Gm-Gg: ATEYQzzevePn5A8QL477X5K5E0SN01BTBKsBIGhWx8k42fnU6j2QCNg+gng3oLvut34 2Fggj7/yRBfGAer0TpjOSj2RuuD5CdKud4lScyw8hKN5LlDaxXXXT8RXqYsQC9C7bQZqtaJYl43 KXoPfjNrKFMK3pd/N98fSYE6JXRVT4wVau+mlDI89bNTTEbQTzIYr7Pkr6IQM9RwE//4PLp0GzE +5MPIea7BBHDHFMtO1w18s55eS7Q3h/XT+vefZ5PiWYhmTm1ju8mck17zR/ep6le1Pp0eChjc6+ dKn+d0Pzu5qEfwkI3ee5skWFkBWGgucm0qjs6scXEjOR4xDhjQBtmfe6KOX8RiJX+3nbbaipeuT CmJNSThd5Stkt2vQc706lZMvwsriBZLtP+/wenRW+pcl5DymR+K+a+JpS6dMj1n8jVtJUEvKA1h ycmFA/BKAEnZHgKcJmKgKAVnnDZlzjsOKHv0Wn X-Received: by 2002:a17:90b:17c8:b0:35b:e591:99d1 with SMTP id 98e67ed59e1d1-35c0ddc4118mr351953a91.29.1774376851910; Tue, 24 Mar 2026 11:27:31 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:31 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:50 +0530 Subject: [PATCH 02/10] i2c: tegra: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-deverr-v1-2-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=1910; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=T//TFybKN0iS3J929ONSQMLq+NVtMUv+4U4PajSEtpE=; b=fr2E/ILXide+l6/sGLPzjFEjto2BGT6qqnz9x0FPbuW7SDMBkCcBooGAF0nF3tgg5wQpoDzh0 nAnDJBBoQYcAomrkw15oBfCFd8unXKN1lYuv+oiXhwJuhidayGEmEVJ X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-tegra.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index bec619b9af4e..51d15fca82fc 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -575,8 +575,8 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c= _dev) dma_buf =3D dma_alloc_coherent(i2c_dev->dma_dev, i2c_dev->dma_buf_size, &dma_phys, GFP_KERNEL | __GFP_NOWARN); if (!dma_buf) { - dev_err(i2c_dev->dev, "failed to allocate DMA buffer\n"); - err =3D -ENOMEM; + err =3D dev_err_probe(i2c_dev->dev, -ENOMEM, + "failed to allocate DMA buffer\n"); goto err_out; } =20 @@ -588,8 +588,8 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c= _dev) err_out: tegra_i2c_release_dma(i2c_dev); if (err !=3D -EPROBE_DEFER) { - dev_err(i2c_dev->dev, "cannot use DMA: %d\n", err); - dev_err(i2c_dev->dev, "falling back to PIO\n"); + dev_err_probe(i2c_dev->dev, err, + "cannot use DMA, falling back to PIO\n"); return 0; } =20 @@ -1953,7 +1953,7 @@ static int tegra_i2c_init_clocks(struct tegra_i2c_dev= *i2c_dev) =20 err =3D clk_enable(i2c_dev->div_clk); if (err) { - dev_err(i2c_dev->dev, "failed to enable div-clk: %d\n", err); + dev_err_probe(i2c_dev->dev, err, "failed to enable div-clk\n"); goto unprepare_clocks; } =20 @@ -1979,7 +1979,7 @@ static int tegra_i2c_init_hardware(struct tegra_i2c_d= ev *i2c_dev) =20 ret =3D pm_runtime_get_sync(i2c_dev->dev); if (ret < 0) - dev_err(i2c_dev->dev, "runtime resume failed: %d\n", ret); + dev_err_probe(i2c_dev->dev, ret, "runtime resume failed\n"); else ret =3D tegra_i2c_init(i2c_dev); =20 --=20 2.43.0 From nobody Sun Apr 5 13:12:26 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A843E3A3E66 for ; Tue, 24 Mar 2026 18:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376864; cv=none; b=Dt4Ekr+W3U8fgIJtWjOMYcLs31hIyLZlLFE1sIK1wMtRuXcL+1+u32quLlb5o/eqJ1adxVPDJm145zNUWVgiU83wS2SaaNLw7wz6Ya5YLsurhKvUenl0IPHFZ8vNZ8SqRUzkUtv+x+1+hs2Gp64/pP7oTC3TDDCi2+mdfHyFGGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376864; c=relaxed/simple; bh=Gi4d0M5a+5Q4+n74Mmna9wNg+TAzJTOOC5zaGKNgvh0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bx5oLbupNY1OOVz0w6OLh9NO/WQTwsm2hLNkI48hZzH7hDRo+sYyUiRIGZVxvAARcMZzkGWH3O3UREWsoKEozsxdc+bwMXBTrpc7PRDy7jbejcHf6ZjnLn6eNZRhQUNtBaUxYpUWIIPBrNrX4g2sUUkbFYUGEoHa5FzVSElD9IY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WuMmfs9X; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WuMmfs9X" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3585ec417f6so68091a91.1 for ; Tue, 24 Mar 2026 11:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376861; x=1774981661; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=alJwQhTp7nkw0Ib79edmwantLXplbDvUqq4BVXNADKE=; b=WuMmfs9Xmqa9GVDNOZjmNUordZmBGAfWmTmNyhu7SWk9d1fBi9J7mmm9H+nbdWmyJg 1oV4WrXltAPUWBmWaeV3MF4z9LIcaBBXfv27e1H5aTbrXLiuOTVeZeUYNA5dqXvE2MJU jKDBjTnHVysLF9BRylvs0wLrbkMhnJnBIY8fAsyHFm9e2/GeZG9+RWskGeeOCCs+x4OS +oI8wsXi7Q9xh/s1oFEFJGFFoeYKQ4Alkq/jd94/q9rk/kkg/p24Y+cfxQ4QsIYX6Oyb fAPXNU1TkvhBWDY7i11v2l9jys2jwmTGmn69A9e4gFsaKPPsObTfJRlijFVXWYkNVOzG H5SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376861; x=1774981661; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=alJwQhTp7nkw0Ib79edmwantLXplbDvUqq4BVXNADKE=; b=FUa5okspjeuk5KlX7o0l5CFkOujpErYtBPWstSsNsQAXhRyqnlrIY1yLDiqygo5bRx bvQtJzcaniE/QgvCQLz34v4IzAd6EejfNKV8mvsPfC9hup2+GF7mPtCwP3hlNERc1bzG FnbotsKx0xax0aEQOqJldHz0Aa7UhwLDELIdOyr+OUeXbJP6mrprlMinQMYGoi0rySBY Xd6BS5Ep3weQTdY2oFd7bsmNUhagqq5km2NVEIEcn/ezzCjd9TPTc6qowH5mVsCz2jvb f7nF4GcJkcLy7ALi/z+GWWA7elHf+Tvmqu46T2X1BNe0EijzHRWnn+jegeZ+Kq2JwXy9 4jaw== X-Forwarded-Encrypted: i=1; AJvYcCUD39eoOxJ2ISAwiXbn3V4Rj3CLmkYK95sd/qOaa957m30Kyyz2TVD4YIgoh9wxdGdzo4mdagg4+gWJvig=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4MXYOsTXXNXd0L/9sVfTQsWRezWDUxVqbPhjCGlH4YTcsckMY kInRHIGOUZlQhzbIKAIhGlS6nKAk3B1ycfI7C8LLVR5DGUrJJI8XH2aB X-Gm-Gg: ATEYQzwGFhtCs9mPtP0TndFgEvJsF8BYbJIg/fpComdLSb5aSHrzqpIUsEBxq5dUKNJ vS7fzZmwvJef/gsIDNeT+d9/wNDkROoqOLUKPANr8ElabCnL9B0GcJLC6oNfjeViwWViZ/V3MLi 9p9cLai9SznTOmIXwHgR2TRSb48o6dOz07YMQXwCINoFIdWxIyemDdf0RRb0py/+ioIbzF0EviL HUnKGugSl0wDc81KrvISYe91JIWE9oOEfF4uQsB1flvIWSOpZujke9MofV6l+klu0ho2xdxIrFq BRFwQFqq6DX5EXSjSlTGXLiTMBvDTk8xfATtzm2Ybac1yOvWChEZruLjelgXyrT9KO3zBwwZY2d GyA3SbSyUoM5JJnKEZcqtZylWKmYbdgTySCls+LWtBoe4HLe7iKYDvTTr4BvjHRCovqTkmqpOpV d66P62KwYt1wMtcqSp/70lYO46jw== X-Received: by 2002:a17:90b:57c4:b0:35b:9703:7664 with SMTP id 98e67ed59e1d1-35c008d38f1mr4197956a91.10.1774376860812; Tue, 24 Mar 2026 11:27:40 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:40 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:51 +0530 Subject: [PATCH 03/10] i2c: sun6i-p2wi: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-deverr-v1-3-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=3450; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=mGoeA4RoMr6oMafJS8Wz9uEiYGmdoZGvaadkVl07Ac4=; b=mqDXFTn7P7YKfYZq5yfTqBReywbYSNkXTrDiQ10Gxn0U4N3AcD22e4px2/bKmxQtkFRLFhMV5 D6Rwa2VObbECiZHEiSRVGIVnkT5nDLR0wDkwvKuXdMmJb12BQQQ/qlI X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey Reviewed-by: Chen-Yu Tsai --- drivers/i2c/busses/i2c-sun6i-p2wi.c | 55 ++++++++++++++-------------------= ---- 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-s= un6i-p2wi.c index fb5280b8cf7f..dffbe776a195 100644 --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c @@ -194,22 +194,16 @@ static int p2wi_probe(struct platform_device *pdev) int ret; =20 of_property_read_u32(np, "clock-frequency", &clk_freq); - if (clk_freq > P2WI_MAX_FREQ) { - dev_err(dev, - "required clock-frequency (%u Hz) is too high (max =3D 6MHz)", - clk_freq); - return -EINVAL; - } + if (clk_freq > P2WI_MAX_FREQ) + return dev_err_probe(dev, -EINVAL, + "required clock-frequency (%u Hz) is too high (max =3D 6MHz)", + clk_freq); =20 - if (clk_freq =3D=3D 0) { - dev_err(dev, "clock-frequency is set to 0 in DT\n"); - return -EINVAL; - } + if (clk_freq =3D=3D 0) + return dev_err_probe(dev, -EINVAL, "clock-frequency is set to 0 in DT\n"= ); =20 - if (of_get_child_count(np) > 1) { - dev_err(dev, "P2WI only supports one target device\n"); - return -EINVAL; - } + if (of_get_child_count(np) > 1) + return dev_err_probe(dev, -EINVAL, "P2WI only supports one target device= \n"); =20 p2wi =3D devm_kzalloc(dev, sizeof(struct p2wi), GFP_KERNEL); if (!p2wi) @@ -226,11 +220,9 @@ static int p2wi_probe(struct platform_device *pdev) childnp =3D of_get_next_available_child(np, NULL); if (childnp) { ret =3D of_property_read_u32(childnp, "reg", &target_addr); - if (ret) { - dev_err(dev, "invalid target address on node %pOF\n", - childnp); - return -EINVAL; - } + if (ret) + return dev_err_probe(dev, -EINVAL, + "invalid target address on node %pOF\n", childnp); =20 p2wi->target_addr =3D target_addr; } @@ -245,26 +237,20 @@ static int p2wi_probe(struct platform_device *pdev) return irq; =20 p2wi->clk =3D devm_clk_get_enabled(dev, NULL); - if (IS_ERR(p2wi->clk)) { - ret =3D PTR_ERR(p2wi->clk); - dev_err(dev, "failed to enable clk: %d\n", ret); - return ret; - } + if (IS_ERR(p2wi->clk)) + return dev_err_probe(dev, PTR_ERR(p2wi->clk), + "failed to enable clk\n"); =20 parent_clk_freq =3D clk_get_rate(p2wi->clk); =20 p2wi->rstc =3D devm_reset_control_get_exclusive(dev, NULL); - if (IS_ERR(p2wi->rstc)) { - dev_err(dev, "failed to retrieve reset controller: %pe\n", - p2wi->rstc); - return PTR_ERR(p2wi->rstc); - } + if (IS_ERR(p2wi->rstc)) + return dev_err_probe(dev, PTR_ERR(p2wi->rstc), + "failed to retrieve reset controller\n"); =20 ret =3D reset_control_deassert(p2wi->rstc); - if (ret) { - dev_err(dev, "failed to deassert reset line: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to deassert reset line\n"); =20 init_completion(&p2wi->complete); p2wi->adapter.dev.parent =3D dev; @@ -276,8 +262,7 @@ static int p2wi_probe(struct platform_device *pdev) =20 ret =3D devm_request_irq(dev, irq, p2wi_interrupt, 0, pdev->name, p2wi); if (ret) { - dev_err(dev, "can't register interrupt handler irq%d: %d\n", - irq, ret); + dev_err_probe(dev, ret, "can't register interrupt handler irq%d\n", irq); goto err_reset_assert; } =20 --=20 2.43.0 From nobody Sun Apr 5 13:12:26 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B10F237BE87 for ; Tue, 24 Mar 2026 18:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376872; cv=none; b=ZEZBLahwksSqYlk65qwrRD56woUj1mK8FEzGh+7TVt/x8xpSwt7pPkGVpT4cqM1pangTGwzwJqNNg2r9jJftFZgHZhzfo8iS9xysb1rXG5BDlLlAwv2/RP5maIKVnG1h8RnGFcqnyVdPbbYnibaCOzF8CEfJL5eIW0ihEYi0H3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376872; c=relaxed/simple; bh=INy7r9nqYAh8xRryTtp2F3L3u24eOCBCoOZXV2Ktc3E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QlfFYq0keCiHYsWx9SjfkreUl9F+Plizes+AmH5qVNXF9Vv/7UAyxquSAiZDlIksRGsAu74t9t+Ayia29Lh6+5mTcY+ItKIYEWl2Ld0bpH/L5AqxtgrAD1ppDAyj2+pWhajO0KyR3XUAkq9089OZWZqOOp7/YFWrpkjkGCo9428= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qAkfYh2x; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qAkfYh2x" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c70c112cb61so990044a12.0 for ; Tue, 24 Mar 2026 11:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376870; x=1774981670; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YOUVvE5FNmjkaySdFPrc+7+hSpPNsoY2HaGuj8AkFfI=; b=qAkfYh2xYQHXiHGQvivSqGXRcMqtWLP3pggJM1DGosW4QJUlcSjbPvSm6kfq2uXYLi Ou8tZ65iGdJQ/xmJn+SXVToRlUTmNYFpdCB9UCWhQFG/2sXdWrFD7YHT0HirOt8/aQKM Y6pAVVpbtz1BjwZj+b5EzYj9Et0yFcDBVNo/lS+qimPsBuYxQjAGwZRP0+LRFRCGVhoz NA0txW/yQdxnUtw47dcAV8cgCFDLi1U0eaphyo7BBXWsF46CmTRIRK1p/rNxvX4PbUSR j5rKQwmNGjU9/LoAVe7HlzVvKhnPekeTATFynMs651ziTN9iXQ2/pe+bhBJT22TcqTq3 ea6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376870; x=1774981670; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YOUVvE5FNmjkaySdFPrc+7+hSpPNsoY2HaGuj8AkFfI=; b=lDyU7sABupWsCuqKaUK7OgfRv2D7q+08tzRNuJh+mvUNyequRCMaGZIiv3YsTOkAdA SrjDa+haHp07uNVmFB+IQNyX0Q249vT3XdHtdsTCLpDGX+xLKtZYUhpXnfA4RrK2Zen2 n4YUocd/2tKNt8UhxPDpzSFZCMF3ieqDtJVAd96cfIfjnuXGIU2vJmQ/KEJn1yEGYcno BbDY4sFOUbuUG6WdtqocN2Jkm4p0lOEm30uSNDhP+J8AOMJxdVaY0Km/goJF7GQXw7A2 GNd5/C/Du/a4EtnlDkvBHPnVHSPP8FJTg/hOQs87pDZGhIffZT9VG62B4Fo+YOwCxbyZ SsIg== X-Forwarded-Encrypted: i=1; AJvYcCU5z/X3BVhAX9+0euXlc3yHcreA4va5R78Kx6PFTUb/enw/zw/QxgkC6BaFYMtWAYJEOAn/Uj9NZk9CCsI=@vger.kernel.org X-Gm-Message-State: AOJu0YwSxufNFCcMrGf0Dz4dN0/R3xDmTXu5KZVbG8rZXJ7WlbJdRwtB L1w/YvMJo+EtcEcTm0tFpCCRRshmgUc6KM5cbFpi6LarWHLehmylAhoS X-Gm-Gg: ATEYQzwztQosjqfG384sL4ljl4cmSJjNq496A95qlc9PJ5pfnv4Cx1ZjTUMvy2al4sN uTeAoFh2we08VcigU2u/sfVAbj1NtxT8AqLLWRnjcf1UkMHhl0TKljTaRgPrVLdNBMcDpZu4wuC S50z24k1NaGYSgK5Vz+/LakNcSVRQLb1YUqgN1Dtkxi6GqovdA0sRYO6dIa7Oug9Xdc0XrzeLbo lpNPcKsFw9dYsyz/Qg/DNnsRN2j4h2/Ysi3wpzg9Z4iG7gL7H8bh0hc5b0rtVIIDQuF4ZYoCQ8Z fCn84HreGnz1FZzcv4SKOjzMbxj2jrukkc8zCNBSl9uD+OTXRXM2aggjaMPBSh/3QB5tOLcxooi uiXumjk0ckae4gQKI5wcczX3C+YM0V+nZaO9JoIrJZF5A3jNkexSdJEe1Pv2SXdxd4JoMXLB2M6 0WsCotrFBNXGB1uGtcxlO1zjb3ya3SB+oxJZ/H X-Received: by 2002:a17:90b:1dcd:b0:35b:a656:a60a with SMTP id 98e67ed59e1d1-35c0dcf48dbmr341601a91.8.1774376869963; Tue, 24 Mar 2026 11:27:49 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:49 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:52 +0530 Subject: [PATCH 04/10] i2c: stm32f7: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-deverr-v1-4-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=6197; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=s9JDU7GcgsnDDFXsrCxagGOfCSdKXg3wGsXTsgZz2H0=; b=ah0pTzAjwcV8FwCOGin97Y4dMl89Nw1GTUGKElGrgDchfwSWIGhdZL4fJM5yOH/LB2Vze2ERu 5pFUk9n36AADxerpZp4V7L4H+yM/I6gEVGRW6UOTZNuNCinHlE0yV/c X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-stm32f7.c | 78 ++++++++++++++++--------------------= ---- 1 file changed, 30 insertions(+), 48 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm3= 2f7.c index 70cb5822bf17..e7cc7f0fb56c 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -481,28 +481,22 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_= i2c_dev *i2c_dev, int ret =3D 0; =20 specs =3D stm32f7_get_specs(setup->speed_freq); - if (specs =3D=3D ERR_PTR(-EINVAL)) { - dev_err(i2c_dev->dev, "speed out of bound {%d}\n", - setup->speed_freq); - return -EINVAL; - } + if (specs =3D=3D ERR_PTR(-EINVAL)) + return dev_err_probe(i2c_dev->dev, -EINVAL, "speed out of bound {%d}\n", + setup->speed_freq); =20 if ((setup->rise_time > specs->rise_max) || - (setup->fall_time > specs->fall_max)) { - dev_err(i2c_dev->dev, - "timings out of bound Rise{%d>%d}/Fall{%d>%d}\n", - setup->rise_time, specs->rise_max, - setup->fall_time, specs->fall_max); - return -EINVAL; - } + (setup->fall_time > specs->fall_max)) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "timings out of bound Rise{%d>%d}/Fall{%d>%d}\n", + setup->rise_time, specs->rise_max, + setup->fall_time, specs->fall_max); =20 i2c_dev->dnf =3D DIV_ROUND_CLOSEST(i2c_dev->dnf_dt, i2cclk); - if (i2c_dev->dnf > STM32F7_I2C_DNF_MAX) { - dev_err(i2c_dev->dev, - "DNF out of bound %d/%d\n", - i2c_dev->dnf * i2cclk, STM32F7_I2C_DNF_MAX * i2cclk); - return -EINVAL; - } + if (i2c_dev->dnf > STM32F7_I2C_DNF_MAX) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "DNF out of bound %d/%d\n", i2c_dev->dnf * i2cclk, + STM32F7_I2C_DNF_MAX * i2cclk); =20 /* Analog and Digital Filters */ af_delay_min =3D @@ -567,8 +561,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2= c_dev *i2c_dev, } =20 if (list_empty(&solutions)) { - dev_err(i2c_dev->dev, "no Prescaler solution\n"); - ret =3D -EPERM; + ret =3D dev_err_probe(i2c_dev->dev, -EPERM, "no Prescaler solution\n"); goto exit; } =20 @@ -624,8 +617,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2= c_dev *i2c_dev, } =20 if (!s) { - dev_err(i2c_dev->dev, "no solution at all\n"); - ret =3D -EPERM; + ret =3D dev_err_probe(i2c_dev->dev, -EPERM, "no solution at all\n"); goto exit; } =20 @@ -674,11 +666,9 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c= _dev *i2c_dev, =20 i2c_parse_fw_timings(i2c_dev->dev, t, false); =20 - if (t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) { - dev_err(i2c_dev->dev, "Invalid bus speed (%i>%i)\n", - t->bus_freq_hz, I2C_MAX_FAST_MODE_PLUS_FREQ); - return -EINVAL; - } + if (t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) + return dev_err_probe(i2c_dev->dev, -EINVAL, "Invalid bus speed (%i>%i)\n= ", + t->bus_freq_hz, I2C_MAX_FAST_MODE_PLUS_FREQ); =20 setup->speed_freq =3D t->bus_freq_hz; i2c_dev->setup.rise_time =3D t->scl_rise_ns; @@ -686,10 +676,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c= _dev *i2c_dev, i2c_dev->dnf_dt =3D t->digital_filter_width_ns; setup->clock_src =3D clk_get_rate(i2c_dev->clk); =20 - if (!setup->clock_src) { - dev_err(i2c_dev->dev, "clock rate is 0\n"); - return -EINVAL; - } + if (!setup->clock_src) + return dev_err_probe(i2c_dev->dev, -EINVAL, "clock rate is 0\n"); =20 if (!of_property_read_bool(i2c_dev->dev->of_node, "i2c-digital-filter")) i2c_dev->dnf_dt =3D STM32F7_I2C_DNF_DEFAULT; @@ -698,8 +686,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_= dev *i2c_dev, ret =3D stm32f7_i2c_compute_timing(i2c_dev, setup, &i2c_dev->timing); if (ret) { - dev_err(i2c_dev->dev, - "failed to compute I2C timings.\n"); + dev_err_probe(i2c_dev->dev, ret, + "failed to compute I2C timings.\n"); if (setup->speed_freq <=3D I2C_MAX_STANDARD_MODE_FREQ) break; setup->speed_freq =3D @@ -710,10 +698,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c= _dev *i2c_dev, } } while (ret); =20 - if (ret) { - dev_err(i2c_dev->dev, "Impossible to compute I2C timings.\n"); - return ret; - } + if (ret) + return dev_err_probe(i2c_dev->dev, ret, "Impossible to compute I2C timin= gs.\n"); =20 i2c_dev->analog_filter =3D of_property_read_bool(i2c_dev->dev->of_node, "i2c-analog-filter"); @@ -2175,10 +2161,8 @@ static int stm32f7_i2c_probe(struct platform_device = *pdev) return -ENOMEM; =20 setup =3D of_device_get_match_data(&pdev->dev); - if (!setup) { - dev_err(&pdev->dev, "Can't get device data\n"); - return -ENODEV; - } + if (!setup) + return dev_err_probe(&pdev->dev, -ENODEV, "Can't get device data\n"); i2c_dev->setup =3D *setup; =20 i2c_dev->base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); @@ -2279,7 +2263,7 @@ static int stm32f7_i2c_probe(struct platform_device *= pdev) =20 ret =3D dev_pm_set_wake_irq(i2c_dev->dev, irq_event); if (ret) { - dev_err(i2c_dev->dev, "Failed to set wake up irq\n"); + dev_err_probe(i2c_dev->dev, ret, "Failed to set wake up irq\n"); goto clr_wakeup_capable; } } @@ -2305,9 +2289,8 @@ static int stm32f7_i2c_probe(struct platform_device *= pdev) if (i2c_dev->smbus_mode) { ret =3D stm32f7_i2c_enable_smbus_host(i2c_dev); if (ret) { - dev_err(i2c_dev->dev, - "failed to enable SMBus Host-Notify protocol (%d)\n", - ret); + dev_err_probe(i2c_dev->dev, ret, + "failed to enable SMBus Host-Notify protocol\n"); goto i2c_adapter_remove; } } @@ -2315,9 +2298,8 @@ static int stm32f7_i2c_probe(struct platform_device *= pdev) if (of_property_read_bool(pdev->dev.of_node, "smbus-alert")) { ret =3D stm32f7_i2c_enable_smbus_alert(i2c_dev); if (ret) { - dev_err(i2c_dev->dev, - "failed to enable SMBus alert protocol (%d)\n", - ret); + dev_err_probe(i2c_dev->dev, ret, + "failed to enable SMBus alert protocol\n"); goto i2c_disable_smbus_host; } } --=20 2.43.0 From nobody Sun Apr 5 13:12:26 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D326D8632B for ; Tue, 24 Mar 2026 18:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376882; cv=none; b=L8DSOqbI7bXiDSRWmZWGLJYmOOH8yUFZrdcB7GOJOmPGtUtbN/ME+/sCh5RfwriPfbEp6xqVs7fatswlkwggz/3tVohIb7TVYMFCjqvzTFzQ8kqHk1lF8cpxTFU9K3cAXNtSOxL9ePND6SvhSDY5UXvnZzG+NeOXrtp29boWSD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376882; c=relaxed/simple; bh=Og+ag9IkwKlXlRqp73B5hnPk+W9xiNL+UaCwuonyITY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dLXkgCCLAicXxuz16FkNMsO6UguvM7n8k/myIs2H2e57VpUSYibj8B+bL/3Yvel/mpUDUagFG/tXIWEJOET2xlJWxk7ymhIrHF/KShjTR1pHr4NiIukTbyX9/wYYA0T0tBbH5+51oy8/ipHp1kQMAS/0DjeqgeAyG9gFeyr1wE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WHCrnv0V; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WHCrnv0V" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-35b905a05a8so3382922a91.1 for ; Tue, 24 Mar 2026 11:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376880; x=1774981680; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HHa+g9Yvknw/nsgWzBDeK9srp0wKwbZMTd0+ms6kC4c=; b=WHCrnv0VzU625lqgVnnry/SM1rBVfsO4msu6b3kmrraeCWCplik3gPSvP5kVf9gyQH lWLhnl3sCLyGMMC+EDMS17zeQDwZdeb9Kg+CtMe1Q+dk5nsCbKXWgOTsN5jvkIxhlfrM infMW4EyhTh0j9T/PqE9Zha8wpxnbuIDp3GFk4CNKzHOCTHINVEOjJBCiuldD9xeeVyX hxOhLgnbMbQ7NXvXEbZ6+ZOIiG9wzXSJz7fSTl21ryX2SCFOOCkte57+Y7yxDvY0J6j+ g+g3v6WjXKm3yvibbDgURFpBYZfhvIKkQ1JRe+vigNgm6BA73Q8YyUpEJ+Hus5YkcquF a+YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376880; x=1774981680; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HHa+g9Yvknw/nsgWzBDeK9srp0wKwbZMTd0+ms6kC4c=; b=YCNKc9RP3KPAdV0ZbZ7YNTR9OIcnrxf5+/663xXwTWtToOXGyf6kV29fjARslTrAU9 DEZS14WQf1S7Vrx8x6hgMJ10aVsC4Cn+WnNA5fvJJx9ljNbgNZFvkBls3cDQHVVee+en HndNgE7cKO8oaDRC12iMtSlcvUOoOw2vghWCkkowEWWVpStWaGxaF010fGwUjlwAUUpa kWMyYGHDrIvhNEHBcWSjqyceXNWorAGRQ9JP3QU2uJQh9XT67npbMcW7F6rFqb6F/JRF tKtKu8hne8yJGuGXuwr0iTpCQghtV6aLytzOFEWsY8OcP83hi/fAqdBasR6U7NbvFPej t0pA== X-Forwarded-Encrypted: i=1; AJvYcCWa4juhVDoa4cu16WliztglF5Syohiii7C7fOzPy2L4h8sFgIhfQ0Sd3qSZE8umTB4vObvLkrkdmwwgcUQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwudY5Ftv3fH0HBvKlWdai+E/0xESYUZIe4qIYSARZWVTr1/ZdX xkeTPR+Mg/lsUswDF/EvcyIhCPgbLk5n5RvruDcmyqr5UDkY8yUPHPGr X-Gm-Gg: ATEYQzyj/0phsE6GNu4CYWcSzM0uok7enfH7hmMIuNAK7q8ABYLKjUda1nFhKc2ddtp 6ls4v+MwHSHc7z1VkLmUbP6kaPoBr95HO15Cx+yM3RTKtSXre0lS76wIaAwx3iyJQgxmtSm3N59 /L5BSQmxYA/Nb8XYU8afJ0oQt/9ML+aC7dMDLW6jq7W+UUxmdfpbjmQnlk6OS6Kbj1bQZrjNbZr DLKCpGnF3elpvYwaaF2I4iBPL0soqsm7x7ePfL4rBbdEF2ltFOdifXcONq20czfyF5nmGhkQork RVRBivXcjjlLf1NwigZ0ldjQcTHrCwBLC8SgKWjFCL5wCm9kc9auv/OAQCXNCmMrBru+pbZ0Gu9 AqQJBU32kdfKiaC5oINHoYYYwwO1skj4noSHljEpoM6sApcyZf7DMug4LGi5iMVU50nBZC1xj8m DAW5Ew64r6B3+/M+PTjYhmi4qSNw== X-Received: by 2002:a17:90b:4ec6:b0:35b:e551:90d2 with SMTP id 98e67ed59e1d1-35c0dd95828mr337562a91.28.1774376879990; Tue, 24 Mar 2026 11:27:59 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:59 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:53 +0530 Subject: [PATCH 05/10] i2c: stm32f4: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-deverr-v1-5-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=3441; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=fUyekU3vIj3XVF9IEZZuF8p06qRSr8GpHENT4b6dCL0=; b=Lv6diY6U8yOO+wFg03BiFqyP3QS+BUZjUWZZhiQKaL58Ge1g8J4dtHf+S+KQwwxbmw5DUKteO KpFdph3BhEcCYkTzwZIrFSEDvv+nlC32lTjIg5IZhXq8rp8u8lOOdaA X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-stm32f4.c | 53 ++++++++++++++++--------------------= ---- 1 file changed, 21 insertions(+), 32 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm3= 2f4.c index b3d56d0aa9d0..44e8b04962bb 100644 --- a/drivers/i2c/busses/i2c-stm32f4.c +++ b/drivers/i2c/busses/i2c-stm32f4.c @@ -163,11 +163,9 @@ static int stm32f4_i2c_set_periph_clk_freq(struct stm3= 2f4_i2c_dev *i2c_dev) * to hardware limitation */ if (freq < STM32F4_I2C_MIN_STANDARD_FREQ || - freq > STM32F4_I2C_MAX_FREQ) { - dev_err(i2c_dev->dev, - "bad parent clk freq for standard mode\n"); - return -EINVAL; - } + freq > STM32F4_I2C_MAX_FREQ) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "bad parent clk freq for standard mode\n"); } else { /* * To be as close as possible to 400 kHz, the parent clk @@ -175,11 +173,9 @@ static int stm32f4_i2c_set_periph_clk_freq(struct stm3= 2f4_i2c_dev *i2c_dev) * maximum value of 46 MHz due to hardware limitation */ if (freq < STM32F4_I2C_MIN_FAST_FREQ || - freq > STM32F4_I2C_MAX_FREQ) { - dev_err(i2c_dev->dev, - "bad parent clk freq for fast mode\n"); - return -EINVAL; - } + freq > STM32F4_I2C_MAX_FREQ) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "bad parent clk freq for fast mode\n"); } =20 cr2 |=3D STM32F4_I2C_CR2_FREQ(freq); @@ -772,22 +768,19 @@ static int stm32f4_i2c_probe(struct platform_device *= pdev) return PTR_ERR(i2c_dev->base); =20 irq_event =3D irq_of_parse_and_map(np, 0); - if (!irq_event) { - dev_err(&pdev->dev, "IRQ event missing or invalid\n"); - return -EINVAL; - } + if (!irq_event) + return dev_err_probe(&pdev->dev, -EINVAL, + "IRQ event missing or invalid\n"); =20 irq_error =3D irq_of_parse_and_map(np, 1); - if (!irq_error) { - dev_err(&pdev->dev, "IRQ error missing or invalid\n"); - return -EINVAL; - } + if (!irq_error) + return dev_err_probe(&pdev->dev, -EINVAL, + "IRQ error missing or invalid\n"); =20 i2c_dev->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); - if (IS_ERR(i2c_dev->clk)) { - dev_err(&pdev->dev, "Failed to enable clock\n"); - return PTR_ERR(i2c_dev->clk); - } + if (IS_ERR(i2c_dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk), + "Failed to enable clock\n"); =20 rst =3D devm_reset_control_get_exclusive(&pdev->dev, NULL); if (IS_ERR(rst)) @@ -807,19 +800,15 @@ static int stm32f4_i2c_probe(struct platform_device *= pdev) =20 ret =3D devm_request_irq(&pdev->dev, irq_event, stm32f4_i2c_isr_event, 0, pdev->name, i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq event %i\n", - irq_event); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to request irq event %i\n", irq_event); =20 ret =3D devm_request_irq(&pdev->dev, irq_error, stm32f4_i2c_isr_error, 0, pdev->name, i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq error %i\n", - irq_error); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to request irq error %i\n", irq_error); =20 ret =3D stm32f4_i2c_hw_config(i2c_dev); if (ret) --=20 2.43.0 From nobody Sun Apr 5 13:12:26 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC9023A381C for ; Tue, 24 Mar 2026 18:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376894; cv=none; b=mHz9GHZhuXAnv1Jy3Vv21ZUVjg1gurkUyWWWvCZnuytHK02BeDOILC5o1zSttEKk9BMmPf27nfpZGKzfc4u05sbdBeHV5p1EysNVLdfrGppRWwWbQ7H5Yfd+75nckywdGr5fyyaJZaqfok5hptQtFtP32r6KDv26nooao687KHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376894; c=relaxed/simple; bh=iap5qBBPM9+z7GkIgQPTPNBQ4CZotIn48Ss9ISZDGxI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Jwwqv+OlDbildmBgZwJlBbQ2cc2vABgXCA343uN2nItoO7KhndO2ki/eeH4qeh1EkHAN/z5NP+/P6Iq/sNWkEuUnSWXdJDpqqua/6tFAIjmINEGzS43qoKDMpVsqg88d/8vQ8esN3mC5JNYlHuaPq9phkS1jGv7EGEAgUnpGOZ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FKoCeDce; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FKoCeDce" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35ba749f441so1366353a91.1 for ; Tue, 24 Mar 2026 11:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376892; x=1774981692; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LOh7L59SGXDe0n/0/CxydhLmu3Ccl2K/OUt14k5rUoM=; b=FKoCeDcel0G0anI6qTVqErqOwL60iPwadrkclMevwba2YpJpSB8NUHG+kmnypHCqRN gOyu09/OzA4cQFLGKSNcf0Kt+Wfpb95E22E/fhzEf1PqwfPDnnzfAa6lWOyjbLxQMtAV UIn3hZOLcB0FwgSNahhtfHE/U0TEebgJkVvvY3O7MEfJgwuB6Eqp0a0FUZl9v16fTNCb of2L9Eo5qthsbwzP7RSs04VhPhNpOBt2+RXLSC8CfKSJnZq0uPjxBRP69m+Bo6AXwT5R p7AwEFYOXRy3M5tbRFLIneQn2+1rzYzLjfP4e3oTt01TZpX4SNPD4h4zwd/aG50SJdCz tSUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376892; x=1774981692; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LOh7L59SGXDe0n/0/CxydhLmu3Ccl2K/OUt14k5rUoM=; b=P0gnKDJ066gvEbolVRldZdvfzYuObMHFipRnGOksdA+R737usUgz7Z99MEUOKTPxE6 Xj4HzF5Mvn3mcAZZfPpLqAKTY9jLyTtXMGfOeFodNdswi3xCBQhNsosbncoeuF285irz XgC+xDqTgaZX5ZhRLsVXWV8Jc4avtTXGJhCu6F68q7FpT4IcPcGRE5nYMVSuuCvn5noT hf6DwZvHBhxLTlSOeG0WgRk0DW7X+hwDEy62Bo4SdyCQR+Saxjh7nYdVDRi9vvzluCx3 8oOA/PhGfzqrEicg11qo9nbAxftZTTJpODBWm2Gd49g+XUx0ft+tcfAh5KnQM34x2bKk J/Sg== X-Forwarded-Encrypted: i=1; AJvYcCXusXRFladRQ3recOpfyzTLbdzcArHcLzHkZmLTUu7A2TSXv4CGk1zdqTMSg+mGvBuFSrVTJ/2pSH/m36s=@vger.kernel.org X-Gm-Message-State: AOJu0YzrfLUwmNZ9HK2AVcconJcH4v3zzNFkzgiIBL5ZYpmuiJJCajCe jhn/0gCi88hcx80VLz4+0o7Tf/8SafETkhuzv4OAHvyb+FJ0frSGl88M X-Gm-Gg: ATEYQzynQYvZ1YbBQF10xnfpcq/rFf9ANFX2Qt4AfRvGV/jdXQIhUdYun9B7elllFYZ uZmriYo4O08wt0PubTZjY70mXmN6p43/6NsCpG+6UVbismzB4ADM+iG0EHbFSWXVDm5i7gUxlrQ GgxBzirwQxl9szkH+AjU9v/CWN4SRA5lLNN3aKU/tuO56YQmIEHP7qNkGRyRmzVuzP7LFXzpATV ywZQYTLE5Cys2okb3j9JEVJ5ToH/9TMGEHtg1PRh8Hx5Nskv0gIFPMU0sQ4wNg1vSJUjOiKnt7z ukknFCatnuZ5akIogGAx7qYolxTYlITJGCnrtZ6hubpdN/7ij801qu+gFPmu2SIGe+AVPpiDxPk o7IwYqpNnIB9a+0iR1NeuVhELZ0KOx0hYGdWwxksxR4hddzNQx/JkyuYPx5NlVVJJbXTCp2vxUj ZPYcYyOC4OJaDl0xt5o4slB8iLeQ== X-Received: by 2002:a17:90b:4a4f:b0:359:f22:8879 with SMTP id 98e67ed59e1d1-35c0ddb253amr350462a91.22.1774376892133; Tue, 24 Mar 2026 11:28:12 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:28:11 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:54 +0530 Subject: [PATCH 06/10] i2c: stm32: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-deverr-v1-6-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=1144; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=fGh6XbxSkvU5zsFALrHQqBdXVjE2X7LO7LjtYihQc1Q=; b=bSr5WSYN2sBbQ56eV/RU7Nsc30A+f8iif2b8KvF+i2QPU4oV/n2gxZwRlmFwYUL0Sn4WgwU3t BHbt5Op51GJBjc0aJ76ljbLTb0hDHykJdiMU+4SpjB/VkJQQUf6r5CT X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c index becf8977979f..064e47d6c96f 100644 --- a/drivers/i2c/busses/i2c-stm32.c +++ b/drivers/i2c/busses/i2c-stm32.c @@ -39,7 +39,7 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device= *dev, dma_sconfig.direction =3D DMA_MEM_TO_DEV; ret =3D dmaengine_slave_config(dma->chan_tx, &dma_sconfig); if (ret < 0) { - dev_err(dev, "can't configure tx channel\n"); + dev_err_probe(dev, ret, "can't configure tx channel\n"); goto fail_tx; } =20 @@ -60,7 +60,7 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device= *dev, dma_sconfig.direction =3D DMA_DEV_TO_MEM; ret =3D dmaengine_slave_config(dma->chan_rx, &dma_sconfig); if (ret < 0) { - dev_err(dev, "can't configure rx channel\n"); + dev_err_probe(dev, ret, "can't configure rx channel\n"); goto fail_rx; } =20 --=20 2.43.0 From nobody Sun Apr 5 13:12:26 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E0D33A3E66 for ; Tue, 24 Mar 2026 18:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376907; cv=none; b=WwnkOZtWBavRSssQy8tPO3OT1ViG98mjYqCel8Ato7d7CLsNhw+nwItSpEmMiv3qd2N99huyHojHMkodm/03cSKnwXRHH7Mfrbt9G9zFviDVDcO34V3Yg6dtUnZgSzCVpFq7ps0vigN44VdnbKnK89/eSzCbWEE3+9zggiJkJMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376907; c=relaxed/simple; bh=cDcTMwkXqvLZxNGPDMHwcK5wJhpj2l1qGF/0VyfBQEI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nqjGKfvfU/2wMN365TbJvU8AEY1Z2s+rQhfaO/+yIpNWoNqY8qewFv4nDNbDNbZ0J2RYvoJh0nzWxKOGLYR7nTCbgxOipUBEDo6M7l3QytxK9+laMObQVGkNNqfFTqFOoyeO5CMWh3M9MqvTilwn34y+y0KshuaZQAaU655/2pk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iAyuvfKi; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iAyuvfKi" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-35b88a4f123so69803a91.1 for ; Tue, 24 Mar 2026 11:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376904; x=1774981704; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7jbYoDFFKwnOMKQiaSrjwW8IJ/VZkZBU3IOohjNwPSU=; b=iAyuvfKi9nJTHxonB7equYs5mZNti7S+SsGf9MUsJXMlh8pcIPrXU4iPcznnnuB5FO FV7t48qTUIAC9gaqVQ9I6Ru8IOZGYNwX5DMX2TyPNQKG1ils3NC7HCLkILBNGn3mBe5d lqGMtPGoXXxRlaVaRKM2gxHRbwye2AT6PqWSWV/4nBUsT/xmet98IxKIUfN27Bqcb9o3 NfyCVavU4GCTp7LdQmDKcdDT1aHm/WHRrwFwybTSqUJrhooRViAfDakbAkhp5+REyG8P R1gxl0f7V8S7Fls3JDTYoXBx1uDeehUyS3x9QcZkugZ5yZ2Ho1mgYMKjEb28StiGIs4b L77g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376904; x=1774981704; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7jbYoDFFKwnOMKQiaSrjwW8IJ/VZkZBU3IOohjNwPSU=; b=lSDl+102ibbZm+hP/HR+k8j1+yxJuaM9gysZyWszc5IRJLHh4fXT0CaxtU2zXpufrv jdLUqMPzoDhwNq0Y1cvor7YteBZL3SStwtWIj3dDW059Dfw/lZg1DdtBhjyOJw6eoLho a3m8Xv+FbJpHNWXIXDmLXUuL2H2EH8OhyCnceMBdmRhoMwunJWdpgntsR5sYLBc6Vlyo j8vBS8laCWnk1LdT6xlA4SZ8kx3Fr3Mm8LCwcXSfUH3NM2eDhvVMMUaQ2R5SaNvZOcKY iOIgYsAVTtl0ioJmQvB/rmKBDlFPBe9DbnKKcdvHKvI5fcLIl5LS2J/VfYtHuxe7kvhl 7fsw== X-Forwarded-Encrypted: i=1; AJvYcCVD+cT+xzNOr37ovIP9XC8Zmjk8/xCWEoPxUQUWsdzc9qHdFdzUvq0YGIyMBBQKxm4JWBw/5P2Y2FWAVmQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzTzVY+hQpyT5I58/u9u2N0zYcG6JK+Z6Yo1TNoEjefzO2Bijeu fAgxWCj0+PH3UA2XN2Cid246wBPUynrpV0qZKCK9yjbO2LeHkutuRuZr X-Gm-Gg: ATEYQzzQSiqkYCuqnojPG8EGUpfabTEZekWjqcS21CljYk0cTBsDiNNXzSn8yprbv4z iwSos5GD9NvrmZQ0R26XN2DJGEHmn4UWCSTlWyyyg/U0lbSy7/4CcpIj6W9ALclrisZ+Aw3LoOa RX3DIy/tvDX/shjQs906y7S+k9KwL8A5ds6cSJdz01efmEgvZ4n6tBBcm2MBpfZ4oBvqXC0/Pne SazuC+vZm0BvgbpgCghdNlPGzO3qa54ZqnOeRD5S+YewVD8SzI+nULM618Zja6+9vfh5J1DwkDm 5QnC6A1ZvyBgKRfXi3I1dy4tCwEjDI01GTc2pov2hyMpaSUAdurBQB4lE+BCLN0QukdbPf5aWI3 l+UyPz2nMdWXw1fMvHd1JGmLwKc7uZ/AHmEtEziR9nWpdLUNwOVJ9pdHpTIy5ekjlVokrmp8ElF BzY699T8PKZGUauBVZV6Vy12jyqQ== X-Received: by 2002:a17:90b:3c07:b0:35b:a0f0:8327 with SMTP id 98e67ed59e1d1-35c0d1001a9mr618620a91.2.1774376904310; Tue, 24 Mar 2026 11:28:24 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:28:23 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:55 +0530 Subject: [PATCH 07/10] i2c: st: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-deverr-v1-7-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=2664; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=QTq/SsBBXUdzBzLen+lO5rBpYhODcjwD4XTKabWXWjM=; b=6uYv7INtZBtXz/5CGPPLnmZfr7dOa2FHZwl9/oOHXGn01WGXqmOPkElSojC2emL6vTKD8y1gU mA1lXC4EoXKCgHD1s/6elwyP7MOynX9ePlEaoKUiP69Jyq2pL/sIZCs X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-st.c | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c index 751ea421caaf..3f89c2145741 100644 --- a/drivers/i2c/busses/i2c-st.c +++ b/drivers/i2c/busses/i2c-st.c @@ -775,17 +775,15 @@ static int st_i2c_of_get_deglitch(struct device_node = *np, =20 ret =3D of_property_read_u32(np, "st,i2c-min-scl-pulse-width-us", &i2c_dev->scl_min_width_us); - if ((ret =3D=3D -ENODATA) || (ret =3D=3D -EOVERFLOW)) { - dev_err(i2c_dev->dev, "st,i2c-min-scl-pulse-width-us invalid\n"); - return ret; - } + if ((ret =3D=3D -ENODATA) || (ret =3D=3D -EOVERFLOW)) + return dev_err_probe(i2c_dev->dev, ret, + "st,i2c-min-scl-pulse-width-us invalid\n"); =20 ret =3D of_property_read_u32(np, "st,i2c-min-sda-pulse-width-us", &i2c_dev->sda_min_width_us); - if ((ret =3D=3D -ENODATA) || (ret =3D=3D -EOVERFLOW)) { - dev_err(i2c_dev->dev, "st,i2c-min-sda-pulse-width-us invalid\n"); - return ret; - } + if ((ret =3D=3D -ENODATA) || (ret =3D=3D -EOVERFLOW)) + return dev_err_probe(i2c_dev->dev, ret, + "st,i2c-min-sda-pulse-width-us invalid\n"); =20 return 0; } @@ -808,16 +806,13 @@ static int st_i2c_probe(struct platform_device *pdev) return PTR_ERR(i2c_dev->base); =20 i2c_dev->irq =3D irq_of_parse_and_map(np, 0); - if (!i2c_dev->irq) { - dev_err(&pdev->dev, "IRQ missing or invalid\n"); - return -EINVAL; - } + if (!i2c_dev->irq) + return dev_err_probe(&pdev->dev, -EINVAL, "IRQ missing or invalid\n"); =20 i2c_dev->clk =3D of_clk_get_by_name(np, "ssc"); - if (IS_ERR(i2c_dev->clk)) { - dev_err(&pdev->dev, "Unable to request clock\n"); - return PTR_ERR(i2c_dev->clk); - } + if (IS_ERR(i2c_dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk), + "Unable to request clock\n"); =20 i2c_dev->mode =3D I2C_MODE_STANDARD; ret =3D of_property_read_u32(np, "clock-frequency", &clk_rate); @@ -829,10 +824,9 @@ static int st_i2c_probe(struct platform_device *pdev) ret =3D devm_request_threaded_irq(&pdev->dev, i2c_dev->irq, NULL, st_i2c_isr_thread, IRQF_ONESHOT, pdev->name, i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq %i\n", i2c_dev->irq); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to request irq %i\n", i2c_dev->irq); =20 pinctrl_pm_select_default_state(i2c_dev->dev); /* In case idle state available, select it */ --=20 2.43.0 From nobody Sun Apr 5 13:12:26 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 459C3248883 for ; Tue, 24 Mar 2026 18:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376917; cv=none; b=MQWKY34ocvG2yuGf97LX0MnrjxaSCSx4oOYEm4U5rozyJnqpCGdBTkKG3UGjTBZwEA06xis6Za7cX8gLUFRrG5LYOTGf82LkGMNb8QEjeg1J/bJeJEkPmKCXH+oLHHFFPkgSBlglFud1AFTvzmvCfSVhaGBi6o8Wch7GU2PhWTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376917; c=relaxed/simple; bh=InYIOZ74uRoVGHRDFdN9ukawBsa/EDFlsLY4lGClCxs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=N9rO4bTmPqUzz+aKiayrPjae3SyE0sbP/vM4cvckPG3TuiPbuXWe65N74NsEF2g/cIdBBVvTv4h8pc1RzkaP6c/t60pIyw/ehRWp+YwlcCrpNzXOXa3amf0oxguuW9M95qq6uX9jyN4OmRPDaDiOkPwWKgLjGotkrBdvq6ey6ZE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qAnF8TBl; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qAnF8TBl" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35a07c4b17dso2114408a91.2 for ; Tue, 24 Mar 2026 11:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376916; x=1774981716; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pWQFrxeJ9xbwYy1VhHH7N7bPolG8RRVJqSZfUbUVPdk=; b=qAnF8TBlRT4R65eQu95gtSWiZ7VeUtt4W77VIKMKI/UO8AMGqvEz3rcekBF1eLhSWI SXksNJlNvnHZzqCP8dPzuxK4GC8UjEBHiox9K1wuja11qXhN8k3wTZTYGS43PTbtY+u2 Hnf2OeZhAIGMOoYQKLqd72lIIuT78mXFI9vtNlHo7JjHZ24hb/bebzrXpsO3vyjCroZt 4O9Ew1bajxCTTiV6txX6T0y3vBW48sJKsHbreMGDyt8LOvb1UZ2X4QNV63VW/+hOkYal 18VOukCrtxQyn2VkS/57y+UaTBvD3CAt4I5C5eHDieMQdrgSxpom+cblkSDhanUh0SMC NF5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376916; x=1774981716; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pWQFrxeJ9xbwYy1VhHH7N7bPolG8RRVJqSZfUbUVPdk=; b=DSJRkrwmuO9BZ0ssf79d2BYqg0hNGlHa7pSnLnlWwJhW7Pkf0SgkBndxJ8TnNjqhcx xNv12t798xOMkh+B4DTp8jZMoWVf3C5wQcfTZWW9f03Afhl8LIShdIPbqxbrK8W+w4d2 eln13DdkBsxWeiWIDIMYu1LfO5B/wuQFZTr2q0YlkmSZ4oTbsXSMahIfdyqD5q7DShq/ NFgpK3pA4PNsLDJh44ZER2CFuwGD4e2lYvBK2HcWzyGze3YNrvucDuxZ5+juyMVoLJyO GZIJoYHogvhjK68gN5xmlW8NyIGxIQs3gKgHUmtYh3u0EQPFZK2mmxdCps2HoQyi2Dzl WJ0w== X-Forwarded-Encrypted: i=1; AJvYcCUjEM5uMyh9bGKTjFwLD7z35M0IqKOFhXsQp6yGmaDBCOEP/oBtr8GyYeN0Lvvajxkim91bzO9sz/uQaYY=@vger.kernel.org X-Gm-Message-State: AOJu0YyX+KnioxRbawHDYiAxKjMxZ3uZkrTjm0YaanRUHT4hjyjVCv/M W33WsFw+bB9ZZLd+FpDT12V+X6HQ/RMtnMXm37jMClsN86W+tfm/uiIt X-Gm-Gg: ATEYQzwam3VrtEIjANwNkZHS7owz+HH9Z0fV/WK7Bfrt4d7j3zgGBfWpD9s0dfWTqI+ /d4u82RkTGRe8kbeB/czDGaiWeOXOq1/1kzOHW3+NQ+66iszi5K7iYxXB86s76GOZbIxlIM7tYr dxOWW/6/eiwaBHieuYzaeZWhK3GGzcCOhsrV8XWzzq0Zuz2+tMzFhAgitpg0FrMo3UyPHvMs6NC Lmc2GCbJ0B5Gffdrhw3+w24M1UUsNw2z/XGU6eNJGyYoIyuopoYUAX6J+6KZkKe5r+kW0OlmWzQ TpGpzMbE5jq00rHXg9f0WcRLjOPt9qVa5xCNUBrEOaur2fsXz2kb6rlG7l2EIW0hvjtcJvBnzbG tm7vkEUuqLJpfcUCv/c/6xP+SSEK0C8+BZiUvfRVI/cKlFROlJXHqynCNATiCal2CqK5GxiBXSB 9RCdjlv0doJvoA8N+AspQtfomTLg== X-Received: by 2002:a17:90b:17c8:b0:35b:e555:f19 with SMTP id 98e67ed59e1d1-35c0ddc5abamr302415a91.25.1774376915602; Tue, 24 Mar 2026 11:28:35 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:28:35 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:56 +0530 Subject: [PATCH 08/10] i2c: sprd: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-deverr-v1-8-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=1529; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=ASHKLgyhVdhgUS0PF+wcYp1muqF4w//oNCLBXZkcUHY=; b=hXROFYzb3OmT3cxRxEoFIuEeGuiZJd8xLM4x0yhyQx4WWK4SUYX6zSFRnwpUkd47L0bbPAvtp mE3F0pCOHTsA7C6xaX1n86n4DvW3PrzzB2RQAlr/W45yvtlvUvwnwXb X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-sprd.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c index 1b490525d8dd..7b321a956fca 100644 --- a/drivers/i2c/busses/i2c-sprd.c +++ b/drivers/i2c/busses/i2c-sprd.c @@ -469,11 +469,10 @@ static int sprd_i2c_clk_init(struct sprd_i2c *i2c_dev) i2c_dev->adap.nr, i2c_dev->src_clk); =20 i2c_dev->clk =3D devm_clk_get(i2c_dev->dev, "enable"); - if (IS_ERR(i2c_dev->clk)) { - dev_err(i2c_dev->dev, "i2c%d can't get the enable clock\n", - i2c_dev->adap.nr); - return PTR_ERR(i2c_dev->clk); - } + if (IS_ERR(i2c_dev->clk)) + return dev_err_probe(i2c_dev->dev, PTR_ERR(i2c_dev->clk), + "i2c%d can't get the enable clock\n", + i2c_dev->adap.nr); =20 return 0; } @@ -548,13 +547,13 @@ static int sprd_i2c_probe(struct platform_device *pde= v) IRQF_NO_SUSPEND | IRQF_ONESHOT, pdev->name, i2c_dev); if (ret) { - dev_err(&pdev->dev, "failed to request irq %d\n", i2c_dev->irq); + dev_err_probe(&pdev->dev, ret, "failed to request irq %d\n", i2c_dev->ir= q); goto err_rpm_put; } =20 ret =3D i2c_add_numbered_adapter(&i2c_dev->adap); if (ret) { - dev_err(&pdev->dev, "add adapter failed\n"); + dev_err_probe(&pdev->dev, ret, "add adapter failed\n"); goto err_rpm_put; } =20 --=20 2.43.0 From nobody Sun Apr 5 13:12:26 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26810248883 for ; Tue, 24 Mar 2026 18:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376930; cv=none; b=DY2/UD2Sr45jFE1oPiQswLURWUWbMZwHkzTAWJ+Zb2jrVYq6Q/wh2b+XDY0UPxKf3bcji6I/siRbD9nqoDt+FD7pqmjoBwd+yEcAbkbb3si0kk0L7a31hlOTOMoWindg8kjBjkeh2H4F8lVBNj5Kj6QNT7JGKjpZT1LD4H9bMUo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376930; c=relaxed/simple; bh=WclG9/5UCAVmNpJ6wIy91+8u1Ud041oHxz1zl+TJNjA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UCZGCYx2wlfVA0FP9eU/d8w0I0op+Ugnz9m0+WjNg0p0+kJXVRBAkbDAtWhP5fSPqvKZSjwCWgP4e+EEUhPDg5e1xoD1A9SosnF0kpJx5V2hFJ0ZvDQrF1IH3NvYeRfJzGGKkYSmlckjIoMHVlTC+kKj33Ys1wW2KQvsM76fqus= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PNwhm2D7; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PNwhm2D7" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-358e3cc5e7eso3159605a91.0 for ; Tue, 24 Mar 2026 11:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376927; x=1774981727; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TNhN09MjB5vo7WQrY09vfIIZoGUP1LY8sfZbk/6EDLE=; b=PNwhm2D7X/t5grbCzfbSsK938XLqC8zliWWJl7CHQeygpCZhAYKg9ueMW6WcooRWtm hx/+a574mi6Ddy2NR7xtXVnJuy7cRErVDGBX9UqYcdOOElMzK5cra+ldtlYXQd5kESR5 UUKhBEkRjSz/F7tWlojAuRS19GTh+gg8CUiiLHic3k+Nz7yf+T/K89Vkh8Wn67U9hJht khTlX9ALg7J8Vzjq7NvUePRnxVyfkaF3AMb5FCE/ED5VR3ZRAvTEFnntWFuw0jjgfgZC 0u3C4aicVQZl8UeTBMQLCeDaFYcc+zzXGj9JCZI8SMncELHZH+86BQGKyFc6sgd7zQhn xlRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376927; x=1774981727; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TNhN09MjB5vo7WQrY09vfIIZoGUP1LY8sfZbk/6EDLE=; b=TJOq6GnosSakiW6FBV3nqexH4059IUHe0vCIDwetef+kJhUnkG1C7d/mjue1yS1jc6 VKyOVMG8o0i+U81lQkfskjOe6auASUvmU4xtFDDVnUuPNQVJ4e/1FQ2P7AJv0BUop3QF GyBcfmivfICsamCsDH8PHaMcdCCZzqPIWGbvzJRosvezNxQymgrO0rZyK3yo/Lbqg5hD LtYrH0MTW8z8SZLXtpQpR/XKGElulyJ9/l270owLm3BRe/KfZxx8IEJ5Wr1Xy+civ30J qhZ2BZv+NfJJE618mNjRFJB9dRPwYp+zCt2SVj3thDyhnnRwpWqFr8RMoEZAjZ8FS38M HbmA== X-Forwarded-Encrypted: i=1; AJvYcCXfYXqY0aOiRGol36jp46M56C+qTxYR4f+x8pj+kEOglqVHjPmUHCN4Qmptuh7fsHRdi/6dCTzTWySmYq0=@vger.kernel.org X-Gm-Message-State: AOJu0YxnMfcWI5OmUjrCUHdazrzMsQP2Gcasfrtk4RxSSO6GhP3At3lz mXNl0oXnRxmqeoFDH0KntY/CaHUI1m4rGbhwgRYWb2J/atHKWqa3OVlq X-Gm-Gg: ATEYQzzXHiM2MUtudoGU4QmPv/ZvFrwZmTYzopeAEwtnuTygqU5MKfNpnCSlC/RXm/J cGTXhFuqtfFSu4JINUjkxW2x1yQ5RFbjWP7jWL9cyGl1SRwGRU3EP+/p7GDPnpFhN45t7CwI7ot HQISBB6MsQlZ9CBZXt3G5jkZ9TOoO23kH6SHD/84qqOolwjPm+qKx4NtKF5k+dC4lXg8/GgaS9L 31bOTA7qQT84YguA2fOWtjndgIJK0RNfm8iOiynL1U3nCE5N3rhqTxn3tSCms32Sh88HUpUH8u5 mjNx+3gO0pGzROVpS8qwWtX5gliITzSOFsBcCC8U/QV9LBWcdstoA/BU9iDHhKWVGhWsIVIGFzb m4Usi20aROghxaa4l74preTbQ1cbltcmd0xNGuC2J0slBPiIWqiIqZH1l5KOizzGfFD8MeCkor3 GZz56Uc/+uYPf4z3cnaWRm3k3friSY6fNuW66D X-Received: by 2002:a17:90b:1d8a:b0:35b:e5ba:c0c8 with SMTP id 98e67ed59e1d1-35c0ddd9ed9mr320446a91.28.1774376927304; Tue, 24 Mar 2026 11:28:47 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:28:46 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:57 +0530 Subject: [PATCH 09/10] i2c: sis96x: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-deverr-v1-9-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=2523; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=2gYAVvyUJk/qxHL4KJceROL4iNDzsuJ4eDXGcgjkpVk=; b=vB2gL2qhGY3YL/cIJqmvowLCaQEngaBk72sJRkrwCl3oRTHnnpcQvD7hzPfvDqHKUYnT4Wr6Y Zfn7Uu0NXm6B/rb6bM9jYBJr8GEREU1oPwc+1RRqWHn4xFjESwTrs7U X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-sis96x.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/drivers/i2c/busses/i2c-sis96x.c b/drivers/i2c/busses/i2c-sis96= x.c index 77529dda6fcd..eee41dc9d706 100644 --- a/drivers/i2c/busses/i2c-sis96x.c +++ b/drivers/i2c/busses/i2c-sis96x.c @@ -245,23 +245,19 @@ static int sis96x_probe(struct pci_dev *dev, u16 ww =3D 0; int retval; =20 - if (sis96x_smbus_base) { - dev_err(&dev->dev, "Only one device supported.\n"); - return -EBUSY; - } + if (sis96x_smbus_base) + return dev_err_probe(&dev->dev, -EBUSY, "Only one device supported.\n"); =20 pci_read_config_word(dev, PCI_CLASS_DEVICE, &ww); - if (PCI_CLASS_SERIAL_SMBUS !=3D ww) { - dev_err(&dev->dev, "Unsupported device class 0x%04x!\n", ww); - return -ENODEV; - } + if (ww !=3D PCI_CLASS_SERIAL_SMBUS) + return dev_err_probe(&dev->dev, -ENODEV, + "Unsupported device class 0x%04x!\n", ww); =20 sis96x_smbus_base =3D pci_resource_start(dev, SIS96x_BAR); - if (!sis96x_smbus_base) { - dev_err(&dev->dev, "SiS96x SMBus base address " - "not initialized!\n"); - return -EINVAL; - } + if (!sis96x_smbus_base) + return dev_err_probe(&dev->dev, -EINVAL, + "SiS96x SMBus base address not initialized!\n"); + dev_info(&dev->dev, "SiS96x SMBus base address: 0x%04x\n", sis96x_smbus_base); =20 @@ -272,9 +268,9 @@ static int sis96x_probe(struct pci_dev *dev, /* Everything is happy, let's grab the memory and set things up. */ if (!request_region(sis96x_smbus_base, SMB_IOSIZE, sis96x_driver.name)) { - dev_err(&dev->dev, "SMBus registers 0x%04x-0x%04x " - "already in use!\n", sis96x_smbus_base, - sis96x_smbus_base + SMB_IOSIZE - 1); + dev_err_probe(&dev->dev, -EINVAL, + "SMBus registers 0x%04x-0x%04x already in use!\n", + sis96x_smbus_base, sis96x_smbus_base + SMB_IOSIZE - 1); =20 sis96x_smbus_base =3D 0; return -EINVAL; @@ -287,7 +283,7 @@ static int sis96x_probe(struct pci_dev *dev, "SiS96x SMBus adapter at 0x%04x", sis96x_smbus_base); =20 if ((retval =3D i2c_add_adapter(&sis96x_adapter))) { - dev_err(&dev->dev, "Couldn't register adapter!\n"); + dev_err_probe(&dev->dev, retval, "Couldn't register adapter!\n"); release_region(sis96x_smbus_base, SMB_IOSIZE); sis96x_smbus_base =3D 0; } --=20 2.43.0 From nobody Sun Apr 5 13:12:26 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE76035AC3D for ; Tue, 24 Mar 2026 18:28:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376939; cv=none; b=hwacHHtnSLJRyvpHArWTffDGtMjhCHP33r5b2Skr3BdkZM/L2Zwsj3eDH5VYbd1YxHLQ7uAKQbzo1XKan7PL/DHq7o9//2yHBDWefABOgGbFrzpklFXr0Xvt28IEaqmc0ex3KPHARRt5O13Ze2oqR46bl2MNUOTKTvndLAXh6NE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376939; c=relaxed/simple; bh=7g/jARnkhTd3DIs23AFH73jSfHB7zbCwImSIcA8YsoQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ohp3b8P+M6PxygPUx2BuQPkmewe8Maek9bds8ARAV7656EDfiyddE1Z+T6CvbPR3i8ZPLKPmq5OTIxXJQytffywvy7BDUAtgAR2KrgOA9dgWvM7dWzyvai/lxDuD8VUG2gp8yEwLefbqy7zIYBRN/NOCRH8Kgk//JLDe8LYdawo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oeayEKFn; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oeayEKFn" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-35a02f3b8feso2429548a91.3 for ; Tue, 24 Mar 2026 11:28:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376937; x=1774981737; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2MPILU45gcDsKK8jp+8jqoirIZBgcXX7ZY0CuqSl9cY=; b=oeayEKFny7vadu4kiqbm4VW6IkcFRMWDumZCZUWfZYCw/RxXLv0aaKBlq4/VUUbDp1 KOa5FwW0/GzBQxBlZw6D6fi8V53ez3Bl6fagBvPaNDh7OzWeo774+Sen0yKN4nSYcmCJ 7mtLkTPv7K6AD1jUMNdOoaQduZzvAhBO0XhmZyAkJTbvUPriCVAuuAMM/Z3g1O4cdtpk ou8bmXIQlpxhaPDV2cdSEcDjxt8zhqlatUqSvYdSryoti2ViVZmB6Ac3Sc5DUOq9qS5A +I87rhwmm0Za4LigTmct0Tdjgkj658A48UbVEMAW5aF313a3k+aJOEBCbaLBFBJ5Vz+l wHYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376937; x=1774981737; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2MPILU45gcDsKK8jp+8jqoirIZBgcXX7ZY0CuqSl9cY=; b=VKxezpr3qXFrOrfa/JOqF55+mlxhaTMTFZI66gtv4Lzv37cgBxLQqwTCV5Uvh3ku9x yG3HmCeY1Bx1684ivi/UXcK0xb7iYVRxy0hH4DyM5PJoaXdWguyNta9U9/ZQid6YzPEi nj4tbdJglIg5EQ4YWbsJeGP4fvWL6Q0ZyOQR/qVKKZlM2zV7Wf8tazcXDBz7Z2lIK59P DUjvhzJAZ0wTOcBED2WQ6x14g8oBl2OHfl+JpiOXIwtRSz30mjDhVre7V6YnLVuzN2lO W77Ma21SEcKj8UhvXox545wOPlHJy9U5DidrS+GPOjEcUi1hKDqymngVTGvflhKrZzF/ UqLA== X-Forwarded-Encrypted: i=1; AJvYcCUY48DjrLiYsRwfosQ6nJg+L1fiYC7OMEG7NVKCWMvxZTPKDtqABoIGifsdJ3n19YDWQt+n3zBr3YLKPhw=@vger.kernel.org X-Gm-Message-State: AOJu0YxEgYu+O2wQJNdxjJsNfTGpjTBj1b0UMP4cGOW8Z40IxI4WRIJJ zPrplLvp9px18EWIOAr2OVtPIE406woHA8LSCBCeWyKUz/fKPOZ1EZPz X-Gm-Gg: ATEYQzxVUL9ZhecyXNCQ8k5M0DUcLivu7kKtSYgrg9UBPO4jWOkIPyUClawtavqhlsG fwg/VIKbSSAIv3bQZePl0bhrQvEA7gGRi+ei4rnxlw/9cu03QTHxJI7twN1t2bfJO9KBsnc7jr+ vy2Z64uXJptw2fZm4Zq/L6MVHAQ0XyQ9PdU4mS2MC4uRWkJ0nLOWCSkOqiMD0Y03ran0sEM98Ns oYGCG84EyBtFVd4NJW8dkwzTZ5bjjG0FeIBaFXENEqDHgvJp9F8umHcWexLW5AcoW8sqm8sqWoa O8RAN07V+avtExZj0B2X7rjNI1g13y5qYPN8Owh3BmJGF4k1kXd7O1dmfvC4ODwIa5O3y0EJzrB Hwr6SuK7cEqAOAy0Umda14ypyk/eBlBas/CNmVV2yNagRoEUi+DYA3m5547jYqcFzzZxwKGfkcS hHvr+yEsIQdYW7ajOQqW7C/VFmyw== X-Received: by 2002:a17:90b:3dc4:b0:35b:929f:7e8f with SMTP id 98e67ed59e1d1-35c0dd1000bmr297824a91.13.1774376937217; Tue, 24 Mar 2026 11:28:57 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:28:56 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:58 +0530 Subject: [PATCH 10/10] i2c: sis630: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-deverr-v1-10-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=2804; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=nhsfDSLdFe3nGX23EexwATKRFgvnwZsN/uRkVIgsfDc=; b=MfTL2nua2/UaTOkuHox/mofQ9uGkaQFwD4ef2QTeyEIJWKrK1affTlrqYL2fD+dQbiqZ2kQf1 368O9MeLyraCsNY7XiqbLSbdhihgwtkeZhLhsjgkAnvnbcpMTIg+zrj X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-sis630.c | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis63= 0.c index a19c3d251804..3d0638c2bc51 100644 --- a/drivers/i2c/busses/i2c-sis630.c +++ b/drivers/i2c/busses/i2c-sis630.c @@ -431,24 +431,23 @@ static int sis630_setup(struct pci_dev *sis630_dev) in acpi io space and read acpi base addr */ if (pci_read_config_byte(sis630_dev, SIS630_BIOS_CTL_REG, &b)) { - dev_err(&sis630_dev->dev, "Error: Can't read bios ctl reg\n"); - retval =3D -ENODEV; + retval =3D dev_err_probe(&sis630_dev->dev, -ENODEV, + "Error: Can't read bios ctl reg\n"); goto exit; } /* if ACPI already enabled , do nothing */ if (!(b & 0x80) && pci_write_config_byte(sis630_dev, SIS630_BIOS_CTL_REG, b | 0x80)) { - dev_err(&sis630_dev->dev, "Error: Can't enable ACPI\n"); - retval =3D -ENODEV; + retval =3D dev_err_probe(&sis630_dev->dev, -ENODEV, + "Error: Can't enable ACPI\n"); goto exit; } =20 /* Determine the ACPI base address */ if (pci_read_config_word(sis630_dev, SIS630_ACPI_BASE_REG, &acpi_base)) { - dev_err(&sis630_dev->dev, - "Error: Can't determine ACPI base address\n"); - retval =3D -ENODEV; + retval =3D dev_err_probe(&sis630_dev->dev, -ENODEV, + "Error: Can't determine ACPI base address\n"); goto exit; } =20 @@ -469,11 +468,10 @@ static int sis630_setup(struct pci_dev *sis630_dev) /* Everything is happy, let's grab the memory and set things up. */ if (!request_region(smbus_base + SMB_STS, SIS630_SMB_IOREGION, sis630_driver.name)) { - dev_err(&sis630_dev->dev, - "I/O Region 0x%04x-0x%04x for SMBus already in use.\n", - smbus_base + SMB_STS, - smbus_base + SMB_STS + SIS630_SMB_IOREGION - 1); - retval =3D -EBUSY; + retval =3D dev_err_probe(&sis630_dev->dev, -EBUSY, + "I/O Region 0x%04x-0x%04x for SMBus already in use.\n", + smbus_base + SMB_STS, + smbus_base + SMB_STS + SIS630_SMB_IOREGION - 1); goto exit; } =20 @@ -511,12 +509,9 @@ static int sis630_probe(struct pci_dev *dev, const str= uct pci_device_id *id) { int ret; =20 - if (sis630_setup(dev)) { - dev_err(&dev->dev, - "SIS630 compatible bus not detected, " - "module not inserted.\n"); - return -ENODEV; - } + if (sis630_setup(dev)) + return dev_err_probe(&dev->dev, -ENODEV, + "Compatible bus not detected, module not inserted.\n"); =20 /* set up the sysfs linkage to our parent device */ sis630_adapter.dev.parent =3D &dev->dev; --=20 2.43.0