From nobody Fri Apr 3 16:02:18 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A55983EDACD for ; Tue, 24 Mar 2026 11:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352328; cv=none; b=D2a5/4PLyGrJ8+XDle2cIp3soDBg7MtScXlCKeSK3g05Rw/0cyD7mPlflQelOn63SqkEGVDsHEj/8mzXbu5KdOmN10l5yMkDBbQDz5GnBs6JIIwvg91LfRg2o0DqPnroX+tZOOTZ0Sm1y/RbvWQ9jhtPvnodb/RbHJB9Feu0YMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352328; c=relaxed/simple; bh=xDe5OwkC59HG0l6E9h1OwEErzx9ysv39/KByzvSAFgU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A30tEiejkFtu03VlCP2hHBftekQZwe2vqIsJcSww3uXbUiAxH28qhRsPEdSZOjfh7pv2ABldru6v/+axcf86dCQQBPswfCgjFf6+tZ0/LLGXCl5Tm3P6yfqr+SYgD2dPdojgwgZjrgz+REKDel6NuxFSARSM6U6nPUoGm34tYy0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=vYz0qjw1; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="vYz0qjw1" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so36090005e9.2 for ; Tue, 24 Mar 2026 04:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352325; x=1774957125; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3AEOePYJtU4kn4mkWQfK7NUJrP7JZP+VFvVN1gskxyo=; b=vYz0qjw1Qb3eigahsHUowHZCtHmucwme8mlhLI3BadP14N903BB+xohcWNIuE/mqtN twIfNLwZ/9YHSKHKOeS2A5xQd3fMsLJRf5glwJTUb3AQyYqk9aWf/1XSQq/lIRRWw8Bv n3g9ar3GdBEohYsaZKv4v+ig6b8XpYqbAW21WktREp6OqQPDqk3bUmTPy5wn416Jp69v 297cZ5nm96GC+eOVP6T51XdiSyyQtD5STwSqbWB/x07P5nMQJOxO3xW2Qj6ew74Oehuc DuQ6Pt55pii3b+Px9r8A59B3gMsPhe+a1KHZAT0G3IV1PX12N7vr/v1tMs1jp3jK0y15 gQAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352325; x=1774957125; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3AEOePYJtU4kn4mkWQfK7NUJrP7JZP+VFvVN1gskxyo=; b=g2bAW21MrbuQXLmno7zbEkXKuI+ZBZE5slb0cgDLj87Mo6kDEGU89W//SsVYbV8l96 KyqEAWj2GyVwON0l+SRjZUVQ1idO/uBuvmwlItDU8NL0Xv5eaduuKtB+q2pc20c4gy5h Ripms/y/3o87yFNk8Jc7nBVwTo4nAyyePTgAnqPu6ASqoRS8go2DSyz5x2cgDyaPLL1b L8C3dW5i0MksiJoTor6hF1Jrjz/wyOEpC/On3oF850Uf93WBhlp52Se64dgrp52F8ahe CLA8emz8YAnfkoV094ewcsCdQ3NdY4dZMRJQODtLyyWQGhKlUIgCeTjuCEv0wSnTXOfY h1aw== X-Forwarded-Encrypted: i=1; AJvYcCV9P0hfdIssiEhNI7WVRMtMLQOJPrusRRbHt9i9LiOfCG9G9qSu2D2NoxLZG4NPPU/5oE7jiuCkDonkrBM=@vger.kernel.org X-Gm-Message-State: AOJu0YwDTRVJHKRXtyZUtZ5RD1eTijuxUm/5XOE7fR6F+0M6+RTF6g6F wtgPKpnghuhbH1H2MRgdj96PTkuPAwSlHDCirtgFq0pZu0b+2pt+xZTs0t8uFRrSkvM= X-Gm-Gg: ATEYQzwKguDzy554tAC8IJHRCa5Xb/3c+/pAcAw/xUIzc09LUqHj5IRMKsmqsIqyxD3 lNmNDnd2XZJrK6gVgjNs67plDB+c/dFVTmwc6L6y6IqwL9LEuOa2eTNcsV9hxZs/2Vs9I/5Mi3D bq2FJnpHyne5hCGjOAmckSp7bTfT0Zri6cqMbqGgH25L23ZeUIgMyG+K5d2cw2L6LhTO8zmGPH8 Sc+bQxt4eESJbLaSrGsIcgrzJR15yedNk+7RfVCKQjtxTQPW6p0S4/c6i0RLZdKnGF72HMI66Vz 3uJQsENL3AYSWjCO0Hnv9G0bf7iMI3uAkTxHQwKiM4a0UDg4hHT4sV8BHOls2IbK+8MhwZtZM4H /T0Z79dgsmBVbuTriveWGjJ09HTJHv9Mp8RCBCN8x9+F1aTLaHh2ZwrwNwz9DQkngD4OecuzjCM /ccp9EzC56op6HDsOBY4FMiSe/Ump4Ne5HDIZdSW6C6/Ed/Moj21aYLqLi7hsfwJyAXeo/MTPtg x1Iew== X-Received: by 2002:a05:600c:3b07:b0:485:419c:4eab with SMTP id 5b1f17b1804b1-486fedab40emr213637765e9.6.1774352325006; Tue, 24 Mar 2026 04:38:45 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:44 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:13 +0400 Subject: [PATCH v5 08/11] power: supply: bq257xx: Add fields for 'charging' and 'overvoltage' states Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-8-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3105; i=alchark@flipper.net; h=from:subject:message-id; bh=xDe5OwkC59HG0l6E9h1OwEErzx9ysv39/KByzvSAFgU=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl/78v5FrW3Z0yIrZLIlf7oFrWm6vHcJ2/xOQ6OIh ZOyeFO7OiayMIhxMViKKbLM/bbEdqoR36xdHh5fYeawMoEMkRZpYAACFga+3MS8UiMdIz1TbUM9 Q0MdYx0jBi5OAZhqyQRGho2zmHwjJEP59j2dujnAxM25s9SquE35MsO0nyuqndhOiTL8r2q/Fi1 iv7Y9UPXVO9Y9ZtuO1Hzo3jExf/KhurJbkXxveQE= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The driver currently reports the 'charging' and 'overvoltage' states based on a logical expression in the get_charger_property() wrapper function. This doesn't scale well to other chip variants, which may have a different number and type of hardware reported conditions which fall into these broad power supply states. Move the logic for determining 'charging' and 'overvoltage' states into chip-specific accessors, which can be overridden by each variant as needed. This helps keep the get_charger_property() wrapper function chip-agnostic while allowing for new chip variants to be added bringing their own logic. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 0765673728e4..9c082865e745 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -54,8 +54,10 @@ struct bq257xx_chip_info { * @bq: parent MFD device * @charger: power supply device * @online: charger input is present + * @charging: charger is actively charging the battery * @fast_charge: charger is in fast charge mode * @pre_charge: charger is in pre-charge mode + * @overvoltage: overvoltage fault detected * @ov_fault: charger reports over voltage fault * @batoc_fault: charger reports battery over current fault * @oc_fault: charger reports over current fault @@ -71,8 +73,10 @@ struct bq257xx_chg { struct bq257xx_device *bq; struct power_supply *charger; bool online; + bool charging; bool fast_charge; bool pre_charge; + bool overvoltage; bool ov_fault; bool batoc_fault; bool oc_fault; @@ -106,8 +110,10 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) pdata->online =3D reg & BQ25703_STS_AC_STAT; pdata->fast_charge =3D reg & BQ25703_STS_IN_FCHRG; pdata->pre_charge =3D reg & BQ25703_STS_IN_PCHRG; + pdata->charging =3D pdata->fast_charge || pdata->pre_charge; pdata->ov_fault =3D reg & BQ25703_STS_FAULT_ACOV; pdata->batoc_fault =3D reg & BQ25703_STS_FAULT_BATOC; + pdata->overvoltage =3D pdata->ov_fault || pdata->batoc_fault; pdata->oc_fault =3D reg & BQ25703_STS_FAULT_ACOC; =20 return 0; @@ -478,14 +484,14 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, case POWER_SUPPLY_PROP_STATUS: if (!pdata->online) val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; - else if (pdata->fast_charge || pdata->pre_charge) + else if (pdata->charging) val->intval =3D POWER_SUPPLY_STATUS_CHARGING; else val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; break; =20 case POWER_SUPPLY_PROP_HEALTH: - if (pdata->ov_fault || pdata->batoc_fault) + if (pdata->overvoltage) val->intval =3D POWER_SUPPLY_HEALTH_OVERVOLTAGE; else if (pdata->oc_fault) val->intval =3D POWER_SUPPLY_HEALTH_OVERCURRENT; --=20 2.52.0