From nobody Fri Apr 3 16:02:19 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4EA03F0A8A for ; Tue, 24 Mar 2026 11:38:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352326; cv=none; b=Q9tEeWSE3gg3WPlwTdlsrrzM+U+anqb2+cAj80UoStKFpCPkZTzdEcWjOvCu/LMyYKxF8L5Lqqy47VAybRoCqzvJ3TnQ8Ax9nqoP/Kh/yn/hrfbBaKnRvqE/tVUAOw/NJrmbmldn6xsZfva3q8UBmdzkStK96YkKVdkE7y3mXT0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352326; c=relaxed/simple; bh=K/K91eQQ75phcINLj4DBBQbD0ofWablCORf9BgG8obM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oIqFxV04fLuBw/Vzn2O/kCqYtTbE4A5gQPDrjsKvToKR6wSKRsg+dZ+t95BlfHfv5Cq6l17yzEnpFejR2m16U/qn8IQQ/dKkjfduChKzisJU7/AU0v+LrEhK+Lk4HQxGiBzJTv+Poe/2wMi5lvYf50sxRHer73jIDGK3mBauzZA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=s6qpf/bl; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="s6qpf/bl" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-486507134e4so14303045e9.0 for ; Tue, 24 Mar 2026 04:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352322; x=1774957122; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8b97w0FIxP+iQSlY9+U8NDMrKZX5YXrCInQTxcuoNL8=; b=s6qpf/bli7kxnqYpBCJHYvWsRf0FCHKjGYc5tyw8/2+/ArvH5ctKWE0nspfQ+UWWFa ZplGI8NnZmlExIe5l6vkZjCYfDMQLnui4YZgNrREZDXetdYQq1lV75Hs9irLXxWHOpjI jK3gL0qAT+VEugK340xuck76HDlNjXOvH5sW4nZ7c1QWXE2G0dhgTAyIFkJk2z/Psd2S uffl2nClbMY0ikTe1gf10SP6sAurjZU3m3PSgPTsGkzktLdiirf8qmSws+J5hQ2GDMYY gjJJ6DcvQVyjtQnX9D+LSBhiww5u9tnI7RzBt/qPFzzEalUtXZBRCbhJ6x1NwchHqbZf hrFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352322; x=1774957122; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8b97w0FIxP+iQSlY9+U8NDMrKZX5YXrCInQTxcuoNL8=; b=MWv+s6uzwEpEE0kQezYxIjBH8AXvXvKSD1y/phJHBEGmIm9g+3JW/gNPdbKT4WmDhb AhsZUwILjFfMfUDx7dfbJ9kcY799CHzkFzy7mHvNq3/MQpEJUzg0t6uFWJhH9nGLwQH/ Q/P7Vjak2hLxBudzG3TLpjPRPxbg0oWN+couZJnYJWQNLd04D3tc0qxDBwssYbv9HOAw 2jEh5nQEYDSxBp1mZJ3YrYciGqqnaGiwxJUd9P8utWqE7swPWAfI5IV90vP2ByUlSup/ eaFCfnDXxmUdl2HGGctUyaUEXO36tm5R+GR63U/H8SZktipwqKigyLd7Y0wMZpque9hW Biyw== X-Forwarded-Encrypted: i=1; AJvYcCWKiSIw6QOSGRbPVTvRinCVg0FleC9RKOrpg47AxmxARebBiGzmnli12kpIeIiK43EaDwhkYwwexnopGGY=@vger.kernel.org X-Gm-Message-State: AOJu0YwLZOoXZSqdDd/wpSPXa1WVzRdhLSS8eu7f6+l/6He2kJq7rM6b H8gbpjmr7zlnjF2S2Gz8Dy3bq4sUA0ITCcWMNsc3IpNcb5AudVfjaw2E6VrZtRXjMlQ= X-Gm-Gg: ATEYQzxNfyQ9aL4+YBKdmyAWAR1fcH1z8H8CKS6dJmlEFCXrcBHD7E5DNsUif3oiHe4 xSXqChUb2JcNZJA16P5b/K5ZlFFjsI00AtgGKbqgBCo5SSY19I6T6lUlUBJHjHA4Ad5lJpTsmJA hd0aSlrQKDm+EqQRE3dumU0axXAm7U2w+nXdpVCkfhifgIKg5X947Cqwx6ird0dzqzI0zhsAiXx 69a3EdFhNb59n+o2x6dF3oVtM7k7wjSirTWZu34FF1VKGg5bMJpDANhBZGrjEFIr2sKUKg22i2P rzLItX4SKIJgouoc5t+d8pp40KdPQKWZW1r2+dHSD5/8OGMzi3gupONvPEadXTyEpFecfxpVwQv sNQARhWz8weJ5JNbgd8JTRTYj/ThttJstyjOaGmz+ryCnOManVV7dUxgcN4vhuAaOWdCM1cHm/N LrOtBgDITjymAGNNee3L59HfdXg8BhKN+LFTlYwqZHuFxogCWZjnB8rjhmxm9R4DnaR+2dBwtzg FVj9A== X-Received: by 2002:a05:600c:3e8d:b0:485:3a03:ceca with SMTP id 5b1f17b1804b1-486fee26501mr204972165e9.23.1774352322085; Tue, 24 Mar 2026 04:38:42 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:41 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:12 +0400 Subject: [PATCH v5 07/11] power: supply: bq257xx: Consistently use indirect get/set helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-7-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4242; i=alchark@flipper.net; h=from:subject:message-id; bh=K/K91eQQ75phcINLj4DBBQbD0ofWablCORf9BgG8obM=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl97wX577jHP7rKNP51nyfjunKR07ofdXDaheA7Xu FnCU/mudkxkYRDjYrAUU2SZ+22J7VQjvlm7PDy+wsxhZQIZIi3SwAAELAx8uYl5pUY6Rnqm2oZ6 hoY6xjpGDFycAjDV3KsY/srqfJ05k7WmRvDWow98zzUORx5f9s/rHSfnnHTm1dwsETcZGRYJue5 8vy38kot39/Q3gt82x3K/vKq0x8RHk1dF+NaU/7wA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Move the remaining get/set helper functions to indirect calls via the per-chip bq257xx_chip_info struct. This improves the consistency of the code and prepares the driver to support multiple chip variants with different register layouts and bit definitions. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 39718223c3f9..0765673728e4 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -22,18 +22,30 @@ struct bq257xx_chg; * @bq257xx_hw_init: init function for hw * @bq257xx_hw_shutdown: shutdown function for hw * @bq257xx_get_state: get and update state of hardware + * @bq257xx_get_ichg: get maximum charge current (in uA) * @bq257xx_set_ichg: set maximum charge current (in uA) + * @bq257xx_get_vbatreg: get maximum charge voltage (in uV) * @bq257xx_set_vbatreg: set maximum charge voltage (in uV) + * @bq257xx_get_iindpm: get maximum input current (in uA) * @bq257xx_set_iindpm: set maximum input current (in uA) + * @bq257xx_get_cur: get battery current from ADC (in uA) + * @bq257xx_get_vbat: get battery voltage from ADC (in uV) + * @bq257xx_get_min_vsys: get minimum system voltage (in uV) */ struct bq257xx_chip_info { int default_iindpm_uA; int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); + int (*bq257xx_get_ichg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_ichg)(struct bq257xx_chg *pdata, int ichg); + int (*bq257xx_get_vbatreg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_vbatreg)(struct bq257xx_chg *pdata, int vbatreg); + int (*bq257xx_get_iindpm)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_iindpm)(struct bq257xx_chg *pdata, int iindpm); + int (*bq257xx_get_cur)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_vbat)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_min_vsys)(struct bq257xx_chg *pdata, int *intval); }; =20 /** @@ -490,22 +502,22 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, break; =20 case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: - return bq25703_get_iindpm(pdata, &val->intval); + return pdata->chip->bq257xx_get_iindpm(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX: - return bq25703_get_chrg_volt(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbatreg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CURRENT_NOW: - return bq25703_get_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_cur(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_NOW: - return bq25703_get_vbat(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbat(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX: - return bq25703_get_ichg_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_ichg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_MIN: - return bq25703_get_min_vsys(pdata, &val->intval); + return pdata->chip->bq257xx_get_min_vsys(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_USB_TYPE: val->intval =3D pdata->usb_type; @@ -633,9 +645,15 @@ static const struct bq257xx_chip_info bq25703_chip_inf= o =3D { .bq257xx_hw_init =3D &bq25703_hw_init, .bq257xx_hw_shutdown =3D &bq25703_hw_shutdown, .bq257xx_get_state =3D &bq25703_get_state, + .bq257xx_get_ichg =3D &bq25703_get_ichg_cur, .bq257xx_set_ichg =3D &bq25703_set_ichg_cur, + .bq257xx_get_vbatreg =3D &bq25703_get_chrg_volt, .bq257xx_set_vbatreg =3D &bq25703_set_chrg_volt, + .bq257xx_get_iindpm =3D &bq25703_get_iindpm, .bq257xx_set_iindpm =3D &bq25703_set_iindpm, + .bq257xx_get_cur =3D &bq25703_get_cur, + .bq257xx_get_vbat =3D &bq25703_get_vbat, + .bq257xx_get_min_vsys =3D &bq25703_get_min_vsys, }; =20 /** --=20 2.52.0