From nobody Fri Apr 3 16:02:18 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C42B03EFD04 for ; Tue, 24 Mar 2026 11:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352319; cv=none; b=SIT6TOMBWvaxM/kawsuRugwoxnd2QaauPdq4DhQKpUPPCiUt8nqdPgRQHT2jmU+eD0lhTdO7akEPRZssnDGaRzvHow7PT9RDAk6XXopzfaqIfgf971g0gR69erQp9IPEvjyN1Q/Cyy7enn+5sgc0J6o8xkJIJ89aQ29nY/D3Ai8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352319; c=relaxed/simple; bh=0GDlOYezmKEXCru71ex6Z77WQ5tS0GByeoQbXgUi37g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QT/qWNzV8JxziEml0TRDRld2tuJsP8Mw4uyOxIgzdfaIUwdnHGVvQbH+EQgwlI9gZWPYw8FScRuWcYM+9E12SlL/vfKD6/7wz0CGMriXxJmeaJydIiVxiVi+GED35UyVjP9Isx0bEooqX+bLH5Wy2dHPBqCR3eCh0n4cpLIJSqA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=jMczJ74f; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="jMczJ74f" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-486b96760easo10658205e9.2 for ; Tue, 24 Mar 2026 04:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352316; x=1774957116; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j1uQzW3+bjNeF/wEPgSsxYt2kbdgf5x20O5xEAeMiek=; b=jMczJ74f+p4Oa2Xl9eCmCm+k+OyS0x73hIZG1wfmP9dexw91n6Q4UQojcvn8q8x9BS yPndZW+lCvh19+8phFYkA43uYe4xhTnU5VzIXE6ieZEGMnkxQclMsIgita0rofjLE53x OQoCseDmpaRVXomJTqTTNjS4X9Eq3O99YX37lyTC4MjkLb4QEr4MvW/t9jTacIGiSXTL iOhwqZvAGxBkxIxo7hPSArFTvfu+m1MFAkDlo48ehA2M2rDbMU7Kdk6VSBxlbCmlaeuO QSUQPHwZTFU0/UzY6G7gVKeg0M9BKMTY4jcOHkYC9T+iFh2ugqaqAknRh7QIzspmVIcU 3Y0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352316; x=1774957116; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j1uQzW3+bjNeF/wEPgSsxYt2kbdgf5x20O5xEAeMiek=; b=Khz2agoz+ft7TJNA+cegn3qParsiAmVZsbnjInjOUT1LOmJYHkBi2HNtzusVxDJoJJ ZtHnvZneMvc7dQENgBuUO4G9jpEAmggr7jLlMKZgnS+3x7wxVjAku3+Upb2G0PmXCqrA Z3LZSIRGaSR+TFQwTgnrNmORpgfb7X/HGYXc+Skg5Ynt/E24peyevaO4KnGkGANt3w4A tRiRmUnRFbTTltWdwgeztsJS+26SyV9gEk0pT6jrIaTnBiPO9S0DG1kveG2w+RiCYNBb 0pq3I76MsLX/nQMOw4MYCbE+GyvBgCLmIIOhj/nRlcEh6k4IfyVv2O7r98zPQOwT+vSF ZcXQ== X-Forwarded-Encrypted: i=1; AJvYcCXu8GKZPfDAVqUsYdjHmyKNkIQBYHzjePEHEzXsh6m5jF91tPtjXebG3/45pXd7E3ySjYOqtyOKM7pmtt4=@vger.kernel.org X-Gm-Message-State: AOJu0YzAIxawFVfIaFpIbyP3dTZUUP0jXcCjBcruFB2B/RCgsfu2UOkE /oZxFVUX1qhIcQoHKlgSOEZmuxYj+QFLNC7y72e4WerCSE2XCU6gsNv2WXPPpFy4DDW5OTAoW8i H59ud0VU= X-Gm-Gg: ATEYQzzShV91d3NxZwFY4Rjl3CRaVvW5DM+eRErLh/nFLPPPI0my+rwDcS1X8SVgji7 EDGCF2v5BuMew1TN3+6ewhp3eYUjhdD03L8TuTEYP5nOmEDYGEJ/vSuRSwqiAtWlM8fa8QCCP/+ QxcsJfFeWJAQ3Ew9P3vWvQkJJe/3jd1K5pB8zqr+fwUwsv6GANHtwc2jtnftNkq5htTXoTyfcVr M98gBEHHnYeBD1knjj5Dx4yJIfymodILAsN0s9BtBBaMLdC99mAa2XbYW5pBUSSbA1xrJdN4rM7 udkhx9JVSwoZS9ztDfDqqr665nd/XpI6j0ZmxXBzGCZoc4PMO299ltYOBt3bskem6SkD5AWDq4W wWjEqqNXoAdyLEsXA9DQ5MpkEP4nAehs2zbut2VsSsZLO3EqBnAx9IyzpN6oln2xJ0RnDZIue+A DwtYXMYQBZwf3MuBprnnBuNz+gkt0mqoKkxTjNEJF6Dcf4MsPRKK1JfcYvHnMnm8+B3U9kDnTz5 7Il3gBVU+z9Fp0z X-Received: by 2002:a05:600c:8707:b0:487:338:b4df with SMTP id 5b1f17b1804b1-4870338b5d9mr166015045e9.15.1774352316223; Tue, 24 Mar 2026 04:38:36 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:35 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:10 +0400 Subject: [PATCH v5 05/11] power: supply: bq257xx: Fix VSYSMIN clamping logic Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-5-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2028; i=alchark@flipper.net; h=from:subject:message-id; bh=0GDlOYezmKEXCru71ex6Z77WQ5tS0GByeoQbXgUi37g=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl/7QnLhoeT0m79ifgX1brk/cd7ONeq7DRZmddc2t Px9d4nvYMdEFgYxLgZLMUWWud+W2E414pu1y8PjK8wcViaQIdIiDQxAwMLAl5uYV2qkY6Rnqm2o Z2ioY6xjxMDFKQBTfbWA4Q/PDdWI70vfPcuWmeP/5HqS3YPrLy5+XT3BXWdv5LpwxY2rGRmu+7m tLdlxpXbxwp4ZaX9eHGh8vlLFeaK2zxvGDL55309yAQA= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The minimal system voltage (VSYSMIN) is meant to protect the battery from dangerous over-discharge. When the device tree provides a value for the minimum design voltage of the battery, the user should not be allowed to set a lower VSYSMIN, as that would defeat the purpose of this protection. Flip the clamping logic when setting VSYSMIN to ensure that battery design voltage is respected. Cc: stable@vger.kernel.org Fixes: 1cc017b7f9c7 ("power: supply: bq257xx: Add support for BQ257XX charg= er") Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 02c7d8b61e82..7ca4ae610902 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -128,9 +128,8 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pda= ta, int *intval) * @vsys: voltage value to set in uV. * * This function takes a requested minimum system voltage value, clamps - * it between the minimum supported value by the charger and a user - * defined minimum system value, and then writes the value to the - * appropriate register. + * it between the user defined minimum system value and the maximum suppor= ted + * value by the charger, and then writes the value to the appropriate regi= ster. * * Return: Returns 0 on success or error if an error occurs. */ @@ -139,7 +138,7 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pda= ta, int vsys) unsigned int reg; int vsys_min =3D pdata->vsys_min; =20 - vsys =3D clamp(vsys, BQ25703_MINVSYS_MIN_UV, vsys_min); + vsys =3D clamp(vsys, vsys_min, BQ25703_MINVSYS_MAX_UV); reg =3D ((vsys - BQ25703_MINVSYS_MIN_UV) / BQ25703_MINVSYS_STEP_UV); reg =3D FIELD_PREP(BQ25703_MINVSYS_MASK, reg); =20 --=20 2.52.0