From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D65E93EAC95 for ; Tue, 24 Mar 2026 11:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352308; cv=none; b=c0pyuWIYvIpU4IXlfABn71vPz4FCNT5ZSINFIBKy3wktpjYwXuBE2p69mZ0Ids0WJ4D7ozLH4E/GZPrQZN7XbdowpBm3RcWplpIeHperLiw6G84kv2AAfiYy4A0lJBHKRPTsyWdbeSKdjYzT1P6jSS7594NC1UIqlbcj5whzJ80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352308; c=relaxed/simple; bh=Kch86XWLNpsoWXsiUYScxG9+qZq2PDWJ+mVUNiuprdY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TeXcwBjCF6wmtS398+hv11ob2giejHiPyT4cgLwbscUtrNj2aB8SQ09o5ONinHk0Qd8Yh3rUB8l8pD+nhRXUzOcIAHE8k8IYI8IdRCRiA1U/E2jvuTrqWg1ekDgSJ6YaWzpqhdZcuRXOeTK7rgVjXOK73Ks/1X0We/5+jF2puYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=ubRAuAF8; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="ubRAuAF8" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486fe2024a9so29770065e9.0 for ; Tue, 24 Mar 2026 04:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352305; x=1774957105; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=a3tePfAp0V+6zfOlKlirFvJa8IZ0hYoxL5FVcQEbR28=; b=ubRAuAF88g4+lGWoPq64KrLUncS0g4eFfK1GJ4EduzgXwzIMBMpksvLqtcKEpnkqYr RjJixLr6YTCJErncVwJ/iz1ObtxBs4QjKFx7oAsPnVRuTlej7zfHXIBeCu1tSZecOhDP J5r9bg8tYNJqsveGsmqym3qp58bXbvdi3aM/spXa8SmHg8Dn7vJ8dfTC4+ZwSsQtQXko +siLqm4ngQT5QRGih05PnlMinhG/ddNVu0S3NzlR+k923E3ruKg2OQ1X/5ij1/NzNM6m /VxMy5C53NzbdxF6JUBOZPvL5n2yEgrupK/gAgp8hW7nsZ5a8Mur+c2Mw489bOU7vsJN tDAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352305; x=1774957105; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=a3tePfAp0V+6zfOlKlirFvJa8IZ0hYoxL5FVcQEbR28=; b=k4ir/eFyuVlnZeAin3wnQhENp20mJt4l035/dQXdFGFOzwFXBQ+BCLXttLsiEMfDkT dMa6rIWxECl/n6TcOeWmEjt1qi2BxCFWqL/u7tc0H2uNwTFO2cdFKWQRcTFReJsFY9JW QncEwZexfwEJi9bz615JfMyuKM/uY3mBD5fCcF0+osWdmXukDNKQU79mJop6Ezhgw4dg Odkfevm6CCBwDF9G4xg1YgOKRmWq6tHI9gahoI9jHZUzACRqYgrklgP1oc2cAsSyn3+Y 0Lb6eONiZEz2HbETWSoi1UjBVtOEsvwQSfLWwcalkXNmhhO9Pilnw/LKucQZXC2UH33n 7e6w== X-Forwarded-Encrypted: i=1; AJvYcCWFfMmrCCvkmpaWV5h9lg6i2QA0hwAZyaHqTXDkuEfHcZX+r9w0cwsFU4GOZy9BXiLxSP6g5ZarjKdzlfs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4xjLyPgugyp9WDe5qmFSYBEJul5B31qm71Ak4RwwTTWx5TSaN zFpNfvfLU8qBJgVdANbJqpctjWBWW4lVPXsusWSfrrx0l2cY2rTpwY6PUwfbN257ErE= X-Gm-Gg: ATEYQzzJHtoulV18UZRR1rhJfcWt1Uwom9ZiUBGy6WiaIk6WjKLuwg9GlMwYUUpQN17 Kr+QZwkV6I21D7T8zHhwWUVTjOSpitoA/jg/2ILgnvD8j7MrfVHmUs+E+EYUw1ol4Y+G/ASlR9k Gd9hJXoeoMorvmHgQ9TBHwi4hYcQHY4lHJ75IgLJ1zd9xQzV6bE610qsduTtzlpI/mD7iTtvssi HSipfLWNaZ3CJ7KWB32Lg37h2RGfH129LZflSCXhvUGsQS29O8ZF+hh87unkSXfxk6b7ZMYj6ki SePPPl4zTIssud1XWNPLwM28prtJrIGioXJEJ74WFLzMAM75NBnVAc6QhahDIAYbtogb7mAcqWf KCmKq2hBhzYXBOKI5ZdJZQPNlGlKyoTHQM6nng7wYRAQ1IHeINY0S1iQI8T+lslDU8EwX2WCF6O 4VLD2f+ljhDKOyPQ/vfJHK1E7oL4P3KuBVuaS3uu4IrF2xaq+7cBVD9P5VgVyKnSV7jCPoS+SAE t572A== X-Received: by 2002:a05:600c:4f10:b0:487:2e8:69c5 with SMTP id 5b1f17b1804b1-48702e86a88mr199543535e9.15.1774352305270; Tue, 24 Mar 2026 04:38:25 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:24 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:06 +0400 Subject: [PATCH v5 01/11] dt-bindings: mfd: ti,bq25703a: Expand to include BQ25792 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-1-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov , Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3922; i=alchark@flipper.net; h=from:subject:message-id; bh=Kch86XWLNpsoWXsiUYScxG9+qZq2PDWJ+mVUNiuprdY=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl8b/UHHfAfH3BNlrTrCV1ZnLHZjV5NhvPzZ+aL28 Q/X5x+X75jIwiDGxWAppsgy99sS26lGfLN2eXh8hZnDygQyRFqkgQEIWBj4chPzSo10jPRMtQ31 DA11jHWMGLg4BWCqQ7MYGU4/Ulia0nej+siCabodsmeTlz/LZ/+6flfnzJU9Pi1r5ngz/A9vfH+ wd9qU+HPN+iL3m15oxeRn3dXSKd2h76M/XYlbhgkA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 TI BQ25792 is similar in operation to BQ25703A, but has a different register layout and different current/voltage capabilities. Expand the existing BQ25703A binding to include BQ25792, and move the voltage and current limits into per-variant conditional statements. Reviewed-by: Krzysztof Kozlowski Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- .../devicetree/bindings/mfd/ti,bq25703a.yaml | 73 ++++++++++++++++++= +--- 1 file changed, 63 insertions(+), 10 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml b/Docum= entation/devicetree/bindings/mfd/ti,bq25703a.yaml index ba14663c9266..cdce83f05804 100644 --- a/Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml +++ b/Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml @@ -4,17 +4,16 @@ $id: http://devicetree.org/schemas/mfd/ti,bq25703a.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# =20 -title: BQ25703A Charger Manager/Buck/Boost Converter +title: BQ257xx Charger Manager/Buck/Boost Converter =20 maintainers: - Chris Morgan =20 -allOf: - - $ref: /schemas/power/supply/power-supply.yaml# - properties: compatible: - const: ti,bq25703a + enum: + - ti,bq25703a + - ti,bq25792 =20 reg: const: 0x6b @@ -25,7 +24,6 @@ properties: powering the device. minimum: 50000 maximum: 6400000 - default: 3250000 =20 interrupts: maxItems: 1 @@ -57,11 +55,11 @@ properties: minimum: 0 maximum: 6350000 regulator-min-microvolt: - minimum: 4480000 - maximum: 20800000 + minimum: 2800000 + maximum: 22000000 regulator-max-microvolt: - minimum: 4480000 - maximum: 20800000 + minimum: 2800000 + maximum: 22000000 enable-gpios: description: The BQ25703 may require both a register write and a GPIO @@ -74,6 +72,61 @@ properties: - regulator-min-microvolt - regulator-max-microvolt =20 +allOf: + - $ref: /schemas/power/supply/power-supply.yaml# + - if: + properties: + compatible: + const: ti,bq25703a + then: + properties: + input-current-limit-microamp: + minimum: 50000 + maximum: 6400000 + default: 3250000 + regulators: + properties: + vbus: + properties: + regulator-min-microamp: + minimum: 0 + maximum: 6350000 + regulator-max-microamp: + minimum: 0 + maximum: 6350000 + regulator-min-microvolt: + minimum: 4480000 + maximum: 20800000 + regulator-max-microvolt: + minimum: 4480000 + maximum: 20800000 + - if: + properties: + compatible: + const: ti,bq25792 + then: + properties: + input-current-limit-microamp: + minimum: 100000 + maximum: 3300000 + default: 3000000 + regulators: + properties: + vbus: + properties: + regulator-min-microamp: + minimum: 0 + maximum: 3320000 + regulator-max-microamp: + minimum: 0 + maximum: 3320000 + regulator-min-microvolt: + minimum: 2800000 + maximum: 22000000 + regulator-max-microvolt: + minimum: 2800000 + maximum: 22000000 + unevaluatedProperties: false =20 required: --=20 2.52.0 From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CC0A3EDACF for ; Tue, 24 Mar 2026 11:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352311; cv=none; b=BKMqp6VxbTTxtbOVilUDirJW+oA0z+iHn41huhrq+yjUYR8akAy3f6+m9nylXj1AWM3+6CLLPwLBi06BJ8bsOD5OffKKzYA0KczzlkJBl3pUOkcvR9Hija6YyjQ477tJ7/gmCltNiH2BHkO2xQspINVKkareO3gN9YgpevLlGRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352311; c=relaxed/simple; bh=DcG8KW5Fnk3rc/f7uk3dyHKO5i3tnn1nAb2IeSenCzU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aV6Tr7b6f9ymh1YD8rLvCDr96p29TwMOjbOK74ZqpmI7KhqAgENcyUZeve9lBSbbznJNUchYeltlIqZUnRWWuWiM8qRx7jgPFfDl64cRgZWsqJF3IoWuAL8pGTMRhLbA8aDCdMg1oNy2wgRviFeXTokCCputRbskiVVxqb7ZjMA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=vNKDZEjy; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="vNKDZEjy" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48557c8ad47so8145695e9.0 for ; Tue, 24 Mar 2026 04:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352308; x=1774957108; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jCpuZJNVNsInRc1C9w8uAr8XhXxWVpiElBj6DPaFINQ=; b=vNKDZEjycG/LdeTJ9wbuWhQQp/Mqyk1skRDVv9wXyU/Q5qk/ByhovZFDOQZAr+5OVG 8Aox31IQmm6FTnfLs5sla3z5TEW+06nQdLb+N15OkWlIDsNXMvt2W5q7GrkY9PZbiVdh dave+OIvgpNJS89M9GJNK7Pn+OX51REBZ0sVvpIvai1uccf/PeJ3Vo0a5VV05PxjEXZA 30PDkr+4wS0i8Xo2UjHREcCV/lCVRVYAJNGXkeWh+C5gJ20Tkp9Dh7Arqex4iwzN4fu8 kcNJ1sEJKaRaCKwNJZaPnElRpJLY5AO4dzqTRMBgsMkNyVWeb42Uoo/m9hr7Fop+URk+ OJPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352308; x=1774957108; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jCpuZJNVNsInRc1C9w8uAr8XhXxWVpiElBj6DPaFINQ=; b=VMGImQdS4TBnQ4F4pjI6S+hlzdyXwhmRkt/wkBGJ88GRXk96QI+QRJkk3Ecp8Dxy/J O7M3KcWSCErJ3/UzGbwG/Os32nSBf6BTOQK3JnffNAngXFPHaxF2EXNK5LwLodiLTR1h yMIcfHWmWD8F8/2NvGDLrL39XqTzIP57Vw3RbYvPcoUUsDKoZZ3fGpFZhdse3ceTmtOw XfAappQz3LFofLBDCBY5RexlNP7yLmAznyfIEwqs04x3BUvi6k6wh6/Ik3mqS4dv0xaG SpZ+uyBGZUnzlhkOLnhcgAyQO8kQCkL3QS8riupYAX0iRb9kNe1qaBsy/BhyCeKXGV8U b3Eg== X-Forwarded-Encrypted: i=1; AJvYcCXo90YQUdlCzzN6CHsROFyjLWNN56zwdjk/DeqnXSgL++XC/XgFbK9ZjAX9pUNVBzknOkjw6HyPyVRwURU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4eVo6RQeEsfCws5EpS34aIUBywTo/nqB9yBjjTftgD4YgvIfE BmywSIemQl3YnwGDUADx3PoVZRSokozACM6wR+J9hiYX8SPW8gY2yGg9cn+FDFrCoBA= X-Gm-Gg: ATEYQzzEwNxAMr9A4rGygxVRHQuUGgVaYFs6MOXgPsnXvjmdyXZuhCDirFdDIkRaDKb 19QtErfTdNCV8lD8wsTJNJ2haO29CcSqPdNMZBpBnm82rh20J9VJGg0ahSc5qkzf1RZVwDjp/95 TYBrPTT6I9MtBRleqNL1RgM5GEniyKNpXFjnK3En1Om0Z7tCKJdwCcuAU72Az1A0f4zMZa5aWVA lWyOtdFDTKsijonOPWeBYCOc3xFR+AetN+5AQEp+bY4yLnwJRz7dDGa0cXBymOktNUE9wH3VQ9M wmhPZjQzdOMnOgTcEJ0uaUrOKsg0gcOoUimm6M3IttXrg/xRHeJDQV0MPddL78BIa3Sr/Vp605N G2F4eQfLvo9Iq6RqqwTOkT873HlXWTQPMqHMvafLWxbaCEz7OKM/99XI63Kql8zTj1cszDICfls LNcoV2G48lIAE47pxT9CFWBU3QAprgEBDVz3ncxdA/DdcotlkXNChIScDuLJQkg2ZGtRqTOdN81 J36gQ== X-Received: by 2002:a05:600c:3f16:b0:485:3f38:3de3 with SMTP id 5b1f17b1804b1-486fedab1aamr219446515e9.3.1774352307887; Tue, 24 Mar 2026 04:38:27 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:27 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:07 +0400 Subject: [PATCH v5 02/11] regulator: bq257xx: Remove reference to the parent MFD's dev Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-2-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2756; i=alchark@flipper.net; h=from:subject:message-id; bh=DcG8KW5Fnk3rc/f7uk3dyHKO5i3tnn1nAb2IeSenCzU=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl8rViMv/XX2sYXax7y3pAv/Xhd8nDVQ4jRHkl9/f sZSh4q1HRNZGMS4GCzFFFnmfltiO9WIb9YuD4+vMHNYmUCGSIs0MAABCwNfbmJeqZGOkZ6ptqGe oaGOsY4RAxenAEz1tVsM/6yei39g79P+260asTuzM/eh8i7OipfWLFpPXhpdE2ea1s7wV1CiYaH Qj19ysyI9eWfpHTqz4WkQX//jY7+btA55aT6u5AQA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Drop the ->bq field from the platform data of the bq257xx regulator driver, which was only used to get the regmap of the parent MFD device, and use the regmap from the regulator_dev instead, slimming down the code a bit. Acked-by: Mark Brown Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/regulator/bq257xx-regulator.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index dab8f1ab4450..812938e565e3 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -15,7 +15,6 @@ #include =20 struct bq257xx_reg_data { - struct bq257xx_device *bq; struct regulator_dev *bq257xx_reg; struct gpio_desc *otg_en_gpio; struct regulator_desc desc; @@ -23,11 +22,11 @@ struct bq257xx_reg_data { =20 static int bq25703_vbus_get_cur_limit(struct regulator_dev *rdev) { - struct bq257xx_reg_data *pdata =3D rdev_get_drvdata(rdev); + struct regmap *regmap =3D rdev_get_regmap(rdev); int ret; unsigned int reg; =20 - ret =3D regmap_read(pdata->bq->regmap, BQ25703_OTG_CURRENT, ®); + ret =3D regmap_read(regmap, BQ25703_OTG_CURRENT, ®); if (ret) return ret; return FIELD_GET(BQ25703_OTG_CUR_MASK, reg) * BQ25703_OTG_CUR_STEP_UA; @@ -40,7 +39,7 @@ static int bq25703_vbus_get_cur_limit(struct regulator_de= v *rdev) static int bq25703_vbus_set_cur_limit(struct regulator_dev *rdev, int min_uA, int max_uA) { - struct bq257xx_reg_data *pdata =3D rdev_get_drvdata(rdev); + struct regmap *regmap =3D rdev_get_regmap(rdev); unsigned int reg; =20 if ((min_uA > BQ25703_OTG_CUR_MAX_UA) || (max_uA < 0)) @@ -52,7 +51,7 @@ static int bq25703_vbus_set_cur_limit(struct regulator_de= v *rdev, if ((reg * BQ25703_OTG_CUR_STEP_UA) < min_uA) return -EINVAL; =20 - return regmap_write(pdata->bq->regmap, BQ25703_OTG_CURRENT, + return regmap_write(regmap, BQ25703_OTG_CURRENT, FIELD_PREP(BQ25703_OTG_CUR_MASK, reg)); } =20 @@ -137,7 +136,6 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_d= evice *pdev) static int bq257xx_regulator_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct bq257xx_device *bq =3D dev_get_drvdata(pdev->dev.parent); struct bq257xx_reg_data *pdata; struct device_node *np =3D dev->of_node; struct regulator_config cfg =3D {}; @@ -149,7 +147,6 @@ static int bq257xx_regulator_probe(struct platform_devi= ce *pdev) if (!pdata) return -ENOMEM; =20 - pdata->bq =3D bq; pdata->desc =3D bq25703_vbus_desc; =20 platform_set_drvdata(pdev, pdata); --=20 2.52.0 From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C98F3EF0DE for ; Tue, 24 Mar 2026 11:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352313; cv=none; b=LMtsWxQcrsQBgafhGLW6NxOseLkwr+44N4xhOweXa41DwknyT9gshVlk1CwvRoDCSC5rDEqKxfbHd3SFYePIJE4J7aJ0wal8rko246fZajOUazTbiCH9dRsxsVfVfDuB6ugO+nxOOUrNIIlNHmHN7BatNNjDL8HZB0nvjJsCUB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352313; c=relaxed/simple; bh=1uAjKjH8Mriiu2XHqXVfsDGlgQSHnV96d3u/aQzpXDo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fsrpp5w1kOq976SJc0b4TcZ6n1wm5+XMC3wXV2rwa+8R8shkHJsVayKagp+KlkAHzA5ka/aLU17H35MMsdEohSm58fbMAQ8ohr9ZXAdcUBRt5990RIxOm6cO5gmzECN0RSu9mlsKO1NYedqpASXx/pjEdvvCfEoKtQScWq2whxg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=LoxWdPsh; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="LoxWdPsh" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-486fe655187so49157865e9.2 for ; Tue, 24 Mar 2026 04:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352310; x=1774957110; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=veDJydETiE9Gv6g2pRG32dl9Jb7Mpm7Du1gG7k28aTM=; b=LoxWdPsh6BjiTuvi12E25hu0JCTEt6cVS7lNv90ueKFeHmMYU2kjIowpu953fNiu8x ZhKDF9xDPBWxUSZopo1AB0hjHIoliPxHbjaUHq0rVPc9kZoL34CNfptTRvJzgRbw5o2A vZo/Bxc+ozxUMm4Ry+60CNxi8pLqiPJ+5EVJafB8SIZQyuZoht8MUu5/I+EpNj9YEJt0 DsArQsjWNuQfgsA3FFmqwxfj1TenwEUexmgH+FKLkShE4ReUj+CrPGvSqtUdOFz3+YWa ovK0IBBGnD7ytEPLMy0qntNUYyifkX6qWo6QeNqcyeE/8zKT0w+olBVZEP8NC9i2ERNm Oi6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352310; x=1774957110; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=veDJydETiE9Gv6g2pRG32dl9Jb7Mpm7Du1gG7k28aTM=; b=VUHagBP61lC6W8fWiOlsuDJqOuVzgt0jha41fBeiQ5kJ2P1aVCOLPY1HYEuVksZkLO rRjRp6YS1Z3cDed0VAdUTmLSYm2ak3wF8C3psLBReKwfIL0vNGzgxPAjVjbX0+GKjvTl SdQru8KjqLIo6twOx0jrDPXFKGQabaEzTT8Ie6EgGotdo/IAbmv/C5dconDo1UyNEm3a HHlEil1/0z6VY1HLn6oT0L1wcWVYpdlngO/Ohd+Ea+0E0h01m6Rrof4OzdzLFbvZ3sa2 oyDSgp3BlJaX99joHi5Go75N3tmO1fAFRwxmmmbLjsrTbLejQPwmwYpCKtkyX+RGI/Sq MFtw== X-Forwarded-Encrypted: i=1; AJvYcCVjJ3W/LTHduhc5Poq3NQ1S6diXGd7d4G4urc3uKal+AjCCc9F4OAueJZw/LkrpJGR+/8bSfKVnSwFe7WM=@vger.kernel.org X-Gm-Message-State: AOJu0YwuKmDSmRW64+itcorwpAlUZi4x9Uc1RKTHE8PG72FiV0rAx+vq bjmW3uAmNF6UqwFxYJn6+gBFpSFMd9Qj1Guy0G0XMmAhckHzNBguo1NJERlORzaBZ9o= X-Gm-Gg: ATEYQzyGgDe5mSlldbOs1PC902nNKM/ACmrCrVooxrpySJSGJyCfpmgnTYjjtvFgw+3 IMBM3Cws8FzSZ1Gy/f3DYGbKpV4kmtirtukhFY1qh+CcY2Fz9w0jTslRRFxSHypzC1BXyUAG8KO HbtueHApUcYgWpp5EbX/79G35KuJq/cDjbtkziTK8vv1uopq8DaCS+pHDkB4V65BuhY05PEeR5t 1km+HAy+dP8LDrG4BzbHLTr6ipHJL6An5x062nxKAvdBSjMW1QFOzD/zGeePCfNuEoSW7q1EMCh czjPuMnQl8e3MW0MBTz2hSSifEqjOMaT3NkkEIB/wQczktAP2eRpUTsHF2v5b09OMXljcXUqGsu IjSH9MKFwLYd+gsM9LTmUg9f5QQt+Om8YKxiXF1B0ppCuLdrw23bM1VuBT7GOuQWsTH3Fg7emYv CB2aihcGrNyGwvcQJvRKDl7h8hqHp0RZ5xpdERU4SjvTGHVrJUjPIHyKx7iJfiMPwcekRxTJ1rv T9CkQ== X-Received: by 2002:a05:600c:8b31:b0:485:40a4:364 with SMTP id 5b1f17b1804b1-486fee1af50mr221443735e9.26.1774352310539; Tue, 24 Mar 2026 04:38:30 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:30 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:08 +0400 Subject: [PATCH v5 03/11] regulator: bq257xx: Drop the regulator_dev from the driver data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-3-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1643; i=alchark@flipper.net; h=from:subject:message-id; bh=1uAjKjH8Mriiu2XHqXVfsDGlgQSHnV96d3u/aQzpXDo=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl8bE7h14Z3g1uhf17mkmTYxbLs9Rzhw84QMT22+Z qmVvM1pHRNZGMS4GCzFFFnmfltiO9WIb9YuD4+vMHNYmUCGSIs0MAABCwNfbmJeqZGOkZ6ptqGe oaGOsY4RAxenAEz152cM/11dK333mmwI/bU2OpH7ESNv/vu7gTKVv6uvCOq2dCYe/szIMOXO089 NQqcPyvffbd6ao9s1N3jKR7M+ScXOIGnfxo5PDAA= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The field was not used anywhere in the driver, so just drop it. This helps further slim down the platform data structure. Acked-by: Mark Brown Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/regulator/bq257xx-regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index 812938e565e3..674dae6109e9 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -15,7 +15,6 @@ #include =20 struct bq257xx_reg_data { - struct regulator_dev *bq257xx_reg; struct gpio_desc *otg_en_gpio; struct regulator_desc desc; }; @@ -139,6 +138,7 @@ static int bq257xx_regulator_probe(struct platform_devi= ce *pdev) struct bq257xx_reg_data *pdata; struct device_node *np =3D dev->of_node; struct regulator_config cfg =3D {}; + struct regulator_dev *rdev; =20 pdev->dev.of_node =3D pdev->dev.parent->of_node; pdev->dev.of_node_reused =3D true; @@ -159,9 +159,9 @@ static int bq257xx_regulator_probe(struct platform_devi= ce *pdev) if (!cfg.regmap) return -ENODEV; =20 - pdata->bq257xx_reg =3D devm_regulator_register(dev, &pdata->desc, &cfg); - if (IS_ERR(pdata->bq257xx_reg)) { - return dev_err_probe(&pdev->dev, PTR_ERR(pdata->bq257xx_reg), + rdev =3D devm_regulator_register(dev, &pdata->desc, &cfg); + if (IS_ERR(rdev)) { + return dev_err_probe(&pdev->dev, PTR_ERR(rdev), "error registering bq257xx regulator"); } =20 --=20 2.52.0 From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0D553ED5BE for ; Tue, 24 Mar 2026 11:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352316; cv=none; b=aFe4qZqDf5tAcgZJVJx9QmluYNF9gUouZNob8y76ITBKyJMHRbU6ytouJ1krxYwLvVrALNxwjJAdB4hLuIbUDKx8A5abLw1CRu6j6HZ9FrPyZsa75UgGH0z2ImgoKpibl/8HI8bkmYPQQt0zzK+L+FEj2InRm/vGsRrf9XgFECM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352316; c=relaxed/simple; bh=Vj+thyx6im8c/60dw5piAk8vyroKtJcY1a74UdrGYxA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lG8E67DorX/NzazbIpuaR1x3wgkleP95CRz0zSp1L5ft3VKvnXqRLYKLN0LlPqCeEoO+ES8ypcWBAFcGjGWp7qo05zibuC8eQj81SqwWwDGousT+PZ01566Yq6yclwYrw8eyJJiZQ/vbquHpx6ibJ2wCA9H2i0eXnu1TUI5ZjpA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=Udfi6hJa; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="Udfi6hJa" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4852afd42ceso8800785e9.2 for ; Tue, 24 Mar 2026 04:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352313; x=1774957113; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8wsphdPWc7OLP974m9ulR0tmXF0Yx3Br+A797hF6by8=; b=Udfi6hJaz9WmpD5YGp741cUe0QC7ni90n0Dx/zBfjYw0XvsImq6XcBoeQiN8st6xAe B3b3Z7L3cDx/f1wCV5EKw2lPwCLBNWrmcUVJyXWI2/0AWMvBmt6m7Bibe930SrTSGgAG fLLGKeaJqkH59Ys0MEhXK9lBit+FBUI7C3hb7TqcP3gJYsSWBPv49yDkLaUbmOZXhF98 WJUqzivV4WwGbDg5OBLF7W1Jloh8jWLAomZtlsZwq7ppPnFa7zCfnZuCj8KdB3hYszgA tYDyy3NqPIZBO693LY2oGgyvzyM5jW/6FJGNoagUybVRtd1Nlp++GRGKMCIxq9qaZZlV 3Ayg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352313; x=1774957113; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8wsphdPWc7OLP974m9ulR0tmXF0Yx3Br+A797hF6by8=; b=LCwYY8HxXrXZ8Q6qKKMXEEJWdUg+sQp0iLLkEcB5xFNrI7KiigjIM7cCr3cyB4u2V5 u8OYId0Ufsr59emwTSsyMt0hb29TDZwO+YRM8vR/nmU7pk4jQtFbOz7Rv7hxtHF6stCL iK2FjV1v/uhdlXpM96mN+wjX7drdV4Eew5TVcp4Q8/KfTK9CqMv51OQP6gjhAwb5rJtQ uVAsdwAc5nsP0evHoBzsWrRK/sFsfDsvI20K6i7qQokcQj0TYtPGl4pb7QPnG2uLKrvf mQWEehpq6eHOXhysCHSgsoMc5YXHexyL6s6VrcrJJBhb4H3AYG0FUORfPdnyxd1FmnVE BbEg== X-Forwarded-Encrypted: i=1; AJvYcCUd22kPFAfq6DnFRmRHJJAXvctvYwoDf70rwK6liDf/ugznFXpMHYZ+70fQPB/29gXg1kopsxHcw3Fgn6o=@vger.kernel.org X-Gm-Message-State: AOJu0YxL6lP2Y0BqSW85XcMmT2P7a7H2tR3qiCrFRcS2Nar3nh6OrJXE HeQ3Xe0ihMRXkZBNgWS5GWPYFccLy/u5iiLUW0p6okDls1C8pdu0oVl3W8TjudD1xJc= X-Gm-Gg: ATEYQzxzHmEGF1gjJQJeDP+whpgtErka3NqVRYEm6Jh+5G8f+XbvlvMYLuLQTglzob7 eH9OQb6UGtimBkpgTp4adTsOZsNelWa96Ua8vIDgwa/MpHZ0FXCKWdAhl0DOfMuhcNXyj0nZC+U 3w/j+1Q1Ipk0K3fKGYDoC6VJk7KjwdHCnO0EiefKXooVAp+1XXAOBEovvEBYaf/Rn3Fnt4tZ/Vw +a/ZBri5k2xRH7R2qWhAR4p7Dv+SsD32FG5+mE2BP/WxwmJdQNoo6rDNr8NoohXMbszOYaByqib iS7ItuhqzMGFn87iEGJGYDpujRO836kKIzrebPsDdOOccYhkLIndHdPRFYSaj8CUgrWDPNHNe+z o/oKO4GMObnCqMNz9Azw0iKqWQvcUsHgG2dQa6vrutl0X9msoCkMztlsiCo/Lt6+G3DEbvyo4Y4 LiuOjqYs+cN5U/UdSECBnxV1hGoHheUh2aPRASSdu6RHj5OWMAIWssRvGTms47mmAN1GYZIcy5Z l7ZuQ== X-Received: by 2002:a05:600c:8b18:b0:485:40fd:8390 with SMTP id 5b1f17b1804b1-486ff01b49emr197751245e9.26.1774352313338; Tue, 24 Mar 2026 04:38:33 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:33 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:09 +0400 Subject: [PATCH v5 04/11] regulator: bq257xx: Make OTG enable GPIO really optional Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-4-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1183; i=alchark@flipper.net; h=from:subject:message-id; bh=Vj+thyx6im8c/60dw5piAk8vyroKtJcY1a74UdrGYxA=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl/rOHvz9Kigk/G3JCUX75M7ku14YzGzSXV9dUdUd oBr5pbTHRNZGMS4GCzFFFnmfltiO9WIb9YuD4+vMHNYmUCGSIs0MAABCwNfbmJeqZGOkZ6ptqGe oaGOsY4RAxenAEx1ThnDfy+1nLMVMj2XuYsSzn6arXWtSNdjfcQj3eU7FrIv7058osLIcPrRynY 50xVPDXdcjZjb584Q/2IJ/xOWruYNK0Uc8w4/YQUA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The bindings describe the OTG enable GPIO as optional, but the driver gets upset if it's not provided in the device tree. Make the driver accept the absence of the GPIO, and just use register writes to handle OTG mode in that case, skipping the error message for -ENOENT. Acked-by: Mark Brown Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/regulator/bq257xx-regulator.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index 674dae6109e9..0bb58ab4b8d4 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -126,6 +126,12 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_= device *pdev) of_node_put(subchild); =20 if (IS_ERR(pdata->otg_en_gpio)) { + if (PTR_ERR(pdata->otg_en_gpio) =3D=3D -ENOENT) { + /* No GPIO, will only use register writes for OTG */ + pdata->otg_en_gpio =3D NULL; + return; + } + dev_err(&pdev->dev, "Error getting enable gpio: %ld\n", PTR_ERR(pdata->otg_en_gpio)); return; --=20 2.52.0 From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C42B03EFD04 for ; Tue, 24 Mar 2026 11:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352319; cv=none; b=SIT6TOMBWvaxM/kawsuRugwoxnd2QaauPdq4DhQKpUPPCiUt8nqdPgRQHT2jmU+eD0lhTdO7akEPRZssnDGaRzvHow7PT9RDAk6XXopzfaqIfgf971g0gR69erQp9IPEvjyN1Q/Cyy7enn+5sgc0J6o8xkJIJ89aQ29nY/D3Ai8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352319; c=relaxed/simple; bh=0GDlOYezmKEXCru71ex6Z77WQ5tS0GByeoQbXgUi37g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QT/qWNzV8JxziEml0TRDRld2tuJsP8Mw4uyOxIgzdfaIUwdnHGVvQbH+EQgwlI9gZWPYw8FScRuWcYM+9E12SlL/vfKD6/7wz0CGMriXxJmeaJydIiVxiVi+GED35UyVjP9Isx0bEooqX+bLH5Wy2dHPBqCR3eCh0n4cpLIJSqA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=jMczJ74f; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="jMczJ74f" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-486b96760easo10658205e9.2 for ; Tue, 24 Mar 2026 04:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352316; x=1774957116; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j1uQzW3+bjNeF/wEPgSsxYt2kbdgf5x20O5xEAeMiek=; b=jMczJ74f+p4Oa2Xl9eCmCm+k+OyS0x73hIZG1wfmP9dexw91n6Q4UQojcvn8q8x9BS yPndZW+lCvh19+8phFYkA43uYe4xhTnU5VzIXE6ieZEGMnkxQclMsIgita0rofjLE53x OQoCseDmpaRVXomJTqTTNjS4X9Eq3O99YX37lyTC4MjkLb4QEr4MvW/t9jTacIGiSXTL iOhwqZvAGxBkxIxo7hPSArFTvfu+m1MFAkDlo48ehA2M2rDbMU7Kdk6VSBxlbCmlaeuO QSUQPHwZTFU0/UzY6G7gVKeg0M9BKMTY4jcOHkYC9T+iFh2ugqaqAknRh7QIzspmVIcU 3Y0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352316; x=1774957116; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j1uQzW3+bjNeF/wEPgSsxYt2kbdgf5x20O5xEAeMiek=; b=Khz2agoz+ft7TJNA+cegn3qParsiAmVZsbnjInjOUT1LOmJYHkBi2HNtzusVxDJoJJ ZtHnvZneMvc7dQENgBuUO4G9jpEAmggr7jLlMKZgnS+3x7wxVjAku3+Upb2G0PmXCqrA Z3LZSIRGaSR+TFQwTgnrNmORpgfb7X/HGYXc+Skg5Ynt/E24peyevaO4KnGkGANt3w4A tRiRmUnRFbTTltWdwgeztsJS+26SyV9gEk0pT6jrIaTnBiPO9S0DG1kveG2w+RiCYNBb 0pq3I76MsLX/nQMOw4MYCbE+GyvBgCLmIIOhj/nRlcEh6k4IfyVv2O7r98zPQOwT+vSF ZcXQ== X-Forwarded-Encrypted: i=1; AJvYcCXu8GKZPfDAVqUsYdjHmyKNkIQBYHzjePEHEzXsh6m5jF91tPtjXebG3/45pXd7E3ySjYOqtyOKM7pmtt4=@vger.kernel.org X-Gm-Message-State: AOJu0YzAIxawFVfIaFpIbyP3dTZUUP0jXcCjBcruFB2B/RCgsfu2UOkE /oZxFVUX1qhIcQoHKlgSOEZmuxYj+QFLNC7y72e4WerCSE2XCU6gsNv2WXPPpFy4DDW5OTAoW8i H59ud0VU= X-Gm-Gg: ATEYQzzShV91d3NxZwFY4Rjl3CRaVvW5DM+eRErLh/nFLPPPI0my+rwDcS1X8SVgji7 EDGCF2v5BuMew1TN3+6ewhp3eYUjhdD03L8TuTEYP5nOmEDYGEJ/vSuRSwqiAtWlM8fa8QCCP/+ QxcsJfFeWJAQ3Ew9P3vWvQkJJe/3jd1K5pB8zqr+fwUwsv6GANHtwc2jtnftNkq5htTXoTyfcVr M98gBEHHnYeBD1knjj5Dx4yJIfymodILAsN0s9BtBBaMLdC99mAa2XbYW5pBUSSbA1xrJdN4rM7 udkhx9JVSwoZS9ztDfDqqr665nd/XpI6j0ZmxXBzGCZoc4PMO299ltYOBt3bskem6SkD5AWDq4W wWjEqqNXoAdyLEsXA9DQ5MpkEP4nAehs2zbut2VsSsZLO3EqBnAx9IyzpN6oln2xJ0RnDZIue+A DwtYXMYQBZwf3MuBprnnBuNz+gkt0mqoKkxTjNEJF6Dcf4MsPRKK1JfcYvHnMnm8+B3U9kDnTz5 7Il3gBVU+z9Fp0z X-Received: by 2002:a05:600c:8707:b0:487:338:b4df with SMTP id 5b1f17b1804b1-4870338b5d9mr166015045e9.15.1774352316223; Tue, 24 Mar 2026 04:38:36 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:35 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:10 +0400 Subject: [PATCH v5 05/11] power: supply: bq257xx: Fix VSYSMIN clamping logic Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-5-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2028; i=alchark@flipper.net; h=from:subject:message-id; bh=0GDlOYezmKEXCru71ex6Z77WQ5tS0GByeoQbXgUi37g=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl/7QnLhoeT0m79ifgX1brk/cd7ONeq7DRZmddc2t Px9d4nvYMdEFgYxLgZLMUWWud+W2E414pu1y8PjK8wcViaQIdIiDQxAwMLAl5uYV2qkY6Rnqm2o Z2ioY6xjxMDFKQBTfbWA4Q/PDdWI70vfPcuWmeP/5HqS3YPrLy5+XT3BXWdv5LpwxY2rGRmu+7m tLdlxpXbxwp4ZaX9eHGh8vlLFeaK2zxvGDL55309yAQA= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The minimal system voltage (VSYSMIN) is meant to protect the battery from dangerous over-discharge. When the device tree provides a value for the minimum design voltage of the battery, the user should not be allowed to set a lower VSYSMIN, as that would defeat the purpose of this protection. Flip the clamping logic when setting VSYSMIN to ensure that battery design voltage is respected. Cc: stable@vger.kernel.org Fixes: 1cc017b7f9c7 ("power: supply: bq257xx: Add support for BQ257XX charg= er") Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 02c7d8b61e82..7ca4ae610902 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -128,9 +128,8 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pda= ta, int *intval) * @vsys: voltage value to set in uV. * * This function takes a requested minimum system voltage value, clamps - * it between the minimum supported value by the charger and a user - * defined minimum system value, and then writes the value to the - * appropriate register. + * it between the user defined minimum system value and the maximum suppor= ted + * value by the charger, and then writes the value to the appropriate regi= ster. * * Return: Returns 0 on success or error if an error occurs. */ @@ -139,7 +138,7 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pda= ta, int vsys) unsigned int reg; int vsys_min =3D pdata->vsys_min; =20 - vsys =3D clamp(vsys, BQ25703_MINVSYS_MIN_UV, vsys_min); + vsys =3D clamp(vsys, vsys_min, BQ25703_MINVSYS_MAX_UV); reg =3D ((vsys - BQ25703_MINVSYS_MIN_UV) / BQ25703_MINVSYS_STEP_UV); reg =3D FIELD_PREP(BQ25703_MINVSYS_MASK, reg); =20 --=20 2.52.0 From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06ABB3F075D for ; Tue, 24 Mar 2026 11:38:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352322; cv=none; b=Bs/MjQ4NcIMkwcVzDaC+VqEOuqqJ3C2fxJgMO/mZm+7KI4h5Z0vWO52RXR3Cta08IWlFH21svs+USly6DscglqYGMUmCu2hDn/7COTWtfOyxsY0iqwBAjcD1Ts/07ne7krWAPYbKeIVmwZZzlNDM9zdvGmIhOBQeWw01GFxikEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352322; c=relaxed/simple; bh=HoUkMd3aj0s9m5BRWarIKv4NrOIfktIuX7B1xZTtvpY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lSqiYiuuh4ynKwDklbVffUxQq+IaG9ji3K3MnlrIYhdPN/L7TI9mLxcXrNvgXXxXcktj+L18BzJc3VyNG5fLp9fdShrBW42xWM91doDe8KRRYs4KOiGt/DclHCiKTyX/J9Fr+SkPtjHJ6hgWZsBedFXUB/cJrw4bpJErteNVvuA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=pjZgSKYz; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="pjZgSKYz" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486fb14227cso11942895e9.3 for ; Tue, 24 Mar 2026 04:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352319; x=1774957119; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Jv4k2NFngBv6AeWEv4O9srLSbI6EPVNmV51Qs0A5klE=; b=pjZgSKYzVnh+C4v0m/ChASHalFS64W+sGcD8ZcT5YHHdMOhYrWBYiytW9ZoNCTVYGq 0kVd4cpW1kP7cYeoqCtb+4UBrV9sJP3u6Tybab8dowIh/AsFAJxWNg62zC7JWgw/b5sv xBef/PdBhbYXb8UsCc55Qq2Qfet/E3BBxybh0NRGnpNZsSxntihHjYZt3UsyaAR2CNW9 5+rL5oYnZkdZNi20cnIOCNlxbQQjRdSMxHCFoeZ+d/sX4VTgczUpjo0/m7QNskqX3J2r MsqzPvCS+i6HMu/XPbrzHjenQ9UVpw/FbIi780aLeVKY6OL+msLcVMYEzPzadPVyq+jk YdaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352319; x=1774957119; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Jv4k2NFngBv6AeWEv4O9srLSbI6EPVNmV51Qs0A5klE=; b=h1cR723qmtbXr6aYOwYO4/T0/XIfGhY/3pGMvq1bQj+AuDIj71VtI1/5q/BBkFgjRv rTy96Lc1G52VdvodLBx2lxzuOcNQAtWVCjxiGfslDmAFPGLtDgdEqGqAaEXmyz2KDYg6 7oQQqBwoMTxkH4WLeOnrKRBgFWQ3iEJ+67TznmgWdVkjSPQS7IVF4bRAv+e8tjFQiMpW P0v2Jct2TawIND/k0A9v7MOydcXOTYpGd1NBE2AflzCwqxptY/JxL7BaLgQhPlin/J8k xj5O1THou00uSIkH7wCcE/vl4B6LSadQi2vL0m/hRUST7wuXMY2Q6McO8JP/bFa2JpcX JhMg== X-Forwarded-Encrypted: i=1; AJvYcCUgh8ww0PcTJcp0fImPs0G7PYcoBtCelN1U/YoPfbjzztkGAtdbOzqIv5wfKMAR3MDf69OG/fvDVn/4P0I=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9DpIAJAXAARAtSaXa+tLVyv9wuc34mrz3KJXfMu8t4+B0F5XV /eUxYwxWzzQnRA6sY1K3YsgLs/W7hRuGAeXUF/5inE/Q4Lt913Qk02WFBAJ1plnoQjUKSiZ8GDk G7B77gAA= X-Gm-Gg: ATEYQzwHma+dUk2NwKIsyWCFxIKEO+hgdYa/XeozM+AyFui+CGV/wDXEGzzxyOy5bhd TbiNycmmA/20AcBHNEDd6hQE6u7m+2ixuaa13IMrVFr3F5OrV8sE385/5PEv6yt4qKOKKWEnKF3 HIrAMhpsYFaEe3yrNS5WP2nJjZXJsH0iupw5bAd08P1/UdhCpJk1wJp/htyghhMTmauceWgyxas 1nU15ABCQ4XN3mLMgbd3043ETQC+wQIZ3DqX2MuYSYAv1Wo3ddE2wItVhmjI6Mua3+e6+VFFIle 6ID/pJLEWPCTHGf1FlEIxBP8SeS5phyRvW8bYeuWURWpSRWCKj0hjYMnhynVSWIDIwIAhPUUOv9 XIdzDTtdNY8HGW3ydMcjh0f4Ee+B/JEtQpB0yQazBqX2lH5ro1QkXOYcxeQ8i5tZ6gCahis7YqU SwSs1Qhn2zPAeQymE81FqaGJLI8P/gpSab1DXmK/y/Tif7l/NLfw8KqybV1bZsdXQ0LAuC8uM1k AH1nQ== X-Received: by 2002:a05:600c:3483:b0:485:7f45:f71f with SMTP id 5b1f17b1804b1-486ff0293fdmr223975835e9.32.1774352319384; Tue, 24 Mar 2026 04:38:39 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:39 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:11 +0400 Subject: [PATCH v5 06/11] power: supply: bq257xx: Make the default current limit a per-chip attribute Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-6-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2056; i=alchark@flipper.net; h=from:subject:message-id; bh=HoUkMd3aj0s9m5BRWarIKv4NrOIfktIuX7B1xZTtvpY=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl8btGJtvBWLs+5ftfIvBW7/dWOn33hixXj2zqLfD ReWPrep7ZjIwiDGxWAppsgy99sS26lGfLN2eXh8hZnDygQyRFqkgQEIWBj4chPzSo10jPRMtQ31 DA11jHWMGLg4BWCqLyQxMvzwjds5K2fqu3t/N909rnzDKDHIyNWnxLJnetDE5TN2L7jC8N/pyJX Z2xeKmgr/vJ3AHJcjkLOLYfuM2EOfLJmO1hr3zmAEAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add a field for the default current limit to the bq257xx_info structure and use it instead of the hardcoded value in the probe function. This prepares the driver for allowing different electrical constraints for different chip variants. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 7ca4ae610902..39718223c3f9 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -18,6 +18,7 @@ struct bq257xx_chg; =20 /** * struct bq257xx_chip_info - chip specific routines + * @default_iindpm_uA: default input current limit in microamps * @bq257xx_hw_init: init function for hw * @bq257xx_hw_shutdown: shutdown function for hw * @bq257xx_get_state: get and update state of hardware @@ -26,6 +27,7 @@ struct bq257xx_chg; * @bq257xx_set_iindpm: set maximum input current (in uA) */ struct bq257xx_chip_info { + int default_iindpm_uA; int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); @@ -627,6 +629,7 @@ static const struct power_supply_desc bq257xx_power_sup= ply_desc =3D { }; =20 static const struct bq257xx_chip_info bq25703_chip_info =3D { + .default_iindpm_uA =3D BQ25703_IINDPM_DEFAULT_UA, .bq257xx_hw_init =3D &bq25703_hw_init, .bq257xx_hw_shutdown =3D &bq25703_hw_shutdown, .bq257xx_get_state =3D &bq25703_get_state, @@ -675,7 +678,7 @@ static int bq257xx_parse_dt(struct bq257xx_chg *pdata, "input-current-limit-microamp", &pdata->iindpm_max); if (ret) - pdata->iindpm_max =3D BQ25703_IINDPM_DEFAULT_UA; + pdata->iindpm_max =3D pdata->chip->default_iindpm_uA; =20 return 0; } --=20 2.52.0 From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4EA03F0A8A for ; Tue, 24 Mar 2026 11:38:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352326; cv=none; b=Q9tEeWSE3gg3WPlwTdlsrrzM+U+anqb2+cAj80UoStKFpCPkZTzdEcWjOvCu/LMyYKxF8L5Lqqy47VAybRoCqzvJ3TnQ8Ax9nqoP/Kh/yn/hrfbBaKnRvqE/tVUAOw/NJrmbmldn6xsZfva3q8UBmdzkStK96YkKVdkE7y3mXT0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352326; c=relaxed/simple; bh=K/K91eQQ75phcINLj4DBBQbD0ofWablCORf9BgG8obM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oIqFxV04fLuBw/Vzn2O/kCqYtTbE4A5gQPDrjsKvToKR6wSKRsg+dZ+t95BlfHfv5Cq6l17yzEnpFejR2m16U/qn8IQQ/dKkjfduChKzisJU7/AU0v+LrEhK+Lk4HQxGiBzJTv+Poe/2wMi5lvYf50sxRHer73jIDGK3mBauzZA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=s6qpf/bl; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="s6qpf/bl" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-486507134e4so14303045e9.0 for ; Tue, 24 Mar 2026 04:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352322; x=1774957122; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8b97w0FIxP+iQSlY9+U8NDMrKZX5YXrCInQTxcuoNL8=; b=s6qpf/bli7kxnqYpBCJHYvWsRf0FCHKjGYc5tyw8/2+/ArvH5ctKWE0nspfQ+UWWFa ZplGI8NnZmlExIe5l6vkZjCYfDMQLnui4YZgNrREZDXetdYQq1lV75Hs9irLXxWHOpjI jK3gL0qAT+VEugK340xuck76HDlNjXOvH5sW4nZ7c1QWXE2G0dhgTAyIFkJk2z/Psd2S uffl2nClbMY0ikTe1gf10SP6sAurjZU3m3PSgPTsGkzktLdiirf8qmSws+J5hQ2GDMYY gjJJ6DcvQVyjtQnX9D+LSBhiww5u9tnI7RzBt/qPFzzEalUtXZBRCbhJ6x1NwchHqbZf hrFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352322; x=1774957122; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8b97w0FIxP+iQSlY9+U8NDMrKZX5YXrCInQTxcuoNL8=; b=MWv+s6uzwEpEE0kQezYxIjBH8AXvXvKSD1y/phJHBEGmIm9g+3JW/gNPdbKT4WmDhb AhsZUwILjFfMfUDx7dfbJ9kcY799CHzkFzy7mHvNq3/MQpEJUzg0t6uFWJhH9nGLwQH/ Q/P7Vjak2hLxBudzG3TLpjPRPxbg0oWN+couZJnYJWQNLd04D3tc0qxDBwssYbv9HOAw 2jEh5nQEYDSxBp1mZJ3YrYciGqqnaGiwxJUd9P8utWqE7swPWAfI5IV90vP2ByUlSup/ eaFCfnDXxmUdl2HGGctUyaUEXO36tm5R+GR63U/H8SZktipwqKigyLd7Y0wMZpque9hW Biyw== X-Forwarded-Encrypted: i=1; AJvYcCWKiSIw6QOSGRbPVTvRinCVg0FleC9RKOrpg47AxmxARebBiGzmnli12kpIeIiK43EaDwhkYwwexnopGGY=@vger.kernel.org X-Gm-Message-State: AOJu0YwLZOoXZSqdDd/wpSPXa1WVzRdhLSS8eu7f6+l/6He2kJq7rM6b H8gbpjmr7zlnjF2S2Gz8Dy3bq4sUA0ITCcWMNsc3IpNcb5AudVfjaw2E6VrZtRXjMlQ= X-Gm-Gg: ATEYQzxNfyQ9aL4+YBKdmyAWAR1fcH1z8H8CKS6dJmlEFCXrcBHD7E5DNsUif3oiHe4 xSXqChUb2JcNZJA16P5b/K5ZlFFjsI00AtgGKbqgBCo5SSY19I6T6lUlUBJHjHA4Ad5lJpTsmJA hd0aSlrQKDm+EqQRE3dumU0axXAm7U2w+nXdpVCkfhifgIKg5X947Cqwx6ird0dzqzI0zhsAiXx 69a3EdFhNb59n+o2x6dF3oVtM7k7wjSirTWZu34FF1VKGg5bMJpDANhBZGrjEFIr2sKUKg22i2P rzLItX4SKIJgouoc5t+d8pp40KdPQKWZW1r2+dHSD5/8OGMzi3gupONvPEadXTyEpFecfxpVwQv sNQARhWz8weJ5JNbgd8JTRTYj/ThttJstyjOaGmz+ryCnOManVV7dUxgcN4vhuAaOWdCM1cHm/N LrOtBgDITjymAGNNee3L59HfdXg8BhKN+LFTlYwqZHuFxogCWZjnB8rjhmxm9R4DnaR+2dBwtzg FVj9A== X-Received: by 2002:a05:600c:3e8d:b0:485:3a03:ceca with SMTP id 5b1f17b1804b1-486fee26501mr204972165e9.23.1774352322085; Tue, 24 Mar 2026 04:38:42 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:41 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:12 +0400 Subject: [PATCH v5 07/11] power: supply: bq257xx: Consistently use indirect get/set helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-7-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4242; i=alchark@flipper.net; h=from:subject:message-id; bh=K/K91eQQ75phcINLj4DBBQbD0ofWablCORf9BgG8obM=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl97wX577jHP7rKNP51nyfjunKR07ofdXDaheA7Xu FnCU/mudkxkYRDjYrAUU2SZ+22J7VQjvlm7PDy+wsxhZQIZIi3SwAAELAx8uYl5pUY6Rnqm2oZ6 hoY6xjpGDFycAjDV3KsY/srqfJ05k7WmRvDWow98zzUORx5f9s/rHSfnnHTm1dwsETcZGRYJue5 8vy38kot39/Q3gt82x3K/vKq0x8RHk1dF+NaU/7wA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Move the remaining get/set helper functions to indirect calls via the per-chip bq257xx_chip_info struct. This improves the consistency of the code and prepares the driver to support multiple chip variants with different register layouts and bit definitions. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 39718223c3f9..0765673728e4 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -22,18 +22,30 @@ struct bq257xx_chg; * @bq257xx_hw_init: init function for hw * @bq257xx_hw_shutdown: shutdown function for hw * @bq257xx_get_state: get and update state of hardware + * @bq257xx_get_ichg: get maximum charge current (in uA) * @bq257xx_set_ichg: set maximum charge current (in uA) + * @bq257xx_get_vbatreg: get maximum charge voltage (in uV) * @bq257xx_set_vbatreg: set maximum charge voltage (in uV) + * @bq257xx_get_iindpm: get maximum input current (in uA) * @bq257xx_set_iindpm: set maximum input current (in uA) + * @bq257xx_get_cur: get battery current from ADC (in uA) + * @bq257xx_get_vbat: get battery voltage from ADC (in uV) + * @bq257xx_get_min_vsys: get minimum system voltage (in uV) */ struct bq257xx_chip_info { int default_iindpm_uA; int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); + int (*bq257xx_get_ichg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_ichg)(struct bq257xx_chg *pdata, int ichg); + int (*bq257xx_get_vbatreg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_vbatreg)(struct bq257xx_chg *pdata, int vbatreg); + int (*bq257xx_get_iindpm)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_iindpm)(struct bq257xx_chg *pdata, int iindpm); + int (*bq257xx_get_cur)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_vbat)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_min_vsys)(struct bq257xx_chg *pdata, int *intval); }; =20 /** @@ -490,22 +502,22 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, break; =20 case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: - return bq25703_get_iindpm(pdata, &val->intval); + return pdata->chip->bq257xx_get_iindpm(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX: - return bq25703_get_chrg_volt(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbatreg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CURRENT_NOW: - return bq25703_get_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_cur(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_NOW: - return bq25703_get_vbat(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbat(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX: - return bq25703_get_ichg_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_ichg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_MIN: - return bq25703_get_min_vsys(pdata, &val->intval); + return pdata->chip->bq257xx_get_min_vsys(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_USB_TYPE: val->intval =3D pdata->usb_type; @@ -633,9 +645,15 @@ static const struct bq257xx_chip_info bq25703_chip_inf= o =3D { .bq257xx_hw_init =3D &bq25703_hw_init, .bq257xx_hw_shutdown =3D &bq25703_hw_shutdown, .bq257xx_get_state =3D &bq25703_get_state, + .bq257xx_get_ichg =3D &bq25703_get_ichg_cur, .bq257xx_set_ichg =3D &bq25703_set_ichg_cur, + .bq257xx_get_vbatreg =3D &bq25703_get_chrg_volt, .bq257xx_set_vbatreg =3D &bq25703_set_chrg_volt, + .bq257xx_get_iindpm =3D &bq25703_get_iindpm, .bq257xx_set_iindpm =3D &bq25703_set_iindpm, + .bq257xx_get_cur =3D &bq25703_get_cur, + .bq257xx_get_vbat =3D &bq25703_get_vbat, + .bq257xx_get_min_vsys =3D &bq25703_get_min_vsys, }; =20 /** --=20 2.52.0 From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A55983EDACD for ; Tue, 24 Mar 2026 11:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352328; cv=none; b=D2a5/4PLyGrJ8+XDle2cIp3soDBg7MtScXlCKeSK3g05Rw/0cyD7mPlflQelOn63SqkEGVDsHEj/8mzXbu5KdOmN10l5yMkDBbQDz5GnBs6JIIwvg91LfRg2o0DqPnroX+tZOOTZ0Sm1y/RbvWQ9jhtPvnodb/RbHJB9Feu0YMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352328; c=relaxed/simple; bh=xDe5OwkC59HG0l6E9h1OwEErzx9ysv39/KByzvSAFgU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A30tEiejkFtu03VlCP2hHBftekQZwe2vqIsJcSww3uXbUiAxH28qhRsPEdSZOjfh7pv2ABldru6v/+axcf86dCQQBPswfCgjFf6+tZ0/LLGXCl5Tm3P6yfqr+SYgD2dPdojgwgZjrgz+REKDel6NuxFSARSM6U6nPUoGm34tYy0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=vYz0qjw1; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="vYz0qjw1" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so36090005e9.2 for ; Tue, 24 Mar 2026 04:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352325; x=1774957125; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3AEOePYJtU4kn4mkWQfK7NUJrP7JZP+VFvVN1gskxyo=; b=vYz0qjw1Qb3eigahsHUowHZCtHmucwme8mlhLI3BadP14N903BB+xohcWNIuE/mqtN twIfNLwZ/9YHSKHKOeS2A5xQd3fMsLJRf5glwJTUb3AQyYqk9aWf/1XSQq/lIRRWw8Bv n3g9ar3GdBEohYsaZKv4v+ig6b8XpYqbAW21WktREp6OqQPDqk3bUmTPy5wn416Jp69v 297cZ5nm96GC+eOVP6T51XdiSyyQtD5STwSqbWB/x07P5nMQJOxO3xW2Qj6ew74Oehuc DuQ6Pt55pii3b+Px9r8A59B3gMsPhe+a1KHZAT0G3IV1PX12N7vr/v1tMs1jp3jK0y15 gQAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352325; x=1774957125; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3AEOePYJtU4kn4mkWQfK7NUJrP7JZP+VFvVN1gskxyo=; b=g2bAW21MrbuQXLmno7zbEkXKuI+ZBZE5slb0cgDLj87Mo6kDEGU89W//SsVYbV8l96 KyqEAWj2GyVwON0l+SRjZUVQ1idO/uBuvmwlItDU8NL0Xv5eaduuKtB+q2pc20c4gy5h Ripms/y/3o87yFNk8Jc7nBVwTo4nAyyePTgAnqPu6ASqoRS8go2DSyz5x2cgDyaPLL1b L8C3dW5i0MksiJoTor6hF1Jrjz/wyOEpC/On3oF850Uf93WBhlp52Se64dgrp52F8ahe CLA8emz8YAnfkoV094ewcsCdQ3NdY4dZMRJQODtLyyWQGhKlUIgCeTjuCEv0wSnTXOfY h1aw== X-Forwarded-Encrypted: i=1; AJvYcCV9P0hfdIssiEhNI7WVRMtMLQOJPrusRRbHt9i9LiOfCG9G9qSu2D2NoxLZG4NPPU/5oE7jiuCkDonkrBM=@vger.kernel.org X-Gm-Message-State: AOJu0YwDTRVJHKRXtyZUtZ5RD1eTijuxUm/5XOE7fR6F+0M6+RTF6g6F wtgPKpnghuhbH1H2MRgdj96PTkuPAwSlHDCirtgFq0pZu0b+2pt+xZTs0t8uFRrSkvM= X-Gm-Gg: ATEYQzwKguDzy554tAC8IJHRCa5Xb/3c+/pAcAw/xUIzc09LUqHj5IRMKsmqsIqyxD3 lNmNDnd2XZJrK6gVgjNs67plDB+c/dFVTmwc6L6y6IqwL9LEuOa2eTNcsV9hxZs/2Vs9I/5Mi3D bq2FJnpHyne5hCGjOAmckSp7bTfT0Zri6cqMbqGgH25L23ZeUIgMyG+K5d2cw2L6LhTO8zmGPH8 Sc+bQxt4eESJbLaSrGsIcgrzJR15yedNk+7RfVCKQjtxTQPW6p0S4/c6i0RLZdKnGF72HMI66Vz 3uJQsENL3AYSWjCO0Hnv9G0bf7iMI3uAkTxHQwKiM4a0UDg4hHT4sV8BHOls2IbK+8MhwZtZM4H /T0Z79dgsmBVbuTriveWGjJ09HTJHv9Mp8RCBCN8x9+F1aTLaHh2ZwrwNwz9DQkngD4OecuzjCM /ccp9EzC56op6HDsOBY4FMiSe/Ump4Ne5HDIZdSW6C6/Ed/Moj21aYLqLi7hsfwJyAXeo/MTPtg x1Iew== X-Received: by 2002:a05:600c:3b07:b0:485:419c:4eab with SMTP id 5b1f17b1804b1-486fedab40emr213637765e9.6.1774352325006; Tue, 24 Mar 2026 04:38:45 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:44 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:13 +0400 Subject: [PATCH v5 08/11] power: supply: bq257xx: Add fields for 'charging' and 'overvoltage' states Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-8-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3105; i=alchark@flipper.net; h=from:subject:message-id; bh=xDe5OwkC59HG0l6E9h1OwEErzx9ysv39/KByzvSAFgU=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl/78v5FrW3Z0yIrZLIlf7oFrWm6vHcJ2/xOQ6OIh ZOyeFO7OiayMIhxMViKKbLM/bbEdqoR36xdHh5fYeawMoEMkRZpYAACFga+3MS8UiMdIz1TbUM9 Q0MdYx0jBi5OAZhqyQRGho2zmHwjJEP59j2dujnAxM25s9SquE35MsO0nyuqndhOiTL8r2q/Fi1 iv7Y9UPXVO9Y9ZtuO1Hzo3jExf/KhurJbkXxveQE= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The driver currently reports the 'charging' and 'overvoltage' states based on a logical expression in the get_charger_property() wrapper function. This doesn't scale well to other chip variants, which may have a different number and type of hardware reported conditions which fall into these broad power supply states. Move the logic for determining 'charging' and 'overvoltage' states into chip-specific accessors, which can be overridden by each variant as needed. This helps keep the get_charger_property() wrapper function chip-agnostic while allowing for new chip variants to be added bringing their own logic. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 0765673728e4..9c082865e745 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -54,8 +54,10 @@ struct bq257xx_chip_info { * @bq: parent MFD device * @charger: power supply device * @online: charger input is present + * @charging: charger is actively charging the battery * @fast_charge: charger is in fast charge mode * @pre_charge: charger is in pre-charge mode + * @overvoltage: overvoltage fault detected * @ov_fault: charger reports over voltage fault * @batoc_fault: charger reports battery over current fault * @oc_fault: charger reports over current fault @@ -71,8 +73,10 @@ struct bq257xx_chg { struct bq257xx_device *bq; struct power_supply *charger; bool online; + bool charging; bool fast_charge; bool pre_charge; + bool overvoltage; bool ov_fault; bool batoc_fault; bool oc_fault; @@ -106,8 +110,10 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) pdata->online =3D reg & BQ25703_STS_AC_STAT; pdata->fast_charge =3D reg & BQ25703_STS_IN_FCHRG; pdata->pre_charge =3D reg & BQ25703_STS_IN_PCHRG; + pdata->charging =3D pdata->fast_charge || pdata->pre_charge; pdata->ov_fault =3D reg & BQ25703_STS_FAULT_ACOV; pdata->batoc_fault =3D reg & BQ25703_STS_FAULT_BATOC; + pdata->overvoltage =3D pdata->ov_fault || pdata->batoc_fault; pdata->oc_fault =3D reg & BQ25703_STS_FAULT_ACOC; =20 return 0; @@ -478,14 +484,14 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, case POWER_SUPPLY_PROP_STATUS: if (!pdata->online) val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; - else if (pdata->fast_charge || pdata->pre_charge) + else if (pdata->charging) val->intval =3D POWER_SUPPLY_STATUS_CHARGING; else val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; break; =20 case POWER_SUPPLY_PROP_HEALTH: - if (pdata->ov_fault || pdata->batoc_fault) + if (pdata->overvoltage) val->intval =3D POWER_SUPPLY_HEALTH_OVERVOLTAGE; else if (pdata->oc_fault) val->intval =3D POWER_SUPPLY_HEALTH_OVERCURRENT; --=20 2.52.0 From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7214C3E7149 for ; Tue, 24 Mar 2026 11:38:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352331; cv=none; b=heuN4Pk/c9lKPK7XGV/m+B7tOek3VYnMC/Ea220ie2i+aaFcKU3V2cebsOCA86e2zpbzPjeHnxczorTdmhPAm7l3VMdOFQDD/lJ1POkp4vdHAO09wswHgcfb1CoT4FDGbTosEDNazeBZlHi8zgufvqyw/yNcbjRvS55DcyKLxPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352331; c=relaxed/simple; bh=C6/PRjiNea0BB85b9/KEzvMseEcJT2a6cx1X8uTzZJE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rn9lRo5fg2pzMHfq19YdyvebwbtwLXBBvC8xBANCEWo83N1ePBoZ0+j5vnI+nX5a8kdEVdDk3YU8kSNvQtiAFbIuqcL7c60ihyqEU9amsLsNy8UnE3RvJcK7Bcp1FHq4VdmPWpFebStmkkM4j4O6UvNIgQOTyG88Pj1DLv8ST88= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=cjkpTIvT; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="cjkpTIvT" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48704db565eso29811985e9.1 for ; Tue, 24 Mar 2026 04:38:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352328; x=1774957128; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cL68ZlGfWsk8bC/BMkTEjWufsytaDZaH5faiZPZv5OM=; b=cjkpTIvTQ9eQ/7GtPcDmlt2+o8iDZn6TxyjMvUeJtjFxQBBJsaBRhLo5pfXN6MOGmB LfXOP/tL50msirPdZ59uj6quKqyaZBZlA9IOOjfVpMJwPAcFBKJ6US5J7CXD9NwdE0Kr +T+0mkHU57VNg6TNp5UK+K2mnWZIkkBAr2AeL0mOBrFNb9komVEQOn6C5wEAmVxePiOF 63dDaewUl9McRbb4cny9mAy4g0K3mnM1pMYfjIJU3PcuOUJCBu4Q/mWDYiVcec5GQwuu 6Nz4ziabhEsrOjDZe6k8C5DYKWc2n57TCnTG6kDtbtc4ILPE/8OYgNiWtYDCVrnpH0uV A2/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352328; x=1774957128; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cL68ZlGfWsk8bC/BMkTEjWufsytaDZaH5faiZPZv5OM=; b=P2OjOTTIKzdJzquyQ5UEjBFY/avNbmFtnf4aYO4zOarvJ0agBBLMgLn/T0OOTZVUDI 0euTp4kCdtqmI8GuE0iyt+yBxQ3meGYir9xlWkN4Xjz4Y7RPYI/+gKL8wXBDSu75JLEV pbbBKFb3019MFA8XaIkXbZctpaUvCSV6uxMm2gqb1+IToqTbdc2fZ8cA5y6Os9XLQCng ZOurbGPLNVwIQGa54sKgwTcJ0uEzxf9rHyaXcU8liUFW4QpMCjlK6L6Rr0kE9i43SVmV /y3cW1qrlOZHc6AFc5X/b349NoLBnx/YmAoZ/PW/09Mb3Cg8Qiqgg7LTvyHg3PeSuH0l gecw== X-Forwarded-Encrypted: i=1; AJvYcCWaHggCf9mPCSm85ZMVHmOtMItgmafDfU/0csNEvOLBIaTD1agrOhKi2kR5OYVtVO9XCMcjaumxiUrhwXU=@vger.kernel.org X-Gm-Message-State: AOJu0YwqaNu4nt1qngTedMaGqtv3kX6AhKjzE44DtL5rLTxU2emcjF2P cKG8m7YawDmuwETjhLjxe45fHwC2kvMhjI4CbNwRIl8W1CRlQC68Gh96nZ/2/wEdEns= X-Gm-Gg: ATEYQzxkBCFWHBPpza2YhiNXhvTGftOilC62bjDIRw/KD4eUTabMbOrq19xSwH1QySr KjO40jkpPiDswJapJbCb20p8vBpKwPPEpw711sXrsfP6/GJ8EqEZvLPA57IqeWvC5jHoS7x1AiK IZYJJvRTN5Sud3+OK1G6vlZooc7UBdb3gDokJvZ5VdefOnMPJm6RLd5bQm8Zr1Bo+ZX1wYl0VAS uaLqifMMMODHY7xrrzYOs3R0mgBORjpS08SjeL1qH20Iui+scNU0u522lSRfcEM95fBnrhkZRE2 TI9vMVBuXbsK5pC5wNfS4ZEVZOXfFxxtCI70HohljhbMjSUfSVcjJfxqTT6U3bv2CVORvtNAAAz HRIm0UQk2NT9SISd6E/AWpPGvdZXM0bLWh95Y8iXqOm76grenDmUqnsJnhs1NlY45KSrx5g1nxn 3lFf8iXRseGvXjwUAEarmShLWDiultRoTbEuyLlls4dF3JNIzQwtWoOhdDh+1zN19vncuhbKYbN 0lhqdalT2CjQHzC X-Received: by 2002:a05:600c:4ecd:b0:485:3f58:d84 with SMTP id 5b1f17b1804b1-486fee30199mr204763505e9.32.1774352327742; Tue, 24 Mar 2026 04:38:47 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:47 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:14 +0400 Subject: [PATCH v5 09/11] mfd: bq257xx: Add BQ25792 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-9-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=19368; i=alchark@flipper.net; h=from:subject:message-id; bh=C6/PRjiNea0BB85b9/KEzvMseEcJT2a6cx1X8uTzZJE=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl8rePls/pSNu9v52U/l5z3Qrt9178Avdv2Nryc1N 1VMP3KnqmMiC4MYF4OlmCLL3G9LbKca8c3a5eHxFWYOKxPIEGmRBgYgYGHgy03MKzXSMdIz1TbU MzTUMdYxYuDiFICpZjZmZGjZazhtyaOrP8+6HDmg+LhMblITm5h5iNeth+m2J8UTDBwZGa5PftZ bVWkQf/vc90nVuQIRDVGLq47eNrUosJof45yYzwIA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add register definitions and a new 'type' enum to be passed via MFD private data to support the BQ25792, which is a newer variant of the BQ257xx family. BQ25792 shares similar logic of operation with the already supported BQ25703A but has a completely different register map and different electrical constraints. Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/mfd/bq257xx.c | 54 +++++- include/linux/mfd/bq257xx.h | 412 ++++++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 463 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/bq257xx.c b/drivers/mfd/bq257xx.c index e9d49dac0a16..31654925afa5 100644 --- a/drivers/mfd/bq257xx.c +++ b/drivers/mfd/bq257xx.c @@ -39,6 +39,39 @@ static const struct regmap_config bq25703_regmap_config = =3D { .val_format_endian =3D REGMAP_ENDIAN_LITTLE, }; =20 +static const struct regmap_range bq25792_writeable_reg_ranges[] =3D { + regmap_reg_range(BQ25792_REG00_MIN_SYS_VOLTAGE, + BQ25792_REG18_NTC_CONTROL_1), + regmap_reg_range(BQ25792_REG28_CHARGER_MASK_0, + BQ25792_REG30_ADC_FUNCTION_DISABLE_1), +}; + +static const struct regmap_access_table bq25792_writeable_regs =3D { + .yes_ranges =3D bq25792_writeable_reg_ranges, + .n_yes_ranges =3D ARRAY_SIZE(bq25792_writeable_reg_ranges), +}; + +static const struct regmap_range bq25792_volatile_reg_ranges[] =3D { + regmap_reg_range(BQ25792_REG19_ICO_CURRENT_LIMIT, + BQ25792_REG27_FAULT_FLAG_1), + regmap_reg_range(BQ25792_REG31_IBUS_ADC, + BQ25792_REG47_DPDM_DRIVER), +}; + +static const struct regmap_access_table bq25792_volatile_regs =3D { + .yes_ranges =3D bq25792_volatile_reg_ranges, + .n_yes_ranges =3D ARRAY_SIZE(bq25792_volatile_reg_ranges), +}; + +static const struct regmap_config bq25792_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .max_register =3D BQ25792_REG48_PART_INFORMATION, + .cache_type =3D REGCACHE_MAPLE, + .wr_table =3D &bq25792_writeable_regs, + .volatile_table =3D &bq25792_volatile_regs, +}; + static const struct mfd_cell cells[] =3D { MFD_CELL_NAME("bq257xx-regulator"), MFD_CELL_NAME("bq257xx-charger"), @@ -46,6 +79,7 @@ static const struct mfd_cell cells[] =3D { =20 static int bq257xx_probe(struct i2c_client *client) { + const struct regmap_config *rcfg; struct bq257xx_device *ddata; int ret; =20 @@ -53,9 +87,21 @@ static int bq257xx_probe(struct i2c_client *client) if (!ddata) return -ENOMEM; =20 + ddata->type =3D (uintptr_t)i2c_get_match_data(client); ddata->client =3D client; =20 - ddata->regmap =3D devm_regmap_init_i2c(client, &bq25703_regmap_config); + switch (ddata->type) { + case BQ25703A: + rcfg =3D &bq25703_regmap_config; + break; + case BQ25792: + rcfg =3D &bq25792_regmap_config; + break; + default: + return dev_err_probe(&client->dev, -EINVAL, "Unsupported device type\n"); + } + + ddata->regmap =3D devm_regmap_init_i2c(client, rcfg); if (IS_ERR(ddata->regmap)) { return dev_err_probe(&client->dev, PTR_ERR(ddata->regmap), "Failed to allocate register map\n"); @@ -73,13 +119,15 @@ static int bq257xx_probe(struct i2c_client *client) } =20 static const struct i2c_device_id bq257xx_i2c_ids[] =3D { - { "bq25703a" }, + { "bq25703a", BQ25703A }, + { "bq25792", BQ25792 }, {} }; MODULE_DEVICE_TABLE(i2c, bq257xx_i2c_ids); =20 static const struct of_device_id bq257xx_of_match[] =3D { - { .compatible =3D "ti,bq25703a" }, + { .compatible =3D "ti,bq25703a", .data =3D (void *)BQ25703A }, + { .compatible =3D "ti,bq25792", .data =3D (void *)BQ25792 }, {} }; MODULE_DEVICE_TABLE(of, bq257xx_of_match); diff --git a/include/linux/mfd/bq257xx.h b/include/linux/mfd/bq257xx.h index 1d6ddc7fb09f..4ec72eb920f2 100644 --- a/include/linux/mfd/bq257xx.h +++ b/include/linux/mfd/bq257xx.h @@ -98,7 +98,419 @@ =20 #define BQ25703_EN_OTG_MASK BIT(12) =20 +#define BQ25792_REG00_MIN_SYS_VOLTAGE 0x00 +#define BQ25792_REG01_CHARGE_VOLTAGE_LIMIT 0x01 +#define BQ25792_REG03_CHARGE_CURRENT_LIMIT 0x03 +#define BQ25792_REG05_INPUT_VOLTAGE_LIMIT 0x05 +#define BQ25792_REG06_INPUT_CURRENT_LIMIT 0x06 +#define BQ25792_REG08_PRECHARGE_CONTROL 0x08 +#define BQ25792_REG09_TERMINATION_CONTROL 0x09 +#define BQ25792_REG0A_RECHARGE_CONTROL 0x0a +#define BQ25792_REG0B_VOTG_REGULATION 0x0b +#define BQ25792_REG0D_IOTG_REGULATION 0x0d +#define BQ25792_REG0E_TIMER_CONTROL 0x0e +#define BQ25792_REG0F_CHARGER_CONTROL_0 0x0f +#define BQ25792_REG10_CHARGER_CONTROL_1 0x10 +#define BQ25792_REG11_CHARGER_CONTROL_2 0x11 +#define BQ25792_REG12_CHARGER_CONTROL_3 0x12 +#define BQ25792_REG13_CHARGER_CONTROL_4 0x13 +#define BQ25792_REG14_CHARGER_CONTROL_5 0x14 +/* REG15 reserved */ +#define BQ25792_REG16_TEMPERATURE_CONTROL 0x16 +#define BQ25792_REG17_NTC_CONTROL_0 0x17 +#define BQ25792_REG18_NTC_CONTROL_1 0x18 +#define BQ25792_REG19_ICO_CURRENT_LIMIT 0x19 +#define BQ25792_REG1B_CHARGER_STATUS_0 0x1b +#define BQ25792_REG1C_CHARGER_STATUS_1 0x1c +#define BQ25792_REG1D_CHARGER_STATUS_2 0x1d +#define BQ25792_REG1E_CHARGER_STATUS_3 0x1e +#define BQ25792_REG1F_CHARGER_STATUS_4 0x1f +#define BQ25792_REG20_FAULT_STATUS_0 0x20 +#define BQ25792_REG21_FAULT_STATUS_1 0x21 +#define BQ25792_REG22_CHARGER_FLAG_0 0x22 +#define BQ25792_REG23_CHARGER_FLAG_1 0x23 +#define BQ25792_REG24_CHARGER_FLAG_2 0x24 +#define BQ25792_REG25_CHARGER_FLAG_3 0x25 +#define BQ25792_REG26_FAULT_FLAG_0 0x26 +#define BQ25792_REG27_FAULT_FLAG_1 0x27 +#define BQ25792_REG28_CHARGER_MASK_0 0x28 +#define BQ25792_REG29_CHARGER_MASK_1 0x29 +#define BQ25792_REG2A_CHARGER_MASK_2 0x2a +#define BQ25792_REG2B_CHARGER_MASK_3 0x2b +#define BQ25792_REG2C_FAULT_MASK_0 0x2c +#define BQ25792_REG2D_FAULT_MASK_1 0x2d +#define BQ25792_REG2E_ADC_CONTROL 0x2e +#define BQ25792_REG2F_ADC_FUNCTION_DISABLE_0 0x2f +#define BQ25792_REG30_ADC_FUNCTION_DISABLE_1 0x30 +#define BQ25792_REG31_IBUS_ADC 0x31 +#define BQ25792_REG33_IBAT_ADC 0x33 +#define BQ25792_REG35_VBUS_ADC 0x35 +#define BQ25792_REG37_VAC1_ADC 0x37 +#define BQ25792_REG39_VAC2_ADC 0x39 +#define BQ25792_REG3B_VBAT_ADC 0x3b +#define BQ25792_REG3D_VSYS_ADC 0x3d +#define BQ25792_REG3F_TS_ADC 0x3f +#define BQ25792_REG41_TDIE_ADC 0x41 +#define BQ25792_REG43_DP_ADC 0x43 +#define BQ25792_REG45_DM_ADC 0x45 +#define BQ25792_REG47_DPDM_DRIVER 0x47 +#define BQ25792_REG48_PART_INFORMATION 0x48 + +/* Minimal System Voltage */ +#define BQ25792_REG00_VSYSMIN_MASK GENMASK(5, 0) + +#define BQ25792_MINVSYS_MIN_UV 2500000 +#define BQ25792_MINVSYS_STEP_UV 250000 +#define BQ25792_MINVSYS_MAX_UV 16000000 + +/* Charge Voltage Limit */ +#define BQ25792_REG01_VREG_MASK GENMASK(10, 0) + +#define BQ25792_VBATREG_MIN_UV 3000000 +#define BQ25792_VBATREG_STEP_UV 10000 +#define BQ25792_VBATREG_MAX_UV 18800000 + +/* Charge Current Limit */ +#define BQ25792_REG03_ICHG_MASK GENMASK(8, 0) + +#define BQ25792_ICHG_MIN_UA 50000 +#define BQ25792_ICHG_STEP_UA 10000 +#define BQ25792_ICHG_MAX_UA 5000000 + +/* Input Voltage Limit */ +#define BQ25792_REG05_VINDPM_MASK GENMASK(7, 0) + +/* Input Current Limit */ +#define BQ25792_REG06_IINDPM_MASK GENMASK(8, 0) +#define BQ25792_IINDPM_DEFAULT_UA 3000000 +#define BQ25792_IINDPM_STEP_UA 10000 +#define BQ25792_IINDPM_MIN_UA 100000 +#define BQ25792_IINDPM_MAX_UA 3300000 + +/* Precharge Control */ +#define BQ25792_REG08_VBAT_LOWV_MASK GENMASK(7, 6) +#define BQ25792_REG08_IPRECHG_MASK GENMASK(5, 0) + +/* Termination Control */ +#define BQ25792_REG09_REG_RST BIT(6) +#define BQ25792_REG09_ITERM_MASK GENMASK(4, 0) + +/* Re-charge Control */ +#define BQ25792_REG0A_CELL_MASK GENMASK(7, 6) +#define BQ25792_REG0A_TRECHG_MASK GENMASK(5, 4) +#define BQ25792_REG0A_VRECHG_MASK GENMASK(3, 0) + +/* VOTG regulation */ +#define BQ25792_REG0B_VOTG_MASK GENMASK(10, 0) + +#define BQ25792_OTG_VOLT_MIN_UV 2800000 +#define BQ25792_OTG_VOLT_STEP_UV 10000 +#define BQ25792_OTG_VOLT_MAX_UV 22000000 +#define BQ25792_OTG_VOLT_NUM_VOLT ((BQ25792_OTG_VOLT_MAX_UV \ + - BQ25792_OTG_VOLT_MIN_UV) \ + / BQ25792_OTG_VOLT_STEP_UV + 1) + +/* IOTG regulation */ +#define BQ25792_REG0D_PRECHG_TMR BIT(7) +#define BQ25792_REG0D_IOTG_MASK GENMASK(6, 0) + +#define BQ25792_OTG_CUR_MIN_UA 120000 +#define BQ25792_OTG_CUR_STEP_UA 40000 +#define BQ25792_OTG_CUR_MAX_UA 3320000 + +/* Timer Control */ +#define BQ25792_REG0E_TOPOFF_TMR_MASK GENMASK(7, 6) +#define BQ25792_REG0E_EN_TRICHG_TMR BIT(5) +#define BQ25792_REG0E_EN_PRECHG_TMR BIT(4) +#define BQ25792_REG0E_EN_CHG_TMR BIT(3) +#define BQ25792_REG0E_CHG_TMR_MASK GENMASK(2, 1) +#define BQ25792_REG0E_TMR2X_EN BIT(0) + +/* Charger Control 0 */ +#define BQ25792_REG0F_EN_AUTO_IBATDIS BIT(7) +#define BQ25792_REG0F_FORCE_IBATDIS BIT(6) +#define BQ25792_REG0F_EN_CHG BIT(5) +#define BQ25792_REG0F_EN_ICO BIT(4) +#define BQ25792_REG0F_FORCE_ICO BIT(3) +#define BQ25792_REG0F_EN_HIZ BIT(2) +#define BQ25792_REG0F_EN_TERM BIT(1) +/* bit0 reserved */ + +/* Charger Control 1 */ +#define BQ25792_REG10_VAC_OVP_MASK GENMASK(5, 4) +#define BQ25792_REG10_WD_RST BIT(3) +#define BQ25792_REG10_WATCHDOG_MASK GENMASK(2, 0) + +/* Charger Control 2 */ +#define BQ25792_REG11_FORCE_INDET BIT(7) +#define BQ25792_REG11_AUTO_INDET_EN BIT(6) +#define BQ25792_REG11_EN_12V BIT(5) +#define BQ25792_REG11_EN_9V BIT(4) +#define BQ25792_REG11_HVDCP_EN BIT(3) +#define BQ25792_REG11_SDRV_CTRL_MASK GENMASK(2, 1) +#define BQ25792_REG11_SDRV_DLY BIT(0) + +/* Charger Control 3 */ +#define BQ25792_REG12_DIS_ACDRV BIT(7) +#define BQ25792_REG12_EN_OTG BIT(6) +#define BQ25792_REG12_PFM_OTG_DIS BIT(5) +#define BQ25792_REG12_PFM_FWD_DIS BIT(4) +#define BQ25792_REG12_WKUP_DLY BIT(3) +#define BQ25792_REG12_DIS_LDO BIT(2) +#define BQ25792_REG12_DIS_OTG_OOA BIT(1) +#define BQ25792_REG12_DIS_FWD_OOA BIT(0) + +/* Charger Control 4 */ +#define BQ25792_REG13_EN_ACDRV2 BIT(7) +#define BQ25792_REG13_EN_ACDRV1 BIT(6) +#define BQ25792_REG13_PWM_FREQ BIT(5) +#define BQ25792_REG13_DIS_STAT BIT(4) +#define BQ25792_REG13_DIS_VSYS_SHORT BIT(3) +#define BQ25792_REG13_DIS_VOTG_UVP BIT(2) +#define BQ25792_REG13_FORCE_VINDPM_DET BIT(1) +#define BQ25792_REG13_EN_IBUS_OCP BIT(0) + +/* Charger Control 5 */ +#define BQ25792_REG14_SFET_PRESENT BIT(7) +/* bit6 reserved */ +#define BQ25792_REG14_EN_IBAT BIT(5) +#define BQ25792_REG14_IBAT_REG_MASK GENMASK(4, 3) +#define BQ25792_REG14_EN_IINDPM BIT(2) +#define BQ25792_REG14_EN_EXTILIM BIT(1) +#define BQ25792_REG14_EN_BATOC BIT(0) + +#define BQ25792_IBAT_3A FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 0) +#define BQ25792_IBAT_4A FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 1) +#define BQ25792_IBAT_5A FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 2) +#define BQ25792_IBAT_UNLIM FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 3) + +/* Temperature Control */ +#define BQ25792_REG16_TREG_MASK GENMASK(7, 6) +#define BQ25792_REG16_TSHUT_MASK GENMASK(5, 4) +#define BQ25792_REG16_VBUS_PD_EN BIT(3) +#define BQ25792_REG16_VAC1_PD_EN BIT(2) +#define BQ25792_REG16_VAC2_PD_EN BIT(1) + +/* NTC Control 0 */ +#define BQ25792_REG17_JEITA_VSET_MASK GENMASK(7, 5) +#define BQ25792_REG17_JEITA_ISETH_MASK GENMASK(4, 3) +#define BQ25792_REG17_JEITA_ISETC_MASK GENMASK(2, 1) + +/* NTC Control 1 */ +#define BQ25792_REG18_TS_COOL_MASK GENMASK(7, 6) +#define BQ25792_REG18_TS_WARM_MASK GENMASK(5, 4) +#define BQ25792_REG18_BHOT_MASK GENMASK(3, 2) +#define BQ25792_REG18_BCOLD BIT(1) +#define BQ25792_REG18_TS_IGNORE BIT(0) + +/* ICO Current Limit */ +#define BQ25792_REG19_ICO_ILIM_MASK GENMASK(8, 0) + +/* Charger Status 0 */ +#define BQ25792_REG1B_IINDPM_STAT BIT(7) +#define BQ25792_REG1B_VINDPM_STAT BIT(6) +#define BQ25792_REG1B_WD_STAT BIT(5) +#define BQ25792_REG1B_POORSRC_STAT BIT(4) +#define BQ25792_REG1B_PG_STAT BIT(3) +#define BQ25792_REG1B_AC2_PRESENT_STAT BIT(2) +#define BQ25792_REG1B_AC1_PRESENT_STAT BIT(1) +#define BQ25792_REG1B_VBUS_PRESENT_STAT BIT(0) + +/* Charger Status 1 */ +#define BQ25792_REG1C_CHG_STAT_MASK GENMASK(7, 5) +#define BQ25792_REG1C_VBUS_STAT_MASK GENMASK(4, 1) +#define BQ25792_REG1C_BC12_DONE_STAT BIT(0) + +/* Charger Status 2 */ +#define BQ25792_REG1D_ICO_STAT_MASK GENMASK(7, 6) +#define BQ25792_REG1D_TREG_STAT BIT(2) +#define BQ25792_REG1D_DPDM_STAT BIT(1) +#define BQ25792_REG1D_VBAT_PRESENT_STAT BIT(0) + +/* Charger Status 3 */ +#define BQ25792_REG1E_ACRB2_STAT BIT(7) +#define BQ25792_REG1E_ACRB1_STAT BIT(6) +#define BQ25792_REG1E_ADC_DONE_STAT BIT(5) +#define BQ25792_REG1E_VSYS_STAT BIT(4) +#define BQ25792_REG1E_CHG_TMR_STAT BIT(3) +#define BQ25792_REG1E_TRICHG_TMR_STAT BIT(2) +#define BQ25792_REG1E_PRECHG_TMR_STAT BIT(1) + +/* Charger Status 4 */ +#define BQ25792_REG1F_VBATOTG_LOW_STAT BIT(4) +#define BQ25792_REG1F_TS_COLD_STAT BIT(3) +#define BQ25792_REG1F_TS_COOL_STAT BIT(2) +#define BQ25792_REG1F_TS_WARM_STAT BIT(1) +#define BQ25792_REG1F_TS_HOT_STAT BIT(0) + +/* FAULT Status 0 */ +#define BQ25792_REG20_IBAT_REG_STAT BIT(7) +#define BQ25792_REG20_VBUS_OVP_STAT BIT(6) +#define BQ25792_REG20_VBAT_OVP_STAT BIT(5) +#define BQ25792_REG20_IBUS_OCP_STAT BIT(4) +#define BQ25792_REG20_IBAT_OCP_STAT BIT(3) +#define BQ25792_REG20_CONV_OCP_STAT BIT(2) +#define BQ25792_REG20_VAC2_OVP_STAT BIT(1) +#define BQ25792_REG20_VAC1_OVP_STAT BIT(0) + +#define BQ25792_REG20_OVERVOLTAGE_MASK (BQ25792_REG20_VBAT_OVP_STAT | \ + BQ25792_REG20_VAC2_OVP_STAT | \ + BQ25792_REG20_VAC1_OVP_STAT) +#define BQ25792_REG20_OVERCURRENT_MASK (BQ25792_REG20_IBAT_OCP_STAT | \ + BQ25792_REG20_CONV_OCP_STAT) + +/* FAULT Status 1 */ +#define BQ25792_REG21_VSYS_SHORT_STAT BIT(7) +#define BQ25792_REG21_VSYS_OVP_STAT BIT(6) +#define BQ25792_REG21_OTG_OVP_STAT BIT(5) +#define BQ25792_REG21_OTG_UVP_STAT BIT(4) +#define BQ25792_REG21_TSHUT_STAT BIT(2) + + +/* Charger Flag 0 */ +#define BQ25792_REG22_IINDPM_FLAG BIT(7) +#define BQ25792_REG22_VINDPM_FLAG BIT(6) +#define BQ25792_REG22_WD_FLAG BIT(5) +#define BQ25792_REG22_POORSRC_FLAG BIT(4) +#define BQ25792_REG22_PG_FLAG BIT(3) +#define BQ25792_REG22_AC2_PRESENT_FLAG BIT(2) +#define BQ25792_REG22_AC1_PRESENT_FLAG BIT(1) +#define BQ25792_REG22_VBUS_PRESENT_FLAG BIT(0) + +/* Charger Flag 1 */ +#define BQ25792_REG23_CHG_FLAG BIT(7) +#define BQ25792_REG23_ICO_FLAG BIT(6) +#define BQ25792_REG23_VBUS_FLAG BIT(4) +#define BQ25792_REG23_TREG_FLAG BIT(2) +#define BQ25792_REG23_VBAT_PRESENT_FLAG BIT(1) +#define BQ25792_REG23_BC12_DONE_FLAG BIT(0) + +/* Charger Flag 2 */ +#define BQ25792_REG24_DPDM_DONE_FLAG BIT(6) +#define BQ25792_REG24_ADC_DONE_FLAG BIT(5) +#define BQ25792_REG24_VSYS_FLAG BIT(4) +#define BQ25792_REG24_CHG_TMR_FLAG BIT(3) +#define BQ25792_REG24_TRICHG_TMR_FLAG BIT(2) +#define BQ25792_REG24_PRECHG_TMR_FLAG BIT(1) +#define BQ25792_REG24_TOPOFF_TMR_FLAG BIT(0) + +/* Charger Flag 3 */ +#define BQ25792_REG25_VBATOTG_LOW_FLAG BIT(4) +#define BQ25792_REG25_TS_COLD_FLAG BIT(3) +#define BQ25792_REG25_TS_COOL_FLAG BIT(2) +#define BQ25792_REG25_TS_WARM_FLAG BIT(1) +#define BQ25792_REG25_TS_HOT_FLAG BIT(0) + +/* FAULT Flag 0 */ +#define BQ25792_REG26_IBAT_REG_FLAG BIT(7) +#define BQ25792_REG26_VBUS_OVP_FLAG BIT(6) +#define BQ25792_REG26_VBAT_OVP_FLAG BIT(5) +#define BQ25792_REG26_IBUS_OCP_FLAG BIT(4) +#define BQ25792_REG26_IBAT_OCP_FLAG BIT(3) +#define BQ25792_REG26_CONV_OCP_FLAG BIT(2) +#define BQ25792_REG26_VAC2_OVP_FLAG BIT(1) +#define BQ25792_REG26_VAC1_OVP_FLAG BIT(0) + +/* FAULT Flag 1 */ +#define BQ25792_REG27_VSYS_SHORT_FLAG BIT(7) +#define BQ25792_REG27_VSYS_OVP_FLAG BIT(6) +#define BQ25792_REG27_OTG_OVP_FLAG BIT(5) +#define BQ25792_REG27_OTG_UVP_FLAG BIT(4) +#define BQ25792_REG27_TSHUT_FLAG BIT(2) + +/* Charger Mask 0 */ +#define BQ25792_REG28_IINDPM_MASK BIT(7) +#define BQ25792_REG28_VINDPM_MASK BIT(6) +#define BQ25792_REG28_WD_MASK BIT(5) +#define BQ25792_REG28_POORSRC_MASK BIT(4) +#define BQ25792_REG28_PG_MASK BIT(3) +#define BQ25792_REG28_AC2_PRESENT_MASK BIT(2) +#define BQ25792_REG28_AC1_PRESENT_MASK BIT(1) +#define BQ25792_REG28_VBUS_PRESENT_MASK BIT(0) + +/* Charger Mask 1 */ +#define BQ25792_REG29_CHG_MASK BIT(7) +#define BQ25792_REG29_ICO_MASK BIT(6) +#define BQ25792_REG29_VBUS_MASK BIT(4) +#define BQ25792_REG29_TREG_MASK BIT(2) +#define BQ25792_REG29_VBAT_PRESENT_MASK BIT(1) +#define BQ25792_REG29_BC12_DONE_MASK BIT(0) + +/* Charger Mask 2 */ +#define BQ25792_REG2A_DPDM_DONE_MASK BIT(6) +#define BQ25792_REG2A_ADC_DONE_MASK BIT(5) +#define BQ25792_REG2A_VSYS_MASK BIT(4) +#define BQ25792_REG2A_CHG_TMR_MASK BIT(3) +#define BQ25792_REG2A_TRICHG_TMR_MASK BIT(2) +#define BQ25792_REG2A_PRECHG_TMR_MASK BIT(1) +#define BQ25792_REG2A_TOPOFF_TMR_MASK BIT(0) + +/* Charger Mask 3 */ +#define BQ25792_REG2B_VBATOTG_LOW_MASK BIT(4) +#define BQ25792_REG2B_TS_COLD_MASK BIT(3) +#define BQ25792_REG2B_TS_COOL_MASK BIT(2) +#define BQ25792_REG2B_TS_WARM_MASK BIT(1) +#define BQ25792_REG2B_TS_HOT_MASK BIT(0) + +/* FAULT Mask 0 */ +#define BQ25792_REG2C_IBAT_REG_MASK BIT(7) +#define BQ25792_REG2C_VBUS_OVP_MASK BIT(6) +#define BQ25792_REG2C_VBAT_OVP_MASK BIT(5) +#define BQ25792_REG2C_IBUS_OCP_MASK BIT(4) +#define BQ25792_REG2C_IBAT_OCP_MASK BIT(3) +#define BQ25792_REG2C_CONV_OCP_MASK BIT(2) +#define BQ25792_REG2C_VAC2_OVP_MASK BIT(1) +#define BQ25792_REG2C_VAC1_OVP_MASK BIT(0) + +/* FAULT Mask 1 */ +#define BQ25792_REG2D_VSYS_SHORT_MASK BIT(7) +#define BQ25792_REG2D_VSYS_OVP_MASK BIT(6) +#define BQ25792_REG2D_OTG_OVP_MASK BIT(5) +#define BQ25792_REG2D_OTG_UVP_MASK BIT(4) +#define BQ25792_REG2D_TSHUT_MASK BIT(2) + +/* ADC Control */ +#define BQ25792_REG2E_ADC_EN BIT(7) +#define BQ25792_REG2E_ADC_RATE BIT(6) +#define BQ25792_REG2E_ADC_SAMPLE_MASK GENMASK(5, 4) +#define BQ25792_REG2E_ADC_AVG BIT(3) +#define BQ25792_REG2E_ADC_AVG_INIT BIT(2) + +/* ADC Function Disable 0 */ +#define BQ25792_REG2F_IBUS_ADC_DIS BIT(7) +#define BQ25792_REG2F_IBAT_ADC_DIS BIT(6) +#define BQ25792_REG2F_VBUS_ADC_DIS BIT(5) +#define BQ25792_REG2F_VBAT_ADC_DIS BIT(4) +#define BQ25792_REG2F_VSYS_ADC_DIS BIT(3) +#define BQ25792_REG2F_TS_ADC_DIS BIT(2) +#define BQ25792_REG2F_TDIE_ADC_DIS BIT(1) + +/* ADC Function Disable 1 */ +#define BQ25792_REG30_DP_ADC_DIS BIT(7) +#define BQ25792_REG30_DM_ADC_DIS BIT(6) +#define BQ25792_REG30_VAC2_ADC_DIS BIT(5) +#define BQ25792_REG30_VAC1_ADC_DIS BIT(4) + +/* 0x31-0x45: ADC result registers (16-bit, RO): single full-width field */ + +#define BQ25792_ADCVSYSVBAT_STEP_UV 1000 +#define BQ25792_ADCIBAT_STEP_UA 1000 + +/* DPDM Driver */ +#define BQ25792_REG47_DPLUS_DAC_MASK GENMASK(7, 5) +#define BQ25792_REG47_DMINUS_DAC_MASK GENMASK(4, 2) + +/* Part Information */ +#define BQ25792_REG48_PN_MASK GENMASK(5, 3) +#define BQ25792_REG48_DEV_REV_MASK GENMASK(2, 0) + +enum bq257xx_type { + BQ25703A =3D 1, + BQ25792, +}; + struct bq257xx_device { struct i2c_client *client; struct regmap *regmap; + enum bq257xx_type type; }; --=20 2.52.0 From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B2F3F1647 for ; Tue, 24 Mar 2026 11:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352333; cv=none; b=KM8+gK4fKobTyDl4LJdLpJ1enUNra9aXqTOnS9qGzQ87OLa2aQXiYPd1f8kVEh4P6+Ku5HV9YlFevD3+AS8+iPDc3wnIvZkgpZao1iEbP+Au5c1yFuyXh4B7B/qb3aWkIrkXR8WDKX8iiJUHGnqXjRrLOfY0dGW+81WuYIXgqCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352333; c=relaxed/simple; bh=q9BptJDuAQnjOV/HxIZuYo7P6hJdxkSiFaoHcUpNVb0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hdxEeDyXnM2kPvGgo+aQIYHFKhASTZnvdOsqKld50I8VHAS4DHL4dCHN11eKtJH5sztvj0lxtbE4GdWAfdWpKnmGberAlnsOLocse7QpXeRSrOy29C5LFjpz04CyxF7srBHI9aRyHHgfljKPizgfWaZgGowPsxFFqjMKGluCwjc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=z+Af7ybM; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="z+Af7ybM" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4852c9b4158so39634325e9.0 for ; Tue, 24 Mar 2026 04:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352331; x=1774957131; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gzdSIakIBsa879u0fxfflVhMlKymXjPa/1rJ4QxUnO8=; b=z+Af7ybMDeDxHoYjyX6A3X/5nLpChJaMOHXBeIDqtommvTuA8gSP0VIh1jBO6ELlX8 gJS8TB+jQgSr02km22+uidJ7KwBsgzBSrIf0jpN4HKbaiW5dojCLYRkS+5qYfo5wH/Vf 1WXkDDRAwK1CQOsRUBY7LOnA5rR+Wb76FwxSmRfQuRRwO0ykYUCSnFNQfOV/m3yNpO4j TUaA+S/0mP4WHCuTHEmtSHZJIk1Z4u3Vw0dZlIu6zvu6r7ysROg0+YnCcOsqHO2UgEuu 5Ikbb8E9VJh+j1frg6e7IOR9QoInpAzw4Y0wA0vimV8bTYTlmSeTpmXzmi+9Q1dodc2/ 0ttw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352331; x=1774957131; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gzdSIakIBsa879u0fxfflVhMlKymXjPa/1rJ4QxUnO8=; b=OJSS5eSzDHZbxOh6ifpctAzFe2hH+Ca23Kvkopd0n3N92od7aIpSeqtrFm5aHNL7K7 whVYCEPTt5jU5Y3DVNWjMlf3axoVhBUIn6aCAQ55k6ZlrzP5YAVRMrxeCdvx+qOCoTut WYJ9PgNGajtZ8W2VU0jc8nUJ4j104Iv/N67YQ+oVa8G5WGjaFoSqVrmQ9ikylCVbkusj VhWkJOT7nLTT+Gu4pGttuhBf/IRsNQLL7WdurxoAratEHYLK0wLa4cJqOQugpH3ZTdP6 mDl879cyKswMt+m26UdZ4cYyFRCnHm3pjIsQRWpyRhujMXuvrEhXuDPzQdH+aWFVYjxp aOPw== X-Forwarded-Encrypted: i=1; AJvYcCUnejv1ZNODYi508jl/Pd3+XVPwDaM0tvOKVXYPUcNNl3Wgb0Qc04n1EN7BHUr4Idrwfl3N8l7ssiQQL8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxNIg3KUnX7TrQ+VbR934s7fcww9f5EwWDIqmkehAwD/9nma4gU julO8hhrsPhnLsp5YiJ83sjoIwJgD0sUHhtAW4+KvmQC/nVh6/dXUWOJivJcdaLNMnE= X-Gm-Gg: ATEYQzzjMNeuAop8usQXwdX0Fg0TYotPPzoQCPVwVJXw31EIt8BvQVPg0Untdmy5kN3 FmGdYdFt2s/+33N8kf2J2DS9jnUKGTJRTT6VImzc/Sjp36KALvdToFRyedij57Vun8wdB6Xv+OI mySAbjZ8pMeDoCzMLcMQcILRfykqerstHbavVQtFKzy3G7l40ZXEk23riGDcy2pTF49FOzsBXFT tEY5QENgI11636KCLsjge4iaEwUV5EDYc8uol2e7T1EYyKG7sXk5mDkr4LbvEaOsu9KUOxWNQin HA09mbYIyKtS7dqEAS7rd86Pm+SHCxgRaQITMx1HJDuF59YEqse59K/a1u9OHsg9GeOm4avwWhR c3aQCbN0FlYqCSeYictE8lj129y3UDicgzwuORk3RC1Ul4XSLoZeXBQoHjF5+463b8Ai6jbytW+ J1bvGqPbN6FmkrsjONCRKfHcOF3M0Jp0Dbu3dfwXjbGkrc1oxtsZfYA9js9tKFYKLWWVRXzScgj cu/DQ== X-Received: by 2002:a05:600c:3b1e:b0:483:8062:b43 with SMTP id 5b1f17b1804b1-486fee05925mr211358475e9.19.1774352330747; Tue, 24 Mar 2026 04:38:50 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:50 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:15 +0400 Subject: [PATCH v5 10/11] regulator: bq257xx: Add support for BQ25792 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-10-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5094; i=alchark@flipper.net; h=from:subject:message-id; bh=q9BptJDuAQnjOV/HxIZuYo7P6hJdxkSiFaoHcUpNVb0=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl9bOIX1qU7uv0cVcss2Pwx+s8FztqSVc+qLbOtPD LPXOP5/3TGRhUGMi8FSTJFl7rcltlON+Gbt8vD4CjOHlQlkiLRIAwMQsDDw5SbmlRrpGOmZahvq GRrqGOsYMXBxCsBUJ75lZJi5z78goz2uPJd5nbXDpuOL0/0snVnXaHxol2TN8jj3wJeR4brZbd/ Wzz3spUxrNvDuOHrY4bjXve6LHhs9apLWXfvPzgUA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add support for TI BQ25792, an integrated battery charger and buck/boost regulator. This enables VBUS output from the charger's boost converter for use in USB OTG applications, supporting 2.8-22V output at up to 3.32A with 10mV and 40mA resolution. Acked-by: Mark Brown Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/regulator/bq257xx-regulator.c | 98 +++++++++++++++++++++++++++++++= +++- 1 file changed, 97 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index 0bb58ab4b8d4..f197162382cc 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -31,6 +31,32 @@ static int bq25703_vbus_get_cur_limit(struct regulator_d= ev *rdev) return FIELD_GET(BQ25703_OTG_CUR_MASK, reg) * BQ25703_OTG_CUR_STEP_UA; } =20 +static int bq25792_vbus_get_cur_limit(struct regulator_dev *rdev) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + int ret; + unsigned int reg; + + ret =3D regmap_read(regmap, BQ25792_REG0D_IOTG_REGULATION, ®); + if (ret) + return ret; + return FIELD_GET(BQ25792_REG0D_IOTG_MASK, reg) * BQ25792_OTG_CUR_STEP_UA; +} + +static int bq25792_vbus_get_voltage_sel(struct regulator_dev *rdev) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + __be16 reg; + int ret; + + ret =3D regmap_raw_read(regmap, BQ25792_REG0B_VOTG_REGULATION, + ®, sizeof(reg)); + if (ret) + return ret; + + return FIELD_GET(BQ25792_REG0B_VOTG_MASK, be16_to_cpu(reg)); +} + /* * Check if the minimum current and maximum current requested are * sane values, then set the register accordingly. @@ -54,6 +80,37 @@ static int bq25703_vbus_set_cur_limit(struct regulator_d= ev *rdev, FIELD_PREP(BQ25703_OTG_CUR_MASK, reg)); } =20 +static int bq25792_vbus_set_cur_limit(struct regulator_dev *rdev, + int min_uA, int max_uA) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + unsigned int reg; + + if ((min_uA > BQ25792_OTG_CUR_MAX_UA) || + (max_uA < BQ25792_OTG_CUR_MIN_UA)) + return -EINVAL; + + reg =3D (max_uA / BQ25792_OTG_CUR_STEP_UA); + + /* Catch rounding errors since our step is 40000uA. */ + if ((reg * BQ25792_OTG_CUR_STEP_UA) < min_uA) + return -EINVAL; + + return regmap_write(regmap, BQ25792_REG0D_IOTG_REGULATION, + FIELD_PREP(BQ25792_REG0D_IOTG_MASK, reg)); +} + +static int bq25792_vbus_set_voltage_sel(struct regulator_dev *rdev, + unsigned int sel) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + __be16 reg; + + reg =3D cpu_to_be16(FIELD_PREP(BQ25792_REG0B_VOTG_MASK, sel)); + return regmap_raw_write(regmap, BQ25792_REG0B_VOTG_REGULATION, + ®, sizeof(reg)); +} + static int bq25703_vbus_enable(struct regulator_dev *rdev) { struct bq257xx_reg_data *pdata =3D rdev_get_drvdata(rdev); @@ -101,6 +158,34 @@ static const struct regulator_desc bq25703_vbus_desc = =3D { .vsel_mask =3D BQ25703_OTG_VOLT_MASK, }; =20 +static const struct regulator_ops bq25792_vbus_ops =3D { + /* No GPIO for enabling the OTG regulator */ + .enable =3D regulator_enable_regmap, + .disable =3D regulator_disable_regmap, + .is_enabled =3D regulator_is_enabled_regmap, + .list_voltage =3D regulator_list_voltage_linear, + .get_voltage_sel =3D bq25792_vbus_get_voltage_sel, + .set_voltage_sel =3D bq25792_vbus_set_voltage_sel, + .get_current_limit =3D bq25792_vbus_get_cur_limit, + .set_current_limit =3D bq25792_vbus_set_cur_limit, +}; + +static const struct regulator_desc bq25792_vbus_desc =3D { + .name =3D "vbus", + .of_match =3D of_match_ptr("vbus"), + .regulators_node =3D of_match_ptr("regulators"), + .type =3D REGULATOR_VOLTAGE, + .owner =3D THIS_MODULE, + .ops =3D &bq25792_vbus_ops, + .min_uV =3D BQ25792_OTG_VOLT_MIN_UV, + .uV_step =3D BQ25792_OTG_VOLT_STEP_UV, + .n_voltages =3D BQ25792_OTG_VOLT_NUM_VOLT, + .enable_mask =3D BQ25792_REG12_EN_OTG, + .enable_reg =3D BQ25792_REG12_CHARGER_CONTROL_3, + .enable_val =3D BQ25792_REG12_EN_OTG, + .disable_val =3D 0, +}; + /* Get optional GPIO for OTG regulator enable. */ static void bq257xx_reg_dt_parse_gpio(struct platform_device *pdev) { @@ -141,6 +226,7 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_d= evice *pdev) static int bq257xx_regulator_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; + struct bq257xx_device *bq =3D dev_get_drvdata(pdev->dev.parent); struct bq257xx_reg_data *pdata; struct device_node *np =3D dev->of_node; struct regulator_config cfg =3D {}; @@ -153,7 +239,17 @@ static int bq257xx_regulator_probe(struct platform_dev= ice *pdev) if (!pdata) return -ENOMEM; =20 - pdata->desc =3D bq25703_vbus_desc; + switch (bq->type) { + case BQ25703A: + pdata->desc =3D bq25703_vbus_desc; + break; + case BQ25792: + pdata->desc =3D bq25792_vbus_desc; + break; + default: + return dev_err_probe(&pdev->dev, -EINVAL, + "Unsupported device type\n"); + } =20 platform_set_drvdata(pdev, pdata); bq257xx_reg_dt_parse_gpio(pdev); --=20 2.52.0 From nobody Fri Apr 3 10:24:44 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 852DF3EF64D for ; Tue, 24 Mar 2026 11:38:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352339; cv=none; b=WU0Dl4XO1qrv3roJtqb3+VTEsvzQS56FYL1J5bJOSgv+EFq7Hnjp4CptFUKm0OgFqA3ywbmLtVMUemmXaGAkR4gGAod1+cQH2H1zTcNwaSTlqtdTF+wYvelDfoOeWZlO9qO/Y0WsQbVgkQM6isezaHzm7d0CBKEn5FYhBxTXxqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774352339; c=relaxed/simple; bh=VW4PGKQbMprs05QZjLUFAcp7NQ6qIj6tfIjDvxiwqeE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C8jJWudaeEygTcvSfkwHKIt28K1IOKRt6T5DtpxG19koEK8QfLhzGF790qfAXQ57eCjDG2LzaFFoFhKC7ndulusSWD9HKI9xjz3cf5bnLFR8KfRkTRl10PFmrl5Wc498mSjw8kZEJ0j10wedbpI8mdR3VB/p0AQUaIUJscmzBx0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=g/Y9sYH3; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="g/Y9sYH3" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-486fd5360d4so13077725e9.1 for ; Tue, 24 Mar 2026 04:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774352334; x=1774957134; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HJBOPz5cenCqobIA2pP3hpiRljJx71ZTKxf/DvRJSFg=; b=g/Y9sYH3vZLd2YlqDYaEmSKIBtDQx3QI5BcXSmkR3+7n+l1gcluEXkeI7uFQnCGadH 82sc6IEGi+BR5ifPsVzn+JbupOrQMXpYrm9MaV17NT+LfE3YTtbJtRJKG6cMB84HpLP3 kBnVRsaX8N6UeLbp2Snnx7qTIz4wsjxC4QGYNNJr5RX7es6J0L9wMdT/AB5KI80RDnyQ jYTJz9bU3cHKZk4m9CZdgbB8wNpGDB7qlGNC8HiZL/Ud7mEvtHuc12DbGCvX2Ad/rTq7 ZY2QCkuZKehRMOZwhnxuc5QvxqBiVNSkSJ6mUQb2gCEIYGp8QjdyIRG01opex9nCNdmr 82rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774352334; x=1774957134; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HJBOPz5cenCqobIA2pP3hpiRljJx71ZTKxf/DvRJSFg=; b=eobGq+FUGmZj5GlOYAY0czml7xXj+aW5E1xxxVWND6XSXMuFb3OC2UDa2mUiPekuUg nQbgA5JWasTFB4YTL5jHNjbWOFXXt9NWbm6G/Aiykts/4qK2mBRqYTiMbgbSO1dIaR3r iXvXCoDBKB4Ciw7Jr9FZBA9kIwLw6i9FtN7SJUasVkJ0A1WzwI2n1+7z6JPbOpXNQIFC 02f92rfd+JvMBALYuZD2S+z7V+mpLJFErNQEJCj7o6wYTEgE9cbTuMVW0AQqiWVs9DOY 6ESaLatsOIQy5ywcEK3LWNY77FYjUlVaMITUA6gXJm5yKjGamOUVsTOvAvv9GcaqXuje PaVg== X-Forwarded-Encrypted: i=1; AJvYcCWCG2HR7PTu7MlDPNuhiW/yGoHAcis3EuvZ5Ksq/77WpzsjVX+8UwwPIADdNsjko7F0YPWfLo6lWxlA2xs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/FomujCENynLjmSY9e+C/5htOiy7qLJ+LwOs9bKFQRdTgYe0X 9V5I1YP2jLJ8WJOE+wnHZkT6D1XtWnbC1EcOtaAvXhGdQ9Bc+ojY7v417zxqCNFeJ0ctj/LYqRP kZpSMUj8= X-Gm-Gg: ATEYQzyYM/2KdckywF2XDHYTw/M7JYdtJ9I7ObAIMThOhAkOEpBpIq48ZVrML/UaKhX T3RLLxBy9nXWDd8odT3JvZjfMfuPahnrhyVBoxaZV0QDTD3BZMPoJl/eJaYpD5Ww1qEqRBPIshO 1yeI641RyXD1ZOUy6jMHEd2kDWfuRgxKGqOOOJCiUbP+DEFKGzdhlNeQRUpJql01q3edPbkNYIe CWH28ujg2GbMpWxd7/uFmwc0OfyTHtzICLCGlzeKlpC95NHEEegzFE2XmFKKicXXOJOOFYThCfl pfnnJKnzU89M6cQOICbSpF0E+73e7GOw1rorJ2Qr+hPm7Dc15gxm46paiH4VMCfc8qr4rDQvKdE UEhGIB91/Z97Ahqp71nGUwtpTimFRm0ouPkJT2KHTaOKllOdtw9bqcCcqYPzm58Fec6/Bs2R22/ 2jODFQaXDSg2LnFZ1sHT/MaGytDaPBBP43AArJm2IUpkI2OS8LW1uMvvxuf2YE3A87QFZHnplVH TJZrw== X-Received: by 2002:a05:600c:608c:b0:487:1114:d42f with SMTP id 5b1f17b1804b1-4871114d526mr28933925e9.1.1774352333551; Tue, 24 Mar 2026 04:38:53 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4870f6c0fa6sm20846715e9.1.2026.03.24.04.38.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 04:38:53 -0700 (PDT) From: Alexey Charkov Date: Tue, 24 Mar 2026 15:38:16 +0400 Subject: [PATCH v5 11/11] power: supply: bq257xx: Add support for BQ25792 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-bq25792-v5-11-0a2eb58cf11d@flipper.net> References: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> In-Reply-To: <20260324-bq25792-v5-0-0a2eb58cf11d@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=20378; i=alchark@flipper.net; h=from:subject:message-id; bh=VW4PGKQbMprs05QZjLUFAcp7NQ6qIj6tfIjDvxiwqeE=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWQeKl+ny7M77a+6w9l1uoE3a3oU2UKd9z681SusKPKbf d62mo1POiayMIhxMViKKbLM/bbEdqoR36xdHh5fYeawMoEMkRZpYAACFga+3MS8UiMdIz1TbUM9 Q0MdYx0jBi5OAZjqnhSG/8Edjn/ua0cax6mpt3JrJN+4wLL7+6LbOgK/mJYEP5i3MoGRYdlhpsS f/jNf5DL+ZFiTw5h4eUv0r+wDO9+9FJ/aUjHhMS8A X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add support for TI BQ25792 integrated battery charger and buck-boost converter. It shares high-level logic of operation with the already supported BQ25703A, but has a different register map, bit definitions and some of the lower-level hardware states. Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 482 +++++++++++++++++++++++++++++= +++- 1 file changed, 481 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 9c082865e745..b9a41fe6f00e 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -5,6 +5,7 @@ */ =20 #include +#include #include #include #include @@ -88,6 +89,53 @@ struct bq257xx_chg { u32 vsys_min; }; =20 +/** + * bq25792_read16() - Read a 16-bit value from device register + * @pdata: driver platform data + * @reg: register address to read from + * @val: pointer to store the register value + * + * Read a 16-bit big-endian value from the BQ25792 device via regmap + * and convert to CPU byte order. + * + * Return: Returns 0 on success or error on failure to read. + */ +static int bq25792_read16(struct bq257xx_chg *pdata, unsigned int reg, u16= *val) +{ + __be16 regval; + int ret; + + ret =3D regmap_raw_read(pdata->bq->regmap, reg, ®val, sizeof(regval)); + if (ret) + return ret; + + *val =3D be16_to_cpu(regval); + return 0; +} + +/** + * bq25792_write16() - Write a 16-bit value to device register + * @pdata: driver platform data + * @reg: register address to write to + * @val: 16-bit value to write in CPU byte order + * + * Convert the value to big-endian and write a 16-bit value to the + * BQ25792 device via regmap. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_write16(struct bq257xx_chg *pdata, unsigned int reg, u1= 6 val) +{ + __be16 regval =3D cpu_to_be16(val); + int ret; + + ret =3D regmap_raw_write(pdata->bq->regmap, reg, ®val, sizeof(regval)); + if (ret) + return ret; + + return 0; +} + /** * bq25703_get_state() - Get the current state of the device * @pdata: driver platform data @@ -119,6 +167,43 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) return 0; } =20 +/** + * bq25792_get_state() - Get the current state of the device + * @pdata: driver platform data + * + * Get the current state of the BQ25792 charger by reading status + * registers. Updates the online, charging, overvoltage, and fault + * status fields in the driver data structure. + * + * Return: Returns 0 on success or error on failure to read device. + */ +static int bq25792_get_state(struct bq257xx_chg *pdata) +{ + unsigned int reg; + int ret; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG1B_CHARGER_STATUS_0, &r= eg); + if (ret) + return ret; + + pdata->online =3D reg & BQ25792_REG1B_PG_STAT; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG1C_CHARGER_STATUS_1, &r= eg); + if (ret) + return ret; + + pdata->charging =3D reg & BQ25792_REG1C_CHG_STAT_MASK; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG20_FAULT_STATUS_0, ®= ); + if (ret) + return ret; + + pdata->overvoltage =3D reg & BQ25792_REG20_OVERVOLTAGE_MASK; + pdata->oc_fault =3D reg & BQ25792_REG20_OVERCURRENT_MASK; + + return 0; +} + /** * bq25703_get_min_vsys() - Get the minimum system voltage * @pdata: driver platform data @@ -142,6 +227,31 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pd= ata, int *intval) return ret; } =20 +/** + * bq25792_get_min_vsys() - Get the minimum system voltage + * @pdata: driver platform data + * @intval: pointer to store the minimum voltage value + * + * Read the current minimum system voltage setting from the device + * and return it in microvolts. + * + * Return: Returns 0 on success or error on failure to read. + */ +static int bq25792_get_min_vsys(struct bq257xx_chg *pdata, int *intval) +{ + unsigned int reg; + int ret; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG00_MIN_SYS_VOLTAGE, &re= g); + if (ret) + return ret; + + reg =3D FIELD_GET(BQ25792_REG00_VSYSMIN_MASK, reg); + *intval =3D (reg * BQ25792_MINVSYS_STEP_UV) + BQ25792_MINVSYS_MIN_UV; + + return ret; +} + /** * bq25703_set_min_vsys() - Set the minimum system voltage * @pdata: driver platform data @@ -166,6 +276,29 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pd= ata, int vsys) reg); } =20 +/** + * bq25792_set_min_vsys() - Set the minimum system voltage + * @pdata: driver platform data + * @vsys: voltage value to set in uV + * + * Set the minimum system voltage by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_min_vsys(struct bq257xx_chg *pdata, int vsys) +{ + unsigned int reg; + int vsys_min =3D pdata->vsys_min; + + vsys =3D clamp(vsys, vsys_min, BQ25792_MINVSYS_MAX_UV); + reg =3D ((vsys - BQ25792_MINVSYS_MIN_UV) / BQ25792_MINVSYS_STEP_UV); + reg =3D FIELD_PREP(BQ25792_REG00_VSYSMIN_MASK, reg); + + return regmap_write(pdata->bq->regmap, + BQ25792_REG00_MIN_SYS_VOLTAGE, reg); +} + /** * bq25703_get_cur() - Get the reported current from the battery * @pdata: driver platform data @@ -195,6 +328,30 @@ static int bq25703_get_cur(struct bq257xx_chg *pdata, = int *intval) return ret; } =20 +/** + * bq25792_get_cur() - Get the reported current from the battery + * @pdata: driver platform data + * @intval: pointer to store the battery current value + * + * Read the current ADC value from the device representing the battery + * charge or discharge current and return it in microamps. + * + * Return: Returns 0 on success or error on failure to read. + */ +static int bq25792_get_cur(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG33_IBAT_ADC, ®); + if (ret < 0) + return ret; + + *intval =3D (s16)reg * BQ25792_ADCIBAT_STEP_UA; + + return ret; +} + /** * bq25703_get_ichg_cur() - Get the maximum reported charge current * @pdata: driver platform data @@ -218,6 +375,30 @@ static int bq25703_get_ichg_cur(struct bq257xx_chg *pd= ata, int *intval) return ret; } =20 +/** + * bq25792_get_ichg_cur() - Get the maximum reported charge current + * @pdata: driver platform data + * @intval: pointer to store the maximum charge current value + * + * Read the programmed maximum charge current limit from the device. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_ichg_cur(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG03_CHARGE_CURRENT_LIMIT, ®); + if (ret) + return ret; + + *intval =3D FIELD_GET(BQ25792_REG03_ICHG_MASK, reg) * + BQ25792_ICHG_STEP_UA; + + return ret; +} + /** * bq25703_set_ichg_cur() - Set the maximum charge current * @pdata: driver platform data @@ -242,6 +423,28 @@ static int bq25703_set_ichg_cur(struct bq257xx_chg *pd= ata, int ichg) reg); } =20 +/** + * bq25792_set_ichg_cur() - Set the maximum charge current + * @pdata: driver platform data + * @ichg: current value to set in uA + * + * Set the maximum charge current by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_ichg_cur(struct bq257xx_chg *pdata, int ichg) +{ + int ichg_max =3D pdata->ichg_max; + u16 reg; + + ichg =3D clamp(ichg, BQ25792_ICHG_MIN_UA, ichg_max); + reg =3D FIELD_PREP(BQ25792_REG03_ICHG_MASK, + (ichg / BQ25792_ICHG_STEP_UA)); + + return bq25792_write16(pdata, BQ25792_REG03_CHARGE_CURRENT_LIMIT, reg); +} + /** * bq25703_get_chrg_volt() - Get the maximum set charge voltage * @pdata: driver platform data @@ -265,6 +468,30 @@ static int bq25703_get_chrg_volt(struct bq257xx_chg *p= data, int *intval) return ret; } =20 +/** + * bq25792_get_chrg_volt() - Get the maximum set charge voltage + * @pdata: driver platform data + * @intval: pointer to store the maximum charge voltage value + * + * Read the current charge voltage limit from the device. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_chrg_volt(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG01_CHARGE_VOLTAGE_LIMIT, ®); + if (ret) + return ret; + + *intval =3D FIELD_GET(BQ25792_REG01_VREG_MASK, reg) * + BQ25792_VBATREG_STEP_UV; + + return ret; +} + /** * bq25703_set_chrg_volt() - Set the maximum charge voltage * @pdata: driver platform data @@ -291,6 +518,29 @@ static int bq25703_set_chrg_volt(struct bq257xx_chg *p= data, int vbat) reg); } =20 +/** + * bq25792_set_chrg_volt() - Set the maximum charge voltage + * @pdata: driver platform data + * @vbat: voltage value to set in uV + * + * Set the maximum charge voltage by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_chrg_volt(struct bq257xx_chg *pdata, int vbat) +{ + int vbat_max =3D pdata->vbat_max; + u16 reg; + + vbat =3D clamp(vbat, BQ25792_VBATREG_MIN_UV, vbat_max); + + reg =3D FIELD_PREP(BQ25792_REG01_VREG_MASK, + (vbat / BQ25792_VBATREG_STEP_UV)); + + return bq25792_write16(pdata, BQ25792_REG01_CHARGE_VOLTAGE_LIMIT, reg); +} + /** * bq25703_get_iindpm() - Get the maximum set input current * @pdata: driver platform data @@ -319,6 +569,30 @@ static int bq25703_get_iindpm(struct bq257xx_chg *pdat= a, int *intval) return ret; } =20 +/** + * bq25792_get_iindpm() - Get the maximum set input current + * @pdata: driver platform data + * @intval: pointer to store the maximum input current value + * + * Read the current input current limit from the device. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_iindpm(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG06_INPUT_CURRENT_LIMIT, ®); + if (ret) + return ret; + + reg =3D FIELD_GET(BQ25792_REG06_IINDPM_MASK, reg); + *intval =3D reg * BQ25792_IINDPM_STEP_UA; + + return ret; +} + /** * bq25703_set_iindpm() - Set the maximum input current * @pdata: driver platform data @@ -344,6 +618,29 @@ static int bq25703_set_iindpm(struct bq257xx_chg *pdat= a, int iindpm) FIELD_PREP(BQ25703_IINDPM_MASK, reg)); } =20 +/** + * bq25792_set_iindpm() - Set the maximum input current + * @pdata: driver platform data + * @iindpm: current value in uA + * + * Set the maximum input current by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_iindpm(struct bq257xx_chg *pdata, int iindpm) +{ + u16 reg; + int iindpm_max =3D pdata->iindpm_max; + + iindpm =3D clamp(iindpm, BQ25792_IINDPM_MIN_UA, iindpm_max); + + reg =3D iindpm / BQ25792_IINDPM_STEP_UA; + + return bq25792_write16(pdata, BQ25792_REG06_INPUT_CURRENT_LIMIT, + FIELD_PREP(BQ25792_REG06_IINDPM_MASK, reg)); +} + /** * bq25703_get_vbat() - Get the reported voltage from the battery * @pdata: driver platform data @@ -368,6 +665,30 @@ static int bq25703_get_vbat(struct bq257xx_chg *pdata,= int *intval) return ret; } =20 +/** + * bq25792_get_vbat() - Get the reported voltage from the battery + * @pdata: driver platform data + * @intval: pointer to store the battery voltage value + * + * Read the current ADC value representing the battery voltage + * and return it in microvolts. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_vbat(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG3B_VBAT_ADC, ®); + if (ret) + return ret; + + *intval =3D reg * BQ25792_ADCVSYSVBAT_STEP_UV; + + return ret; +} + /** * bq25703_hw_init() - Set all the required registers to init the charger * @pdata: driver platform data @@ -434,6 +755,62 @@ static int bq25703_hw_init(struct bq257xx_chg *pdata) return ret; } =20 +/** + * bq25792_hw_init() - Initialize BQ25792 hardware + * @pdata: driver platform data + * + * Initialize the BQ25792 by disabling the watchdog, enabling discharge + * current sensing with 5A limit, and configuring input current regulation. + * Set the charge current, charge voltage, minimum system voltage, and + * input current limit from platform data. Enable and configure the ADC + * to measure all available channels. + * + * Return: Returns 0 on success or error code on error. + */ +static int bq25792_hw_init(struct bq257xx_chg *pdata) +{ + struct regmap *regmap =3D pdata->bq->regmap; + int ret =3D 0; + + /* Disable watchdog (TODO: make it work instead) */ + regmap_write(regmap, BQ25792_REG10_CHARGER_CONTROL_1, 0); + + /* + * Enable battery discharge current sensing, 5A discharge current + * limit, input current regulation and ship FET functions + */ + regmap_write(regmap, BQ25792_REG14_CHARGER_CONTROL_5, + BQ25792_REG14_SFET_PRESENT | + BQ25792_REG14_EN_IBAT | + BQ25792_IBAT_5A | + BQ25792_REG14_EN_IINDPM); + + ret =3D pdata->chip->bq257xx_set_ichg(pdata, pdata->ichg_max); + if (ret) + return ret; + + ret =3D pdata->chip->bq257xx_set_vbatreg(pdata, pdata->vbat_max); + if (ret) + return ret; + + ret =3D bq25792_set_min_vsys(pdata, pdata->vsys_min); + if (ret) + return ret; + + ret =3D pdata->chip->bq257xx_set_iindpm(pdata, pdata->iindpm_max); + if (ret) + return ret; + + /* Enable the ADC. */ + regmap_write(regmap, BQ25792_REG2E_ADC_CONTROL, BQ25792_REG2E_ADC_EN); + + /* Clear per-channel ADC disable bits - enable all channels */ + regmap_write(regmap, BQ25792_REG2F_ADC_FUNCTION_DISABLE_0, 0); + regmap_write(regmap, BQ25792_REG30_ADC_FUNCTION_DISABLE_1, 0); + + return ret; +} + /** * bq25703_hw_shutdown() - Set registers for shutdown * @pdata: driver platform data @@ -446,6 +823,30 @@ static void bq25703_hw_shutdown(struct bq257xx_chg *pd= ata) BQ25703_EN_LWPWR, BQ25703_EN_LWPWR); } =20 +/** + * bq25792_hw_shutdown() - Shutdown BQ25792 hardware + * @pdata: driver platform data + * + * Perform hardware shutdown for the BQ25792. Currently a no-op + * as the device does not require special shutdown configuration. + */ +static void bq25792_hw_shutdown(struct bq257xx_chg *pdata) +{ + /* Nothing to do here */ +} + +/** + * bq257xx_set_charger_property() - Set a power supply property + * @psy: power supply device + * @prop: power supply property to set + * @val: value to set for the property + * + * Handle requests to set power supply properties such as input current + * limit, constant charge voltage, and constant charge current. Routes + * the request to the chip-specific implementation. + * + * Return: Returns 0 on success or -EINVAL if property is not supported. + */ static int bq257xx_set_charger_property(struct power_supply *psy, enum power_supply_property prop, const union power_supply_propval *val) @@ -469,6 +870,19 @@ static int bq257xx_set_charger_property(struct power_s= upply *psy, return -EINVAL; } =20 +/** + * bq257xx_get_charger_property() - Get a power supply property + * @psy: power supply device + * @psp: power supply property to get + * @val: pointer to store the property value + * + * Handle requests to get power supply properties, including status, + * health, manufacturer, online state, and various voltage/current + * measurements. Reads current device state and routes chip-specific + * property requests to appropriate handlers. + * + * Return: Returns 0 on success or -EINVAL if property is not supported. + */ static int bq257xx_get_charger_property(struct power_supply *psy, enum power_supply_property psp, union power_supply_propval *val) @@ -550,6 +964,17 @@ static enum power_supply_property bq257xx_power_supply= _props[] =3D { POWER_SUPPLY_PROP_USB_TYPE, }; =20 +/** + * bq257xx_property_is_writeable() - Check if a property is writeable + * @psy: power supply device + * @prop: power supply property to check + * + * Determines which power supply properties can be written to. Only + * charge current limit, charge voltage limit, and input current + * limit are writeable. + * + * Return: Returns 1 if property is writeable, 0 otherwise. + */ static int bq257xx_property_is_writeable(struct power_supply *psy, enum power_supply_property prop) { @@ -622,6 +1047,17 @@ static void bq257xx_external_power_changed(struct pow= er_supply *psy) power_supply_changed(psy); } =20 +/** + * bq257xx_irq_handler_thread() - Handle charger interrupt + * @irq: interrupt number + * @private: pointer to driver private data + * + * Thread handler for charger interrupts. Triggers re-evaluation of + * external power status and updates power supply state in response + * to charger events. + * + * Return: Returns IRQ_HANDLED if interrupt was processed. + */ static irqreturn_t bq257xx_irq_handler_thread(int irq, void *private) { struct bq257xx_chg *pdata =3D private; @@ -662,6 +1098,22 @@ static const struct bq257xx_chip_info bq25703_chip_in= fo =3D { .bq257xx_get_min_vsys =3D &bq25703_get_min_vsys, }; =20 +static const struct bq257xx_chip_info bq25792_chip_info =3D { + .default_iindpm_uA =3D BQ25792_IINDPM_DEFAULT_UA, + .bq257xx_hw_init =3D &bq25792_hw_init, + .bq257xx_hw_shutdown =3D &bq25792_hw_shutdown, + .bq257xx_get_state =3D &bq25792_get_state, + .bq257xx_get_ichg =3D &bq25792_get_ichg_cur, + .bq257xx_set_ichg =3D &bq25792_set_ichg_cur, + .bq257xx_get_vbatreg =3D &bq25792_get_chrg_volt, + .bq257xx_set_vbatreg =3D &bq25792_set_chrg_volt, + .bq257xx_get_iindpm =3D &bq25792_get_iindpm, + .bq257xx_set_iindpm =3D &bq25792_set_iindpm, + .bq257xx_get_cur =3D &bq25792_get_cur, + .bq257xx_get_vbat =3D &bq25792_get_vbat, + .bq257xx_get_min_vsys =3D &bq25792_get_min_vsys, +}; + /** * bq257xx_parse_dt() - Parse the device tree for required properties * @pdata: driver platform data @@ -707,6 +1159,17 @@ static int bq257xx_parse_dt(struct bq257xx_chg *pdata, return 0; } =20 +/** + * bq257xx_charger_probe() - Probe routine for charger platform device + * @pdev: platform device + * + * Probe the charger device, allocate driver data structure, select the + * appropriate chip-specific function pointers, register the power supply, + * parse device tree properties for battery limits, initialize hardware, + * and set up the interrupt handler if available. + * + * Return: Returns 0 on success or error code on failure. + */ static int bq257xx_charger_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -722,7 +1185,17 @@ static int bq257xx_charger_probe(struct platform_devi= ce *pdev) return -ENOMEM; =20 pdata->bq =3D bq; - pdata->chip =3D &bq25703_chip_info; + + switch (bq->type) { + case BQ25703A: + pdata->chip =3D &bq25703_chip_info; + break; + case BQ25792: + pdata->chip =3D &bq25792_chip_info; + break; + default: + return dev_err_probe(dev, -EINVAL, "Unknown chip type\n"); + } =20 platform_set_drvdata(pdev, pdata); =20 @@ -760,6 +1233,13 @@ static int bq257xx_charger_probe(struct platform_devi= ce *pdev) return ret; } =20 +/** + * bq257xx_charger_shutdown() - Shutdown routine for charger platform devi= ce + * @pdev: platform device + * + * Called during system shutdown to perform charger cleanup, including + * disabling watchdog timers or other chip-specific shutdown procedures. + */ static void bq257xx_charger_shutdown(struct platform_device *pdev) { struct bq257xx_chg *pdata =3D platform_get_drvdata(pdev); --=20 2.52.0