From nobody Sun Apr 5 16:28:28 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83AF026738B for ; Mon, 23 Mar 2026 17:58:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774288686; cv=none; b=EYDonFlrBNY4EPKiBLvZdo1aLwIFmYQ6jO8uwEusvqfs01iQ0yBhcBDaPnmPs/RPVtrjsNFYmmy/Lo2a6GhrpYI8EprKel5q6IuhxHsQod6Ff9tMD/qc/qtmv9iDYEynbDA6x6oGdA+eeUmfC1RJGzWRCd6keIgnpQ8vLPkbgh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774288686; c=relaxed/simple; bh=cYrcg8cZ1OOgmV+TAbZ97fcCPC0PWmH/iybgc6SDMxs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=hDFNZ9Su0y1ILsiO7CH0jGU3fgRCCvhEnhX/BEVV8YzxcMaVXR6At/ZMpEamxygMGLnbv3EEYj7Yd4xKTrGFTuc+9YhRlXBOcOYjWaFe8AYemEIF3VzY9ulPgULvo0IB6tP5lMcIwwdQe2mId7vrt/ekysl9NU7Bgntei3G7zeI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kaukIa+4; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kaukIa+4" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2ab46931cf1so46156865ad.0 for ; Mon, 23 Mar 2026 10:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774288685; x=1774893485; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=DAFVmIYqCpTk7YHQuUKCiaGw6d7SaBhhkzvznBNGhns=; b=kaukIa+4csz/mtudT0nzcnsT0ZN3TVoF8ndd6mwSfypW8xu/NZAgVcKvbbDv6uVmy6 Emts4ZGA8HxlTa9KNfJ39ZHGii6Cvd8/Z/rLlNmab1PFnZnYx4dhXftq5e42bSXjD9HR TG7fNQf9zwTkPWRAbi4DGhEFPvYcM6he3w88DIMZahXZwwWg+b3DODp/N8/25ZwV2vYU KY0SDJcfG4XezeLhxpjLlME++wp8KawBJk4PUkx+rt3oRUCaaAFVOfd53UlyoFg7Wjr6 KFsX+wHA5qmSxew0+HS8Id1aieNK6vnSlmwFqkGPH580w0Pm0GVj/ftbCfhSkV9npmXC pFXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774288685; x=1774893485; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DAFVmIYqCpTk7YHQuUKCiaGw6d7SaBhhkzvznBNGhns=; b=ftPSc9DplptV9terXgUPv+KiZNmDnSagRsQXU44MC3GAU20Am6K0YF9sNsZejitouy iRYJC+hjqkO1g+zb/FtXlWQnFnne03o5+T5c5ZfltW3h9Jnv+Ti7oYqfMpO01iuFoL5M x4/d1rGz7COOe5NQ1DeEzbuAZhNewWTTMxd2eoxIb3fsKfD7P7cdtzdO2TisLs84Hzeh C4mqifuy818jscvvJ383x7jq37mifb3PyAJ3UEb2wp2FmjSBMJYK29qlkgEEn4nL5mzz sPafa7v/RerQugYAbjEfL/Jilk2TR1ONO0V0UCx/yrUpd58QDs/8AwYAcL3ujCDaUtjL wW2g== X-Forwarded-Encrypted: i=1; AJvYcCXJgSaWG888Ibi7EyJFa3U9v+uijfDZ8MbgBIk/9bGYVY5jMQpgsfMdVXQm3H13qsmbkKKqD4teaLde4Y4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1icuHg5Amx+jrAapUkswdKn0szcgLsAs10HJzr649vHrjNFlA adpozjfcFOnsVz/o8Xv0e0QYURv793PP8+bg4Dktvet4iF15NLDMBIdF X-Gm-Gg: ATEYQzzJFIgs6BSNeBI8BbdmcGiRVoCk/R1jlOf46NyLkHj6jABqnNJvu8DDAducX0F WkbQunYZGI6mfnQahqsq1Wdv2VADnGx7cvUcBUvW86Qy0OeS7zwZcrwJAAK44id55yahnqHMN5K 09sSXv5p5DvE6gtgcHD/avBg1HGhwUOeBdGQ/uV+Tbe7uIoTMKA8mzOuUV3mLIQXyY2LRv451gy +/bXaT+xRndyTdqJBKwhqlLqTP/abziAArGB5+LjgOodqsQm9Hl5+CBLTL3+gxBu5ZN37pPwnZn 5tKSucN5LHuT/K6HN7j/OAo7/5UYnb+mOWinN5LZ21PIdDTdUYcMOYJaflHHxMGS5snCj9tKvVL C7JN1tcRK6i3Yx3InEdqqeYL7WykTXy8w5X2sNKX142yaOi0AfCa6slpnVKycYcPggN/SOyOajb yrx1x1OmnYzwHALvYOfbyiZeE+YDLHj4F4duqV X-Received: by 2002:a17:903:2acc:b0:2ae:7f85:33d1 with SMTP id d9443c01a7336-2b0a4cd49e4mr4562165ad.0.1774288684737; Mon, 23 Mar 2026 10:58:04 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0835551c3sm113415065ad.35.2026.03.23.10.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 10:58:04 -0700 (PDT) From: Felix Gu Date: Tue, 24 Mar 2026 01:57:59 +0800 Subject: [PATCH] PCI: aspeed: Fix IRQ domain leak on platform_get_irq() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-aspeed-v1-1-354181624c00@gmail.com> X-B4-Tracking: v=1; b=H4sIACZ/wWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYyMT3cTigtTUFN0kA1MTUxNLM8MUc1MloOKCotS0zAqwQdGxtbUAgHK gQ1gAAAA= X-Change-ID: 20260324-aspeed-b05454961d75 To: Jacky Chou , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Joel Stanley , Andrew Jeffery Cc: linux-aspeed@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774288681; l=1574; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=cYrcg8cZ1OOgmV+TAbZ97fcCPC0PWmH/iybgc6SDMxs=; b=l+RPKAQMkKB3prPtTq61GiYDOiTZZEVvZpdPRmil5aMf0ygzxdGhIKpTojXIdqk8Guifwxe3Y UOj7efLJOKnAPRYwxbJvxbBY6Iz1Z6VcYRmZbAzVLfAw5weD9l6RPeg X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The aspeed_pcie_probe() function calls aspeed_pcie_init_irq_domain() which allocates pcie->intx_domain and initializes MSI. However, if platform_get_irq() fails afterwards, the cleanup action was not yet registered via devm_add_action_or_reset(), causing the IRQ domain resources to leak. Fix this by registering the devm cleanup action immediately after aspeed_pcie_init_irq_domain() succeeds, before calling platform_get_irq(). This ensures proper cleanup on any subsequent failure. Fixes: 9aa0cb68fcc1 ("PCI: aspeed: Add ASPEED PCIe RC driver") Signed-off-by: Felix Gu --- drivers/pci/controller/pcie-aspeed.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pcie-aspeed.c b/drivers/pci/controller/= pcie-aspeed.c index 3e1a39d1e648..6acfae7d026e 100644 --- a/drivers/pci/controller/pcie-aspeed.c +++ b/drivers/pci/controller/pcie-aspeed.c @@ -1052,14 +1052,14 @@ static int aspeed_pcie_probe(struct platform_device= *pdev) if (ret) return ret; =20 - irq =3D platform_get_irq(pdev, 0); - if (irq < 0) - return irq; - ret =3D devm_add_action_or_reset(dev, aspeed_pcie_irq_domain_free, pcie); if (ret) return ret; =20 + irq =3D platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + ret =3D devm_request_irq(dev, irq, aspeed_pcie_intr_handler, IRQF_SHARED, dev_name(dev), pcie); if (ret) --- base-commit: 785f0eb2f85decbe7c1ef9ae922931f0194ffc2e change-id: 20260324-aspeed-b05454961d75 Best regards, --=20 Felix Gu